debitech_soap 0.0.2 → 0.0.3

data/CHANGELOG

@@ -1,3 +1,7 @@
+0.0.3
+
+Added support for Java style method names.
+
 0.0.2
 
 Removed activesupport dependency.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    debitech_soap (0.0.1)
+    debitech_soap (0.0.2)
 
 GEM
   remote: http://rubygems.org/

data/lib/debitech_soap.rb

@@ -8,20 +8,24 @@ module DebitechSoap
 
     RETURN_DATA = %w{aCSUrl acquirerAddress acquirerAuthCode acquirerAuthResponseCode acquirerCity acquirerConsumerLimit acquirerErrorDescription acquirerFirstName acquirerLastName acquirerMerchantLimit acquirerZipCode amount errorMsg infoCode infoDescription pAReqMsg resultCode resultText verifyID}
 
-    PARAMS = { "settle"                => ["verifyID", "transID", "amount", "extra"],
-               "subscribe_and_settle"  => ["verifyID", "transID", "data", "ip", "extra"],
-               "authorize"             => ["billingFirstName", "billingLastName", "billingAddress", "billingCity",
-                                           "billingCountry", "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID", "extra"],
-               "authorizeAndSettle3DS" => ["verifyID", "paRes", "extra"],
-               "refund"                => ["verifyID", "transID", "amount", "extra"],
-               "askIf3DSEnrolled"      => ["billingFirstName", "billingLastName", "billingAddress", "billingCity",
-                                           "billingCountry", "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID",
-                                           "httpAcceptHeader", "httpUserAgentHeader", "method", "referenceNo", "extra"],
-               "auth_reversal"         => ["verifyID", "amount", "transID", "extra"],
-               "authorize3DS"          => ["verifyID", "paRes", "extra"],
-               "subscribe"             => ["verifyID", "transID", "data", "ip", "extra"],
-               "authorize_and_settle"  => ["billingFirstName", "billingLastName", "billingAddress", "billingCity", "billingCountry",
-                                           "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID", "extra"] }
+    PARAMS = { %w(settle)                     => ["verifyID", "transID", "amount", "extra"],
+               %w(subscribeAndSettle subscribe_and_settle) \
+                                              => ["verifyID", "transID", "data", "ip", "extra"],
+               %w(authorize)                  => ["billingFirstName", "billingLastName", "billingAddress", "billingCity",
+                                                  "billingCountry", "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID", "extra"],
+               %w(authorizeAndSettle3DS authorize_and_settle_3ds) \
+                                              => ["verifyID", "paRes", "extra"],
+               %w(refund)                     => ["verifyID", "transID", "amount", "extra"],
+               %w(askIf3DSEnrolled ask_if_3ds_enrolled) \
+                                              => ["billingFirstName", "billingLastName", "billingAddress", "billingCity",
+                                                  "billingCountry", "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID",
+                                                  "httpAcceptHeader", "httpUserAgentHeader", "method", "referenceNo", "extra"],
+               %w(authReversal auth_reversal) => ["verifyID", "amount", "transID", "extra"],
+               %w(authorize3DS authorize_3ds) => ["verifyID", "paRes", "extra"],
+               %w(subscribe)                  => ["verifyID", "transID", "data", "ip", "extra"],
+               %w(authorizeAndSettle authorize_and_settle) \
+                                              => ["billingFirstName", "billingLastName", "billingAddress", "billingCity", "billingCountry",
+                                                  "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID", "extra"] }
 
     def initialize(opts = {})
       @api_credentials = {}
@@ -45,7 +49,7 @@ module DebitechSoap
   private
 
     def define_java_wrapper_methods!
-      PARAMS.keys.each { |method|
+      PARAMS.keys.flatten.each { |method|
         (class << self; self; end).class_eval do                          # Doc:
           define_method(method) do |*args|                                # def refund(*args)
             attributes = @api_credentials.clone
@@ -53,13 +57,13 @@ module DebitechSoap
             if args.first.is_a?(Hash) 
               attributes.merge!(args.first)
             else
-              parameter_order = PARAMS[method.to_s] 
+              parameter_order = api_signature(method).last
               args.each_with_index { |argument, i|
                 attributes[parameter_order[i].to_sym] = argument
               }
             end
 
-            return_data @client.send(method, attributes).return
+            return_data @client.send(api_signature(method).first.first, attributes).return
           end                                                             # end
         end
       }
@@ -95,5 +99,9 @@ module DebitechSoap
       end
     end
 
+    def api_signature(method)
+      PARAMS.find {|key,value| key.include?(method.to_s) }
+    end
+
   end
 end

data/lib/debitech_soap/string_extensions.rb

@@ -18,7 +18,7 @@ module DebitechSoap
         if first_letter_in_uppercase
           self.to_s.gsub(/\/(.?)/) { "::#{$1.upcase}" }.gsub(/(?:^|_)(.)/) { $1.upcase }
         else
-          self.to_s[0].chr.downcase + camelize(lower_case_and_underscored_word)[1..1]
+          self.to_s[0].chr.downcase + self.camelcase[1..-1]
         end
       end
     end

data/lib/debitech_soap/version.rb

@@ -1,3 +1,3 @@
 module DebitechSoap
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/debitech_soap_spec.rb

@@ -50,7 +50,15 @@ describe DebitechSoap::API, "calling a method with java-style arguments" do
                                           and_return(MockSoapResult.new)
     api.refund(1234567, 23456, 100, "extra")
   end
-  
+
+  it "should camel case method names" do
+    api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
+    @client.should_receive("authorize3DS").with(:verifyID => 1234567, :paRes => "RES", :extra => "extra",
+                                          :shopName => "merchant_name", :userName => "api_user_name", :password => "api_user_password").
+                                          and_return(MockSoapResult.new)
+    api.authorize_3ds(1234567, "RES", "extra")
+  end
+
   it "should not keep old attributes when making subsequent api calls" do
     api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
     @client.should_receive("refund").with(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra",

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: debitech_soap
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: 
   segments: 
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  - 3
+  version: 0.0.3
 platform: ruby
 authors: 
 - "Joakim Kolsj\xC3\xB6"