dead_bro 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d751a73992758c9392fbf0a89445536ce1a97cd2aea29470e54c4da62075e6b
-  data.tar.gz: e868200d7940c736922ea80e0a5d98fd665a86f1258725e9db33098ccbe75927
+  metadata.gz: fb42d69f24067aad16e5b9287d018590cd4876d5d37d40c4903d4216af721054
+  data.tar.gz: 27ce42b49dd15c548cebbbf8f95cb294c0479da8a3c41a1a8413e855fe929908
 SHA512:
-  metadata.gz: 2ae9d9a17ca3975e68fdd762dd1f93eb173fca163ba01fdd6bea4813c0e7fca6566fee6943ee518b20f5f7b624cbc96b17dc0afcb45837cca703a94cfdde5e4b
-  data.tar.gz: 631e395e237463d6d76b0bc08868ee28712f90450a1c22935f21c05e1ff766c3b2b6f906249cbe6f29e8217c73a5bd196e746c6fab614e9f722f199f64e60eaa
+  metadata.gz: daeeb6923d46b072535cff1e03d89b7f9cb7f5d3373bfdcb36c36f876c3460dbc612885c65940f2b65f99ce3929cefb41b9db1204ce22e8601eee9987b22a73c
+  data.tar.gz: 59335da8149d74c7e1e00be6ba7dc700a09eb261bb4e5322fd22914c57f57f468ee34733973ab08125c79072c9ff59bba42990bd9cc5721aff5484e38fea3243

data/README.md

@@ -22,9 +22,9 @@ You can set via an initializer:
 
 
 ```ruby
-DeadBro.configure do |cfg|
-  cfg.api_key = ENV["dead_bro_API_KEY"]
-  cfg.enabled = true
+DeadBro.configure do |config|
+  config.api_key = ENV["DEAD_BRO_API_KEY"]
+  config.enabled = true
 end
 ```
 
@@ -180,7 +180,7 @@ DeadBro can automatically run `EXPLAIN ANALYZE` on slow SQL queries to help you
 
 ```ruby
 DeadBro.configure do |config|
-  config.api_key = ENV['dead_bro_API_KEY']
+  config.api_key = ENV['DEAD_BRO_API_KEY']
   config.enabled = true
   
   # Enable EXPLAIN ANALYZE for queries slower than 500ms

data/lib/dead_bro/configuration.rb

@@ -107,7 +107,7 @@ module DeadBro
     def resolve_api_key
       return @api_key unless @api_key.nil?
       
-      ENV["dead_bro_API_KEY"]
+      ENV["DEAD_BRO_API_KEY"]
     end
 
     def sample_rate=(value)

data/lib/dead_bro/sql_subscriber.rb

@@ -58,7 +58,9 @@ module DeadBro
         if should_explain_query?(duration_ms, original_sql)
           # Store reference to query_info so we can update it when EXPLAIN completes
           query_info[:explain_plan] = nil # Placeholder
-          start_explain_analyze_background(original_sql, data[:connection_id], query_info)
+          # Capture binds if available (type_casted_binds is preferred as they are ready for quoting)
+          binds = data[:type_casted_binds] || data[:binds]
+          start_explain_analyze_background(original_sql, data[:connection_id], query_info, binds)
         end
 
         # Add to thread-local storage
@@ -142,7 +144,7 @@ module DeadBro
       true
     end
 
-    def self.start_explain_analyze_background(sql, connection_id, query_info)
+    def self.start_explain_analyze_background(sql, connection_id, query_info, binds = nil)
       return unless defined?(ActiveRecord)
       return unless ActiveRecord::Base.respond_to?(:connection)
       
@@ -160,8 +162,11 @@ module DeadBro
             connection = ActiveRecord::Base.connection
           end
           
+          # Interpolate binds if present to ensure EXPLAIN works with placeholders
+          final_sql = interpolate_sql_with_binds(sql, binds, connection)
+          
           # Build EXPLAIN query based on database adapter
-          explain_sql = build_explain_query(sql, connection)
+          explain_sql = build_explain_query(final_sql, connection)
           
           # Execute the EXPLAIN query
           # For PostgreSQL, use select_all which returns ActiveRecord::Result
@@ -182,10 +187,8 @@ module DeadBro
           # This updates the hash that's already in the queries array
           if explain_plan && !explain_plan.to_s.strip.empty?
             query_info[:explain_plan] = explain_plan
-            append_log_to_thread(main_thread, :debug, "Captured EXPLAIN ANALYZE for slow query (#{query_info[:duration_ms]}ms): #{explain_plan[0..1000]}...")
           else
             query_info[:explain_plan] = nil
-            append_log_to_thread(main_thread, :debug, "EXPLAIN ANALYZE returned empty result. Result type: #{result.class}, Result: #{result.inspect[0..200]}")
           end
         rescue => e
           # Silently fail - don't let EXPLAIN break the application
@@ -267,6 +270,46 @@ module DeadBro
       end
     end
 
+    def self.interpolate_sql_with_binds(sql, binds, connection)
+      return sql if binds.nil? || binds.empty?
+      return sql unless connection
+
+      interpolated_sql = sql.dup
+      
+      # Handle $1, $2 style placeholders (PostgreSQL)
+      if interpolated_sql.include?("$1")
+        binds.each_with_index do |val, index|
+          # Get value from bind param (handle both raw values and ActiveRecord::Relation::QueryAttribute)
+          value = val
+          if val.respond_to?(:value_for_database)
+            value = val.value_for_database
+          elsif val.respond_to?(:value)
+            value = val.value
+          end
+          
+          quoted_value = connection.quote(value)
+          interpolated_sql = interpolated_sql.gsub("$#{index + 1}", quoted_value)
+        end
+      elsif interpolated_sql.include?("?")
+        # Handle ? style placeholders (MySQL, SQLite)
+        # We need to replace ? one by one in order
+        binds.each do |val|
+          # Get value from bind param
+          value = val
+          if val.respond_to?(:value_for_database)
+            value = val.value_for_database
+          elsif val.respond_to?(:value)
+            value = val.value
+          end
+          
+          quoted_value = connection.quote(value)
+          interpolated_sql = interpolated_sql.sub("?", quoted_value)
+        end
+      end
+      
+      interpolated_sql
+    end
+
     def self.format_explain_result(result, connection)
       adapter_name = connection.adapter_name.downcase
       

data/lib/dead_bro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeadBro
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dead_bro
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Emanuel Comsa