ddy_remote_resource 0.4.8 → 0.4.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ce5cc7ceb2e97f6d89d729d698a9aeeea910a00
-  data.tar.gz: ab72610052c96c506e621036a9b0a0a95c79123b
+  metadata.gz: 4fb6043c6ff3de6d36965017bffec730b1659f17
+  data.tar.gz: 32cf30b232c83c0a42c969ff24ce78f362a3bd6c
 SHA512:
-  metadata.gz: ef3676f7fbedebb4b8837ce1eb75460fd308554b342f2948be204a68a9bfdca4660495e6f7bb2c9d52da04456780cc4ac7655b0085d61ec01886020d568813ad
-  data.tar.gz: 3591412c2147fa17d98d7ac4b5a5f249cbc4395f9010e4656fa2c1dc324e460e1986446374a504be7a28ed42960014e2b0da7fcb469af8efc55db512a696ddab
+  metadata.gz: 948ad8bad7470092350a50a357f63810ff24728e4b9b4114766a64d56c217e720ba76727b4ea3b4c3a982e044db6c4e4a905b0cf0626fba01cdee7060338dffc
+  data.tar.gz: 02723a379602c6bb06e99b7c63882d833a79562122951e886c050ee7c4dd044d0242e85168eae0d3fe5d86a90155d03627e1c9e2d5bafb87409ffdf555349aec

data/lib/remote_resource/querying/finder_methods.rb

@@ -6,7 +6,7 @@ module RemoteResource
       module ClassMethods
 
         def find(id, connection_options = {})
-          connection_options.merge! no_params: true
+          connection_options.merge! no_attributes: true
           response = RemoteResource::Request.new(self, :get, { id: id }, connection_options).perform
           build_resource_from_response response
         end

data/lib/remote_resource/version.rb

@@ -1,3 +1,3 @@
 module RemoteResource
-  VERSION = '0.4.8'
+  VERSION = '0.4.9'
 end

data/remote_resource.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.4'
   spec.add_development_dependency 'rspec', '~> 3.1'
   spec.add_development_dependency 'pry', '~> 0.10'
+  spec.add_development_dependency 'webmock', '~> 1.24'
 
   spec.add_runtime_dependency 'activesupport', '~> 4.1'
   spec.add_runtime_dependency 'activemodel', '~> 4.1'

data/spec/lib/remote_resource/querying/finder_methods_spec.rb

@@ -24,15 +24,25 @@ describe RemoteResource::Querying::FinderMethods do
       allow_any_instance_of(RemoteResource::Request).to receive(:perform) { response }
     end
 
-    it 'performs a RemoteResource::Request with the connection_options no_params' do
-      expect(RemoteResource::Request).to receive(:new).with(dummy_class, :get, { id: '12' }, { no_params: true }).and_call_original
-      expect_any_instance_of(RemoteResource::Request).to receive(:perform)
-      dummy_class.find '12'
+    it 'performs a RemoteResource::Request with the connection_options no_attributes' do
+      stub_request(:get, 'https://foobar.com/finder_methods_dummy/12.json').to_return(status: 200, body: {}.to_json)
+      expect(RemoteResource::Request).to receive(:new).with(dummy_class, :get, { id: '12' }, { no_attributes: true }).and_call_original
+      expect_any_instance_of(RemoteResource::Request).to receive(:perform).and_call_original
+      dummy_class.find('12')
     end
 
     it 'builds the resource from the RemoteResource::Response' do
       expect(dummy_class).to receive(:build_resource_from_response).with response
-      dummy_class.find '12'
+      dummy_class.find('12')
+    end
+
+    context 'with extra params' do
+      it 'performs a RemoteResource::Request with params' do
+        stub_request(:get, 'https://foobar.com/finder_methods_dummy/12.json?skip_associations=true').to_return(status: 200, body: {}.to_json)
+        expect(RemoteResource::Request).to receive(:new).with(dummy_class, :get, { id: '12' }, { params: { skip_associations: true }, no_attributes: true }).and_call_original
+        expect_any_instance_of(RemoteResource::Request).to receive(:perform).and_call_original
+        dummy_class.find('12', params: { skip_associations: true })
+      end
     end
   end
 

data/spec/lib/remote_resource/version_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe RemoteResource::VERSION do
 
-  it { should eql '0.4.8' }
+  it { should eql '0.4.9' }
 end
 
 

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require 'remote_resource'
 
+require 'webmock/rspec'
 require 'pry'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ddy_remote_resource
 version: !ruby/object:Gem::Version
-  version: 0.4.8
+  version: 0.4.9
 platform: ruby
 authors:
 - Jan van der Pas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-21 00:00:00.000000000 Z
+date: 2016-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.24'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.24'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement