ddy_remote_resource 0.4.7 → 0.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee1e160b0d79e1f23df3b5f2005f26440bd443c5
-  data.tar.gz: 85fb186045fd88dadeccd07f349c7695c4338df9
+  metadata.gz: 7ce5cc7ceb2e97f6d89d729d698a9aeeea910a00
+  data.tar.gz: ab72610052c96c506e621036a9b0a0a95c79123b
 SHA512:
-  metadata.gz: 6e50af7d6a5c7049e2067ea0521c8f74030eedbf74644ff254d831b797c923c87c6e2f74c7e968cf2706ac65d86036a9e5ad212eed20d32e79b916cb34e8681a
-  data.tar.gz: 88f99d3f9c0d5b136095d0baf364017b821b8e8108019d642e8d73c24bc80b5188e5fe470b0236b3e63750a794b2a0b50cf82001c2026f74fda31a029e71b84a
+  metadata.gz: ef3676f7fbedebb4b8837ce1eb75460fd308554b342f2948be204a68a9bfdca4660495e6f7bb2c9d52da04456780cc4ac7655b0085d61ec01886020d568813ad
+  data.tar.gz: 3591412c2147fa17d98d7ac4b5a5f249cbc4395f9010e4656fa2c1dc324e460e1986446374a504be7a28ed42960014e2b0da7fcb469af8efc55db512a696ddab

data/lib/remote_resource.rb

@@ -24,6 +24,10 @@ require 'remote_resource/request'
 module RemoteResource
   RemoteResourceError = Class.new StandardError
 
+  IdMissingError = Class.new(RemoteResourceError)
+  
+  CollectionOptionKeyError = Class.new(RemoteResourceError)
+
   RESTActionUnknown = Class.new RemoteResourceError # REST action
 
   class HTTPError < RemoteResourceError # HTTP errors

data/lib/remote_resource/querying/persistence_methods.rb

@@ -10,6 +10,12 @@ module RemoteResource
           response = RemoteResource::Request.new(self, :post, attributes, connection_options).perform
           resource.handle_response response
         end
+
+        def destroy(id, connection_options = {})
+          resource = new
+          response = RemoteResource::Request.new(self, :delete, { id: id }, connection_options).perform
+          resource.handle_response(response)
+        end
       end
 
       def update_attributes(attributes = {}, connection_options = {})
@@ -33,6 +39,13 @@ module RemoteResource
         handle_response response
       end
 
+      def destroy(connection_options = {})
+        id.present? || raise(RemoteResource::IdMissingError.new("`id` is missing from resource"))
+        response = RemoteResource::Request.new(self, :delete, { id: id }, connection_options).perform
+        handle_response(response)
+        success? ? self : false
+      end
+
     end
   end
-end
+end

data/lib/remote_resource/request.rb

@@ -31,6 +31,8 @@ module RemoteResource
         response = connection.public_send rest_action, determined_request_url, params: determined_params, headers: determined_headers
       when :put, :patch, :post
         response = connection.public_send rest_action, determined_request_url, body: determined_attributes, headers: determined_headers
+      when :delete
+        response = connection.public_send rest_action, determined_request_url, body: determined_attributes, headers: determined_headers
       else
         raise RemoteResource::RESTActionUnknown, "for action: '#{rest_action}'"
       end

data/lib/remote_resource/rest.rb

@@ -2,7 +2,7 @@ module RemoteResource
   module REST
     extend ActiveSupport::Concern
 
-    ACTIONS = [:get, :put, :patch, :post]
+    ACTIONS = [:get, :put, :patch, :post, :delete]
 
     module ClassMethods
 
@@ -26,4 +26,4 @@ module RemoteResource
     end
 
   end
-end
+end

data/lib/remote_resource/url_naming_determination.rb

@@ -1,6 +1,5 @@
 module RemoteResource
   class UrlNamingDetermination
-    CollectionOptionKeyError = Class.new(StandardError)
 
     attr_reader :resource_klass, :connection_options
 
@@ -30,7 +29,7 @@ module RemoteResource
         prefix.gsub(/:\w+/) do |key|
           value = collection_options.fetch(key[1..-1], nil)
           if value.nil?
-            raise(CollectionOptionKeyError, "`collection_prefix` variable `#{key}` is missing from `collection_options`") if check_collection_options
+            raise(RemoteResource::CollectionOptionKeyError, "`collection_prefix` variable `#{key}` is missing from `collection_options`") if check_collection_options
             value = key
           end
           URI.parser.escape(value.to_s)

data/lib/remote_resource/version.rb

@@ -1,3 +1,3 @@
 module RemoteResource
-  VERSION = '0.4.7'
+  VERSION = '0.4.8'
 end

data/remote_resource.gemspec

@@ -19,14 +19,14 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.6'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'rake', '~> 10.4'
+  spec.add_development_dependency 'rspec', '~> 3.1'
+  spec.add_development_dependency 'pry', '~> 0.10'
 
-  spec.add_runtime_dependency 'activesupport'
-  spec.add_runtime_dependency 'activemodel'
-  spec.add_runtime_dependency 'virtus'
-  spec.add_runtime_dependency 'mime-types', '>= 1.16'
-  spec.add_runtime_dependency 'ethon', '~> 0.7.1'
-  spec.add_runtime_dependency 'typhoeus'
+  spec.add_runtime_dependency 'activesupport', '~> 4.1'
+  spec.add_runtime_dependency 'activemodel', '~> 4.1'
+  spec.add_runtime_dependency 'virtus', '~> 1.0', '>= 1.0.4'
+  spec.add_runtime_dependency 'mime-types', '~> 2.0'
+  spec.add_runtime_dependency 'ethon', '~> 0.7', '>= 0.7.1'
+  spec.add_runtime_dependency 'typhoeus', '~> 0.7', '>= 0.7.0'
 end

data/spec/lib/remote_resource/querying/persistence_methods_spec.rb

@@ -46,6 +46,31 @@ describe RemoteResource::Querying::PersistenceMethods do
     end
   end
 
+  describe '.destroy' do
+    let(:response) { instance_double(RemoteResource::Response) }
+
+    before do
+      allow_any_instance_of(dummy_class).to receive(:handle_response)
+      allow_any_instance_of(RemoteResource::Request).to receive(:perform) { response }
+    end
+
+    it 'instantiates the resource without attributes' do
+      expect(dummy_class).to receive(:new).with(no_args()).and_call_original
+      dummy_class.destroy('15')
+    end
+
+    it 'performs a RemoteResource::Request' do
+      expect(RemoteResource::Request).to receive(:new).with(dummy_class, :delete, { id: '15' }, {}).and_call_original
+      expect_any_instance_of(RemoteResource::Request).to receive(:perform)
+      dummy_class.destroy('15')
+    end
+
+    it 'handles the RemoteResource::Response' do
+      expect_any_instance_of(dummy_class).to receive(:handle_response).with response
+      dummy_class.destroy('15')
+    end
+  end
+
   describe '#update_attributes' do
     let(:dummy) { dummy_class.new id: 10 }
 
@@ -171,4 +196,51 @@ describe RemoteResource::Querying::PersistenceMethods do
     end
   end
 
-end
+  describe '#destroy' do
+    let(:dummy) { dummy_class.new(id: 18) }
+
+    let(:response) { instance_double(RemoteResource::Response) }
+
+    before do
+      allow(dummy).to receive(:handle_response)                           { dummy }
+      allow_any_instance_of(RemoteResource::Request).to receive(:perform) { response }
+      allow(dummy).to receive(:success?)
+    end
+
+    it 'performs a RemoteResource::Request with rest_action :delete' do
+      expect(RemoteResource::Request).to receive(:new).with(dummy, :delete, { id: dummy.id }, {}).and_call_original
+      expect_any_instance_of(RemoteResource::Request).to receive(:perform)
+      dummy.destroy
+    end
+
+    it 'handles the RemoteResource::Response' do
+      expect(dummy).to receive(:handle_response).with response
+      dummy.destroy
+    end
+
+    context 'when the destroy was successful' do
+      it 'returns the resource' do
+        allow(dummy).to receive(:success?) { true }
+
+        expect(dummy.destroy).to eql dummy
+      end
+    end
+
+    context 'when the destroy was NOT successful' do
+      it 'returns false' do
+        allow(dummy).to receive(:success?) { false }
+
+        expect(dummy.destroy).to eql false
+      end
+    end
+
+    context 'when the id is NOT present' do
+      let(:dummy) { dummy_class.new }
+
+      it 'raises the RemoteResource::IdMissingError error' do
+        expect { dummy.destroy }.to raise_error(RemoteResource::IdMissingError, "`id` is missing from resource")
+      end
+    end
+  end
+
+end

data/spec/lib/remote_resource/request_spec.rb

@@ -271,6 +271,17 @@ describe RemoteResource::Request do
       it_behaves_like 'a conditional construct for the response'
     end
 
+    context 'when the rest_action is :delete' do
+      let(:rest_action) { 'delete' }
+
+      it 'makes a DELETE request with the attributes as body' do
+        expect(connection).to receive(:delete).with(determined_request_url, body: determined_attributes, headers: determined_headers).and_call_original
+        request.perform
+      end
+
+      it_behaves_like 'a conditional construct for the response'
+    end
+
     context 'when the rest_action is unknown' do
       let(:rest_action) { 'foo' }
 
@@ -352,7 +363,7 @@ describe RemoteResource::Request do
 
       context 'when connection_options does NOT include collection_options' do
         it 'raises error' do
-          expect{ request.determined_request_url }.to raise_error(RemoteResource::UrlNamingDetermination::CollectionOptionKeyError)
+          expect{ request.determined_request_url }.to raise_error(RemoteResource::CollectionOptionKeyError)
         end
       end
     end

data/spec/lib/remote_resource/rest_spec.rb

@@ -63,6 +63,14 @@ describe RemoteResource::REST do
     end
   end
 
+  describe '.delete' do
+    it 'performs a RemoteResource::Request with the rest_action :delete' do
+      expect(RemoteResource::Request).to receive(:new).with(dummy_class, :delete, attributes, connection_options).and_call_original
+      expect_any_instance_of(RemoteResource::Request).to receive(:perform)
+      dummy_class.delete(attributes, connection_options)
+    end
+  end
+
   describe '#get' do
     it 'performs a RemoteResource::Request with the rest_action :get' do
       expect(RemoteResource::Request).to receive(:new).with(dummy, :get, params, connection_options).and_call_original
@@ -95,4 +103,12 @@ describe RemoteResource::REST do
     end
   end
 
+  describe '#delete' do
+    it 'performs a RemoteResource::Request with the rest_action :delete' do
+      expect(RemoteResource::Request).to receive(:new).with(dummy, :delete, attributes, connection_options).and_call_original
+      expect_any_instance_of(RemoteResource::Request).to receive(:perform)
+      dummy.delete(attributes, connection_options)
+    end
+  end
+
 end

data/spec/lib/remote_resource/url_naming_determination_spec.rb

@@ -116,7 +116,7 @@ describe RemoteResource::UrlNamingDetermination do
 
           context 'when check_collection_options is true' do
             it 'raises an exception' do
-              expect { url_naming_determination.base_url(nil, check_collection_options: true) }.to raise_error(RemoteResource::UrlNamingDetermination::CollectionOptionKeyError)
+              expect { url_naming_determination.base_url(nil, check_collection_options: true) }.to raise_error(RemoteResource::CollectionOptionKeyError)
             end
           end
         end
@@ -132,7 +132,7 @@ describe RemoteResource::UrlNamingDetermination do
 
           context 'when check_collection_options is true' do
             it 'raises an exception' do
-              expect { url_naming_determination.base_url(nil, check_collection_options: true) }.to raise_error(RemoteResource::UrlNamingDetermination::CollectionOptionKeyError)
+              expect { url_naming_determination.base_url(nil, check_collection_options: true) }.to raise_error(RemoteResource::CollectionOptionKeyError)
             end
           end
         end
@@ -160,7 +160,7 @@ describe RemoteResource::UrlNamingDetermination do
 
             context 'when check_collection_options is true' do
               it 'raises an exception' do
-                expect { url_naming_determination.base_url(nil, check_collection_options: true) }.to raise_error(RemoteResource::UrlNamingDetermination::CollectionOptionKeyError)
+                expect { url_naming_determination.base_url(nil, check_collection_options: true) }.to raise_error(RemoteResource::CollectionOptionKeyError)
               end
             end
           end

data/spec/lib/remote_resource/version_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe RemoteResource::VERSION do
 
-  it { should eql '0.4.7' }
+  it { should eql '0.4.8' }
 end
 
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ddy_remote_resource
 version: !ruby/object:Gem::Version
-  version: 0.4.7
+  version: 0.4.8
 platform: ruby
 authors:
 - Jan van der Pas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-14 00:00:00.000000000 Z
+date: 2016-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,105 +28,114 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.1'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.1'
 - !ruby/object:Gem::Dependency
   name: virtus
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.4
 - !ruby/object:Gem::Dependency
   name: mime-types
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: ethon
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.7.1
   type: :runtime
@@ -134,22 +143,31 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.7.1
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.7.0
 description: RemoteResource, a gem to use resources with REST services. A replacement
   for ActiveResource gem.
 email: