ddy_remote_resource 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb2c03a904db96aa05327826f442deb7b2852228
-  data.tar.gz: 4cd7f8229e8a6c7d43d47bc1e4d45c1f3cdb832c
+  metadata.gz: 57d80488ade688d52701471d6532652efbe3675f
+  data.tar.gz: 583505b4037a9b8eed898c10f2e8fd732a138ec7
 SHA512:
-  metadata.gz: 7390456c69a1ca82d053f44e7966f6f160e0b361af64f4670e2000bb5fe5160feafb2499809be857538c8d1b8e03dc96db218da497c3f73be6e97e5401cec7f3
-  data.tar.gz: aa727cdb44ed2933313c2c3681f6fa7e400c66d607be48194c6ade900add787f6754e107885c1fc4a1549a1504641ffa787b12158593b7d634f4ff51418dc0fd
+  metadata.gz: 2bad3f981adebf946c9bcee91dd1851c25f681dcc3b29d20d0fe5d94f219e412406b4cbe896d2d18e7583928c8b80f9d363d837322027eaec6809360e715d4a4
+  data.tar.gz: 09c52c8ce325004846c3c5a39be66b3ed5b0872f62a67cd535977a7f8d6a80c1464fcd01259a901157c2780aad07aee74840e1281c0bb634bedf862175755360

data/lib/remote_resource.rb

@@ -29,10 +29,10 @@ module RemoteResource
   class HTTPError < RemoteResourceError # HTTP errors
 
     def initialize(response)
-      if response.try :response_code
-        super "with HTTP response status: #{response.response_code} and response: #{response}"
+      if response.try(:response_code)
+        super "for url: #{response.try(:effective_url)} with HTTP response status: #{response.response_code} and response: #{response.inspect}"
       else
-        super "with HTTP response: #{response}"
+        super "for url: #{response.try(:effective_url)} with HTTP response: #{response.inspect}"
       end
     end
   end

data/lib/remote_resource/base.rb

@@ -36,7 +36,7 @@ module RemoteResource
     module ClassMethods
 
       def connection_options
-        Thread.current[connection_options_thread_name] ||= RemoteResource::ConnectionOptions.new(self)
+        RemoteResource::ConnectionOptions.new(self)
       end
 
       def threaded_connection_options
@@ -59,10 +59,6 @@ module RemoteResource
         "remote_resource.#{_module_name}.threaded_connection_options"
       end
 
-      def connection_options_thread_name
-        "remote_resource.#{_module_name}.connection_options"
-      end
-
       def _module_name
         self.name.to_s.demodulize.underscore.downcase
       end

data/lib/remote_resource/version.rb

@@ -1,3 +1,3 @@
 module RemoteResource
-  VERSION = '0.4.2'
+  VERSION = '0.4.3'
 end

data/remote_resource.gemspec

@@ -6,8 +6,8 @@ require 'remote_resource/version'
 Gem::Specification.new do |spec|
   spec.name          = 'ddy_remote_resource'
   spec.version       = RemoteResource::VERSION
-  spec.authors       = ["Jan van der Pas"]
-  spec.email         = ["jvanderpas@digidentity.eu"]
+  spec.authors       = ['Jan van der Pas']
+  spec.email         = ['jvanderpas@digidentity.eu']
   spec.summary       = %q{RemoteResource, a gem to use resources with REST services.}
   spec.description   = %q{RemoteResource, a gem to use resources with REST services. A replacement for ActiveResource gem.}
   spec.homepage      = ''

data/spec/lib/remote_resource/base_spec.rb

@@ -74,8 +74,8 @@ describe RemoteResource::Base do
       expect(dummy_class.connection_options.base_class).to be RemoteResource::Dummy
     end
 
-    it 'sets the name of Thread variable with the implemented class' do
-      expect(dummy_class.connection_options).to eql Thread.current['remote_resource.dummy.connection_options']
+    it 'does NOT memorize the connection options' do
+      expect(dummy_class.connection_options.object_id).not_to eql dummy_class.connection_options.object_id
     end
   end
 

data/spec/lib/remote_resource/request_spec.rb

@@ -520,10 +520,14 @@ describe RemoteResource::Request do
   end
 
   describe '#raise_http_errors' do
+    let(:effective_url)     { 'http://www.foobar.com/request_dummy.json' }
     let(:response)          { instance_double Typhoeus::Response }
     let(:raise_http_errors) { request.send :raise_http_errors, response }
 
-    before { allow(response).to receive(:response_code) { response_code } }
+    before do
+      allow(response).to receive(:response_code) { response_code }
+      allow(response).to receive(:effective_url) { effective_url }
+    end
 
     context 'when the response code is 301, 302, 303 or 307' do
       response_codes = [301, 302, 303, 307]
@@ -532,7 +536,7 @@ describe RemoteResource::Request do
         it "raises a RemoteResource::HTTPRedirectionError with response code #{response_code}" do
           allow(response).to receive(:response_code) { response_code }
 
-          expect{ raise_http_errors }.to raise_error RemoteResource::HTTPRedirectionError, "with HTTP response status: #{response_code} and response: #{response}"
+          expect{ raise_http_errors }.to raise_error RemoteResource::HTTPRedirectionError, "for url: #{effective_url} with HTTP response status: #{response_code} and response: #{response.inspect}"
         end
       end
     end
@@ -561,7 +565,7 @@ describe RemoteResource::Request do
         it "raises a #{error_class} with response code #{response_code}" do
           allow(response).to receive(:response_code) { response_code }
 
-          expect{ raise_http_errors }.to raise_error error_class, "with HTTP response status: #{response_code} and response: #{response}"
+          expect{ raise_http_errors }.to raise_error error_class, "for url: #{effective_url} with HTTP response status: #{response_code} and response: #{response.inspect}"
         end
       end
     end
@@ -570,7 +574,7 @@ describe RemoteResource::Request do
       let(:response_code) { 430 }
 
       it 'raises a RemoteResource::HTTPClientError' do
-        expect{ raise_http_errors }.to raise_error RemoteResource::HTTPClientError, "with HTTP response status: #{response_code} and response: #{response}"
+        expect{ raise_http_errors }.to raise_error RemoteResource::HTTPClientError, "for url: #{effective_url} with HTTP response status: #{response_code} and response: #{response.inspect}"
       end
     end
 
@@ -578,7 +582,7 @@ describe RemoteResource::Request do
       let(:response_code) { 501 }
 
       it 'raises a RemoteResource::HTTPServerError' do
-        expect{ raise_http_errors }.to raise_error RemoteResource::HTTPServerError, "with HTTP response status: #{response_code} and response: #{response}"
+        expect{ raise_http_errors }.to raise_error RemoteResource::HTTPServerError, "for url: #{effective_url} with HTTP response status: #{response_code} and response: #{response.inspect}"
       end
     end
 
@@ -586,7 +590,7 @@ describe RemoteResource::Request do
       let(:response_code) { nil }
 
       it 'raises a RemoteResource::HTTPError' do
-        expect{ raise_http_errors }.to raise_error RemoteResource::HTTPError, "with HTTP response: #{response}"
+        expect{ raise_http_errors }.to raise_error RemoteResource::HTTPError, "for url: #{effective_url} with HTTP response: #{response.inspect}"
       end
     end
   end

data/spec/lib/remote_resource/version_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe RemoteResource::VERSION do
 
-  it { should eql '0.4.2' }
+  it { should eql '0.4.3' }
 end
 
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ddy_remote_resource
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Jan van der Pas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-12 00:00:00.000000000 Z
+date: 2015-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler