ddtrace 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6517e04d64a4ad46051c9841bf7438809e6379693f5796a26c063e3335788963
-  data.tar.gz: 646ad1cdabd82d2c94c4d4d5d1e4ab96f6a36890a9f50ea4cbbedac4c123a00e
+  metadata.gz: 7eadd5e3cd8cb0144883eb120e8aee9289d06acfc2e8c5b4b6d863f524be26e7
+  data.tar.gz: 6d0005127cfe83c0332275215a850a33d13e7670ae74982286e9fe77ac7214b9
 SHA512:
-  metadata.gz: 6d17badd3ed215171d47529092da1ea2a90e0acbdd9071237fc3637052d2b8fb72c422594dfd504a773dc504bcb8862c07d40123fdd97df207d07e07dee5a491
-  data.tar.gz: 9cbde75b86ba09ccb13161ab106ec24d3b10d93bab1b5996fdec72c14c429b227df3bbc965ab528369ac25e36a5650368b1339e89c17e632605c1e95566bae87
+  metadata.gz: 58e0edde95e595e435e6fad3ee078fe6bb6cf70301b6802b3b527b2804af259276752f3820901962ff94729149d60f4c81be7d3fe5c1c81b5b2119db89a9d3fa
+  data.tar.gz: baf7561a9b11f8a80fd8f36fe331c8dbdb7a7271db4cfe69f78e50b26a5946c426d0cba38b032eea964e619c3f67fcecb8b0350e72e73b7c02c53af84dbd8ecd

data/CHANGELOG.md

@@ -2,8 +2,44 @@
 
 ## [Unreleased]
 
+## [1.2.0] - 2022-07-11
+
+Release notes: https://github.com/DataDog/dd-trace-rb/releases/tag/v1.2.0
+
+Git diff: https://github.com/DataDog/dd-trace-rb/compare/v1.1.0...v1.2.0
+
+Special thanks go to [@miketheman][] for gifting Datadog access to the `datadog` gem a few days ago.
+
+### Added
+
+* Add Postgres (`pg` gem) instrumentation ([#2054][]) ([@jennchenn][])
+* Add env var for debugging profiling native extension compilation issues ([#2069][])
+* Teach Rest Client integration the `:split_by_domain` option ([#2079][]) ([@agrobbin][])
+* Allow passing request_queuing option to Rack through Rails tracer ([#2082][]) ([@KieranP][])
+* Add Utility to Collect Platform Information ([#2097][]) ([@jennchenn][])
+* Add convenient interface for getting and setting tags using `[]` and `[]=` respectively ([#2076][]) ([@ioquatix][])
+* Add b3 metadata in grpc ([#2110][]) ([@henrich-m][])
+
+### Changed
+
+* Profiler now reports profiling data using the libddprof gem ([#2059][])
+* Rename `Kernel#at_fork_blocks` monkey patch to `Kernel#ddtrace_at_fork_blocks` ([#2070][])
+* Improved error message for enabling profiling when `pkg-config` system tool is not installed ([#2134][])
+
+### Fixed
+
+* Prevent errors in `action_controller` integration when tracing is disabled ([#2027][]) ([@ahorner][])
+* Fix profiler not building on ruby-head (3.2) due to VM refactoring ([#2066][])
+* Span and trace IDs should not be zero ([#2113][]) ([@albertvaka][])
+* Fix object_id usage as thread local key ([#2096][])
+* Fix profiling not working on Heroku and AWS Elastic Beanstalk due to linking issues ([#2125][])
+
 ## [1.1.0] - 2022-05-25
 
+Release notes: https://github.com/DataDog/dd-trace-rb/releases/tag/v1.1.0
+
+Git diff: https://github.com/DataDog/dd-trace-rb/compare/v1.0.0...v1.1.0
+
 ### Added
 
 * [Application Security Monitoring](https://docs.datadoghq.com/security_platform/application_security/)
@@ -2852,7 +2888,22 @@ Git diff: https://github.com/DataDog/dd-trace-rb/compare/v0.3.0...v0.3.1
 [#2010]: https://github.com/DataDog/dd-trace-rb/issues/2010
 [#2011]: https://github.com/DataDog/dd-trace-rb/issues/2011
 [#2022]: https://github.com/DataDog/dd-trace-rb/issues/2022
+[#2027]: https://github.com/DataDog/dd-trace-rb/issues/2027
 [#2028]: https://github.com/DataDog/dd-trace-rb/issues/2028
+[#2054]: https://github.com/DataDog/dd-trace-rb/issues/2054
+[#2059]: https://github.com/DataDog/dd-trace-rb/issues/2059
+[#2066]: https://github.com/DataDog/dd-trace-rb/issues/2066
+[#2069]: https://github.com/DataDog/dd-trace-rb/issues/2069
+[#2070]: https://github.com/DataDog/dd-trace-rb/issues/2070
+[#2076]: https://github.com/DataDog/dd-trace-rb/issues/2076
+[#2079]: https://github.com/DataDog/dd-trace-rb/issues/2079
+[#2082]: https://github.com/DataDog/dd-trace-rb/issues/2082
+[#2096]: https://github.com/DataDog/dd-trace-rb/issues/2096
+[#2097]: https://github.com/DataDog/dd-trace-rb/issues/2097
+[#2110]: https://github.com/DataDog/dd-trace-rb/issues/2110
+[#2113]: https://github.com/DataDog/dd-trace-rb/issues/2113
+[#2125]: https://github.com/DataDog/dd-trace-rb/issues/2125
+[#2134]: https://github.com/DataDog/dd-trace-rb/issues/2134
 [@AdrianLC]: https://github.com/AdrianLC
 [@Azure7111]: https://github.com/Azure7111
 [@BabyGroot]: https://github.com/BabyGroot
@@ -2865,6 +2916,7 @@ Git diff: https://github.com/DataDog/dd-trace-rb/compare/v0.3.0...v0.3.1
 [@Jared-Prime]: https://github.com/Jared-Prime
 [@Joas1988]: https://github.com/Joas1988
 [@JustSnow]: https://github.com/JustSnow
+[@KieranP]: https://github.com/KieranP
 [@MMartyn]: https://github.com/MMartyn
 [@NobodysNightmare]: https://github.com/NobodysNightmare
 [@Redapted]: https://github.com/Redapted
@@ -2875,7 +2927,9 @@ Git diff: https://github.com/DataDog/dd-trace-rb/compare/v0.3.0...v0.3.1
 [@agirlnamedsophia]: https://github.com/agirlnamedsophia
 [@agrobbin]: https://github.com/agrobbin
 [@ahammel]: https://github.com/ahammel
+[@ahorner]: https://github.com/ahorner
 [@al-kudryavtsev]: https://github.com/al-kudryavtsev
+[@albertvaka]: https://github.com/albertvaka
 [@alksl]: https://github.com/alksl
 [@alloy]: https://github.com/alloy
 [@aurelian]: https://github.com/aurelian
@@ -2921,11 +2975,14 @@ Git diff: https://github.com/DataDog/dd-trace-rb/compare/v0.3.0...v0.3.1
 [@guizmaii]: https://github.com/guizmaii
 [@hatstand]: https://github.com/hatstand
 [@hawknewton]: https://github.com/hawknewton
+[@henrich-m]: https://github.com/henrich-m
 [@hs-bguven]: https://github.com/hs-bguven
 [@illdelph]: https://github.com/illdelph
+[@ioquatix]: https://github.com/ioquatix
 [@jamiehodge]: https://github.com/jamiehodge
 [@janz93]: https://github.com/janz93
 [@jeffjo]: https://github.com/jeffjo
+[@jennchenn]: https://github.com/jennchenn
 [@jfrancoist]: https://github.com/jfrancoist
 [@joeyAghion]: https://github.com/joeyAghion
 [@jpaulgs]: https://github.com/jpaulgs
@@ -2945,6 +3002,7 @@ Git diff: https://github.com/DataDog/dd-trace-rb/compare/v0.3.0...v0.3.1
 [@mdehoog]: https://github.com/mdehoog
 [@mdross95]: https://github.com/mdross95
 [@michaelkl]: https://github.com/michaelkl
+[@miketheman]: https://github.com/miketheman
 [@mriddle]: https://github.com/mriddle
 [@mscrivo]: https://github.com/mscrivo
 [@mstruve]: https://github.com/mstruve
@@ -2983,4 +3041,4 @@ Git diff: https://github.com/DataDog/dd-trace-rb/compare/v0.3.0...v0.3.1
 [@vramaiah]: https://github.com/vramaiah
 [@walterking]: https://github.com/walterking
 [@y-yagi]: https://github.com/y-yagi
-[@zachmccormick]: https://github.com/zachmccormick
+[@zachmccormick]: https://github.com/zachmccormick

data/CONTRIBUTING.md

@@ -52,7 +52,7 @@ We welcome code contributions to the library, which you can [submit as a pull re
 
 1. **Fork the repository** from https://github.com/DataDog/dd-trace-rb
 2. **Make any changes** for your patch.
-3. **Write tests** that demonstrate how the feature works or how the bug is fixed.
+3. **Write tests** that demonstrate how the feature works or how the bug is fixed. See the [DevelopmentGuide](https://github.com/DataDog/dd-trace-rb/blob/master/docs/DevelopmentGuide.md) for detailed test instructions.
 4. **Update any documentation** such as `docs/GettingStarted.md`, especially for new features.
 5. **Submit the pull request** from your fork back to the latest revision of the `master` branch on https://github.com/DataDog/dd-trace-rb.
 

data/README.md

@@ -5,7 +5,7 @@
 [![Gem](https://img.shields.io/gem/v/ddtrace)](https://rubygems.org/gems/ddtrace/)
 [![CircleCI](https://circleci.com/gh/DataDog/dd-trace-rb/tree/master.svg?style=svg&circle-token=b0bd5ef866ec7f7b018f48731bb495f2d1372cc1)](https://circleci.com/gh/DataDog/dd-trace-rb/tree/master)
 [![codecov](https://codecov.io/gh/DataDog/dd-trace-rb/branch/master/graph/badge.svg)](https://app.codecov.io/gh/DataDog/dd-trace-rb/branch/master)
-[![YARD documentation](https://img.shields.io/badge/YARD-documentation-blue)](https://www.rubydoc.info/gems/ddtrace/)
+[![YARD documentation](https://img.shields.io/badge/YARD-documentation-blue)](https://s3.amazonaws.com/gems.datadoghq.com/trace/docs/index.html)
 
 ``ddtrace`` is Datadog’s tracing client for Ruby. It is used to trace requests as they flow across web servers,
 databases and microservices so that developers have great visiblity into bottlenecks and troublesome requests.
@@ -22,7 +22,12 @@ For contributing, checkout the [contribution guidelines][contribution docs] and
 
 [setup docs]: https://docs.datadoghq.com/tracing/setup/ruby/
 [api docs]: https://github.com/DataDog/dd-trace-rb/blob/master/docs/GettingStarted.md
-[gem docs]: http://gems.datadoghq.com/trace/docs/
+[gem docs]: https://s3.amazonaws.com/gems.datadoghq.com/trace/docs/index.html
 [visualization docs]: https://docs.datadoghq.com/tracing/visualization/
 [contribution docs]: https://github.com/DataDog/dd-trace-rb/blob/master/CONTRIBUTING.md
 [development docs]: https://github.com/DataDog/dd-trace-rb/blob/master/docs/DevelopmentGuide.md
+
+## Special thanks
+
+* [Mike Fiedler](https://github.com/miketheman) for working on a number of Datadog Ruby projects, as well as graciously
+  gifting control of the `datadog` gem

data/ddtrace.gemspec

@@ -54,9 +54,12 @@ Gem::Specification.new do |spec|
 
   # Used by the profiler native extension to support older Rubies (see NativeExtensionDesign.md for notes)
   #
-  # Because we only use this for older Rubies, and we consider it "feature-complete" for those older Rubies,
+  # Most versions of this gem work for us, but 0.10.16 includes an important fix for Ruby 2.5.4 to 2.5.9
+  # (https://github.com/ruby-debug/debase-ruby_core_source/pull/6) so we should keep that as a lower bound going
+  # forward.
+  #
   # we're pinning it at the latest available version and will manually bump the dependency as needed.
-  spec.add_dependency 'debase-ruby_core_source', '<= 0.10.16'
+  spec.add_dependency 'debase-ruby_core_source', '= 0.10.16'
 
   # Used by appsec
   spec.add_dependency 'libddwaf', '~> 1.3.0.2.0'

data/docs/GettingStarted.md

@@ -62,6 +62,7 @@ To contribute, check out the [contribution guidelines][contribution docs] and [d
      - [MongoDB](#mongodb)
      - [MySQL2](#mysql2)
      - [Net/HTTP](#nethttp)
+     - [Postgres](#postgres)
      - [Presto](#presto)
      - [Qless](#qless)
      - [Que](#que)
@@ -497,6 +498,7 @@ For a list of available integrations, and their configuration options, please re
 | MongoDB                    | `mongo`                    | `>= 2.1`                 | `>= 2.1`                  | *[Link](#mongodb)*                  | *[Link](https://github.com/mongodb/mongo-ruby-driver)*                         |
 | MySQL2                     | `mysql2`                   | `>= 0.3.21`              | *gem not available*       | *[Link](#mysql2)*                   | *[Link](https://github.com/brianmario/mysql2)*                                 |
 | Net/HTTP                   | `http`                     | *(Any supported Ruby)*   | *(Any supported Ruby)*    | *[Link](#nethttp)*                  | *[Link](https://ruby-doc.org/stdlib-2.4.0/libdoc/net/http/rdoc/Net/HTTP.html)* |
+| Postgres                     | `pg`                   | `>= 0.18.4`              | *gem not available*       | *[Link](#postgres)*                   | *[Link](https://github.com/ged/ruby-pg)*                  |
 | Presto                     | `presto`                   | `>= 0.5.14`              | `>= 0.5.14`               | *[Link](#presto)*                   | *[Link](https://github.com/treasure-data/presto-client-ruby)*                  |
 | Qless                      | `qless`                    | `>= 0.10.0`              | `>= 0.10.0`               | *[Link](#qless)*                    | *[Link](https://github.com/seomoz/qless)*                                      |
 | Que                        | `que`                      | `>= 1.0.0.beta2`         | `>= 1.0.0.beta2`          | *[Link](#que)*                      | *[Link](https://github.com/que-rb/que)*                                        |
@@ -1142,6 +1144,7 @@ Where `options` is an optional `Hash` that accepts the following parameters:
 
 | Key | Description | Default |
 | --- | ----------- | ------- |
+| `distributed_tracing` | Enables [distributed tracing](#distributed-tracing) | `true` |
 | `service_name` | Service name used for `grpc` instrumentation | `'grpc'` |
 | `error_handler` | Custom error handler invoked when a request is an error. A `Proc` that accepts `span` and `error` parameters. Sets error on the span by default. | `proc { |span, error| span.set_error(error) unless span.nil? }` |
 
@@ -1369,6 +1372,27 @@ If you wish to configure each connection object individually, you may use the `D
 client = Net::HTTP.new(host, port)
 Datadog.configure_onto(client, **options)
 ```
+### Postgres
+
+The PG integration traces SQL commands sent through the `pg` gem via:
+* `exec`, `exec_params`, `exec_prepared`;
+* `async_exec`, `async_exec_params`, `async_exec_prepared`; or,
+* `sync_exec`, `sync_exec_params`, `sync_exec_prepared`
+
+```ruby
+require 'pg'
+require 'ddtrace'
+
+Datadog.configure do |c|
+  c.tracing.instrument :pg, options
+end
+```
+
+Where `options` is an optional `Hash` that accepts the following parameters:
+
+| Key | Description | Default |
+| --- | ----------- | ------- |
+| `service_name` | Service name used for `pg` instrumentation | `'pg'` |
 
 ### Presto
 
@@ -1556,6 +1580,7 @@ Where `options` is an optional `Hash` that accepts the following parameters:
 | `cache_service` | Cache service name used when tracing cache activity | `'<app_name>-cache'` |
 | `database_service` | Database service name used when tracing database activity | `'<app_name>-<adapter_name>'` |
 | `distributed_tracing` | Enables [distributed tracing](#distributed-tracing) so that this service trace is connected with a trace of another service if tracing headers are received | `true` |
+| `request_queuing` | Track HTTP request time spent in the queue of the frontend server. See [HTTP request queuing](#http-request-queuing) for setup details. Set to `true` to enable. | `false` |
 | `exception_controller` | Class or Module which identifies a custom exception controller class. Tracer provides improved error behavior when it can identify custom exception controllers. By default, without this option, it 'guesses' what a custom exception controller looks like. Providing this option aids this identification. | `nil` |
 | `middleware` | Add the trace middleware to the Rails application. Set to `false` if you don't want the middleware to load. | `true` |
 | `middleware_names` | Enables any short-circuited middleware requests to display the middleware name as a resource for the trace. | `false` |
@@ -1757,6 +1782,7 @@ Where `options` is an optional `Hash` that accepts the following parameters:
 | --- | ----------- | ------- |
 | `distributed_tracing` | Enables [distributed tracing](#distributed-tracing) | `true` |
 | `service_name` | Service name for `rest_client` instrumentation. | `'rest_client'` |
+| `split_by_domain` | Uses the request domain as the service name when set to `true`. | `false` |
 
 ### RSpec
 
@@ -1867,7 +1893,7 @@ Where `options` is an optional `Hash` that accepts the following parameters:
 | Key | Description | Default |
 | --- | ----------- | ------- |
 | `tag_args` | Enable tagging of job arguments. `true` for on, `false` for off. | `false` |
-| `error_handler` | Custom error handler invoked when a job raises an error. Provided `span` and `error` as arguments. Sets error on the span by default. Useful for ignoring transient errors. | `proc { |span, error| span.set_error(error) unless span.nil? }` |
+| `error_handler` | Custom error handler invoked when a job raises an error. Provided `span` and `error` as arguments. Sets error on the span by default. Useful for ignoring transient errors. | `proc { \|span, error\| span.set_error(error) unless span.nil? }` |
 | `quantize` | Hash containing options for quantization of job arguments. | `{}` |
 
 ### Sinatra
@@ -2639,8 +2665,6 @@ However, additional instrumentation provided by Datadog can be activated alongsi
 
 ### Profiling
 
-*Currently available as BETA feature.*
-
 `ddtrace` can produce profiles that measure method-level application resource usage within production environments. These profiles can give insight into resources spent in Ruby code outside of existing trace instrumentation.
 
 **Setup**

data/docs/ProfilingDevelopment.md

@@ -11,23 +11,23 @@ Components below live inside <../lib/datadog/profiling>:
 * `Collectors::OldStack`: Collects stack trace samples from Ruby threads for both CPU-time (if available) and wall-clock.
   Runs on its own background thread.
 * `Collectors::CodeProvenance`: Collects library metadata to power grouping and categorization of stack traces (e.g. to help distinguish user code, from libraries, from the standard library, etc).
-* `Encoding::Profile`: Encodes gathered data into the pprof format.
+* `Encoding::Profile::Protobuf`: Encodes gathered data into the pprof format.
 * `Events::Stack`, `Events::StackSample`: Entity classes used to represent stacks.
 * `Ext::Forking`: Monkey patches `Kernel#fork`, adding a `Kernel#at_fork` callback mechanism which is used to restore
   profiling abilities after the VM forks (such as re-instrumenting the main thread, and restarting profiler threads).
-* `Pprof::*` (in <../lib/datadog/profiling/pprof>): Converts samples captured in the `Recorder` into the pprof format.
-* `Tasks::Setup`: Takes care of loading our extensions/monkey patches to handle fork().
-* `Transport::*` (in <../lib/datadog/profiling/transport>): Implements transmission of profiling payloads to the Datadog agent
-  or backend.
+* `Pprof::*` (in <../lib/datadog/profiling/pprof>): Used by `Encoding::Profile::Protobuf` to convert samples captured in
+  the `OldRecorder` into the pprof format.
+* `Tasks::Setup`: Takes care of loading our extensions/monkey patches to handle `fork()`.
+* `HttpTransport`: Implements transmission of profiling payloads to the Datadog agent or backend.
 * `TraceIdentifiers::*`: Used to retrieve trace id and span id from tracers, to be used to connect traces to profiles.
 * `BacktraceLocation`: Entity class used to represent an entry in a stack trace.
 * `Buffer`: Bounded buffer used to store profiling events.
-* `Exporter`: Writes profiling data to a given transport.
-* `Flush`: Entity class used to represent metadata for a given profile.
+* `Flush`: Entity class used to represent the payload to be reported for a given profile.
 * `Profiler`: Profiling entry point, which coordinates collectors and a scheduler.
-* `Recorder`: Stores profiling events gathered by the `Collector::OldStack`. (To be removed after migration to libddprof aggregation)
-* `Scheduler`: Periodically (every 1 minute) takes data from the `Recorder` and pushes them to all configured
-  `Exporter`s. Runs on its own background thread.
+* `OldRecorder`: Stores profiling events gathered by the `Collector::OldStack`. (To be removed after migration to libddprof aggregation)
+* `Exporter`: Gathers data from `OldRecorder` and `Collectors::CodeProvenance` to be reported as a profile.
+* `Scheduler`: Periodically (every 1 minute) takes data from the `Exporter` and pushes them to the configured transport.
+  Runs on its own background thread.
 
 ## Initialization
 
@@ -35,11 +35,10 @@ When started via `ddtracerb exec` (together with `DD_PROFILING_ENABLED=true`), i
 flow:
 
 1. <../lib/datadog/profiling/preload.rb> triggers the creation of the profiler instance by calling the method `Datadog::Profiling.start_if_enabled`
-2. The profiler instance is handled by `Datadog::Configuration`, which triggers the configuration of `ddtrace` components
-   in `#build_components`
-3. Inside `Datadog::Components`, the `build_profiler` method triggers the execution of the `Tasks::Setup`
-4. The `Setup` task activates our extensions
-    * `Datadog::Profiling::Ext::Forking`
+2. Creation of the profiler instance is handled by `Datadog::Configuration`, which triggers the configuration of all
+  `ddtrace` components in `#build_components`
+3. Inside `Datadog::Components`, the `build_profiler` method triggers the execution of the `Tasks::Setup` task
+4. The `Setup` task activates our extensions (`Datadog::Profiling::Ext::Forking`)
 5. Still inside `Datadog::Components`, the `build_profiler` method then creates and wires up the Profiler as such:
     ```asciiflow
             +------------+
@@ -52,17 +51,17 @@ flow:
     +---------+--+  +-+-------+-+
               |       |       |
               v       |       v
-     +--------+-+     |  +----+------+
-     | OldStack |     |  | Exporters |
-     +--------+-+     |  +-----------+
+     +--------+-+     |  +----+----------+
+     | OldStack |     |  | HttpTransport |
+     +--------+-+     |  +---------------+
               |       |
               v       v
-            +-+-------+-+
-            | Recorder  |
-            +-----------+
-              |
-              v
-        +-----------------+
+    +---------+---+  ++---------+
+    | OldRecorder |<-| Exporter |
+    +-------------+  +-+--------+
+                       |
+                       v
+        +--------------+--+
         | Code Provenance |
         +-----------------+
     ```
@@ -73,11 +72,11 @@ flow:
 During run-time, the `Scheduler` and the `Collectors::OldStack` each execute on their own background thread.
 
 The `Collectors::OldStack` samples stack traces of threads, capturing both CPU-time (if available) and wall-clock, storing
-them in the `Recorder`.
+them in the `OldRecorder`.
 
-The `Scheduler` wakes up every 1 minute to flush the results of the `Recorder` into one or more `exporter`s.
-Usually only one exporter is in use. By default, the `Exporter` delegates to the default `Transport::HTTP` transport, which
-takes care of encoding the data and reporting it to the datadog agent (or to the API, when running without an agent).
+The `Scheduler` wakes up every 1 minute to flush the results of the `Exporter` into the transport.
+By default, the `Scheduler` gets created with the default `HttpTransport`, which
+takes care of encoding the data and reporting it to the Datadog agent.
 
 ## How CPU-time profiling works
 

data/docs/UpgradeGuide.md

@@ -84,7 +84,7 @@ Datadog.configure do |c|
   # Global settings
   c.tracer.hostname = '127.0.0.1'
   c.tracer.port = 8126
-  c.runtime_metrics.enabled = true
+  c.runtime_metrics_enabled = true
   c.service = 'billing-api'
 
   # Tracing settings

data/ext/ddtrace_profiling_loader/ddtrace_profiling_loader.c

@@ -41,7 +41,7 @@ static void unload_failed_library(void *handle);
 
 #define DDTRACE_EXPORT __attribute__ ((visibility ("default")))
 
-void DDTRACE_EXPORT Init_ddtrace_profiling_loader() {
+void DDTRACE_EXPORT Init_ddtrace_profiling_loader(void) {
   VALUE datadog_module = rb_define_module("Datadog");
   VALUE profiling_module = rb_define_module_under(datadog_module, "Profiling");
   VALUE loader_module = rb_define_module_under(profiling_module, "Loader");

data/ext/ddtrace_profiling_loader/extconf.rb

@@ -1,4 +1,5 @@
 # typed: ignore
+
 # rubocop:disable Style/StderrPuts
 # rubocop:disable Style/GlobalVars
 

data/ext/ddtrace_profiling_native_extension/NativeExtensionDesign.md

@@ -10,13 +10,13 @@ JRuby or TruffleRuby. When below we say "Ruby", read it as "MRI Ruby".
 
 ## Disabling
 
-The profiling native extension can be disabled by setting `DD_PROFILING_NO_EXTENSION=true` when installing or running
+The profiling native extension can be disabled by setting `DD_PROFILING_NO_EXTENSION=true` when installing
 the gem. Setting `DD_PROFILING_NO_EXTENSION` at installation time skips compilation of the extension entirely.
 
 (If you're a customer and needed to use this, please tell us why on <https://github.com/DataDog/dd-trace-rb/issues/new>.)
 
-Currently the profiler can still "limp along" when the native extension is disabled, but the plan is to require it
-in future releases -- e.g. disabling the extension will disable profiling entirely.
+In past releases, it was possible for the profiler to run without the native extension, but that's no longer the case,
+and disabling the extension will disable profiling.
 
 ## Must not block or break users that cannot use it
 
@@ -44,13 +44,15 @@ We avoid issues using a combination of:
 * Avoiding calling Ruby VM APIs after doing dynamic allocations
 * Wrapping dynamic allocations into Ruby GC-managed objects (using `TypedData_Wrap_Struct`), so that Ruby will manage
   their lifetime and call `free` when the GC-managed object is no longer being referenced
+* Using [`rb_protect` and similar APIs](https://silverhammermba.github.io/emberb/c/?#rescue) to run cleanup code on
+  exception cases
 
 Non-exhaustive list of APIs that cause exceptions to be raised:
 
 * `Check_TypedStruct`, `Check_Type`
 * `rb_funcall`
 * `rb_thread_call_without_gvl`, `rb_thread_call_without_gvl2`
-* [Numeric conversion APIs, e.g. `NUM2LONG`, `NUM2INT`, etc.](https://silverhammermba.github.io/emberb/c/?utm_source=pocket_mylist#translation)
+* [Numeric conversion APIs, e.g. `NUM2LONG`, `NUM2INT`, etc.](https://silverhammermba.github.io/emberb/c/?#translation)
 * Our `char_slice_from_ruby_string` helper
 
 ## Usage of private VM headers
@@ -90,7 +92,6 @@ Thus, even though a regular Ruby installation does not include these files, we c
 ## Feature: Getting thread CPU-time clock_ids
 
 * **OS support**: Linux
-* **Ruby support**: 2.6+
 
 To enable CPU-time profiling, we use the `pthread_getcpuclockid(pthread_t thread, clockid_t *clockid)` C function to
 obtain a `clockid_t` that can then be used with the `Process.clock_gettime` method (or directly with the

data/ext/ddtrace_profiling_native_extension/clock_id.h

@@ -1,4 +1,4 @@
 #pragma once
 
-void self_test_clock_id();
+void self_test_clock_id(void);
 VALUE clock_id_for(VALUE self, VALUE thread);

data/ext/ddtrace_profiling_native_extension/clock_id_from_pthread.c

@@ -13,7 +13,7 @@
 #include "clock_id.h"
 
 // Validate that our home-cooked pthread_id_for() matches pthread_self() for the current thread
-void self_test_clock_id() {
+void self_test_clock_id(void) {
   rb_nativethread_id_t expected_pthread_id = pthread_self();
   rb_nativethread_id_t actual_pthread_id = pthread_id_for(rb_thread_current());
 

data/ext/ddtrace_profiling_native_extension/clock_id_noop.c

@@ -8,7 +8,7 @@
 
 #include "clock_id.h"
 
-void self_test_clock_id() { } // Nothing to check
+void self_test_clock_id(void) { } // Nothing to check
 VALUE clock_id_for(VALUE self, VALUE thread) { return Qnil; } // Nothing to return
 
 #endif