dblint 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a456608b04d3132f18e4c9de00ab708d799e0373
-  data.tar.gz: 17a007e706e33f5d7a72406d8c98dfebe3783c8d
+  metadata.gz: 5882547f7ba7be4f29dfbd2e4fc685168e656036
+  data.tar.gz: 1171ff0b3c9bdd3f8fb3d94d48fdff3ff041fb35
 SHA512:
-  metadata.gz: fe6ca2ea60ab241e5e680751ad05c96bf58045f0a0fa947812f4add848264dbc3f55adade3e92b041715d2a252ec6a1d5a34b074603998373124518c5f836caf
-  data.tar.gz: 838612d7f6f26f839228a115c5168ff00dc23ee9098de039dfa5c098e7f3164f31b38d3f4f15fddd62e166eed72ab92e374f5ae4f52fef4f0f8b1fd73e405a5a
+  metadata.gz: 72f796d6ddf84cf2ccb305e6e182b4172b0ced77455ed1377d563a65fe851ee731b6538386b3ad25b97b4e7467a45e993b321cc7bbf25bb36a31439ecabd8845
+  data.tar.gz: 4734c644bb32a0f13a61cce0e2235351516ab241c3e403f65fe035f2e2f571c80b7da91a676281d317aca882948aa944dfa43a1fca74dbca29fe0c76a413e12b

data/.travis.yml

@@ -1,3 +1,17 @@
 language: ruby
 rvm:
-  - 2.2.0
+  - 1.9.3-p551
+  - 2.0.0-p648
+  - 2.1.8
+  - 2.2.4
+  - 2.3.1
+  - rbx-3.20
+addons:
+  postgresql: 9.4
+env:
+  - DATABASE_URL=postgresql://postgres@localhost:5432/dblint
+before_install:
+  - gem install bundler
+before_script:
+  - createdb dblint
+script: bundle exec rake

data/CHANGELOG.md

@@ -0,0 +1,10 @@
+# Changelog
+
+## 0.1.1    2016-04-27
+
+* Fix handling of vendored gems [#1](https://github.com/lfittl/dblint/pull/1) [@ksykulev](https://github.com/ksykulev)
+
+
+## 0.1.0    2015-05-04
+
+* Initial release

data/README.md

@@ -1,7 +1,8 @@
-# dblint [ ![Codeship Status for lfittl/dblint](https://img.shields.io/codeship/db703270-cfa3-0132-a2bb-623bdb9b8d89.svg)](https://codeship.com/projects/76752)
+# dblint [ ![](https://img.shields.io/gem/v/dblint.svg)](https://rubygems.org/gems/dblint) [ ![](https://img.shields.io/gem/dt/dblint.svg)](https://rubygems.org/gems/dblint) [ ![](https://travis-ci.org/lfittl/dblint.svg?branch=master)](https://travis-ci.org/lfittl/dblint)
 
 Automatically checks all SQL queries that are executed during your tests, to find common mistakes, including missing indices and locking issues due to long transactions.
 
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -27,7 +28,7 @@ Note that it will check the callstack for the problematic query, and only count
 ```
 Failures:
 
-  1) FeedsController#show 
+  1) FeedsController#show
      Failure/Error: get :show, format: :atom
      Dblint::Checks::MissingIndex::Error:
        Missing index on oauth_applications for '((twitter_app_name)::text = 'My Feed App'::text)' in 'SELECT  "oauth_applications".* FROM "oauth_applications" WHERE "oauth_applications"."twitter_app_name" = $1 LIMIT 1', called by app/controllers/feeds_controller.rb:6:in `show'
@@ -89,3 +90,14 @@ application, also included in the error message for the check.
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create a new Pull Request
+
+
+## Authors
+
+- [Lukas Fittl](mailto:lukas@fittl.com)
+
+
+## License
+
+Copyright (c) 2015, Lukas Fittl <lukas@fittl.com><br>
+dblint is licensed under the MIT license, see LICENSE.txt file for details.

data/dblint.gemspec

@@ -26,6 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec-rails'
   spec.add_development_dependency 'sqlite3'
   spec.add_development_dependency 'dotenv'
-  spec.add_development_dependency 'rubocop', '~> 0.30'
+  spec.add_development_dependency 'rubocop', '~> 0.39'
   spec.add_development_dependency 'rubocop-rspec'
 end

data/lib/dblint/checks/base.rb

@@ -8,10 +8,12 @@ module Dblint
       end
 
       def find_main_app_caller(callstack)
-        main_app_caller = callstack.find { |f| f.start_with?(Rails.root.to_s) }
+        main_app_caller = callstack.find { |f| f.start_with?(Rails.root.to_s) && !f.include?('/vendor/bundle') }
         main_app_caller.slice!(Rails.root.to_s + '/')
-        main_app_dir    = main_app_caller[/^\w+/]
+
+        main_app_dir = main_app_caller[/^\w+/]
         return if %w(spec test).include?(main_app_dir)
+
         main_app_caller
       end
 

data/lib/dblint/checks/long_held_lock.rb

@@ -83,7 +83,7 @@ module Dblint
 
           # We need an explicit begin here since we're interrupting the transaction flow
           ActiveRecord::Base.connection.execute('BEGIN')
-          fail Error, error_msg
+          raise Error, error_msg
 
           # TODO: Add a config setting for enabling this as a warning
           # puts format('Warning: %s', error_msg)

data/lib/dblint/checks/missing_index.rb

@@ -34,7 +34,7 @@ module Dblint
 
           error_msg = format("Missing index on %s for '%s' in '%s', called by %s",
                              plan['Relation Name'], plan['Filter'], payload[:sql], main_app_caller)
-          fail Error, error_msg
+          raise Error, error_msg
         end
 
         (plan['Plans'] || []).each do |subplan|

data/lib/dblint/rails_integration.rb

@@ -5,7 +5,7 @@ module Dblint
     CHECKS = [
       Dblint::Checks::LongHeldLock,
       Dblint::Checks::MissingIndex
-    ]
+    ].freeze
 
     def check_instance_for_connection(connid, klass)
       @checks ||= {}

data/lib/dblint/version.rb

@@ -1,3 +1,3 @@
 module Dblint
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dblint
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Lukas Fittl
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-04 00:00:00.000000000 Z
+date: 2016-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.30'
+        version: '0.39'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.30'
+        version: '0.39'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -176,6 +176,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -208,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Automatically tests your Rails app for common database query mistakes