dbalatero-fpswax 0.0.3 → 0.0.4

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 0
-:patch: 3
+:patch: 4
 :major: 0

data/lib/fpswax.rb

@@ -1,5 +1,6 @@
 $LOAD_PATH.unshift(File.expand_path(File.dirname(__FILE__)))
 
+require 'cgi'
 require 'logger'
 require 'openssl'
 require 'nokogiri'

data/lib/fpswax/multi_use_pipeline_request.rb

@@ -34,7 +34,7 @@ module Fpswax
 
     def create_url!
       @url = "" << cbui_url << "?awsSignature=#{@signature}&"
-      @url << @params.keys.map { |key| "#{key}=#{@params[key]}" }.join('&')
+      @url << @params.keys.map { |key| "#{key}=#{CGI.escape(@params[key].to_s)}" }.join('&')
     end
   end
 end

data/spec/fpswax/multi_use_pipeline_request_spec.rb

@@ -12,7 +12,7 @@ describe Fpswax::MultiUsePipelineRequest do
 
 
     it "should add the access key" do
-      @request.url.should =~ /callerKey=my access key/
+      @request.url.should =~ /callerKey=my\+access\+key/
     end
 
     it "should calculate an HMAC signature" do
@@ -28,7 +28,19 @@ describe Fpswax::MultiUsePipelineRequest do
     end
 
     it "should contain any parameters passed in" do
-      @request.url.should =~ /&returnURL=http:\/\/return_url/
+      @request.url.should =~ /&returnURL=http%3A%2F%2Freturn_url/
+    end
+
+    it "should urlencode every parameter" do
+      request = Fpswax::MultiUsePipelineRequest.new(
+        'foo',
+        'bar',
+        :var1 => "ok let's do this",
+        :var2 => "ok here+ is more### stuff ://"
+      )
+
+      request.url.should =~ /var1=ok\+let%27s\+do\+this/
+      request.url.should =~ /var2=ok\+here%2B\+is\+more%23%23%23\+stuff\+%3A%2F%2F/
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: dbalatero-fpswax
 version: !ruby/object:Gem::Version 
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors: 
 - David Balatero
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-05-25 00:00:00 -07:00
+date: 2009-05-28 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency