db_memoize 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 254ec2be767020e1ff61a4b5ddbfc561f894b716
-  data.tar.gz: b27ccaf67e4a4dc32901fe802ab6b7da5872d9ba
+  metadata.gz: ec9a05ceb15a0252b3e145983035f1192d9252c4
+  data.tar.gz: 53190328b2d6a04e861bc0d4d88dd29aea61ad7c
 SHA512:
-  metadata.gz: e430b58340a10f27910e558068cca7ac75ab8e07ec9d0aa5898d340aeeaa142dc3241779d3f1c02d16755d8390ddaee44518a704c563e9c5b7a5aa2ac670ea36
-  data.tar.gz: 82949ec2ac4094966459edbeadb5f34c91f03d9f20cda7e98ee9c1978b3b6fb12a671623473fdb7db88554a01f0ec9fcfb28c8fe8da873f5f218adbd1d07b430
+  metadata.gz: 1da1fe68e2389d0d6a74ac03d38f486fcd249f58142f52e4fa5aa3b683a1905f2dc879bd57f188957519fb3181bcbd2fca2dcd521071e155ed3fda6e20e3cfe4
+  data.tar.gz: f448a8946e63346fe401d763d396994638ced3cf9e25340ea36b40fcc26372654da88e9593bcbf18f596497325f3dc40c5ae4fc7877421a36d7f5b3489f41d0b

data/README.md

@@ -103,6 +103,14 @@ class CreateMemoizedValues < ActiveRecord::Migration
 end
 ```
 
+### Testing
+
+Note that db_memoize needs Postgres. To set up the database needed to run tests, this is what you can do:
+
+    # sudo su postgresql
+    # createuser >>yourusername<<
+    # createdb -O >>yourusername<< db_memoize_test
+
 
 Have fun!
 

data/lib/db_memoize/metal.rb

@@ -46,20 +46,37 @@ module DbMemoize
         @base_klass.columns_hash.key?(column_name)
       end
 
-      def insert_sql(field_names)
-        @query_cache[field_names] ||= _insert_sql(field_names)
+      class Inserter
+        def initialize(sql:, bytea_indices:)
+          @sql           = sql
+          @bytea_indices = bytea_indices
+        end
+
+        def exec(raw_connection:, values:)
+          @bytea_indices.each do |bytea_index|
+            value = values[bytea_index]
+            values[bytea_index] = PGconn.escape_bytea(value) if value
+          end
+
+          raw_connection.exec_params(@sql, values)
+        end
+      end
+
+      # returns an Inserter
+      def inserter(field_names)
+        @query_cache[field_names] ||= _inserter(field_names)
       end
 
       DATABASE_IDENTIFIER_REGEX = /\A\w+\z/
 
       def check_database_identifiers!(*strings)
         strings.each do |s|
-          next if DATABASE_IDENTIFIER_REGEX =~ s.to_s
+          next if DATABASE_IDENTIFIER_REGEX =~ s
           raise ArgumentError, "Invalid database identifier: #{s.inspect}"
         end
       end
 
-      def _insert_sql(field_names)
+      def _inserter(field_names)
         check_database_identifiers! table_name, *field_names
 
         placeholders = 0.upto(field_names.count - 1).map { |idx| "$#{idx + 1}" }
@@ -76,16 +93,24 @@ module DbMemoize
 
         sql = "INSERT INTO #{table_name} (#{field_names.join(',')}) VALUES(#{placeholders.join(',')})"
         sql += " RETURNING #{primary_key.column}" if primary_key.column
-        sql
+
+        columns_hash  = @base_klass.columns_hash
+        bytea_indices = []
+        field_names.each_with_index { |column, idx|
+          next unless :binary == columns_hash.fetch(column).type
+          bytea_indices << idx
+        }
+
+        Inserter.new sql: sql, bytea_indices: bytea_indices
       end
 
       public
 
       def create!(record)
         keys, values = record.to_a.transpose
+        keys = keys.map(&:to_s)
 
-        sql    = insert_sql(keys)
-        result = raw_connection.exec_params(sql, values)
+        result = inserter(keys).exec(raw_connection: raw_connection, values: values)
 
         # if we don't have an ID column then the sql does not return any value. The result
         # object would be this: #<PG::Result status=PGRES_COMMAND_OK ntuples=0 nfields=0 cmd_tuples=1>

data/lib/db_memoize/version.rb

@@ -1,3 +1,3 @@
 module DbMemoize
-  VERSION = '0.2.1'.freeze
+  VERSION = '0.2.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: db_memoize
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - johannes-kostas goetzinger
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-19 00:00:00.000000000 Z
+date: 2017-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties