datts_right 0.0.17 → 0.0.18

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    datts_right (0.0.16)
+    datts_right (0.0.17)
       datts_right
       rails (>= 3.0.0)
 

data/VERSION

@@ -1 +1 @@
-0.0.17
+0.0.18

data/datts_right.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{datts_right}
-  s.version = "0.0.17"
+  s.version = "0.0.18"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ramon Tayag"]
@@ -257,6 +257,12 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
       s.add_development_dependency(%q<rcov>, [">= 0"])
+      s.add_development_dependency(%q<autotest>, [">= 0"])
+      s.add_development_dependency(%q<sqlite3>, [">= 0"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_development_dependency(%q<rcov>, [">= 0"])
     else
       s.add_dependency(%q<datts_right>, [">= 0"])
       s.add_dependency(%q<rails>, [">= 3.0.0"])
@@ -447,6 +453,12 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
       s.add_dependency(%q<rcov>, [">= 0"])
+      s.add_dependency(%q<autotest>, [">= 0"])
+      s.add_dependency(%q<sqlite3>, [">= 0"])
+      s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_dependency(%q<rcov>, [">= 0"])
     end
   else
     s.add_dependency(%q<datts_right>, [">= 0"])
@@ -638,6 +650,12 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
     s.add_dependency(%q<rcov>, [">= 0"])
+    s.add_dependency(%q<autotest>, [">= 0"])
+    s.add_dependency(%q<sqlite3>, [">= 0"])
+    s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+    s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+    s.add_dependency(%q<rcov>, [">= 0"])
   end
 end
 

data/lib/datts_right/base.rb

@@ -8,7 +8,7 @@ module DattsRight
       has_many :dynamic_attributes, :as => :attributable, :dependent => :destroy
       has_one :dynamic_attribute_definition, :as => :attribute_defineable, :dependent => :destroy
       after_save :save_dynamic_attribute_definition
-      after_create :create_dynamic_attribute_definition, :inherit_definition
+      after_create :create_dynamic_attribute_definition_if_needed, :inherit_definition
       delegate :definition, :definition=, :to => :dynamic_attribute_definition
 
       # Carry out delayed actions before save
@@ -68,7 +68,7 @@ module DattsRight
       # Used when you have already existing records that have don't have definitions, and you want them to
       def self.create_definitions!
         self.all.each do |record|
-          puts "Called create_definitions! on #{record.inspect}. Its dynamic_attribute_definition (if it has one: #{record.dynamic_attribute_definition.inspect})"
+          #puts "Called create_definitions! on #{record.inspect}. Its dynamic_attribute_definition (if it has one: #{record.dynamic_attribute_definition.inspect})"
           record.dynamic_attribute_definition.create if dynamic_attributes_options[:definition] && record.dynamic_attribute_definition.nil?
         end
       end

data/lib/datts_right/instance_methods.rb

@@ -145,8 +145,14 @@ module DattsRight
       end
     end
 
+    def create_dynamic_attribute_definition_if_needed
+      if dynamic_attributes_options[:definition]
+        DynamicAttributeDefinition.create :attribute_defineable_id => self.id, :attribute_defineable_type => self.class.name
+      end
+    end
+
     def save_dynamic_attribute_definition
-      dynamic_attribute_definition.save
+      dynamic_attribute_definition.save if dynamic_attribute_definition
     end
 
     def inherit_definition

data/spec/datts_right_spec.rb

@@ -453,4 +453,10 @@ describe DattsRight do
       }.should raise_error(ActiveRecord::UnknownAttributeError, "unknown attribute: body")
     end
   end
+
+  describe "on the definition" do
+    it "should not be created if it is not defined" do
+      Page.create.dynamic_attribute_definition.should be_nil
+    end
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: datts_right
 version: !ruby/object:Gem::Version 
-  hash: 61
+  hash: 59
   prerelease: 
   segments: 
   - 0
   - 0
-  - 17
-  version: 0.0.17
+  - 18
+  version: 0.0.18
 platform: ruby
 authors: 
 - Ramon Tayag
@@ -2854,6 +2854,96 @@ dependencies:
   name: rcov
   version_requirements: *id189
   prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id190 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: autotest
+  version_requirements: *id190
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id191 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: sqlite3
+  version_requirements: *id191
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id192 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 2
+        - 3
+        - 0
+        version: 2.3.0
+  name: rspec
+  version_requirements: *id192
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id193 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 23
+        segments: 
+        - 1
+        - 0
+        - 0
+        version: 1.0.0
+  name: bundler
+  version_requirements: *id193
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id194 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 1
+        - 5
+        - 2
+        version: 1.5.2
+  name: jeweler
+  version_requirements: *id194
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id195 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: rcov
+  version_requirements: *id195
+  prerelease: false
 description: Creates a separate table that saves all your dynamic attributes.
 email: ramon@tayag.net
 executables: []