datts_right 0.0.12 → 0.0.13

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    datts_right (0.0.11)
+    datts_right (0.0.12)
       datts_right
       rails (>= 3.0.0)
 

data/VERSION

@@ -1 +1 @@
-0.0.12
+0.0.13

data/datts_right.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{datts_right}
-  s.version = "0.0.12"
+  s.version = "0.0.13"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ramon Tayag"]
@@ -35,6 +35,9 @@ Gem::Specification.new do |s|
     "lib/datts_right/page.rb",
     "lib/datts_right/query_methods.rb",
     "spec/datt_spec.rb",
+    "spec/datts_right/add_dynamic_attributes_spec.rb",
+    "spec/datts_right/attributes_spec.rb",
+    "spec/datts_right/remove_dynamic_attribute_spec.rb",
     "spec/datts_right_spec.rb",
     "spec/spec_helper.rb"
   ]
@@ -45,6 +48,9 @@ Gem::Specification.new do |s|
   s.summary = %q{Allows saving of dynamic attributes in your ActiveRecord model}
   s.test_files = [
     "spec/datt_spec.rb",
+    "spec/datts_right/add_dynamic_attributes_spec.rb",
+    "spec/datts_right/attributes_spec.rb",
+    "spec/datts_right/remove_dynamic_attribute_spec.rb",
     "spec/datts_right_spec.rb",
     "spec/spec_helper.rb"
   ]
@@ -200,6 +206,12 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
       s.add_development_dependency(%q<rcov>, [">= 0"])
+      s.add_development_dependency(%q<autotest>, [">= 0"])
+      s.add_development_dependency(%q<sqlite3>, [">= 0"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_development_dependency(%q<rcov>, [">= 0"])
     else
       s.add_dependency(%q<datts_right>, [">= 0"])
       s.add_dependency(%q<rails>, [">= 3.0.0"])
@@ -348,6 +360,12 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
       s.add_dependency(%q<rcov>, [">= 0"])
+      s.add_dependency(%q<autotest>, [">= 0"])
+      s.add_dependency(%q<sqlite3>, [">= 0"])
+      s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_dependency(%q<rcov>, [">= 0"])
     end
   else
     s.add_dependency(%q<datts_right>, [">= 0"])
@@ -497,6 +515,12 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
     s.add_dependency(%q<rcov>, [">= 0"])
+    s.add_dependency(%q<autotest>, [">= 0"])
+    s.add_dependency(%q<sqlite3>, [">= 0"])
+    s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+    s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+    s.add_dependency(%q<rcov>, [">= 0"])
   end
 end
 

data/lib/datts_right/instance_methods.rb

@@ -73,6 +73,35 @@ module DattsRight
       end
     end
 
+    def attributes=(new_attributes, guard_protected_attributes = true)
+      return unless new_attributes.is_a?(Hash)
+      attributes = new_attributes.stringify_keys
+
+      multi_parameter_attributes = []
+      attributes = sanitize_for_mass_assignment(attributes) if guard_protected_attributes
+
+      attributes.each do |k, v|
+        if k.include?("(")
+          multi_parameter_attributes << [ k, v ]
+        else
+          #respond_to?(:"#{k}=") ? send(:"#{k}=", v) : raise(UnknownAttributeError, "unknown attribute: #{k}")
+          begin
+            send("#{k}=", v)
+            #puts "Set super #{k} to #{v}"
+          rescue NoMethodError => e
+            #puts "NoMethodError was raised: #{e}, so we now check to see if '#{k}' is dynamic_attribute"
+            if dynamic_attribute?(k)
+              write_dynamic_attribute("#{k}", v)
+            else
+              raise ActiveRecord::UnknownAttributeError, "unknown attribute: #{k}"
+            end
+          end
+        end
+      end
+
+      assign_multiparameter_attributes(multi_parameter_attributes)
+    end
+
     private
 
     # Called after validation on update so that dynamic attributes behave

data/spec/datts_right/add_dynamic_attributes_spec.rb

@@ -0,0 +1,37 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe DattsRight, ".add_dynamic_attribute(attr_key, object_type)" do
+  before do
+    reset_database
+    @page = Page.create
+  end
+
+  it "should be aliased by add_datt" do
+    Page.instance_method(:add_dynamic_attribute).should == Page.instance_method(:add_datt)
+  end
+
+  it "should add a dynamic attribute" do
+    @page.add_dynamic_attribute(:rocks, "string")
+    @page.dynamic_attribute_details(:rocks).value.should be_nil
+    @page.add_dynamic_attribute(:rock, "string", "123")
+    @page.read_datt(:rock).should == "123"
+    @page.dynamic_attribute_details(:rock).value.should == "123"
+  end
+
+  it "should ignore when trying to add same attribute" do
+    @page.add_dynamic_attribute(:rocks, "string")
+    @page.add_dynamic_attribute(:rocks, "integer")
+    @page.dynamic_attribute_details(:rocks).object_type.should == "string"
+  end
+
+  it "should return false if the method that is being added already exists" do
+    @page.add_dynamic_attribute(:name, "text").should be_false
+  end
+
+  it "should not make any changes to the original attribute" do
+    @page.update_attribute(:name, "juno")
+    @page.add_dynamic_attribute(:name, "text")
+    @page.name.should == "juno"
+  end
+end
+

data/spec/datts_right/attributes_spec.rb

@@ -0,0 +1,21 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe DattsRight, ".attributes=" do
+  before do
+    reset_database
+    @page = Page.create
+  end
+
+  it "should accept a mix of normal and dynamic attributes" do
+    @page.add_dynamic_attribute(:price, "integer", 200)
+    @page.attributes = {:name => "fark", :price => 300}
+    @page.name.should == "fark"
+    @page.read_datt(:price).should == 300
+  end
+
+  it "should raise UnknownAttributeError if the attribute doesn't exist" do
+    lambda {
+      @page.attributes = {:name => "fark", :body => "lark"}
+    }.should raise_error(ActiveRecord::UnknownAttributeError, "unknown attribute: body")
+  end
+end

data/spec/datts_right/remove_dynamic_attribute_spec.rb

@@ -0,0 +1,26 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe DattsRight, ".remove_dynamic_attribute(attr_key)" do
+  before do
+    reset_database
+    @page = Page.create
+  end
+
+  it "should be aliased by remove_datt" do
+    Page.instance_method(:remove_dynamic_attribute).should == Page.instance_method(:remove_datt)
+  end
+
+  it "should remove the attribute completely" do
+    @page.add_dynamic_attribute(:rocks, "string")
+    @page.remove_dynamic_attribute(:rocks)
+    lambda { @page.rocks }.should raise_error(NoMethodError)
+  end
+
+  it "should not explode if the attribute being removed isn't there" do
+    @page.add_dynamic_attribute(:rocks, "string")
+    @page.remove_dynamic_attribute(:rocks)
+    lambda {
+      @page.remove_dynamic_attribute(:rocks)
+    }.should_not raise_error(NoMethodError)
+  end
+end

data/spec/datts_right_spec.rb

@@ -1,4 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+# Raised when unknown attributes are supplied via mass assignment.
+#class UnknownAttributeError < NoMethodError
+#end
 
 describe DattsRight do
   before do
@@ -435,4 +438,19 @@ describe DattsRight do
     @page.save
     @page.body.should == "dude"
   end
+
+  describe ".attributes=" do
+    it "should accept a mix of normal and dynamic attributes" do
+      @page.add_dynamic_attribute(:price, "integer", 200)
+      @page.attributes = {:name => "fark", :price => 300}
+      @page.name.should == "fark"
+      @page.read_datt(:price).should == 300
+    end
+
+    it "should raise UnknownAttributeError if the attribute doesn't exist" do
+      lambda {
+        @page.attributes = {:name => "fark", :body => "lark"}
+      }.should raise_error(ActiveRecord::UnknownAttributeError, "unknown attribute: body")
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -2,6 +2,7 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'rubygems'
 require 'active_record'
+require 'active_record/errors'
 require 'rspec'
 require 'datts_right'
 require 'datts_right/page'

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: datts_right
 version: !ruby/object:Gem::Version 
-  hash: 7
+  hash: 5
   prerelease: 
   segments: 
   - 0
   - 0
-  - 12
-  version: 0.0.12
+  - 13
+  version: 0.0.13
 platform: ruby
 authors: 
 - Ramon Tayag
@@ -2224,6 +2224,96 @@ dependencies:
   name: rcov
   version_requirements: *id147
   prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id148 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: autotest
+  version_requirements: *id148
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id149 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: sqlite3
+  version_requirements: *id149
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id150 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 2
+        - 3
+        - 0
+        version: 2.3.0
+  name: rspec
+  version_requirements: *id150
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id151 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 23
+        segments: 
+        - 1
+        - 0
+        - 0
+        version: 1.0.0
+  name: bundler
+  version_requirements: *id151
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id152 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 1
+        - 5
+        - 2
+        version: 1.5.2
+  name: jeweler
+  version_requirements: *id152
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id153 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: rcov
+  version_requirements: *id153
+  prerelease: false
 description: Creates a separate table that saves all your dynamic attributes.
 email: ramon@tayag.net
 executables: []
@@ -2252,6 +2342,9 @@ files:
 - lib/datts_right/page.rb
 - lib/datts_right/query_methods.rb
 - spec/datt_spec.rb
+- spec/datts_right/add_dynamic_attributes_spec.rb
+- spec/datts_right/attributes_spec.rb
+- spec/datts_right/remove_dynamic_attribute_spec.rb
 - spec/datts_right_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
@@ -2290,5 +2383,8 @@ specification_version: 3
 summary: Allows saving of dynamic attributes in your ActiveRecord model
 test_files: 
 - spec/datt_spec.rb
+- spec/datts_right/add_dynamic_attributes_spec.rb
+- spec/datts_right/attributes_spec.rb
+- spec/datts_right/remove_dynamic_attribute_spec.rb
 - spec/datts_right_spec.rb
 - spec/spec_helper.rb