datts_right 0.0.10 → 0.0.11

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    datts_right (0.0.9)
+    datts_right (0.0.10)
       datts_right
       rails (>= 3.0.0)
 

data/VERSION

@@ -1 +1 @@
-0.0.10
+0.0.11

data/datts_right.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{datts_right}
-  s.version = "0.0.10"
+  s.version = "0.0.11"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ramon Tayag"]
@@ -182,6 +182,12 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
       s.add_development_dependency(%q<rcov>, [">= 0"])
+      s.add_development_dependency(%q<autotest>, [">= 0"])
+      s.add_development_dependency(%q<sqlite3>, [">= 0"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_development_dependency(%q<rcov>, [">= 0"])
     else
       s.add_dependency(%q<datts_right>, [">= 0"])
       s.add_dependency(%q<rails>, [">= 3.0.0"])
@@ -312,6 +318,12 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
       s.add_dependency(%q<rcov>, [">= 0"])
+      s.add_dependency(%q<autotest>, [">= 0"])
+      s.add_dependency(%q<sqlite3>, [">= 0"])
+      s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_dependency(%q<rcov>, [">= 0"])
     end
   else
     s.add_dependency(%q<datts_right>, [">= 0"])
@@ -443,6 +455,12 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
     s.add_dependency(%q<rcov>, [">= 0"])
+    s.add_dependency(%q<autotest>, [">= 0"])
+    s.add_dependency(%q<sqlite3>, [">= 0"])
+    s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+    s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+    s.add_dependency(%q<rcov>, [">= 0"])
   end
 end
 

data/lib/datts_right/dynamic_attribute.rb

@@ -10,15 +10,9 @@ class DynamicAttribute < ActiveRecord::Base
   def value=(v)
     object_type = self.class.attr_type?(v)
 
-    # only allow object_type changes if this is NOT a new record
-    # and it's text to string or vice versa
-    interchangeable_types = %w(text string)
-    #puts "#{attr_key} is currently a #{self.object_type}, and we wanna make it a #{object_type}"
-    if !new_record? && interchangeable_types.include?(self.object_type) && interchangeable_types.include?(object_type) && self.object_type != object_type
-      #puts "#{attr_key} is not new, and we're setting object_type to #{object_type}"
-      self.object_type = object_type
+    if self.object_type == object_type # has to be the same kind of object
       send "#{self.class.attr_column(v)}=", v
-    elsif self.object_type == object_type # has to be the same kind of object
+    elsif v.nil?
       send "#{self.object_type}_value=", v
     end
   end

data/spec/datt_spec.rb

@@ -5,16 +5,4 @@ describe DynamicAttribute do
     reset_database
     @page = Page.create
   end
-
-  it "should allow transferring between String and Text" do
-    @page.add_dynamic_attribute(:foo, "string")
-    @page.write_dynamic_attribute :foo, "this is a string"
-    @page.save
-    @page.write_dynamic_attribute :foo, "t"*300
-    @page.save
-    @page.dynamic_attributes.find_by_attr_key("foo").object_type.should == "text"
-    @page.write_dynamic_attribute :foo, "this is a string again"
-    @page.save
-    @page.dynamic_attributes.find_by_attr_key("foo").object_type.should == "string"
-  end
 end

data/spec/datts_right_spec.rb

@@ -15,6 +15,7 @@ describe DattsRight do
       @page.add_dynamic_attribute(:rocks, "string")
       @page.dynamic_attribute_details(:rocks).value.should be_nil
       @page.add_dynamic_attribute(:rock, "string", "123")
+      @page.read_datt(:rock).should == "123"
       @page.dynamic_attribute_details(:rock).value.should == "123"
     end
 
@@ -33,11 +34,6 @@ describe DattsRight do
       @page.add_dynamic_attribute(:name, "text")
       @page.name.should == "juno"
     end
-
-    it "should still work after reloading" do
-      @page.add_dynamic_attribute(:rocks, "string")
-      @page = Page.last
-    end
   end
 
   describe ".remove_dynamic_attribute(attr_key)" do
@@ -60,13 +56,6 @@ describe DattsRight do
     end
   end
 
-  describe ".dynamic_columns(reload)" do
-    it "should return an array of symbols of the available dynamic columns" do
-      @page.add_dynamic_attribute(:rocks, "string")
-      @page.dynamic_attribute?(:rocks).should be_true
-    end
-  end
-
   it "should not allow arbitrary creation of attributes" do
     lambda {
       @page.some_field = "woot"
@@ -417,12 +406,12 @@ describe DattsRight do
 
   describe "when loading from database" do
     it "should load the dynamic attributes for use" do
-      @page.add_dynamic_attribute(:price, "integer")
-      @page.write_dynamic_attribute(:price, 200)
+      @page.add_datt(:body, "text")
+      @page.write_datt(:body, "t"*300)
       @page.save
       @page = Page.last
-      @page.read_datt(:price).should == 200
-      @page.dynamic_attribute_details(:price).value.should == 200
+      @page.read_datt(:body).should == "t"*300
+      @page.dynamic_attribute_details(:body).value.should == @page.read_datt(:body)
     end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: datts_right
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 9
   prerelease: 
   segments: 
   - 0
   - 0
-  - 10
-  version: 0.0.10
+  - 11
+  version: 0.0.11
 platform: ruby
 authors: 
 - Ramon Tayag
@@ -1954,6 +1954,96 @@ dependencies:
   name: rcov
   version_requirements: *id129
   prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id130 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: autotest
+  version_requirements: *id130
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id131 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: sqlite3
+  version_requirements: *id131
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id132 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 2
+        - 3
+        - 0
+        version: 2.3.0
+  name: rspec
+  version_requirements: *id132
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id133 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 23
+        segments: 
+        - 1
+        - 0
+        - 0
+        version: 1.0.0
+  name: bundler
+  version_requirements: *id133
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id134 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 1
+        - 5
+        - 2
+        version: 1.5.2
+  name: jeweler
+  version_requirements: *id134
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id135 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: rcov
+  version_requirements: *id135
+  prerelease: false
 description: Creates a separate table that saves all your dynamic attributes.
 email: ramon@tayag.net
 executables: []