datev 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2c321a3bfeae671bbfdb6873b7b75bb34887f453
-  data.tar.gz: dbe77e04243cdb4afa3dbd9ee26bb2867b4cedf9
+  metadata.gz: 956e90c7d3a49baf12d3337b605381daa3e20d87
+  data.tar.gz: 172c44ef62e75de78b96dec23b6db196e466ba2e
 SHA512:
-  metadata.gz: bfb8ba8f87cb539f9c9bc3ba446449752ade2c1295eba4baf4d183d210cf3f6c3648cc4f4c781e6e625a8ea0824eba39ca51a7120a99b4b4045379971894367d
-  data.tar.gz: f6511e6f062388127bc692fa0d3d4359d1bbe53c8e432c0caae018fa82a64978956966da96b1e19d1862469fa675d0280b39a908fd887014439192ea1c32f4cd
+  metadata.gz: cdcda8fd8dc40c21fe94ef4430eb29a962d0cfb6f8d78ac63f91e2ae7ca935a003be7b820d6fa7602601a23dd59efa97cb37a9e13fc7adcfc268c0e7579d2d2a
+  data.tar.gz: 90c7657ff7d11bce0598678d6f41e4d12bdb99a2ff216c76c43e5fdbba482bd705fb54d230371fee262f7adb0854e09e6cdca9717854587e4ca73e696bff4997

data/README.md

@@ -4,6 +4,7 @@ Ruby gem for exporting bookings to DATEV via CSV file
 
 [![Build Status](https://travis-ci.org/ledermann/datev.svg?branch=master)](https://travis-ci.org/ledermann/datev)
 [![Code Climate](https://codeclimate.com/github/ledermann/datev/badges/gpa.svg)](https://codeclimate.com/github/ledermann/datev)
+[![Coverage Status](https://coveralls.io/repos/github/ledermann/datev/badge.svg?branch=master)](https://coveralls.io/github/ledermann/datev?branch=master)
 
 ## Installation
 
@@ -35,7 +36,7 @@ export = Datev::Export.new(
   'Bezeichnung'     => 'Beispiel-Buchungen'
 ) # For available hash keys see /lib/datev/header.rb
 
-export << Datev::Booking.new(
+export << {
   'Belegdatum'                     => Date.new(2016,6,21),
   'Buchungstext'                   => 'Fachbuch: Controlling für Dummies',
   'Umsatz (ohne Soll/Haben-Kz)'    => 24.95,
@@ -43,9 +44,9 @@ export << Datev::Booking.new(
   'Konto'                          => 1200,
   'Gegenkonto (ohne BU-Schlüssel)' => 4940,
   'BU-Schlüssel'                   => '8'
-) # For available hash keys see /lib/datev/booking.rb
+} # For available hash keys see /lib/datev/booking.rb
 
-export << Datev::Booking.new(
+export << {
   'Belegdatum'                     => Date.new(2016,6,22),
   'Buchungstext'                   => 'Honorar FiBu-Seminar',
   'Umsatz (ohne Soll/Haben-Kz)'    => 5950.00,
@@ -53,7 +54,7 @@ export << Datev::Booking.new(
   'Konto'                          => 10000,
   'Gegenkonto (ohne BU-Schlüssel)' => 8400,
   'Belegfeld 1'                    => 'RE201606-135'
-)
+}
 
 export.to_file('EXTF_Buchungsstapel.csv')
 ```

data/datev.gemspec

@@ -23,4 +23,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'coveralls'
 end

data/lib/datev/base.rb

@@ -13,7 +13,7 @@ module Datev
 
       # Check if there is already a field with the same name
       if self.fields.find { |f| f.name == name }
-        raise ArgumentError.new("Field #{name} already exists")
+        raise ArgumentError.new("Field '#{name}' already exists")
       end
 
       self.fields << Field.new(name, type, options)
@@ -22,10 +22,12 @@ module Datev
     def initialize(attributes)
       self.attributes = {}
 
-      # Check existing name and set value (if valid)
+      raise ArgumentError.new('Hash required') unless attributes.is_a?(Hash)
+
+      # Check existing names and set value (if valid)
       attributes.each_pair do |name,value|
         unless field = self.class.fields.find { |f| f.name == name }
-          raise ArgumentError.new("Field #{name} not found")
+          raise ArgumentError.new("Field '#{name}' not found")
         end
 
         field.validate!(value)
@@ -35,7 +37,7 @@ module Datev
       # Check for missing values
       self.class.fields.select(&:required?).each do |field|
         if attributes[field.name].nil?
-          raise ArgumentError.new("Field #{field.name} is required but missing")
+          raise ArgumentError.new("Value for field '#{field.name}' is required but missing")
         end
       end
     end

data/lib/datev/export.rb

@@ -12,7 +12,7 @@ module Datev
       'Datenkategorie'  => 21,
       'Formatname'      => 'Buchungsstapel',
       'Formatversion'   => 7,
-      'Erzeugt am'      => Time.now,
+      'Erzeugt am'      => Time.now.utc,
       'Sachkontenlänge' => 4,
       'Bezeichnung'     => 'Buchungen',
       'Buchungstyp'     => 1,
@@ -20,14 +20,14 @@ module Datev
     }
 
     def initialize(header_attributes)
+      raise ArgumentError.new('Hash required') unless header_attributes.is_a?(Hash)
+
       @header = Header.new DEFAULT_HEADER_ATTRIBUTES.merge(header_attributes)
       @rows = []
     end
 
-    def <<(booking)
-      raise ArgumentError.new('Param must be a Datev::Booking instance') unless booking.is_a?(Booking)
-
-      @rows << booking
+    def <<(attributes)
+      @rows << Datev::Booking.new(attributes)
     end
 
     def to_s

data/lib/datev/field.rb

@@ -36,29 +36,38 @@ module Datev
       options[:limit]
     end
 
+    def precision
+      options[:precision]
+    end
+
+    def scale
+      options[:scale]
+    end
+
     def validate!(value)
-      if value
+      if value.nil?
+        raise ArgumentError.new("Value for field '#{name}' is required") if required?
+      else
         case type
         when :string
-          raise ArgumentError.new("Field '#{name}' is not a String") unless value.is_a?(String)
-          raise ArgumentError.new("Value '#{value}' fo field '#{name}' is too long") if limit && value.length > limit
+          raise ArgumentError.new("Value given for field '#{name}' is not a String") unless value.is_a?(String)
+          raise ArgumentError.new("Value '#{value}' for field '#{name}' is too long") if limit && value.length > limit
         when :integer
-          raise ArgumentError.new("Field '#{name}' is not an Integer") unless value.is_a?(Integer)
-          raise ArgumentError.new("Value '#{value}' fo field '#{name}' is too long") if limit && value.to_s.length > limit
+          raise ArgumentError.new("Value given for field '#{name}' is not an Integer") unless value.is_a?(Integer)
+          raise ArgumentError.new("Value '#{value}' for field '#{name}' is too long") if limit && value.to_s.length > limit
         when :decimal
-          raise ArgumentError.new("Field '#{name}' is not a Numeric") unless value.is_a?(Numeric)
+          raise ArgumentError.new("Value given for field '#{name}' is not a Decimal") unless value.is_a?(Numeric)
+          raise ArgumentError.new("Value '#{value}' for field '#{name}' is too long") if precision && value.to_s.length > precision+1
         when :date
-          raise ArgumentError.new("Field '#{name}' is not a Date or Time") unless value.is_a?(Time) || value.is_a?(Date)
+          raise ArgumentError.new("Value given for field '#{name}' is not a Date or Time") unless value.is_a?(Time) || value.is_a?(Date)
         when :boolean
-          raise ArgumentError.new("Field '#{name}' is not a Boolean") unless [true, false].include?(value)
+          raise ArgumentError.new("Value given for field '#{name}' is not a Boolean") unless [true, false].include?(value)
         end
-      elsif required?
-        raise ArgumentError.new("Field '#{name}' is required")
       end
     end
 
     def output(value)
-      return unless value
+      return if value.nil?
 
       case type
       when :string
@@ -66,7 +75,7 @@ module Datev
       when :integer
         value.to_s.rjust(limit, '0')
       when :decimal
-        value.to_s.sub('.',',')
+        ("%#{precision - scale - 1}.#{scale}f" % value).sub('.',',')
       when :boolean
         value ? 1 : 0
       when :date

data/lib/datev/version.rb

@@ -1,3 +1,3 @@
 module Datev
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: datev
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Georg Ledermann
@@ -52,6 +52,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Provides an easy way to create CSV files which can be imported into accounting
   applications
 email: