dateless_time 0.0.4 → 1.0.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZjQ4NTk5MGE2ZWVmMWRmNGU1NjUxZDk4ODRhMmRmYzViZjFhMmEwZA==
-  data.tar.gz: !binary |-
-    OGQyMDYzMzMxNDQxNDllNmIwNzk3ZjdkMzNmZjJlZjU2YmU4NDI5MQ==
+SHA1:
+  metadata.gz: bbe2b44e02e4194d806aa04a9cfa911a4a223385
+  data.tar.gz: 00f469012a6eb6a00e1d53f85032a3e321942085
 SHA512:
-  metadata.gz: !binary |-
-    MmNhYWJjYTgyNTFjNDU0ODY1YTUzOWY0OTAwYTI3M2U5ZmJhMDc0YTQzNTYx
-    ZDM3Mzc1ZGIzYzhhN2E3NDBkYzVkMzdhZGYyMGFjMTE2YWMxNDQwNDliNGE1
-    MWRjZDlkYjA2ZmU3NGUwZmI1NTBiZjRiZDM1MTU4NmZhOWU0MDg=
-  data.tar.gz: !binary |-
-    ZTk3YTY5NWQ0ZmViYWQ1NDdjNTVhYzYyMDkwM2VkZjI2MWJmNjgxZTEwNDAx
-    MDE3MDJiMWJlZTMzNGQzNjQwYTc1Mjc1M2UxODlkNzJhYzJkMDYxMDkyNzJl
-    NTRhN2MwNmJkMWM1MjlhMjFiNmViM2Y5OTQ1MDI0NjJkOTkwOWI=
+  metadata.gz: e3eb28671b034fa1fd58ec92c91c24ecc49c54e3157ba2f5db91815ccfc981b5f71b174dc3fee7fbeff13c11d312435de745ebb873629c2da7a8c063f71df023
+  data.tar.gz: f06462a8feb45a5eb8cb55433cd9c944d3892bbddaf850416fc035cb6f02c9b2c321de8455afc338e39694be6c64d458b1813fee550450e4598db5c8d284b684

data/CHANGELOG.md

@@ -0,0 +1,50 @@
+# DatelessTime Changelog
+
+## 1.0.0
+
+The gem graduates from `0.0.x`. The basic functionality is stable and not going to change. The other additions that go into this release are small incremental changes.
+
+#### New Features
+
+* Added a changelog.  
+* The method `#to_time` now also accepts `DateTime` objects as base values, in addition to `Time` and `Date`.  
+* Added `#to_datetime` method, with semantics similar to `#to_time`.
+
+#### Changes
+
+* Small internal improvements.
+
+## 0.0.4
+#### New Features
+
+* Added methos aliases for `hour`, `min` and `sec`, to make the interface more consistent with the default `Time` class.  
+* The method `#to_time` now also accepts `Date` objects as base values, in addition to `Time` objects.
+
+## 0.0.3
+#### New Features
+
+* Added support to initialize new `DatelessTime` objects with other existing `DatelessTime` objects as sources.  
+* Added support to initizlize new `DatelessTime` objects with `DateTime` objects as sources.  
+* Offical support for sorting in arrays (just added tests to make sure it works).  
+
+#### Changes
+
+* The gem now explicitly requires `date` from the standard library.
+
+#### Bug Fixes
+
+* Inizializing `DatelessTime` objects with strings like `"12:01 am"` or `"12:01 pm"` was generating invalid data.
+
+## 0.0.2
+
+#### New Features
+
+* Implemented support for the `Comparable` module. `DatelessTime` objects now support comparison operators: `==`, `<`, etc.
+
+#### Bug Fixes
+
+* The return value of `#to_time` was memoized, this made it impossible to use it moltiple times with different base values.
+
+## 0.0.1
+
+The initial release.

data/README.md

@@ -28,9 +28,9 @@ No external gems.
 
 Tested with:
 
-* MRI `1.9.3`, `2.0.0`, `2.1.0`, `2.1.1` and `2.1.2`
-* Rubinius `2.2.4`
-* JRuby `1.7.10`
+* MRI `>= 1.9.3`
+* Rubinius `>= 2.2`
+* JRuby `>= 1.7`
 
 
 ## How
@@ -75,7 +75,7 @@ require 'dateless_time'
 time = DatelessTime.new "13:37:42"
 
 time.hours
-tome.hour
+time.hour
 #=> 13
 
 time.minutes
@@ -87,7 +87,6 @@ time.sec
 #=> 42
 
 time.seconds_since_midnight
-# or
 time.to_i
 # => 49062
 
@@ -99,13 +98,21 @@ time.to_time
 time.to_time(Time.new(1985, 10, 25, 0, 0, 0, "-08:00"))
 # => 1985-10-25 13:37:42 -0800
 
-# or a base Date
+# or a base Date or DateTime
 time.to_time(Date.new(1985, 10, 25))
 # => 1985-10-25 13:37:42 +0100
 
 time.to_time.class
 # => Time
 
+# this uses DateTime.now to fill the date-related bits
+time.to_datetime
+# => #<DateTime: 2015-11-11T13:37:42+00:00 ((2457338j,49062s,0n),+0s,2299161j)>
+
+# but here, too, you can supply a base object instead (Date, Time or DateTime)
+time.to_datetime(Date.new(1985, 10, 25))
+# => #<DateTime: 1985-10-25T13:37:42+00:00 ((2446364j,49062s,0n),+0s,2299161j)>
+
 time.strftime("%-l:%M %P")
 # => "1:37 pm"
 
@@ -189,6 +196,7 @@ end
 
 1. implement the `+` and `-` artimetic operators, in a way consistent with Ruby's `Time`
 2. nice to have: other methods from `Time`'s public interface
+3. using `DateTime` objects as base for `#to_time` and `#to_datetime` does not support fractional utc offsets (e.g. Australia)
 
 
 

data/lib/dateless_time.rb

@@ -36,8 +36,33 @@ class DatelessTime
 
   def to_time(base = Time.now)
     args = [base.year, base.month, base.day, @hours, @minutes, @seconds]
-    args << base.utc_offset if base.is_a?(Time)
-    @time_value = Time.new(*args)
+
+    if base.is_a?(Time)
+      args << base.utc_offset
+    elsif base.is_a?(DateTime)
+      args << (base.offset * SECONDS_IN_24_HOURS)
+    end
+
+    Time.new(*args)
+  rescue
+    nil
+  end
+
+
+  def to_datetime(base = DateTime.now)
+    args = [base.year, base.month, base.day, @hours, @minutes, @seconds]
+
+    normalized_offset = begin
+      if base.is_a?(DateTime)
+        base.offset * 24
+      elsif base.is_a?(Time)
+        base.utc_offset / 3600
+      end
+    end
+
+    normalized_offset && args << sprintf("%+d", normalized_offset)
+
+    DateTime.new(*args)
   rescue
     nil
   end

data/lib/dateless_time/version.rb

@@ -1,3 +1,3 @@
 class DatelessTime
-  VERSION = "0.0.4"
+  VERSION = "1.0.0"
 end

data/test/query_test.rb

@@ -27,6 +27,15 @@ class QueryTest < Minitest::Test
   end
 
 
+  def test_to_time_with_time_with_offset_base
+    base = Time.new(1990, 11, 10, 12, 13, 14, '+04:00')
+    @to_time = @dl_time.to_time(base)
+    
+    assert_equal Time, @to_time.class
+    assert_equal Time.new(1990, 11, 10, 13, 37, 42, '+04:00'), @to_time
+  end
+
+
   def test_to_time_with_date_base
     base = Date.new(1990, 11, 10)
     @to_time = @dl_time.to_time(base)
@@ -36,6 +45,25 @@ class QueryTest < Minitest::Test
   end
 
 
+
+  def test_to_time_with_datetime_base
+    base = DateTime.new(1990, 11, 10, 12, 13, 14)
+    @to_time = @dl_time.to_time(base)
+    
+    assert_equal Time, @to_time.class
+    assert_equal Time.new(1990, 11, 10, 13, 37, 42), @to_time
+  end
+
+
+  def test_to_time_with_datetime_with_offset_base
+    base = DateTime.new(1990, 11, 10, 12, 13, 14, '+4')
+    @to_time = @dl_time.to_time(base)
+    
+    assert_equal Time, @to_time.class
+    assert_equal Time.new(1990, 11, 10, 13, 37, 42, '+04:00'), @to_time
+  end
+
+
   def test_to_time_with_different_bases_should_change
     @to_time = @dl_time.to_time
     now = Time.now
@@ -53,6 +81,87 @@ class QueryTest < Minitest::Test
   end
 
 
+
+
+
+
+
+  def test_to_datetime_without_base
+    @to_datetime = @dl_time.to_datetime
+    now = DateTime.now
+    expected = DateTime.new(now.year, now.month, now.day, 13, 37, 42)
+
+    assert_equal DateTime, @to_datetime.class
+    assert_equal expected, @to_datetime
+  end
+
+
+  def test_to_datetime_with_time_base
+    base = Time.new(1990, 11, 10, 12, 13, 14)
+    @to_datetime = @dl_time.to_datetime(base)
+    
+    assert_equal DateTime, @to_datetime.class
+    assert_equal DateTime.new(1990, 11, 10, 13, 37, 42), @to_datetime
+  end
+
+
+  def test_to_datetime_with_time_with_offset_base
+    base = Time.new(1990, 11, 10, 12, 13, 14, '+04:00')
+    @to_datetime = @dl_time.to_datetime(base)
+    
+    assert_equal DateTime, @to_datetime.class
+    assert_equal DateTime.new(1990, 11, 10, 13, 37, 42, '+4'), @to_datetime
+  end
+
+
+  def test_to_datetime_with_date_base
+    base = Date.new(1990, 11, 10)
+    @to_datetime = @dl_time.to_datetime(base)
+    
+    assert_equal DateTime, @to_datetime.class
+    assert_equal DateTime.new(1990, 11, 10, 13, 37, 42), @to_datetime
+  end
+
+
+
+  def test_to_datetime_with_datetime_base
+    base = DateTime.new(1990, 11, 10, 12, 13, 14)
+    @to_datetime = @dl_time.to_datetime(base)
+    
+    assert_equal DateTime, @to_datetime.class
+    assert_equal DateTime.new(1990, 11, 10, 13, 37, 42), @to_datetime
+  end
+
+
+  def test_to_datetime_with_datetime_with_offset_base
+    base = DateTime.new(1990, 11, 10, 12, 13, 14, '+4')
+    @to_datetime = @dl_time.to_datetime(base)
+    
+    assert_equal DateTime, @to_datetime.class
+    assert_equal DateTime.new(1990, 11, 10, 13, 37, 42, '+4'), @to_datetime
+  end
+
+
+  def test_to_datetime_with_different_bases_should_change
+    @to_datetime = @dl_time.to_datetime
+    now = Time.now
+    expected = DateTime.new(now.year, now.month, now.day, 13, 37, 42)
+
+    assert_equal DateTime, @to_datetime.class
+    assert_equal expected, @to_datetime
+
+
+    base = Time.new(1990, 11, 10, 12, 13, 14)
+    @to_datetime = @dl_time.to_datetime(base)
+    
+    assert_equal DateTime, @to_datetime.class
+    assert_equal DateTime.new(1990, 11, 10, 13, 37, 42), @to_datetime
+  end
+
+
+
+
+
   def test_to_s
     assert_equal "13:37:42", @dl_time.to_s
   end

metadata

@@ -1,55 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: dateless_time
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 1.0.0
 platform: ruby
 authors:
 - Tommaso Pavese
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-04 00:00:00.000000000 Z
+date: 2015-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '5.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '5.3'
 description: A class to handle dateless time values. DatelessTime objects are a lightweight
@@ -59,7 +59,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -81,17 +82,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: A class to handle dateless time values.
@@ -100,3 +101,4 @@ test_files:
 - test/creation_test.rb
 - test/query_test.rb
 - test/test_helper.rb
+has_rdoc: