date_time_precision 0.2.0 → 0.3.0

data/README.md

@@ -68,7 +68,7 @@ JSON.parse(json).to_date.precision
  => 2
 ```
 
-## Compatibility
+## Ruby Compatibility
 
 Tested in MRI 1.8.7/1.9.2/1.9.3, REE, JRuby 1.8/1.9, and Rubinius 1.8/1.9.
 
@@ -76,6 +76,23 @@ Note that starting in MRI 1.9.3, the core Date/Time classes were rewritten in C,
 override internal functionality. Some functions are now implemented internally and are not exposed.
 The workaround is inefficient: `#parse` and `#strptime` perform the same work twice, once to get the precision and once inside the original C method.
 
+## Gem Compatibility
+
+Sometimes other gems will use the Date/Time class in ways that don't preserve precision. If you want to use the DateTimePrecision gem with these
+gems, any compatibility issues will most likely need to be patched within DateTimePrecision itself. This is because DateTimePrecision makes some
+modifications to how the core Date/Time classes work. (For example, by allowing nil values to be passed to constructors.)
+
+So far, the following gems are on the compatibility watch list:
+
+ - [x] [ActiveSupport](https://github.com/rails/rails/tree/master/activesupport)
+ - [x] [Virtus](https://github.com/solnic/virtus)
+ - [x] [Coercible](https://github.com/solnic/coercible)
+ - [ ] [Chronic](https://github.com/mojombo/chronic)
+ - [ ] [Timeliness](https://github.com/adzap/timeliness)
+ - [ ] [Timecop](https://github.com/travisjeffery/timecop)
+
+If you know of any others, feel free to submit a pull request!
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/Rakefile

@@ -3,4 +3,4 @@ require "bundler/gem_tasks"
 
 Dir['gem_tasks/**/*.rake'].each { |rake| load rake }
 
-task :default => [:spec, :active_support_spec]
+task :default => [:spec, :active_support_spec, :compatibility_spec]

data/date_time_precision.gemspec

@@ -17,6 +17,10 @@ Gem::Specification.new do |gem|
   
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec'
+  
   gem.add_development_dependency 'activesupport'
   gem.add_development_dependency 'json'
+  
+  gem.add_development_dependency 'virtus', '0.5.4'
+  gem.add_development_dependency 'coercible'
 end

data/gem_tasks/rspec.rake

@@ -10,4 +10,10 @@ desc "Run ActiveSupport spec"
 RSpec::Core::RakeTask.new(:active_support_spec) do |t|
   t.verbose = true
   t.pattern = "spec/date_time_precision/active_support_spec.rb"
+end
+
+desc "Run Compatibility spec"
+RSpec::Core::RakeTask.new(:compatibility_spec) do |t|
+  t.verbose = true
+  t.pattern = "spec/date_time_precision/compatibility_spec.rb"
 end

data/gemfiles/activesupport2.gemfile

@@ -2,6 +2,9 @@ source :rubygems
 
 gem 'rake'
 gem 'rspec'
-gem 'json'
 
-gem 'activesupport', '~> 2', :require => false
+gem 'activesupport', '~> 2', :require => false
+
+gem 'json'
+gem 'virtus', '0.5.4'
+gem 'coercible'

data/gemfiles/activesupport3.gemfile

@@ -2,6 +2,9 @@ source :rubygems
 
 gem 'rake'
 gem 'rspec'
-gem 'json'
 
-gem 'activesupport', '~> 3', :require => false
+gem 'activesupport', '~> 3', :require => false
+
+gem 'json'
+gem 'virtus', '0.5.4'
+gem 'coercible'

data/lib/date_time_precision/compat/coercible.rb

@@ -0,0 +1,15 @@
+if defined?(Coercible::Coercer::Hash)
+  class Coercible::Coercer::Hash
+    def to_date(value)
+      value.to_date
+    end
+    
+    def to_datetime(value)
+      value.to_datetime
+    end
+    
+    def to_time(value)
+      value.to_time
+    end
+  end
+end

data/lib/date_time_precision/compat/virtus.rb

@@ -0,0 +1,17 @@
+if defined?(Virtus::Coercion::Hash)
+  class Virtus::Coercion::Hash
+    class << self
+      def to_date(value)
+        value.to_date
+      end
+
+      def to_datetime(value)
+        value.to_datetime
+      end
+
+      def to_time(value)
+        value.to_time
+      end
+    end
+  end
+end

data/lib/date_time_precision/format/hash.rb

@@ -22,7 +22,7 @@ class Hash
   
   protected
   def date_time_args
-    [self[:year] || self[:y] || self['year'] || self['y'],
+    [self[:year] || self[:y] || self[:yr] || self['year'] || self['y'] || self['yr'],
     self[:mon] || self[:m] || self[:month] || self['mon'] || self['m'] || self['month'],
     self[:mday] || self[:d] || self[:day] || self['mday'] || self['d'] || self['day'],
     self[:hour] || self[:h] || self[:hr] || self['hour'] || self['h'] || self['hr'],
@@ -41,4 +41,7 @@ module DateTimePrecision
       [key, self.send(attribute_name)] if self.send("#{attribute_name}?")
     end.compact]
   end
-end
+end
+
+require 'date_time_precision/compat/virtus'
+require 'date_time_precision/compat/coercible'

data/lib/date_time_precision/lib.rb

@@ -1,3 +1,11 @@
+if defined?(ActiveSupport)
+  ['active_support/core_ext/date', 'active_support/core_ext/datetime', 'active_support/core_ext/time', 'active_support/time'].each do |f|
+    begin
+      require f
+    rescue LoadError; end
+  end
+end
+
 module DateTimePrecision
   unless constants.include? "NONE"
     FRAC  = 7
@@ -117,12 +125,12 @@ module DateTimePrecision
 
   def self.included(base)
     # Redefine any conversion methods so precision is preserved
-    [:to_date, :to_time, :to_datetime].each do |m|
-      orig = :"orig_#{m}"
-      if base.method_defined?(m) && !base.method_defined?(orig)
+    [:to_date, :to_time, :to_datetime].each do |conversion_method|
+      orig = :"orig_#{conversion_method}"
+      if base.method_defined?(conversion_method) && !base.method_defined?(orig)
         base.class_exec {
-          alias_method orig, m
-          define_method(m) {
+          alias_method orig, conversion_method
+          define_method(conversion_method) {
             d = send(orig)
             d.precision = [self.precision, d.class::MAX_PRECISION].min
             d

data/lib/date_time_precision/version.rb

@@ -1,3 +1,3 @@
 module DateTimePrecision
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/date_time_precision/active_support_spec.rb

@@ -2,12 +2,6 @@ require 'spec_helper'
 require 'json'
 require 'active_support'
 
-require 'active_support/core_ext/date/conversions'
-require 'active_support/core_ext/time/conversions'
-begin
-  require 'active_support/core_ext/datetime/conversions'
-rescue LoadError; end
-
 require 'date_time_precision'
 
 require 'date_time_precision/format/json'
@@ -15,10 +9,10 @@ require 'date_time_precision/format/json'
 describe DateTimePrecision, 'Conversions' do  
   context 'when converting from Date to Time or DateTime' do
     it 'should maintain precision' do
-      d = Date.new(2005, 1, 2)
-      d.precision.should == DateTimePrecision::DAY
-      d.to_date.precision.should == DateTimePrecision::DAY
-      d.to_datetime.precision.should == DateTimePrecision::DAY
+      d = Date.new(2005, 1)
+      d.precision.should == DateTimePrecision::MONTH
+      d.to_date.precision.should == DateTimePrecision::MONTH
+      d.to_datetime.precision.should == DateTimePrecision::MONTH
     end
   end
   

data/spec/date_time_precision/compatibility_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+require 'virtus'
+require 'coercible'
+require 'date_time_precision'
+require 'date_time_precision/format/hash'
+
+class VirtusModel
+  include Virtus
+  
+  attribute :date, Date
+  attribute :datetime, DateTime
+  attribute :time, Time
+end
+
+describe DateTimePrecision do
+  context 'compatibility' do
+    
+    let(:date_hash) { {:y => 1990} }
+    let(:datetime_hash) { {'year' => 1800, 'mon' => 2} }
+    let(:time_hash) { {:yr => 1950, 'm' => 5, :day => 19, :hr => 5} }
+    
+    context 'with Virtus' do
+      let(:model) { VirtusModel.new }
+      before(:all) do
+        model.date = date_hash
+        model.datetime = datetime_hash
+        model.time = time_hash
+      end
+      
+      context 'when coercing a hash to a Date' do
+        subject { model.date }
+        
+        it { should be_a Date }
+        its(:year) { should == 1990 }
+        its(:precision) { should == DateTimePrecision::YEAR }
+      end
+      
+      context 'when coercing a hash to a DateTime' do
+        subject { model.datetime }
+        
+        it { should be_a DateTime }
+        its(:year) { should == 1800 }
+        its(:month) { should == 2 }
+        its(:precision) { should == DateTimePrecision::MONTH }
+      end
+      
+      context 'when coercing a hash to a Time' do
+        subject { model.time }
+        
+        it { should be_a Time }
+        its(:year) { should == 1950 }
+        its(:month) { should == 5 }
+        its(:day) { should == 19 }
+        its(:hour) { should == 5 }
+        its(:precision) { should == DateTimePrecision::HOUR }
+      end
+    end
+    
+    context 'with Coercible' do
+      let(:coercer) { Coercible::Coercer::Hash.new }
+      
+      context 'when coercing a hash to a Date' do
+        subject { coercer.to_date(date_hash) }
+        
+        it { should be_a Date }
+        its(:year) { should == 1990 }
+        its(:precision) { should == DateTimePrecision::YEAR }
+      end
+      
+      context 'when coercing a hash to a DateTime' do
+        subject { coercer.to_datetime(datetime_hash) }
+        
+        it { should be_a DateTime }
+        its(:year) { should == 1800 }
+        its(:month) { should == 2 }
+        its(:precision) { should == DateTimePrecision::MONTH }
+      end
+      
+      context 'when coercing a hash to a Time' do
+        subject { coercer.to_time(time_hash) }
+        
+        it { should be_a Time }
+        its(:year) { should == 1950 }
+        its(:month) { should == 5 }
+        its(:day) { should == 19 }
+        its(:hour) { should == 5 }
+        its(:precision) { should == DateTimePrecision::HOUR }
+      end
+    end
+  end
+end

metadata

@@ -1,87 +1,118 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: date_time_precision
-version: !ruby/object:Gem::Version
-  version: 0.2.0
+version: !ruby/object:Gem::Version 
+  hash: 19
   prerelease: 
+  segments: 
+  - 0
+  - 3
+  - 0
+  version: 0.3.0
 platform: ruby
-authors:
+authors: 
 - David Butler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-05 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
+
+date: 2013-02-06 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  type: :development
+  name: rake
+  requirement: *id001
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  prerelease: false
+  type: :development
   name: rspec
-  requirement: !ruby/object:Gem::Requirement
+  requirement: *id002
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+  type: :development
   name: activesupport
-  requirement: !ruby/object:Gem::Requirement
+  requirement: *id003
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+  type: :development
   name: json
-  requirement: !ruby/object:Gem::Requirement
+  requirement: *id004
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id005 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        - 5
+        - 4
+        version: 0.5.4
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  type: :development
+  name: virtus
+  requirement: *id005
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id006 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  prerelease: false
+  type: :development
+  name: coercible
+  requirement: *id006
 description: Patches Date, Time, and DateTime ruby classes to keep track of precision
-email:
+email: 
 - dwbutler@ucla.edu
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - .gitignore
 - .travis.yml
 - Gemfile
@@ -94,6 +125,8 @@ files:
 - gemfiles/activesupport2.gemfile
 - gemfiles/activesupport3.gemfile
 - lib/date_time_precision.rb
+- lib/date_time_precision/compat/coercible.rb
+- lib/date_time_precision/compat/virtus.rb
 - lib/date_time_precision/format/hash.rb
 - lib/date_time_precision/format/json.rb
 - lib/date_time_precision/format/nil.rb
@@ -110,39 +143,44 @@ files:
 - lib/date_time_precision/patch/1.9.3/time.rb
 - lib/date_time_precision/version.rb
 - spec/date_time_precision/active_support_spec.rb
+- spec/date_time_precision/compatibility_spec.rb
 - spec/date_time_precision/date_time_precision_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/Spokeo/date_time_precision
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-      segments:
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
       - 0
-      hash: 3562610931592917135
-required_rubygems_version: !ruby/object:Gem::Requirement
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-      segments:
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
       - 0
-      hash: 3562610931592917135
+      version: "0"
 requirements: []
+
 rubyforge_project: 
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Patches Date, Time, and DateTime ruby classes to keep track of precision
-test_files:
+test_files: 
 - spec/date_time_precision/active_support_spec.rb
+- spec/date_time_precision/compatibility_spec.rb
 - spec/date_time_precision/date_time_precision_spec.rb
 - spec/spec_helper.rb