date_parity 0.0.1 → 0.0.2

data/README.md

@@ -1,10 +1,10 @@
 # DateParity
 
-Consistent date formatting per request; creating parity between date.to\_s and
- string.to\_date.
+Consistent date formatting and parsing for Rails applications. Creates parity between date.to\_s and
+ string.to\_date in Rails applications.
 
-Provides a Date.format syntax and usage, similiar to Time.zone in rails. Can be 
-set per request (i.e. per user).
+This is implemented with a "Date.format" syntax and usage, similar to "Time.zone" in rails. This can be 
+set per request (i.e. per user) in a controller before or around filter.
 
 ## Installation
 
@@ -24,22 +24,39 @@ Or install it yourself as:
 
 In Rails controller before\_filter:
 Date.format = '%m/%d/%Y'
-or
+
+or from a persisted field that stores the desired format:
 Date.format = current\_user.date\_format 
 
-In any view assuming @resourc\_created\_on is a date::
-@resource.start\_on  
-will render: 12/31/2012 
+In any view assuming @model\_created\_on is a date, and Date.format
+was set as above:
+<%=@modele.created\_on  %>
+=> 12/31/2012 
 
 And then you get parity when a form with this field is posted. 
 Rails will attempt to convert the posted string value of "12/31/2012"
-using "12/31/2012".to\_date in the respective model before validation. 
-Under normal circumstances, @resource.start\_on will end up being nil 
-because "12/31/2012".to\_date is invalid for Ruby Date.\_parse. 
-
-When date\_parity is required, Date will use the format string stored on Date.formt
-to correctly parse "12/31/2012". This is accomplished by overriding String.to\_date 
-to use : Date.strptime(self, Date.format).to\_s(:db)
+using Date.\_parse, which DateParity overrides and respects your Date.format. 
+Without DateParity gem, @model.start\_on would have ended up nil because 
+"12/31/2012" is invalid argument Ruby Date.\_parse. However, when date\_parity is 
+included, Date will use the format string stored on Date.format
+(if it exist) to correctly parse "12/31/2012", as December 31, 2012, when 
+Date.format = "%m/%d/%Y" 
+
+Note: Rails text\_field form helper uses @model.attribute\before\_type\_cast by default.
+When using date\_parity on plain text fields, you will probably want to set your value
+to explicitly use @model.attribute if it exists. Otherwise, you won't see the formatted
+date field:
+For example:
+<%= f.text_field :created_on, :value => @user.created\_on ||  @user.created\_on\_before\_type\_cast %>
+
+Date.format can be set to any date format that is parsable by strptime. 
+For example, the following are all valid:<br>
+    Date.format = "%m/%d/%Y"<br>
+    Date.format = "%d/%m/%Y"<br>
+    Date.format = '%Y-%m-%d'<br>
+    Date.format = '%d.%m.%Y'<br>
+    Date.format = '%Y.%m.%d'<br>
+    Date.format = '%Y/%m/%d'<br>
 
 ## Contributing
 

data/lib/date_parity/core_ext/date.rb

@@ -6,7 +6,19 @@ class Date
     def format=(format)
       Thread.current[:date_format] = format
     end
+
+    def _parse_with_date_parity_format(string, comp=false)
+      return _parse_without_date_parity_format(string, comp) if string.blank? or Date.format.blank?
+      # normalize date by first respecting custom date_parity Date.format, 
+      # then formatting back to iso/db string for normal _parse call.
+      _parse_without_date_parity_format(Date.strptime(string, Date.format).to_s(:db), comp)
+    rescue
+      _parse_without_date_parity_format(string, comp)
+    end
+
+    alias_method_chain :_parse, :date_parity_format
   end
+
 end
 
 

data/lib/date_parity/version.rb

@@ -1,3 +1,3 @@
 module DateParity
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/date_parity.rb

@@ -1,9 +1,7 @@
 require 'date'
 require 'active_support/core_ext/date/conversions'
 require 'active_support/core_ext/string/conversions'
-
 require "date_parity/version"
-require 'date_parity/core_ext/string'
 require 'date_parity/core_ext/date'
 
 # ActiveSupport provides an implementation of Date.to_s that uses

data/test/date_parity_test.rb

@@ -25,7 +25,31 @@ class DateParityTest < MiniTest::Unit::TestCase
 
   end
 
+ def test_date_parse
+    date_hash = { :year => 2012, :mon => 8, :mday => 12 }
+
+    Date.format = "%m/%d/%Y"
+    assert_equal date_hash,  Date._parse("08/12/2012")
+
+    Date.format = "%d/%m/%Y"
+    assert_equal date_hash,  Date._parse("12/08/2012")
+
+    Date.format = '%Y-%m-%d'
+    assert_equal date_hash,  Date._parse("2012-08-12")
+
+    Date.format = '%d.%m.%Y'
+    assert_equal date_hash,  Date._parse("12.08.2012")
+
+    Date.format = '%Y.%m.%d'
+    assert_equal date_hash,  Date._parse("2012.08.12")
+
+    Date.format = '%Y/%m/%d'
+    assert_equal date_hash,  Date._parse("2012/08/12")
+  end
+
   def test_string_to_date_respects_format
+    # This works because Rails ActiveSupport provides 
+    # string.to_date, which uses Date._parse
     Date.format = "%m/%d/%Y"
     assert_equal Date.parse("2012-08-12"), "08/12/2012".to_date
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: date_parity
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-12 00:00:00.000000000 Z
+date: 2012-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70139748526520 !ruby/object:Gem::Requirement
+  requirement: &70261701192120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '3.2'
   type: :runtime
   prerelease: false
-  version_requirements: *70139748526520
+  version_requirements: *70261701192120
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70139748526100 !ruby/object:Gem::Requirement
+  requirement: &70261701191700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70139748526100
+  version_requirements: *70261701191700
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70139748525640 !ruby/object:Gem::Requirement
+  requirement: &70261701191240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70139748525640
+  version_requirements: *70261701191240
 description: Consistent date formatting done simple
 email: scottpstewart@gamil.com
 executables: []
@@ -58,7 +58,6 @@ files:
 - date_parity.gemspec
 - lib/date_parity.rb
 - lib/date_parity/core_ext/date.rb
-- lib/date_parity/core_ext/string.rb
 - lib/date_parity/version.rb
 - test/date_parity_test.rb
 - test/lib/date_parity/test_helper.rb
@@ -76,7 +75,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3237689646668649695
+      hash: 2984063008747520348
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -85,7 +84,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3237689646668649695
+      hash: 2984063008747520348
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.11

data/lib/date_parity/core_ext/string.rb

@@ -1,13 +0,0 @@
-class String
-
-  def to_date_from_formatted_string
-    return nil if self.blank?
-    Date.strptime(self, Date.format)
-  rescue
-    to_rails_date
-  end
-
-  alias_method :to_rails_date, :to_date
-  alias_method :to_date, :to_date_from_formatted_string
-
-end