datatrans 2.2.0 → 2.2.1

data/lib/datatrans/version.rb

@@ -1,3 +1,3 @@
 module Datatrans
-  VERSION = "2.2.0"
+  VERSION = "2.2.1"
 end

data/lib/datatrans/web/transaction.rb

@@ -36,7 +36,7 @@ module Datatrans::Web
   
   module ViewHelper
     def datatrans_notification_request_hidden_fields(transaction)
-      [
+      fields = [
         hidden_field_tag(:merchantId, Datatrans.merchant_id),
         hidden_field_tag(:hiddenMode, transaction.params[:hiddenMode]),
         hidden_field_tag(:reqtype, transaction.params[:reqtype]),
@@ -45,9 +45,15 @@ module Datatrans::Web
         hidden_field_tag(:useAlias, transaction.params[:useAlias]),
         hidden_field_tag(:sign, transaction.signature),
         hidden_field_tag(:refno, transaction.params[:refno]),
-        hidden_field_tag(:uppCustomerName, transaction.params[:uppCustomerName]),
-        hidden_field_tag(:uppCustomerEmail, transaction.params[:uppCustomerEmail])
-      ].join.html_safe
+      ]
+      
+      [:uppCustomerName, :uppCustomerEmail].each do |field_name|
+        if transaction.params[field_name].present?
+          fields << hidden_field_tag(field_name, transaction.params[field_name])
+        end
+      end
+      
+      fields.join.html_safe
     end
   end
 end

data/spec/web/authorize_spec.rb

@@ -74,7 +74,7 @@ describe Datatrans::Web::Transaction do
     end
     
     it "should generate valid form field string" do
-      @view.datatrans_notification_request_hidden_fields(@transaction).should == "<input id=\"merchantId\" name=\"merchantId\" type=\"hidden\" value=\"1100000000\" /><input id=\"hiddenMode\" name=\"hiddenMode\" type=\"hidden\" value=\"Yes\" /><input id=\"reqtype\" name=\"reqtype\" type=\"hidden\" value=\"NOA\" /><input id=\"amount\" name=\"amount\" type=\"hidden\" value=\"1000\" /><input id=\"currency\" name=\"currency\" type=\"hidden\" value=\"CHF\" /><input id=\"useAlias\" name=\"useAlias\" type=\"hidden\" value=\"Yes\" /><input id=\"sign\" name=\"sign\" type=\"hidden\" value=\"0402fb3fba8c6fcb40df9b7756e7e637\" /><input id=\"refno\" name=\"refno\" type=\"hidden\" value=\"ABCDEF\" /><input id=\"uppCustomerName\" name=\"uppCustomerName\" type=\"hidden\" /><input id=\"uppCustomerEmail\" name=\"uppCustomerEmail\" type=\"hidden\" value=\"customer@email.com\" />"
+      @view.datatrans_notification_request_hidden_fields(@transaction).should == "<input id=\"merchantId\" name=\"merchantId\" type=\"hidden\" value=\"1100000000\" /><input id=\"hiddenMode\" name=\"hiddenMode\" type=\"hidden\" value=\"Yes\" /><input id=\"reqtype\" name=\"reqtype\" type=\"hidden\" value=\"NOA\" /><input id=\"amount\" name=\"amount\" type=\"hidden\" value=\"1000\" /><input id=\"currency\" name=\"currency\" type=\"hidden\" value=\"CHF\" /><input id=\"useAlias\" name=\"useAlias\" type=\"hidden\" value=\"Yes\" /><input id=\"sign\" name=\"sign\" type=\"hidden\" value=\"0402fb3fba8c6fcb40df9b7756e7e637\" /><input id=\"refno\" name=\"refno\" type=\"hidden\" value=\"ABCDEF\" /><input id=\"uppCustomerEmail\" name=\"uppCustomerEmail\" type=\"hidden\" value=\"customer@email.com\" />"
     end
   end
   

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: datatrans
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-09 00:00:00.000000000Z
+date: 2011-08-26 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
-  requirement: &2156252480 !ruby/object:Gem::Requirement
+  requirement: &2152354120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2156252480
+  version_requirements: *2152354120
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2156250300 !ruby/object:Gem::Requirement
+  requirement: &2152353620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *2156250300
+  version_requirements: *2152353620
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &2156249580 !ruby/object:Gem::Requirement
+  requirement: &2152353200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2156249580
+  version_requirements: *2152353200
 - !ruby/object:Gem::Dependency
   name: builder
-  requirement: &2156249020 !ruby/object:Gem::Requirement
+  requirement: &2152352740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2156249020
+  version_requirements: *2152352740
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2156248360 !ruby/object:Gem::Requirement
+  requirement: &2152352320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +66,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156248360
+  version_requirements: *2152352320
 - !ruby/object:Gem::Dependency
   name: actionpack
-  requirement: &2156247640 !ruby/object:Gem::Requirement
+  requirement: &2152351820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -77,7 +77,7 @@ dependencies:
         version: 3.0.0
   type: :development
   prerelease: false
-  version_requirements: *2156247640
+  version_requirements: *2152351820
 description: Datatrans Integration for Ruby on Rails
 email:
 - tobias.miesel@simplificator.com