datarockets-style 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5c6dc78f6cd8d3a32d136c4f7a9719ea01f5df29
-  data.tar.gz: e4dde397b38468d9d2323a15435bc0a44186bb52
+SHA256:
+  metadata.gz: 7fafb7c948730c343855a68d07997ccd3810e8167c2a015e8d36bc62f4d131ed
+  data.tar.gz: 9949285276625c8fc9c699b0cf81b95d571d33d48cc01d28079bfa389a550398
 SHA512:
-  metadata.gz: b8ced1a8863f844fa904ad34030a8fd7a1f52426fc7623d8e9171914d016a75040d9446e1aabb1daa6082f104a472f85bb93ee400d86566c3b32206e23d2922a
-  data.tar.gz: 7d0e9abce97cfea064339749a224f5db4fce7b44de4400218ede97fe42e05699a72a5bc0061d9abf61318d3da900c7449eaf3715326744e75eb3378fbbd1a5a0
+  metadata.gz: 257dfbd765bb44afca6141ad304c8be3140d7b3755b8a39755a5a5d335cc01422cad573ddbd5aab99067a65703b7933a073f53bd7b0a276f8340f42a31a426a5
+  data.tar.gz: 54a27bdd31588eda01c775ec316886fc835f29d714b5a848f858ba828a73e8c845ea2e524231bf8dd31779bc1fb788e90e28b44de0ba94eb1574d957b97a2a31

data/.gitignore

@@ -4,3 +4,5 @@
 /_yardoc/
 /pkg/
 /tmp/
+
+.byebug_history

data/CHANGELOG.md

@@ -2,7 +2,19 @@
 
 The format is described in [Contributing notes](CONTRIBUTING.md#changelog-entry-format).
 
-## master (unreleased)
+## 0.11.0 (2020-11-07)
+
+### Changed
+
+* Update rubocop to '0.93.1'. ([@r.dubrovsky][])
+  * Enable new cops `Lint/BinaryOperatorWithIdenticalOperands`, `Lint/DuplicateRescueException`, `Lint/EmptyConditionalBody`, `Lint/FloatComparison`, `Lint/MissingSuper
+`, `Lint/OutOfRangeRegexpRef`, `Lint/SelfAssignment`, `Lint/TopLevelReturnWithArgument`, `Lint/UnreachableLoop`, `Style/ExplicitBlockArgument`, `Style/GlobalStdStream`, `Style/OptionalBooleanParameter`, `Style/SingleArgumentDig`, `Style/SoleNestedConditional` and `Style/StringConcatenation` in version `0.89`.
+  * Allow to add all new lints automatically.
+  * Add auto-correctable count notification.
+  * Fix tests
+* Update rubocop-rails to `2.7.1`.
+* Update rubocop-rspec tp `1.43.2`.
+  * Disable `RSpec/MultipleMemoizedHelpers` cop.
 
 ## 0.10.0 (2020-07-17)
 

data/Gemfile.lock

@@ -1,30 +1,31 @@
 PATH
   remote: .
   specs:
-    datarockets-style (0.10.0)
-      rubocop (~> 0.88)
-      rubocop-rails (>= 2.6.0, < 2.7.0)
+    datarockets-style (0.11.0)
+      rubocop (~> 0.93)
+      rubocop-rails (>= 2.6.0, < 2.8.0)
       rubocop-rspec (~> 1.42)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (5.2.4.3)
+    activesupport (6.0.3.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
     ast (2.4.1)
     byebug (11.1.3)
     coderay (1.1.2)
-    concurrent-ruby (1.1.6)
+    concurrent-ruby (1.1.7)
     diff-lcs (1.3)
-    i18n (1.8.3)
+    i18n (1.8.5)
       concurrent-ruby (~> 1.0)
     method_source (1.0.0)
-    minitest (5.14.1)
+    minitest (5.14.2)
     parallel (1.19.2)
-    parser (2.7.1.4)
+    parser (2.7.2.0)
       ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
@@ -35,7 +36,7 @@ GEM
     rack (2.2.3)
     rainbow (3.0.0)
     rake (13.0.1)
-    regexp_parser (1.7.1)
+    regexp_parser (1.8.2)
     rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
@@ -50,28 +51,30 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.0)
-    rubocop (0.88.0)
+    rubocop (0.93.1)
       parallel (~> 1.10)
-      parser (>= 2.7.1.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.1.0, < 1.0)
+      rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.1.0)
-      parser (>= 2.7.0.1)
-    rubocop-rails (2.6.0)
+    rubocop-ast (1.1.1)
+      parser (>= 2.7.1.5)
+    rubocop-rails (2.7.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.82.0)
-    rubocop-rspec (1.42.0)
       rubocop (>= 0.87.0)
+    rubocop-rspec (1.44.1)
+      rubocop (~> 0.87)
+      rubocop-ast (>= 0.7.1)
     ruby-progressbar (1.10.1)
     thread_safe (0.3.6)
     tzinfo (1.2.7)
       thread_safe (~> 0.1)
     unicode-display_width (1.7.0)
+    zeitwerk (2.4.1)
 
 PLATFORMS
   ruby

data/config/base.yml

@@ -1,5 +1,8 @@
 require: datarockets/style
 
+AllCops:
+  NewCops: enable
+
 Bundler/DuplicatedGem:
   Enabled: true
 
@@ -54,21 +57,48 @@ Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
   EnforcedStyleForEmptyBraces: no_space
 
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
 Lint/DeprecatedOpenSSLConstant:
   Enabled: true
 
 Lint/DuplicateElsifCondition:
   Enabled: true
 
+Lint/DuplicateRescueException:
+  Enabled: true
+
+Lint/EmptyConditionalBody:
+  Enabled: true
+
+Lint/FloatComparison:
+  Enabled: true
+
+Lint/MissingSuper:
+  Enabled: true
+
 Lint/MixedRegexpCaptureTypes:
   Enabled: true
 
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
 Lint/RaiseException:
   Enabled: true
 
+Lint/SelfAssignment:
+  Enabled: true
+
 Lint/StructNewOverride:
   Enabled: true
 
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Lint/UnreachableLoop:
+  Enabled: true
+
 Naming/MemoizedInstanceVariableName:
   EnforcedStyleForLeadingUnderscores: required
 
@@ -93,9 +123,15 @@ Style/ClassAndModuleChildren:
 Style/EmptyMethod:
   EnforcedStyle: expanded
 
+Style/ExplicitBlockArgument:
+  Enabled: true
+
 Style/ExponentialNotation:
   Enabled: true
 
+Style/GlobalStdStream:
+  Enabled: true
+
 Style/HashAsLastArrayItem:
   Enabled: true
   EnforcedStyle: no_braces
@@ -118,6 +154,9 @@ Style/FrozenStringLiteralComment:
 Style/NestedInterpolation:
   Enabled: true
 
+Style/OptionalBooleanParameter:
+  Enabled: true
+
 Style/RedundantAssignment:
   Enabled: true
 
@@ -133,8 +172,17 @@ Style/RedundantRegexpCharacterClass:
 Style/RedundantRegexpEscape:
   Enabled: true
 
+Style/SingleArgumentDig:
+  Enabled: true
+
 Style/SlicingWithRange:
   Enabled: true
 
+Style/SoleNestedConditional:
+  Enabled: true
+
+Style/StringConcatenation:
+  Enabled: true
+
 Style/StringLiterals:
   EnforcedStyle: double_quotes

data/config/rails.yml

@@ -1,5 +1,7 @@
 require: rubocop-rails
 
+inherit_from: base.yml
+
 AllCops:
   Exclude:
     - "db/**/*"
@@ -12,8 +14,6 @@ AllCops:
     - "config.ru"
     - "Rakefile"
 
-inherit_from: base.yml
-
 Style/Documentation:
   Enabled: true
   Exclude:

data/config/rspec.yml

@@ -31,5 +31,8 @@ RSpec/LetSetup:
 RSpec/MessageSpies:
   EnforcedStyle: have_received
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/NestedGroups:
   Enabled: false

data/datarockets-style.gemspec

@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.88"
-  spec.add_dependency "rubocop-rails", ">= 2.6.0", "< 2.7.0"
+  spec.add_dependency "rubocop", "~> 0.93"
+  spec.add_dependency "rubocop-rails", ">= 2.6.0", "< 2.8.0"
   spec.add_dependency "rubocop-rspec", "~> 1.42"
 end

data/doc/STYLE_GUIDE_RSPEC.md

@@ -15,6 +15,10 @@ This style guide recommends best practices for writing a clear Rspec tests and e
   So there are not any limits for deep or nested groups.
   <sup>[[link](#rspec-nested-groups)]</sup>
 
+* <a name="rspec-let-count"></a>
+  We're not limiting a number of `let` blocks in describe and context blocks.
+  <sup>[[link](#rspec-let-count)]</sup>
+
 * <a name="rspec-subject"></a>
   Each subject should be named, and we should not use `subject` in our test cases.
   Prefer to use `is_expected` that `expect(subject_name)` for small tests.

data/lib/datarockets/style/formatter/todo_list_formatter.rb

@@ -42,7 +42,8 @@ class TodoListFormatter < RuboCop::Formatter::ProgressFormatter
   def finished(inspected_files)
     report_summary(inspected_files.length,
       @total_offense_count,
-      @total_correction_count)
+      @total_correction_count,
+      @total_correctable_count)
     output.puts
 
     Datarockets::Style::Formatter::TodoListFormatter::ReportSummary.new(offense_list).call(output)

data/lib/datarockets/style/formatter/todo_list_formatter/report_summary.rb

@@ -27,7 +27,7 @@ module Datarockets
             end
 
             def print(output)
-              output.puts(cop_name + ":")
+              output.puts("#{cop_name}:")
               output.puts("  Exclude:")
               file_groups.sort_by(&:file).each do |file_group|
                 file_group.print(output)

data/lib/datarockets/style/version.rb

@@ -1,5 +1,5 @@
 module Datarockets
   module Style
-    VERSION = "0.10.0".freeze
+    VERSION = "0.11.0".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: datarockets-style
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Roman Dubrovsky
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-17 00:00:00.000000000 Z
+date: 2020-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.88'
+        version: '0.93'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.88'
+        version: '0.93'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -33,7 +33,7 @@ dependencies:
         version: 2.6.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.7.0
+        version: 2.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,7 +43,7 @@ dependencies:
         version: 2.6.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.7.0
+        version: 2.8.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -119,8 +119,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Datarockets style guides and shared style configs