datadog-ci 1.16.0 → 1.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4f7cf7ed07d7a4543498333996a19347f64010eef7900f53d5790ad6e4fe2aaf
-  data.tar.gz: 7b3ebdaaf30c557ac23f3720f72ef56ab1b9c1f9686e8f62dc597e3c938cfe35
+  metadata.gz: 1d2afc6148658bb41352ad4040c483406594852787e35aa523063a6ae452ec17
+  data.tar.gz: 3b7f9b07092e33b016b94b25d4aae2b12ff442f458dac6bea7b987adef4ca345
 SHA512:
-  metadata.gz: 9412f518c4bba62d062448950f10b956abebe22e33680341454f60f67fd48c25b155d9e0ed3f7d378bcb33f21ee0fa586bee2ff03f3a2ad3f4b753a8a24bb36c
-  data.tar.gz: eb8710ab135550d9c26e1742aefb5ebb05b2c8a1f91e9175e44b0181c4934f1ff5453749820b8720e1febe5c79502e2489d46442f80c4836e56a394c931f7143
+  metadata.gz: 7b368e3e3a1c6004307fe834f6f6442f51f7ab538434fb9a34ea42c6fbefa90f7995e54ed35aded0ddfc9e21ff34e70d91e845e9b82009a9e2977f3de9205ff6
+  data.tar.gz: c56a90e2d3fcc755f9fc224ea8e385c8393a8252487132ca4287377375ac57e839171853391ad9bcb4577a422b0b7c154f32f15c91b69b2b7b17de86aa396ca6

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 ## [Unreleased]
 
+## [1.17.0] - 2025-05-19
+
+### Added
+
+* Impacted tests detection ([#318][])
+
+### Changed
+
+* flaky test management: add sha parameter to the tests_properties request ([#321][])
+* Send `attempt_to_fix_passed:false` when attempt_to_fix_validation did not succeed ([#320][])
+
+### Fixed
+
+* fix CODEOWNERS parsing issue where "**" wasn't matching zero folders ([#323][])
+* fix webmock compatibility of internal telemetry ([#309][])
+
 ## [1.16.0] - 2025-04-15
 
 
@@ -427,7 +443,8 @@ Currently test suite level visibility is not used by our instrumentation: it wil
 
 - Ruby versions < 2.7 no longer supported ([#8][])
 
-[Unreleased]: https://github.com/DataDog/datadog-ci-rb/compare/v1.16.0...main
+[Unreleased]: https://github.com/DataDog/datadog-ci-rb/compare/v1.17.0...main
+[1.17.0]: https://github.com/DataDog/datadog-ci-rb/compare/v1.16.0...v1.17.0
 [1.16.0]: https://github.com/DataDog/datadog-ci-rb/compare/v1.15.0...v1.16.0
 [1.15.0]: https://github.com/DataDog/datadog-ci-rb/compare/v1.14.0...v1.15.0
 [1.14.0]: https://github.com/DataDog/datadog-ci-rb/compare/v1.13.0...v1.14.0
@@ -611,5 +628,10 @@ Currently test suite level visibility is not used by our instrumentation: it wil
 [#301]: https://github.com/DataDog/datadog-ci-rb/issues/301
 [#306]: https://github.com/DataDog/datadog-ci-rb/issues/306
 [#308]: https://github.com/DataDog/datadog-ci-rb/issues/308
+[#309]: https://github.com/DataDog/datadog-ci-rb/issues/309
 [#311]: https://github.com/DataDog/datadog-ci-rb/issues/311
-[#312]: https://github.com/DataDog/datadog-ci-rb/issues/312
+[#312]: https://github.com/DataDog/datadog-ci-rb/issues/312
+[#318]: https://github.com/DataDog/datadog-ci-rb/issues/318
+[#320]: https://github.com/DataDog/datadog-ci-rb/issues/320
+[#321]: https://github.com/DataDog/datadog-ci-rb/issues/321
+[#323]: https://github.com/DataDog/datadog-ci-rb/issues/323

data/lib/datadog/ci/codeowners/rule.rb

@@ -24,7 +24,12 @@ module Datadog
         private
 
         def flags
+          # prevents /path/* from matching subfolders
           return ::File::FNM_PATHNAME if pattern.end_with?("#{::File::SEPARATOR}*")
+          # prevents /path/*.rb from matching Ruby files in subfolders
+          return ::File::FNM_PATHNAME if pattern.include?("*.")
+          # allows /path/**/subfolder to match both /path/subfolder and /path/a/b/c/subfolder
+          return ::File::FNM_PATHNAME if pattern.include?("#{::File::SEPARATOR}**#{::File::SEPARATOR}")
           0
         end
       end

data/lib/datadog/ci/configuration/components.rb

@@ -4,6 +4,7 @@ require "datadog/core/telemetry/ext"
 
 require_relative "../ext/settings"
 require_relative "../git/tree_uploader"
+require_relative "../impacted_tests_detection/component"
 require_relative "../logs/component"
 require_relative "../logs/transport"
 require_relative "../remote/component"
@@ -36,7 +37,7 @@ module Datadog
       # Adds CI behavior to Datadog trace components
       module Components
         attr_reader :test_visibility, :test_optimisation, :git_tree_upload_worker, :ci_remote, :test_retries,
-          :test_management, :agentless_logs_submission
+          :test_management, :agentless_logs_submission, :impacted_tests_detection
 
         def initialize(settings)
           @test_optimisation = nil
@@ -45,6 +46,7 @@ module Datadog
           @ci_remote = nil
           @test_retries = TestRetries::NullComponent.new
           @test_management = TestManagement::NullComponent.new
+          @impacted_tests_detection = nil
 
           # Activate CI mode if enabled
           if settings.ci.enabled
@@ -138,6 +140,8 @@ module Datadog
           )
 
           @agentless_logs_submission = build_agentless_logs_component(settings, test_visibility_api)
+
+          @impacted_tests_detection = ImpactedTestsDetection::Component.new(enabled: settings.ci.impacted_tests_detection_enabled)
         end
 
         def build_test_optimisation(settings, test_visibility_api)
@@ -237,7 +241,7 @@ module Datadog
 
         def build_git_upload_worker(settings, api)
           if settings.ci.git_metadata_upload_enabled
-            git_tree_uploader = Git::TreeUploader.new(api: api)
+            git_tree_uploader = Git::TreeUploader.new(api: api, force_unshallow: settings.ci.impacted_tests_detection_enabled)
             Worker.new do |repository_url|
               git_tree_uploader.call(repository_url)
             end
@@ -323,13 +327,21 @@ module Datadog
           settings.telemetry.shutdown_timeout_seconds = 60.0
 
           begin
-            require "datadog/core/telemetry/http/adapters/net"
+            require "datadog/core/transport/http/adapters/net"
 
-            # patch gem's telemetry transport layer to use Net::HTTP instead of WebMock's Net::HTTP
-            Core::Telemetry::Http::Adapters::Net.include(CI::Transport::Adapters::TelemetryWebmockSafeAdapter)
+            # patch gem's core transport layer to use Net::HTTP instead of WebMock's Net::HTTP
+            Core::Transport::HTTP::Adapters::Net.include(CI::Transport::Adapters::TelemetryWebmockSafeAdapter)
           rescue LoadError, StandardError => e
             Datadog.logger.warn("Failed to patch Datadog gem's telemetry layer: #{e}")
           end
+
+          # for compatibility with old telemetry transport
+          begin
+            require "datadog/core/telemetry/http/adapters/net"
+            Core::Telemetry::Http::Adapters::Net.include(CI::Transport::Adapters::TelemetryWebmockSafeAdapter)
+          rescue LoadError, StandardError => e
+            Datadog.logger.debug("The old telemetry transport layer is not available: #{e}")
+          end
         end
 
         # When timecop is present:

data/lib/datadog/ci/configuration/settings.rb

@@ -151,6 +151,12 @@ module Datadog
                 o.env CI::Ext::Settings::ENV_TEST_VISIBILITY_DRB_SERVER_URI
               end
 
+              option :impacted_tests_detection_enabled do |o|
+                o.type :bool
+                o.env CI::Ext::Settings::ENV_IMPACTED_TESTS_DETECTION_ENABLED
+                o.default false
+              end
+
               define_method(:instrument) do |integration_name, options = {}, &block|
                 return unless enabled
 

data/lib/datadog/ci/contrib/knapsack/patcher.rb

@@ -9,9 +9,7 @@ module Datadog
         module Patcher
           include Datadog::CI::Contrib::Patcher
 
-          module_function
-
-          def patch
+          def self.patch
             if ::RSpec::Core::Runner.ancestors.include?(::KnapsackPro::Extensions::RSpecExtension::Runner)
               # knapsack already patched rspec runner
               require_relative "runner"

data/lib/datadog/ci/contrib/knapsack/runner.rb

@@ -19,6 +19,7 @@ module Datadog
               return super if ::RSpec.configuration.dry_run? && !datadog_configuration[:dry_run_enabled]
               return super unless datadog_configuration[:enabled]
 
+              # @type var test_session: Datadog::CI::TestSession?
               test_session = test_visibility_component.start_test_session(
                 tags: {
                   CI::Ext::Test::TAG_FRAMEWORK => CI::Contrib::RSpec::Ext::FRAMEWORK,
@@ -27,6 +28,7 @@ module Datadog
                 service: datadog_configuration[:service_name]
               )
 
+              # @type var test_module: Datadog::CI::TestModule?
               test_module = test_visibility_component.start_test_module(CI::Contrib::RSpec::Ext::FRAMEWORK)
 
               result = super

data/lib/datadog/ci/contrib/minitest/runner.rb

@@ -38,6 +38,7 @@ module Datadog
             def run_one_method(klass, method_name)
               return super unless datadog_configuration[:enabled]
 
+              # @type var result: untyped
               result = nil
 
               test_retries_component.with_retries do

data/lib/datadog/ci/contrib/minitest/test.rb

@@ -40,7 +40,11 @@ module Datadog
                 },
                 service: datadog_configuration[:service_name]
               )
+              # Steep type checker doesn't know that we patched Minitest::Test class definition
+              #
+              # steep:ignore:start
               test_span&.itr_unskippable! if self.class.dd_suite_unskippable? || self.class.dd_test_unskippable?(name)
+              # steep:ignore:end
               skip(test_span&.datadog_skip_reason) if test_span&.should_skip?
             end
 
@@ -100,9 +104,10 @@ module Datadog
             end
 
             def dd_test_unskippable?(test_name)
-              return false unless @datadog_itr_unskippable_tests
+              tests = @datadog_itr_unskippable_tests
+              return false unless tests
 
-              @datadog_itr_unskippable_tests.include?(test_name)
+              tests.include?(test_name)
             end
           end
         end

data/lib/datadog/ci/contrib/parallel_tests/patcher.rb

@@ -11,9 +11,7 @@ module Datadog
         module Patcher
           include Datadog::CI::Contrib::Patcher
 
-          module_function
-
-          def patch
+          def self.patch
             ::ParallelTests::CLI.include(CLI)
           end
         end

data/lib/datadog/ci/contrib/patcher.rb

@@ -29,9 +29,13 @@ module Datadog
             return unless defined?(super)
 
             patch_only_once.run do
+              # There is no way to tell Steep that we prepend these methods to modules that have .patch method
+              #
+              # steep:ignore:start
               super.tap do
                 @patch_successful = true
               end
+              # steep:ignore:end
             rescue => e
               on_patch_error(e)
             end

data/lib/datadog/ci/contrib/rspec/helpers.rb

@@ -6,9 +6,7 @@ module Datadog
       module RSpec
         # Helper methods for RSpec instrumentation
         module Helpers
-          module_function
-
-          def parallel_tests?
+          def self.parallel_tests?
             !!ENV.fetch("TEST_ENV_NUMBER", nil) && !!ENV.fetch("PARALLEL_TEST_GROUPS", nil)
           end
         end

data/lib/datadog/ci/ext/environment/extractor.rb

@@ -46,14 +46,12 @@ module Datadog
               Git::TAG_COMMIT_COMMITTER_EMAIL => @provider.git_commit_committer_email,
               Git::TAG_COMMIT_COMMITTER_NAME => @provider.git_commit_committer_name,
               Git::TAG_COMMIT_MESSAGE => @provider.git_commit_message,
-              Git::TAG_COMMIT_SHA => @provider.git_commit_sha
+              Git::TAG_COMMIT_SHA => @provider.git_commit_sha,
+              Git::TAG_PULL_REQUEST_BASE_BRANCH => @provider.git_pull_request_base_branch,
+              Git::TAG_PULL_REQUEST_BASE_BRANCH_SHA => @provider.git_pull_request_base_branch_sha,
+              Git::TAG_COMMIT_HEAD_SHA => @provider.git_commit_head_sha
             }
 
-            # set additional tags if provider needs them
-            @provider.additional_tags.each do |key, value|
-              @tags[key] = value
-            end
-
             # Normalize Git references and filter sensitive data
             normalize_git!
             # Expand ~

data/lib/datadog/ci/ext/environment/providers/appveyor.rb

@@ -83,6 +83,11 @@ module Datadog
               commit_message
             end
 
+            def git_pull_request_base_branch
+              # from docs: build branch. For Pull Request commits it is base branch PR is merging into
+              env["APPVEYOR_REPO_BRANCH"]
+            end
+
             private
 
             def github_repo_provider?

data/lib/datadog/ci/ext/environment/providers/base.rb

@@ -96,8 +96,13 @@ module Datadog
             def git_commit_sha
             end
 
-            def additional_tags
-              {}
+            def git_pull_request_base_branch
+            end
+
+            def git_pull_request_base_branch_sha
+            end
+
+            def git_commit_head_sha
             end
 
             private

data/lib/datadog/ci/ext/environment/providers/bitbucket.rb

@@ -59,6 +59,12 @@ module Datadog
               env["BITBUCKET_TAG"]
             end
 
+            def git_pull_request_base_branch
+              # from docs: The pull request destination branch (used in combination with BITBUCKET_BRANCH).
+              # Only available on a pull request triggered build
+              env["BITBUCKET_PR_DESTINATION_BRANCH"]
+            end
+
             private
 
             def url

data/lib/datadog/ci/ext/environment/providers/bitrise.rb

@@ -47,7 +47,7 @@ module Datadog
             end
 
             def git_branch
-              env["BITRISEIO_GIT_BRANCH_DEST"] || env["BITRISE_GIT_BRANCH"]
+              env["BITRISEIO_PULL_REQUEST_HEAD_BRANCH"] || env["BITRISE_GIT_BRANCH"]
             end
 
             def git_tag
@@ -73,6 +73,12 @@ module Datadog
             def git_commit_committer_email
               env["GIT_CLONE_COMMIT_COMMITER_EMAIL"] || env["GIT_CLONE_COMMIT_COMMITER_NAME"]
             end
+
+            def git_pull_request_base_branch
+              # from docs: Used only with builds triggered by pull requests: the destination/target branch of the pull request that triggered the build.
+              # For example, a pull request wants to merge the content of a branch into the branch main. In this case, this Env Var’s value is main.
+              env["BITRISEIO_GIT_BRANCH_DEST"]
+            end
           end
         end
       end

data/lib/datadog/ci/ext/environment/providers/buddy.rb

@@ -65,6 +65,11 @@ module Datadog
             def git_commit_committer_email
               env["BUDDY_EXECUTION_REVISION_COMMITTER_EMAIL"]
             end
+
+            def git_pull_request_base_branch
+              # from docs: The name of the Git BASE branch of the currently run Pull Request
+              env["BUDDY_RUN_PR_BASE_BRANCH"]
+            end
           end
         end
       end

data/lib/datadog/ci/ext/environment/providers/github_actions.rb

@@ -76,34 +76,53 @@ module Datadog
               }.reject { |_, v| v.nil? }.to_json
             end
 
-            def additional_tags
-              base_ref = env["GITHUB_BASE_REF"]
-              return {} if base_ref.nil? || base_ref.empty?
+            def git_pull_request_base_branch
+              return nil if github_event_json.nil?
 
-              # @type var result: Hash[String, String]
-              result = {
-                Git::TAG_PULL_REQUEST_BASE_BRANCH => base_ref
-              }
-
-              event_path = env["GITHUB_EVENT_PATH"]
-              event_json = JSON.parse(File.read(event_path))
+              env["GITHUB_BASE_REF"]
+            end
 
-              head_sha = event_json.dig("pull_request", "head", "sha")
-              result[Git::TAG_COMMIT_HEAD_SHA] = head_sha if head_sha
+            def git_pull_request_base_branch_sha
+              return nil if git_pull_request_base_branch.nil?
 
-              base_sha = event_json.dig("pull_request", "base", "sha")
-              result[Git::TAG_PULL_REQUEST_BASE_BRANCH_SHA] = base_sha if base_sha
+              event_json = github_event_json
+              return nil if event_json.nil?
 
-              result
+              event_json.dig("pull_request", "base", "sha")
             rescue => e
-              Datadog.logger.error("Failed to extract additional tags from GitHub Actions: #{e}")
-              Core::Telemetry::Logger.report(e, description: "Failed to extract additional tags from GitHub Actions")
+              Datadog.logger.error("Failed to extract pull request base branch SHA from GitHub Actions: #{e}")
+              Core::Telemetry::Logger.report(e, description: "Failed to extract pull request base branch SHA from GitHub Actions")
+              nil
+            end
 
-              {}
+            def git_commit_head_sha
+              return nil if git_pull_request_base_branch.nil?
+
+              event_json = github_event_json
+              return nil if event_json.nil?
+
+              event_json.dig("pull_request", "head", "sha")
+            rescue => e
+              Datadog.logger.error("Failed to extract commit head SHA from GitHub Actions: #{e}")
+              Core::Telemetry::Logger.report(e, description: "Failed to extract commit head SHA from GitHub Actions")
+              nil
             end
 
             private
 
+            def github_event_json
+              return @github_event_json if defined?(@github_event_json)
+
+              event_path = env["GITHUB_EVENT_PATH"]
+              return @github_event_json = nil if event_path.nil? || event_path.empty?
+
+              @github_event_json = JSON.parse(File.read(event_path))
+            rescue => e
+              Datadog.logger.error("Failed to parse GitHub event JSON: #{e}")
+              Core::Telemetry::Logger.report(e, description: "Failed to parse GitHub event JSON")
+              @github_event_json = nil
+            end
+
             def github_server_url
               return @github_server_url if defined?(@github_server_url)
 

data/lib/datadog/ci/ext/environment/providers/gitlab.rb

@@ -100,13 +100,25 @@ module Datadog
               }.to_json
             end
 
+            def git_pull_request_base_branch
+              env["CI_MERGE_REQUEST_TARGET_BRANCH_NAME"]
+            end
+
+            def git_pull_request_base_branch_sha
+              env["CI_MERGE_REQUEST_TARGET_BRANCH_SHA"]
+            end
+
+            def git_commit_head_sha
+              env["CI_MERGE_REQUEST_SOURCE_BRANCH_SHA"]
+            end
+
             private
 
             def extract_name_email
               return @name_email_tuple if defined?(@name_email_tuple)
 
               name_and_email_string = env["CI_COMMIT_AUTHOR"]
-              if name_and_email_string.include?("<") && (match = /^([^<]*)<([^>]*)>$/.match(name_and_email_string))
+              if name_and_email_string&.include?("<") && (match = /^([^<]*)<([^>]*)>$/.match(name_and_email_string))
                 name = match[1]
                 name = name.strip if name
                 email = match[2]

data/lib/datadog/ci/ext/environment/providers/user_defined_tags.rb

@@ -54,6 +54,18 @@ module Datadog
             def git_commit_committer_date
               env[Git::ENV_COMMIT_COMMITTER_DATE]
             end
+
+            def git_pull_request_base_branch
+              env[Git::ENV_PULL_REQUEST_BASE_BRANCH]
+            end
+
+            def git_pull_request_base_branch_sha
+              env[Git::ENV_PULL_REQUEST_BASE_BRANCH_SHA]
+            end
+
+            def git_commit_head_sha
+              env[Git::ENV_COMMIT_HEAD_SHA]
+            end
           end
         end
       end

data/lib/datadog/ci/ext/git.rb

@@ -36,6 +36,9 @@ module Datadog
         ENV_COMMIT_COMMITTER_NAME = "DD_GIT_COMMIT_COMMITTER_NAME"
         ENV_COMMIT_COMMITTER_EMAIL = "DD_GIT_COMMIT_COMMITTER_EMAIL"
         ENV_COMMIT_COMMITTER_DATE = "DD_GIT_COMMIT_COMMITTER_DATE"
+        ENV_PULL_REQUEST_BASE_BRANCH = "DD_GIT_PULL_REQUEST_BASE_BRANCH"
+        ENV_PULL_REQUEST_BASE_BRANCH_SHA = "DD_GIT_PULL_REQUEST_BASE_BRANCH_SHA"
+        ENV_COMMIT_HEAD_SHA = "DD_GIT_COMMIT_HEAD_SHA"
       end
     end
   end

data/lib/datadog/ci/ext/settings.rb

@@ -25,6 +25,7 @@ module Datadog
         ENV_TEST_VISIBILITY_DRB_SERVER_URI = "DD_TEST_VISIBILITY_DRB_SERVER_URI"
         ENV_AGENTLESS_LOGS_SUBMISSION_ENABLED = "DD_AGENTLESS_LOG_SUBMISSION_ENABLED"
         ENV_AGENTLESS_LOGS_SUBMISSION_URL = "DD_AGENTLESS_LOG_SUBMISSION_URL"
+        ENV_IMPACTED_TESTS_DETECTION_ENABLED = "DD_CIVISIBILITY_IMPACTED_TESTS_DETECTION_ENABLED"
 
         # Source: https://docs.datadoghq.com/getting_started/site/
         DD_SITE_ALLOWLIST = %w[

data/lib/datadog/ci/ext/telemetry.rb

@@ -68,6 +68,8 @@ module Datadog
 
         METRIC_TEST_SESSION = "test_session"
 
+        METRIC_IMPACTED_TESTS_IS_MODIFIED = "impacted_tests.is_modified"
+
         TAG_TEST_FRAMEWORK = "test_framework"
         TAG_EVENT_TYPE = "event_type"
         TAG_HAS_CODEOWNER = "has_codeowner"
@@ -138,6 +140,8 @@ module Datadog
           GET_LOCAL_COMMITS = "get_local_commits"
           GET_OBJECTS = "get_objects"
           PACK_OBJECTS = "pack_objects"
+          DIFF = "diff"
+          BASE_COMMIT_SHA = "base_commit_sha"
         end
 
         module Provider

data/lib/datadog/ci/ext/test.rb

@@ -94,7 +94,7 @@ module Datadog
             AUTO_TEST_RETRIES_VERSION = "1"
             TEST_MANAGEMENT_QUARANTINE_VERSION = "1"
             TEST_MANAGEMENT_DISABLE_VERSION = "1"
-            TEST_MANAGEMENT_ATTEMPT_TO_FIX_VERSION = "2"
+            TEST_MANAGEMENT_ATTEMPT_TO_FIX_VERSION = "4"
           end
 
           # Map of capabilities to their versions
@@ -108,6 +108,9 @@ module Datadog
           }.freeze
         end
 
+        # impacted tests detection
+        TAG_TEST_IS_MODIFIED = "test.is_modified"
+
         # internal APM tag to mark a span as a test span
         TAG_SPAN_KIND = "span.kind"
         SPAN_KIND_TEST = "test"

data/lib/datadog/ci/ext/transport.rb

@@ -48,6 +48,7 @@ module Datadog
         DD_API_SETTINGS_RESPONSE_TEST_MANAGEMENT_KEY = "test_management"
         DD_API_SETTINGS_RESPONSE_ATTEMPT_TO_FIX_RETRIES_KEY = "attempt_to_fix_retries"
         DD_API_SETTINGS_RESPONSE_DEFAULT = {DD_API_SETTINGS_RESPONSE_ITR_ENABLED_KEY => false}.freeze
+        DD_API_SETTINGS_RESPONSE_IMPACTED_TESTS_ENABLED_KEY = "impacted_tests_enabled"
 
         DD_API_GIT_SEARCH_COMMITS_PATH = "/api/v2/git/repository/search_commits"