datacite_doi_ify 0.0.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7e7aacda4675cf6f5ee73cf69f59e31cdca8b974
-  data.tar.gz: 08883ffae7e22eb41b509d011060fe60017f2f69
+  metadata.gz: dd01ed9332d1f62fe3ae36fad4cbec2aa5ad514c
+  data.tar.gz: 426f292c8bbe2598497f70e81b800576741ce38b
 SHA512:
-  metadata.gz: ee712aadad5d758a64561bfa75f66d61f65ca98dd8349fc35f6d426dfe5276c4541c61bd52741bd9235b77dea304e39e1bc73e7dccbee05bff9a48d310d17b1d
-  data.tar.gz: 2385e3181cf08867bb2ad9a8aa441ca3188ac62159650a7410030cd218751f85fe701dfa05213fc9c50a349ddb7255c16fe09211920d44559f5ad0357c8cea66
+  metadata.gz: 71c4d58d0ae9397935532294d9eadaae4e56bedf37c742682b1afefa58770b4e9f9228cf490e0304a2cdd2ae6ccb811e7549eb5d5aa9515b8408605b8f19f262
+  data.tar.gz: c05c155f2a1ad4ee5b8730df478e1422d10d4d0781317a7e0dbcaa1407e4a15b93268ab587ebeac66f05f97fdd3d508d22b59d5a3c7054fb0fa3f35e49b2011e

data/.gitignore

@@ -1,4 +1,6 @@
 *.gem
 .bundle
+.idea/
+coverage/
 Gemfile.lock
 pkg/*

data/.ruby-version

@@ -1 +1 @@
-ruby-2.1.3
+ruby-2.1.5

data/.travis.yml

@@ -1,8 +1,11 @@
 language: ruby
-bundler_args: --without production
+
+sudo: false
+
+cache: bundler
 
 rvm:
-  - 2.1.3
+  - 2.1.5
 
 script:
   - RAILS_ENV=test bundle exec rspec spec

data/README.md

@@ -1,7 +1,7 @@
 [![Build Status](https://travis-ci.org/FAIRdom/datacite_doi_ify.png?branch=master)](https://travis-ci.org/FAIRdom/datacite_doi_ify)
 
-[![Gem Version](https://badge.fury.io/rb/datacitedoiify.png)](http://badge.fury.io/rb/datacitedoiify)
+[![Gem Version](https://badge.fury.io/rb/datacite_doi_ify.svg)](http://badge.fury.io/rb/datacite_doi_ify)
 
-[![Coverage Status](https://coveralls.io/repos/FAIRdom/datacite_doi_ify/badge.png)](https://coveralls.io/r/FAIRdom/datacite_doi_ify)
+[![Coverage Status](https://coveralls.io/repos/FAIRdom/datacite_doi_ify/badge.png?branch=master)](https://coveralls.io/r/FAIRdom/datacite_doi_ify?branch=master)
 
-[![Code Climate](https://codeclimate.com/github/FAIRdom/datacite_doi_ify/badges/gpa.svg)](https://codeclimate.com/github/FAIRdom/datacite_doi_ify)
+[![Code Climate](https://codeclimate.com/github/FAIRdom/datacite_doi_ify/badges/gpa.svg)](https://codeclimate.com/github/FAIRdom/datacite_doi_ify)

data/datacite_doi_ify.gemspec

@@ -7,9 +7,9 @@ Gem::Specification.new do |s|
   s.version     = DataciteDoiIfy::VERSION
   s.authors     = ["quyen nguyen"]
   s.email       = ["thucquyendn@gmail.com"]
-  s.homepage    = ""
-  s.summary     = "A ruby gem to working with datacite doi restful web service"
-  s.description = "Mint DOI and resolve DOI using Datacite restful web service"
+  s.homepage    = "https://seek.sysmo-db.org/people/372"
+  s.summary     = "A ruby gem for working with the DataCite doi restful web service"
+  s.description = "Mint a DOI and resolve a DOI using the Datacite restful web service"
 
   s.rubyforge_project = "datacite_doi_ify"
 
@@ -20,15 +20,16 @@ Gem::Specification.new do |s|
 
   # specify any dependencies here; for example:
   # s.add_development_dependency "rspec"
-  # s.add_runtime_dependency "rest-client"
-  s.add_development_dependency "rspec"
-  s.add_development_dependency "rspec-nc"
-  s.add_development_dependency "guard"
-  s.add_development_dependency "guard-rspec"
-  s.add_development_dependency "pry"
-  s.add_development_dependency "pry-remote"
-  s.add_development_dependency "pry-nav"
-  s.add_development_dependency "coveralls"
-  s.add_development_dependency "webmock"
-  s.add_development_dependency "vcr"
+  s.add_runtime_dependency "rest-client", "~> 1.7"
+  
+  s.add_development_dependency "rspec", "~> 3.1"
+  s.add_development_dependency "rspec-nc", "~> 0.2"
+  s.add_development_dependency "guard", "~> 2.8"
+  s.add_development_dependency "guard-rspec", "~> 4.3"
+  s.add_development_dependency "pry", "~> 0.10"
+  s.add_development_dependency "pry-remote", "~> 0.1"
+  s.add_development_dependency "pry-nav", "~> 0.2"
+  s.add_development_dependency "coveralls", "~> 0.7"
+  s.add_development_dependency "webmock", "~> 1.20"
+  s.add_development_dependency "vcr", "~> 2.9"
 end

data/lib/datacite_doi_ify/datacite.rb

@@ -3,16 +3,16 @@ require 'rest-client'
 class Datacite
   ENDPOINT = 'https://mds.datacite.org'
 
-  def initialize(user_name, password)
-    @endpoint = RestClient::Resource.new(ENDPOINT, user_name, password)
+  def initialize(user_name, password, endpoint=nil)
+    endpoint ||= ENDPOINT
+    @endpoint = RestClient::Resource.new(endpoint, user_name, password)
   end
 
   def resolve doi
     begin
       response = @endpoint["doi/#{doi}"].get
     rescue Exception => e
-      #error code
-      e.message[0..2]
+      e.message
     end
   end
 
@@ -20,8 +20,7 @@ class Datacite
     begin
       response = @endpoint['doi'].post "doi=#{doi}\nurl=#{url}", content_type: "text/plain;charset=UTF-8"
     rescue Exception => e
-      #error code
-      e.message[0..2]
+      e.message
     end
   end
 
@@ -29,8 +28,7 @@ class Datacite
     begin
       response = @endpoint['metadata'].post(metadata,content_type: 'application/xml;charset=UTF-8')
     rescue Exception => e
-      #error code
-      e.message[0..2]
+      e.message
     end
   end
 
@@ -38,8 +36,7 @@ class Datacite
     begin
       response = @endpoint["metadata/#{doi}"].get
     rescue Exception => e
-      #error code
-      e.message[0..2]
+      e.message
     end
   end
 end

data/lib/datacite_doi_ify/version.rb

@@ -1,3 +1,3 @@
 module DataciteDoiIfy
-  VERSION = "0.0.1"
+  VERSION = "1.0.0"
 end

data/spec/datacite_doi_ify_spec.rb

@@ -15,19 +15,19 @@ describe DataciteDoiIfy do
       invalid_user = 'invalid'
       invalid_password = 'invalid'
       endpoint = Datacite.new(invalid_user, invalid_password)
-      expect(endpoint.resolve(doi)).to eq('401')
+      expect(endpoint.resolve(doi)[0..2]).to eq('401')
     end
 
     it 'returns a 404 for not-found DOI', :vcr => {:cassette_name => "resolve_a_DOI/returns_a_404_for_not-found_DOI"} do
       doi = 'non-existing'
-      expect(endpoint.resolve(doi)).to eq('404')
+      expect(endpoint.resolve(doi)[0..2]).to eq('404')
     end
   end
 
   describe 'mint a DOI' do
     context 'DOI does not exist' do
       it 'mints a new DOI', :vcr => {:cassette_name => "mint_a_DOI/mints_a_new_DOI"} do
-        metadata = open('my_test.xml').read
+        metadata = open_test_metadata('my_test.xml')
         expect(endpoint.upload_metadata(metadata)).to eq('OK (10.5072/my_test)')
         expect(endpoint.mint(doi, url)).to eq('OK')
         expect(endpoint.resolve(doi)).to eq(url)
@@ -36,14 +36,14 @@ describe DataciteDoiIfy do
       it 'returns 412 if metadata has not been uploaded', :vcr => {:cassette_name => "mint_a_DOI/returns_412_if_metadata_has_not_been_uploaded"} do
         new_doi = "10.5072/new_doi"
         #412 Precondition failed
-        expect(endpoint.mint(new_doi, url)).to eq('412')
+        expect(endpoint.mint(new_doi, url)[0..2]).to eq('412')
       end
     end
 
     context 'DOI exists' do
       it 'updates the URL if different', :vcr => {:cassette_name => "mint_a_DOI/updates_the_URL_if_different"} do
         #use test_doi.xml so that it does not update the url of my_test.xml
-        metadata = open('test_doi.xml').read
+        metadata = open_test_metadata('test_doi.xml')
         doi = '10.5072/test_doi'
         expect(endpoint.upload_metadata(metadata)).to eq('OK (10.5072/test_doi)')
         expect(endpoint.mint(doi, url)).to eq('OK')
@@ -58,26 +58,26 @@ describe DataciteDoiIfy do
 
   describe 'retrieve metadata' do
     it 'returns metadata associated with a given DOI', :vcr => {:cassette_name => "retrieve_metadata/returns_metadata_associated_with_a_given_DOI"} do
-      metadata = open('my_test.xml').read
+      metadata = open_test_metadata('my_test.xml')
       expect(endpoint.metadata(doi)).to eq(metadata)
     end
 
     it 'returns 404 for not found DOI', :vcr => {:cassette_name => "retrieve_metadata/returns_404_for_not_found_DOI"} do
       doi = 'non-existing'
-      expect(endpoint.metadata(doi)).to eq('404')
+      expect(endpoint.metadata(doi)[0..2]).to eq('404')
     end
   end
 
   describe 'upload metadata' do
     it 'creates new version of metadata', :vcr => {:cassette_name => "upload_metadata/creates_new_version_of_metadata"} do
-      metadata = open('my_test.xml').read
+      metadata = open_test_metadata('my_test.xml')
       expect(endpoint.upload_metadata(metadata)).to eq('OK (10.5072/my_test)')
     end
 
     it 'returns 400 for an invalid xml', :vcr => {:cassette_name => "upload_metadata/returns_400_for_an_invalid_xml"} do
       # metadata without a DOI => Bad request
-      metadata = open('invalid_doi.xml').read
-      expect(endpoint.upload_metadata(metadata)).to eq('400')
+      metadata = open_test_metadata('invalid_doi.xml')
+      expect(endpoint.upload_metadata(metadata)[0..2]).to eq('400')
     end
   end
 
@@ -91,5 +91,10 @@ describe DataciteDoiIfy do
     end
   end
 
+  def open_test_metadata filename
+    file = File.join "spec/","/metadata_files/", filename
+    open(file).read
+  end
+
   #TODO: Media API
 end

metadata

@@ -1,156 +1,170 @@
 --- !ruby/object:Gem::Specification
 name: datacite_doi_ify
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 1.0.0
 platform: ruby
 authors:
 - quyen nguyen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-05 00:00:00.000000000 Z
+date: 2014-12-04 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: rest-client
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rspec-nc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.8'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.3'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: pry-remote
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: pry-nav
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.20'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.20'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: Mint DOI and resolve DOI using Datacite restful web service
+        version: '2.9'
+description: Mint a DOI and resolve a DOI using the Datacite restful web service
 email:
 - thucquyendn@gmail.com
 executables: []
@@ -168,11 +182,9 @@ files:
 - README.md
 - Rakefile
 - datacite_doi_ify.gemspec
-- invalid_doi.xml
 - lib/datacite_doi_ify.rb
 - lib/datacite_doi_ify/datacite.rb
 - lib/datacite_doi_ify/version.rb
-- my_test.xml
 - spec/cassettes/mint_a_DOI/mints_a_new_DOI.yml
 - spec/cassettes/mint_a_DOI/returns_412_if_metadata_has_not_been_uploaded.yml
 - spec/cassettes/mint_a_DOI/updates_the_URL_if_different.yml
@@ -184,9 +196,11 @@ files:
 - spec/cassettes/upload_metadata/creates_new_version_of_metadata.yml
 - spec/cassettes/upload_metadata/returns_400_for_an_invalid_xml.yml
 - spec/datacite_doi_ify_spec.rb
+- spec/metadata_files/invalid_doi.xml
+- spec/metadata_files/my_test.xml
+- spec/metadata_files/test_doi.xml
 - spec/spec_helper.rb
-- test_doi.xml
-homepage: ''
+homepage: https://seek.sysmo-db.org/people/372
 licenses: []
 metadata: {}
 post_install_message: 
@@ -208,7 +222,7 @@ rubyforge_project: datacite_doi_ify
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: A ruby gem to working with datacite doi restful web service
+summary: A ruby gem for working with the DataCite doi restful web service
 test_files:
 - spec/cassettes/mint_a_DOI/mints_a_new_DOI.yml
 - spec/cassettes/mint_a_DOI/returns_412_if_metadata_has_not_been_uploaded.yml
@@ -221,4 +235,7 @@ test_files:
 - spec/cassettes/upload_metadata/creates_new_version_of_metadata.yml
 - spec/cassettes/upload_metadata/returns_400_for_an_invalid_xml.yml
 - spec/datacite_doi_ify_spec.rb
+- spec/metadata_files/invalid_doi.xml
+- spec/metadata_files/my_test.xml
+- spec/metadata_files/test_doi.xml
 - spec/spec_helper.rb