database_consistency 2.0.8 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3093f4a5d4db53c187939d87a5799b5a932d9ddb6d7c4d124949e66e2ea14477
-  data.tar.gz: d7c73224a9f1006113ad57b8a6a740f5198bcbe2ba7b855cdaac9d34b8794f87
+  metadata.gz: 347875b9be8806850702674f72e235f318f9c307bc915370fa940f3c23476e1d
+  data.tar.gz: b19f093bc18afb4be2f47b3309f9d8bd09f786b774d9226421e2856ec87a63e4
 SHA512:
-  metadata.gz: e0b3a3e3507c77692ffcd1b89430e561bf9c51f1d5419ab5cd176667048c747d03bf9ca0789a60bd02e5e2deac6e666556f0d1c4cc95c666c66b4ee48562e0f6
-  data.tar.gz: 3fa45f23b358a9ce3ab83be7512c6ec7d59c9ae6bf7b5ec39c50f26ddaa0063fb7a31dd2779d67e946222ef7aea0186d1ad1b7383a4c482424b01c6dda1348b4
+  metadata.gz: af8ea0a3e3e1ab9069a9db551601127d2fb82899a315eb40d2bdab4698f134704e248dce76826924b598755f94eb00280ebc15374189987da81cc748a9565ced
+  data.tar.gz: a2348924c764f4ee1d1d880aff03e3414ba9f2c62c4aba2c8b415bc52e92a282a6608e5da768b90468fcae0cf7b618bf4469fc86c0a1c1c5a6b7c2b301ca6079

data/lib/database_consistency/checkers/association_checkers/association_checker.rb

@@ -23,6 +23,13 @@ module DatabaseConsistency
       def table_or_model_name
         @table_or_model_name ||= model.name.to_s
       end
+
+      def foreign_key_exists? # rubocop:disable Metrics/AbcSize
+        model.connection.foreign_keys(model.table_name).any? do |foreign_key|
+          (Helper.extract_columns(association.foreign_key.to_s) - Array.wrap(foreign_key.column)).empty? &&
+            foreign_key.to_table == association.klass.table_name
+        end
+      end
     end
   end
 end

data/lib/database_consistency/checkers/association_checkers/foreign_key_checker.rb

@@ -42,13 +42,8 @@ module DatabaseConsistency
       # | ----------- | ------ |
       # | persisted   | ok     |
       # | missing     | fail   |
-      def check # rubocop:disable Metrics/AbcSize
-        fk_exist = model.connection.foreign_keys(model.table_name).any? do |fk|
-          (Helper.extract_columns(association.foreign_key.to_s) - Array.wrap(fk.column)).empty? &&
-            fk.to_table == association.klass.table_name
-        end
-
-        if fk_exist
+      def check
+        if foreign_key_exists?
           report_template(:ok)
         else
           report_template(:fail, error_slug: :missing_foreign_key)

data/lib/database_consistency/checkers/association_checkers/missing_dependent_destroy_checker.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks for models that need a dependent destroy association
+    class MissingDependentDestroyChecker < AssociationChecker
+      Report = ReportBuilder.define(
+        DatabaseConsistency::Report,
+        :model_name,
+        :attribute_name
+      )
+
+      DEPENDENT_OPTIONS = %i[destroy delete delete_all nullify].freeze
+
+      private
+
+      def preconditions
+        association.belongs_to? && foreign_key_exists?
+      end
+
+      def check
+        if dependent_destroy_exists? || cascade?
+          report_template(:ok)
+        else
+          report_template(:fail, error_slug: :missing_dependent_destroy)
+        end
+      end
+
+      def dependent_destroy_exists?
+        association.class_name.constantize.reflect_on_all_associations.any? do |association|
+          %i[has_many has_one].include?(association.macro) &&
+            DEPENDENT_OPTIONS.include?(association.options[:dependent]) &&
+            association.table_name == model.table_name
+        end
+      end
+
+      def foreign_key
+        association.klass
+                   .connection
+                   .foreign_keys(model.table_name)
+                   .find { |fk| fk.column == association.foreign_key.to_s }
+      end
+
+      def cascade?
+        %i[cascade nullify].include? foreign_key.options[:on_delete]
+      end
+
+      def report_template(status, error_slug: nil)
+        Report.new(
+          status: status,
+          error_message: nil,
+          error_slug: error_slug,
+          model_name: association.class_name,
+          attribute_name: model.table_name,
+          **report_attributes
+        )
+      end
+    end
+  end
+end

data/lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb

@@ -28,7 +28,7 @@ module DatabaseConsistency
       # | persisted    | ok     |
       # | missing      | fail   |
       def check
-        if unique_index
+        if unique_index || primary_key_covers_validation?
           report_template(:ok)
         else
           report_template(:fail, error_slug: :missing_unique_index)
@@ -52,6 +52,14 @@ module DatabaseConsistency
         end
       end
 
+      def primary_key_covers_validation?
+        primary_key = model.connection.primary_key(model.table_name)
+
+        return false if primary_key.blank?
+
+        sorted_uniqueness_validator_columns == Helper.extract_columns(primary_key).sort
+      end
+
       def sorted_uniqueness_validator_columns
         @sorted_uniqueness_validator_columns ||= Helper.sorted_uniqueness_validator_columns(attribute, validator, model)
       end

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '2.0.8'
+  VERSION = '2.1.0'
 end

data/lib/database_consistency/writers/simple/missing_dependent_destroy.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class MissingDependentDestroy < Base # :nodoc:
+        private
+
+        def template
+          'should have a corresponding has_one/has_many association with dependent option (destroy, delete, delete_all, nullify) or a foreign key with on_delete (cascade, nullify)' # rubocop:disable Layout/LineLength
+        end
+
+        def unique_attributes
+          {
+            model_name: report.model_name,
+            attribute_name: report.attribute_name
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency.rb

@@ -43,6 +43,7 @@ require 'database_consistency/writers/simple/three_state_boolean'
 require 'database_consistency/writers/simple/missing_association_class'
 require 'database_consistency/writers/simple/missing_table'
 require 'database_consistency/writers/simple/implicit_order_column_missing'
+require 'database_consistency/writers/simple/missing_dependent_destroy'
 require 'database_consistency/writers/simple_writer'
 
 require 'database_consistency/writers/autofix/helpers/migration'
@@ -83,6 +84,7 @@ require 'database_consistency/checkers/association_checkers/foreign_key_checker'
 require 'database_consistency/checkers/association_checkers/foreign_key_type_checker'
 require 'database_consistency/checkers/association_checkers/foreign_key_cascade_checker'
 require 'database_consistency/checkers/association_checkers/missing_association_class_checker'
+require 'database_consistency/checkers/association_checkers/missing_dependent_destroy_checker'
 
 require 'database_consistency/checkers/column_checkers/column_checker'
 require 'database_consistency/checkers/column_checkers/null_constraint_checker'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 2.0.8
+  version: 2.1.0
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2025-11-12 00:00:00.000000000 Z
+date: 2025-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -151,6 +151,7 @@ files:
 - lib/database_consistency/checkers/association_checkers/foreign_key_checker.rb
 - lib/database_consistency/checkers/association_checkers/foreign_key_type_checker.rb
 - lib/database_consistency/checkers/association_checkers/missing_association_class_checker.rb
+- lib/database_consistency/checkers/association_checkers/missing_dependent_destroy_checker.rb
 - lib/database_consistency/checkers/association_checkers/missing_index_checker.rb
 - lib/database_consistency/checkers/base_checker.rb
 - lib/database_consistency/checkers/column_checkers/column_checker.rb
@@ -225,6 +226,7 @@ files:
 - lib/database_consistency/writers/simple/length_validator_lower_limit.rb
 - lib/database_consistency/writers/simple/length_validator_missing.rb
 - lib/database_consistency/writers/simple/missing_association_class.rb
+- lib/database_consistency/writers/simple/missing_dependent_destroy.rb
 - lib/database_consistency/writers/simple/missing_foreign_key.rb
 - lib/database_consistency/writers/simple/missing_foreign_key_cascade.rb
 - lib/database_consistency/writers/simple/missing_table.rb
@@ -273,7 +275,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.3.22
 signing_key: 
 specification_version: 4
 summary: Provide an easy way to check the consistency of the database constraints