database_consistency 1.1.12 → 1.1.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 908211c725197dadbe72f2f7c8f2f47d48a55ed546c57d2f512b9b2978fb325a
-  data.tar.gz: 4b18e433573c598b25906dce98554516f3c54bacbd897b59c8f72c6d9577a53d
+  metadata.gz: 86037a5780e8f5f906a5232a9925b5e250177b6ebe653a81509167814dc87a2e
+  data.tar.gz: 91cafa728a48dd765a2b66fc41c9a2a4f2952d72737472c6f1f88af28d9053b8
 SHA512:
-  metadata.gz: 43ea449cc58c970f99deb81936461d2f267a107934ad93cfb1f73ef0e0a8e46c97d9ba5085a54538828d162ca06638ad35afb907fa51de661df30bad9527cefc
-  data.tar.gz: 799f1975507dababf597ca140655377e90a1480af4422080349027b03ef7ef9dbade4125e95f317ef3d873706e82f1c24991c9c9600a08cb3dca3e6ff2bbc8e0
+  metadata.gz: d6ac7dbf5de3cc1cbfaa7aef08e86aad7c88b2e5734283ef130ab60582945312faf87828b949d6f2f2e551b2770faca8498ad70e6438bcc6416977df20441aa3
+  data.tar.gz: f31f3a0ad600d45e7fcfe6f9d9aad07a267dfc96de990e03f7e725e9644f09d95ce8b6f0c69de920676e7023a5cf2dc7058dce2506f0ead2f23ee543b2596e8f

data/lib/database_consistency/checkers/association_checkers/missing_index_checker.rb

@@ -6,6 +6,7 @@ module DatabaseConsistency
     class MissingIndexChecker < AssociationChecker
       # Message templates
       MISSING_INDEX = 'associated model should have proper index in the database'
+      MISSING_UNIQUE_INDEX = 'associated model should have proper unique index in the database'
 
       private
 
@@ -28,6 +29,22 @@ module DatabaseConsistency
       # | persisted    | ok     |
       # | missing      | fail   |
       def check
+        if unique_has_one_association?
+          check_unique_has_one
+        else
+          check_remaining
+        end
+      end
+
+      def check_unique_has_one
+        if unique_index
+          report_template(:ok)
+        else
+          report_template(:fail, MISSING_UNIQUE_INDEX)
+        end
+      end
+
+      def check_remaining
         if index
           report_template(:ok)
         else
@@ -35,9 +52,19 @@ module DatabaseConsistency
         end
       end
 
+      def unique_has_one_association?
+        association.scope.nil? && association.macro == :has_one && !association.options[:as].present?
+      end
+
+      def unique_index
+        @unique_index ||= association.klass.connection.indexes(association.klass.table_name).find do |index|
+          index_keys(index) == association_keys && index.unique
+        end
+      end
+
       def index
         @index ||= association.klass.connection.indexes(association.klass.table_name).find do |index|
-          index_keys(index) == association_keys
+          index_keys(index, limit: association_keys.size) == association_keys
         end
       end
 
@@ -45,10 +72,16 @@ module DatabaseConsistency
         @association_keys ||= [association.foreign_key, association.type].compact.map(&:to_s).sort
       end
 
-      def index_keys(index)
+      def index_keys(index, limit: nil)
         return unless index.columns.is_a?(Array)
 
-        index.columns[0...association_keys.size].sort
+        columns = index.columns
+
+        if limit
+          columns.first(limit).sort
+        else
+          columns
+        end
       end
     end
   end

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.1.12'
+  VERSION = '1.1.14'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.1.12
+  version: 1.1.14
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-23 00:00:00.000000000 Z
+date: 2022-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -199,7 +199,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.0.3.1
 signing_key: 
 specification_version: 4
 summary: Provide an easy way to check the consistency of the database constraints