database_consistency 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b074df0ae4a1316afdb9874c811a02189fd664e00b85220730dd0ae985a36c76
-  data.tar.gz: f870f9f74117a6ea1b5592e7610becc5f854c375ee4a82f9720b287ae9288462
+  metadata.gz: f37408420931f459ea476d095f441e40256ea2279e07c21ad9d477c0781d5944
+  data.tar.gz: b054877a7819333fab57dbe22786456d4a0328b462f9808561e470290b3ae6e7
 SHA512:
-  metadata.gz: 99e298ec2e58c3bfcc5c10a9e294891b14eee23b1a4c9ccbf3e78f5e500480baf1c3ec397d0a19f5af6e83f05dbe9a297e062358eab9699d324b6b06a1255889
-  data.tar.gz: 7d742b1d5985792e2fa3b3a6d5195ccb91c4b49cdbcbce800de6db29a16ef1045f4bf786b3d88e981d23b573282d4ddb821ede90951890ab45682c16b37ede7b
+  metadata.gz: c2e7a18dabde150f3f1f2ee144b6076e2c0fb944c9c128851379e86007f0aed056f1fb550cc19319b777767ffc165534939a680e248213473032054dfa8e2924
+  data.tar.gz: f047ff2a3e5e41137a93f5c64e4a0288e74b0d687670e7eabe5b3656a675abf87df75586fd5a0988f25f26f993d20542addfd2d84b430dac7dd30025f2016415

data/lib/database_consistency.rb

@@ -36,6 +36,7 @@ require 'database_consistency/checkers/validators_fraction_checkers/column_prese
 require 'database_consistency/checkers/index_checkers/index_checker'
 require 'database_consistency/checkers/index_checkers/unique_index_checker'
 require 'database_consistency/checkers/index_checkers/redundant_index_checker'
+require 'database_consistency/checkers/index_checkers/redundant_unique_index_checker'
 
 require 'database_consistency/processors/base_processor'
 require 'database_consistency/processors/associations_processor'

data/lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks redundant database indexes
+    class RedundantUniqueIndexChecker < IndexChecker
+      # Message templates
+      REDUNDANT_UNIQUE_INDEX = 'index uniqueness is redundant as (%index) covers it'
+
+      private
+
+      # We skip check when:
+      #  - index is not unique
+      def preconditions
+        index.unique
+      end
+
+      # Table of possible statuses
+      # | validation | status |
+      # | ---------- | ------ |
+      # | provided   | ok     |
+      # | redundant  | fail   |
+      #
+      def check
+        if covered_by_index
+          report_template(:fail, render_message)
+        else
+          report_template(:ok)
+        end
+      end
+
+      def render_message
+        REDUNDANT_UNIQUE_INDEX.sub('%index', covered_by_index.name)
+      end
+
+      def covered_by_index
+        @covered_by_index ||=
+          model.connection.indexes(model.table_name).find do |another_index|
+            next if index.name == another_index.name
+
+            another_index.unique && contain_index?(another_index)
+          end
+      end
+
+      def contain_index?(another_index)
+        another_index_columns = Helper.extract_index_columns(another_index.columns)
+        index_columns & another_index_columns == another_index_columns
+      end
+
+      def index_columns
+        @index_columns ||= Helper.extract_index_columns(index.columns)
+      end
+    end
+  end
+end

data/lib/database_consistency/processors/indexes_processor.rb

@@ -6,7 +6,8 @@ module DatabaseConsistency
     class IndexesProcessor < BaseProcessor
       CHECKERS = [
         Checkers::UniqueIndexChecker,
-        Checkers::RedundantIndexChecker
+        Checkers::RedundantIndexChecker,
+        Checkers::RedundantUniqueIndexChecker
       ].freeze
 
       private

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Evgeniy Demin
@@ -142,6 +142,7 @@ files:
 - lib/database_consistency/checkers/column_checkers/primary_key_type_checker.rb
 - lib/database_consistency/checkers/index_checkers/index_checker.rb
 - lib/database_consistency/checkers/index_checkers/redundant_index_checker.rb
+- lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb
 - lib/database_consistency/checkers/index_checkers/unique_index_checker.rb
 - lib/database_consistency/checkers/validator_checkers/belongs_to_presence_checker.rb
 - lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb