database_consistency 0.7.5 → 0.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a0bd9098639aa98ed190bc90d9334d7dbbeaf9fa368cf73d4e9c08d4778f0be
-  data.tar.gz: 1294d60591ae3bf21313cc88254e57e03225501601b6b5bbb33634e7cb0bfc19
+  metadata.gz: 149d7592b96f1f028881570c9fc3d4c25205361758eaa81de99ee583efad3cab
+  data.tar.gz: 1337cc3b1c115f660906663ee975afedc57308c48cc6b53d02cb6cc52494e8d1
 SHA512:
-  metadata.gz: ef673d307c963330307ca143b6176ba3211f6bc8799ed67b0a1b7d07e0eb1a2cf0a1460aa26a6626c1ac95103e4871aa29ec24f770ef33164ba41bfaf6d8a4df
-  data.tar.gz: c6b5469b5293f8445a6327ab4f65027e00cc5bc417058e688715fd1b7a3c16e5209670c69557388e09e0fb27a79ea109b8e7c5737af2f9ad055d8d2deed9d840
+  metadata.gz: b1f1c9f3d7b598ea7a2d9c0656aed100e8dc3d685316914f769f77f462c49b39541d6aea53552ef123cc05a0b5b6c01750e2951f7b7bd4495a9ddf42b0b76ba2
+  data.tar.gz: 9c781f382b1cbb7180daf21788648d0afd68f581132e69456a3c34a9580d3bc1d0bf85ed4dce8007cb8922fe9a7222efac4b624f56ea87d48c5315931d476603

data/lib/database_consistency.rb

@@ -17,14 +17,16 @@ require 'database_consistency/checkers/column_checkers/column_checker'
 require 'database_consistency/checkers/column_checkers/null_constraint_checker'
 require 'database_consistency/checkers/column_checkers/length_constraint_checker'
 require 'database_consistency/checkers/validator_checkers/validator_checker'
-require 'database_consistency/checkers/validator_checkers/column_presence_checker'
 require 'database_consistency/checkers/validator_checkers/belongs_to_presence_checker'
 require 'database_consistency/checkers/validator_checkers/missing_unique_index_checker'
+require 'database_consistency/checkers/validators_fraction_checkers/validators_fraction_checker'
+require 'database_consistency/checkers/validators_fraction_checkers/column_presence_checker'
 
 require 'database_consistency/processors/base_processor'
 require 'database_consistency/processors/associations_processor'
 require 'database_consistency/processors/validators_processor'
 require 'database_consistency/processors/columns_processor'
+require 'database_consistency/processors/validators_fractions_processor'
 
 # The root module
 module DatabaseConsistency

data/lib/database_consistency/checkers/{validator_checkers → validators_fraction_checkers}/column_presence_checker.rb

@@ -3,7 +3,7 @@
 module DatabaseConsistency
   module Checkers
     # This class checks if presence validator has non-null constraint in the database
-    class ColumnPresenceChecker < ValidatorChecker
+    class ColumnPresenceChecker < ValidatorsFractionChecker
       WEAK_OPTIONS = %i[allow_nil allow_blank if unless].freeze
       # Message templates
       CONSTRAINT_MISSING = 'column should be required in the database'
@@ -11,11 +11,15 @@ module DatabaseConsistency
 
       private
 
+      def filter(validator)
+        validator.kind == :presence
+      end
+
       # We skip check when:
-      #  - validator is not a presence validator
+      #  - there is no presence validators
       #  - there is no column in the database with given name
       def preconditions
-        validator.kind == :presence && column
+        validators.any? && column
       end
 
       # Table of possible statuses
@@ -27,7 +31,7 @@ module DatabaseConsistency
       # | all missing                     | optional | fail   |
       def check
         can_be_null = column.null
-        has_weak_option = validator.options.slice(*WEAK_OPTIONS).any?
+        has_weak_option = validators.all? { |validator| validator.options.slice(*WEAK_OPTIONS).any? }
 
         if can_be_null == has_weak_option
           report_template(:ok)

data/lib/database_consistency/checkers/validators_fraction_checkers/validators_fraction_checker.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # The base class for validator checker
+    class ValidatorsFractionChecker < BaseChecker
+      attr_reader :model, :attribute, :validators
+
+      def initialize(model, attribute, validators)
+        @model = model
+        @attribute = attribute
+        @validators = validators.select(&method(:filter))
+      end
+
+      # @return [String]
+      def column_or_attribute_name
+        @column_or_attribute_name ||= attribute.to_s
+      end
+
+      # @return [String]
+      def table_or_model_name
+        @table_or_model_name ||= model.name.to_s
+      end
+    end
+  end
+end

data/lib/database_consistency/processors/base_processor.rb

@@ -7,7 +7,8 @@ module DatabaseConsistency
       [
         ColumnsProcessor,
         ValidatorsProcessor,
-        AssociationsProcessor
+        AssociationsProcessor,
+        ValidatorsFractionsProcessor
       ].flat_map do |processor|
         processor.new(configuration).reports
       end

data/lib/database_consistency/processors/validators_fractions_processor.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Processors
+    # The class to process validators
+    class ValidatorsFractionsProcessor < BaseProcessor
+      CHECKERS = [
+        Checkers::ColumnPresenceChecker
+      ].freeze
+
+      private
+
+      # @return [Array<Hash>]
+      def check
+        Helper.parent_models.flat_map do |model|
+          next unless configuration.enabled?(model)
+
+          model._validators.flat_map do |attribute, validators|
+            next unless attribute
+
+            enabled_checkers.map do |checker_class|
+              checker = checker_class.new(model, attribute, validators)
+              checker.report_if_enabled?(configuration)
+            end
+          end
+        end.compact
+      end
+    end
+  end
+end

data/lib/database_consistency/processors/validators_processor.rb

@@ -5,7 +5,6 @@ module DatabaseConsistency
     # The class to process validators
     class ValidatorsProcessor < BaseProcessor
       CHECKERS = [
-        Checkers::ColumnPresenceChecker,
         Checkers::BelongsToPresenceChecker,
         Checkers::MissingUniqueIndexChecker
       ].freeze

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '0.7.5'
+  VERSION = '0.7.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.7.6
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-12 00:00:00.000000000 Z
+date: 2019-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -139,14 +139,16 @@ files:
 - lib/database_consistency/checkers/column_checkers/length_constraint_checker.rb
 - lib/database_consistency/checkers/column_checkers/null_constraint_checker.rb
 - lib/database_consistency/checkers/validator_checkers/belongs_to_presence_checker.rb
-- lib/database_consistency/checkers/validator_checkers/column_presence_checker.rb
 - lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb
 - lib/database_consistency/checkers/validator_checkers/validator_checker.rb
+- lib/database_consistency/checkers/validators_fraction_checkers/column_presence_checker.rb
+- lib/database_consistency/checkers/validators_fraction_checkers/validators_fraction_checker.rb
 - lib/database_consistency/configuration.rb
 - lib/database_consistency/helper.rb
 - lib/database_consistency/processors/associations_processor.rb
 - lib/database_consistency/processors/base_processor.rb
 - lib/database_consistency/processors/columns_processor.rb
+- lib/database_consistency/processors/validators_fractions_processor.rb
 - lib/database_consistency/processors/validators_processor.rb
 - lib/database_consistency/rescue_error.rb
 - lib/database_consistency/version.rb