database_consistency 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1528eadd95e4bdb9511b145d5d8584e4ebde5f9bf30b63de852e5d24fa5a79c5
-  data.tar.gz: 4b36f7adca734d72d611c12a846f800a507e5b56c4a32c524713b27a646f79e2
+  metadata.gz: cf718fbfde9b47e8d76e4e77ff2fc8a70ace19a9761eed13c2576b421fab406b
+  data.tar.gz: e212220bdb69019c813686230787ab4cda15a455e997ce37b6b9288067ce36f1
 SHA512:
-  metadata.gz: 7a88219644a5da2c07797b6a9b7e2378c4285498576dcd2b23dd877a8404bbb7be81f08c3aa4acd88d259e9d268748a8026ec5047b4f80ac26b0e240e0c62144
-  data.tar.gz: 15a9f2a8851db00e35b065f5143acb85321839f4a1965800b95d01dc44b741737764bcd261c58f637ad17b65707c298c8f6a4b6abe6874539f726a4ce13ebee3
+  metadata.gz: bd5ae1304d58ab4b8ffffbc2408fde5721f6e1026743c49c08ef93566fa5524293d9fb9f181a2a8129dfff7a1883477dcda5fc0264b411cd9d91990d590ae544
+  data.tar.gz: 2f5af1682db86a9df202227d8c9ff760930c3ef245d1a1f5a9a4d138f30412d32ccee5589c5ce5d9ba1a1a19a79a6944bbae2ed50679297c055026a0ed14faf5

data/lib/database_consistency/checkers/base_checker.rb

@@ -4,6 +4,18 @@ module DatabaseConsistency
   module Checkers
     # The base class for checkers
     class BaseChecker
+      # @param [DatabaseConsistency::Configuration]
+      #
+      # @return [Boolean]
+      def self.enabled?(configuration)
+        configuration.enabled?('DatabaseConsistencyCheckers', checker_name)
+      end
+
+      # @return [String]
+      def self.checker_name
+        @checker_name ||= name.split('::').last
+      end
+
       # @return [Hash, nil]
       def report
         return unless preconditions
@@ -11,7 +23,14 @@ module DatabaseConsistency
         @report ||= check
       end
 
+      # @return [Hash, nil]
+      def report_if_enabled?(configuration)
+        report if enabled?(configuration)
+      end
+
       # @param [DatabaseConsistency::Configuration] configuration
+      #
+      # @return [Boolean]
       def enabled?(configuration)
         configuration.enabled?(table_or_model_name, column_or_attribute_name, checker_name)
       end
@@ -30,7 +49,7 @@ module DatabaseConsistency
 
       # @return [String]
       def checker_name
-        @checker_name ||= self.class.name.split('::').last
+        @checker_name ||= self.class.checker_name
       end
 
       def table_or_model_name

data/lib/database_consistency/checkers/missing_index_checker.rb

@@ -11,13 +11,12 @@ module DatabaseConsistency
 
       # We skip check when:
       #  - association isn't a `HasOne` or `HasMany`
+      #  - association has `through` option
       def preconditions
-        [
-          ActiveRecord::Associations::HasOneAssociation,
-          ActiveRecord::Associations::HasOneThroughAssociation,
-          ActiveRecord::Associations::HasManyAssociation,
-          ActiveRecord::Associations::HasManyThroughAssociation
-        ].include?(association.association_class)
+        %i[
+          has_one
+          has_many
+        ].include?(association.macro) && association.through_reflection.nil?
       end
 
       # Table of possible statuses

data/lib/database_consistency/configuration.rb

@@ -9,7 +9,8 @@ module DatabaseConsistency
 
     def initialize(filepath = CONFIGURATION_PATH)
       @configuration = if filepath && File.exist?(filepath)
-                         YAML.load_file(filepath)
+                         data = YAML.load_file(filepath)
+                         data.is_a?(Hash) ? data : {}
                        else
                          {}
                        end

data/lib/database_consistency/processors/associations_processor.rb

@@ -13,9 +13,9 @@ module DatabaseConsistency
       def check
         Helper.models.flat_map do |model|
           model.reflect_on_all_associations.flat_map do |association|
-            CHECKERS.map do |checker_class|
+            enabled_checkers.map do |checker_class|
               checker = checker_class.new(model, association)
-              checker.report if checker.enabled?(configuration)
+              checker.report_if_enabled?(configuration)
             end
           end
         end.compact

data/lib/database_consistency/processors/base_processor.rb

@@ -27,6 +27,11 @@ module DatabaseConsistency
         @reports ||= check
       end
 
+      # @return [Array<Class>]
+      def enabled_checkers
+        self.class::CHECKERS.select { |checker| checker.enabled?(configuration) }
+      end
+
       private
 
       def check

data/lib/database_consistency/processors/columns_processor.rb

@@ -13,9 +13,9 @@ module DatabaseConsistency
       def check
         Helper.parent_models.flat_map do |model|
           model.columns.flat_map do |column|
-            CHECKERS.map do |checker_class|
+            enabled_checkers.map do |checker_class|
               checker = checker_class.new(model, column)
-              checker.report if checker.enabled?(configuration)
+              checker.report_if_enabled?(configuration)
             end
           end
         end.compact

data/lib/database_consistency/processors/validators_processor.rb

@@ -17,9 +17,9 @@ module DatabaseConsistency
         Helper.parent_models.flat_map do |model|
           model.validators.flat_map do |validator|
             validator.attributes.flat_map do |attribute|
-              CHECKERS.map do |checker_class|
+              enabled_checkers.map do |checker_class|
                 checker = checker_class.new(model, attribute, validator)
-                checker.report if checker.enabled?(configuration)
+                checker.report_if_enabled?(configuration)
               end
             end
           end

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '0.6.0'
+  VERSION = '0.6.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-19 00:00:00.000000000 Z
+date: 2019-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord