database_cleaner-active_record 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 997c59d22ce3ef9178c0b69c3d30b98d2e1126ddf099b5630bf0fbc272c76280
-  data.tar.gz: c8fc2baa15ceb2d6efb1b6b3a0890868dad0b5b51c78929b39564cc6e2be0c0f
+  metadata.gz: 85e54fe3fd85573506fd946df28f0ba19101ca6d854317ea38596e42d7d3e2c8
+  data.tar.gz: 746f002f2a5b7fe97b39550db8d5ac945cc9e7d0ae46a04aafd2001eb214a226
 SHA512:
-  metadata.gz: 6ddd99b203a2a712c8adbf01de42dbc751894ffe52f61cc540ebc116ceb9efc0ad8bb7cdeba08630d77b6754ac81fcad19adb1031d9c84bb4d7cbfcddd250675
-  data.tar.gz: fd9f66f85aa80d0247f9bbb753aad05d58b129723d36676ef09927091630a6e65025180dbb01fb7e9d31f4180933df5f98103c98ba71b0f4f2ff9ea639e31916
+  metadata.gz: e823f4e8874d3369dcbce8f3e626cacac42cca7270544a91afda9b8bda3927577c1c85e50d57bf3ec21bce8c7443c65a845c364e404c04a8b3983678cb2e3bfd
+  data.tar.gz: 538b0e24fc2ff9f1756defdac05ce7290e3c2d24bd42f3d6f59c0001364976a183b42fafba7c847c1113f31265889b79614ab00da4c793abcc12d85bea9d4070

data/.github/workflows/ci.yml

@@ -4,44 +4,51 @@ on: [push, pull_request]
 
 jobs:
   test:
-    name: 'Ruby: ${{ matrix.ruby }}, Rails: ${{ matrix.rails }}'
+    name: 'Ruby: ${{ matrix.ruby }}, Rails: ${{ matrix.rails }}, Channel: ${{ matrix.channel }}'
     runs-on: 'ubuntu-22.04'
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['3.2', '3.1', '3.0', '2.7', '2.6', '2.5']
-        rails: ['5.1', '5.2', '6.0', '6.1', '7.0', '7.1']
-        exclude:
-          - ruby: '3.2'
-            rails: '5.1'
-          - ruby: '3.2'
-            rails: '5.2'
+        ruby: ['3.3', '3.2', '3.1']
+        rails: ['6.1', '7.0', '7.1', '7.2']
+        channel: ['stable']
+
+        include:
+          - ruby: 'ruby-head'
+            rails: 'edge'
+            channel: 'experimental'
+          - ruby: 'ruby-head'
+            rails: '7.2'
+            channel: 'experimental'
+          - ruby: 'ruby-head'
+            rails: '7.1'
+            channel: 'experimental'
+
+          - ruby: '3.3'
+            rails: 'edge'
+            channel: 'experimental'
           - ruby: '3.2'
-            rails: '6.0'
+            rails: 'edge'
+            channel: 'experimental'
+          - ruby: '3.1'
+            rails: 'edge'
+            channel: 'experimental'
+
+        exclude:
+          - ruby: '3.3'
+            rails: '7.0' # TODO: works on 7-0-stable branch, remove after a 7.0.x patch release
+          - ruby: '3.3'
+            rails: '6.1'
+
           - ruby: '3.2'
             rails: '6.1'
-          - ruby: '3.1'
-            rails: '5.1'
-          - ruby: '3.1'
-            rails: '5.2'
-          - ruby: '3.1'
-            rails: '6.0'
-          - ruby: '3.0'
-            rails: '5.1'
-          - ruby: '3.0'
-            rails: '5.2'
-          - ruby: '2.6'
-            rails: '7.0'
-          - ruby: '2.5'
-            rails: '7.0'
-          - ruby: '2.5'
-            rails: '7.1'
-          - ruby: '2.6'
-            rails: '7.1'
+
+    continue-on-error: ${{ matrix.channel != 'stable' }}
+
     env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
       BUNDLE_GEMFILE: gemfiles/rails_${{ matrix.rails }}.gemfile
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby ${{ matrix.ruby }}
         uses: ruby/setup-ruby@v1
         with:

data/Appraisals

@@ -8,16 +8,28 @@ end
 
 appraise "rails-6.0" do
   gem "rails", "~> 6.0.0"
+  gem "sqlite3", "~> 1.5"
 end
 
 appraise "rails-6.1" do
   gem "rails", "~> 6.1.0"
+  gem "sqlite3", "~> 1.5"
 end
 
 appraise "rails-7.0" do
   gem "rails", "~> 7.0.0"
+  gem "sqlite3", "~> 1.7"
 end
 
 appraise "rails-7.1" do
   gem "rails", "~> 7.1.0"
+  gem "sqlite3", "~> 1.7" # FIXME: remove after rails/rails#51592
+end
+
+appraise "rails-7.2" do
+  gem "rails", "~> 7.2.0.beta2"
+end
+
+appraise "rails-edge" do
+  gem "rails", github: "rails/rails"
 end

data/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Development (unreleased)
 
+## v2.2.0 2024-07-12
+
+* Fix "ERROR:  currval of sequence" in Postgres adapter: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/103
+* Use lock synchronize on transaction callback: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/73
+* Stop testing with EOLed Ruby & Rails versions: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/105
+* Fix compatibility issue with Rails 7.2: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/107
+* Fix typo in truncation methods: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/94/files
+* Address deprecation of ActiveRecord::Base.connection in Rails 7.2: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/102
+* Support Rails 7.2+: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/101
+* Fix reset_ids test with Trilogy adapter: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/93
+* Implement resetting ids for deletion strategy: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/71
+* Avoid loading ActiveRecord::Base early: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/91
+* Fix specs to account for trilogy: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/88
+* Add basic support for trilogy: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/85
+
 ## v2.1.0 2023-02-17
 
 * Add Ruby 3.2 to CI matrix: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/79

data/README.md

@@ -8,7 +8,7 @@ Clean your ActiveRecord databases with Database Cleaner.
 
 See https://github.com/DatabaseCleaner/database_cleaner for more information.
 
-For support or to discuss development please use the [Google Group](https://groups.google.com/group/database_cleaner).
+For support or to discuss development please use GitHub Issues.
 
 ## Installation
 
@@ -61,6 +61,8 @@ DatabaseCleaner[:active_record].strategy = DatabaseCleaner::ActiveRecord::Deleti
 
 * `:cache_tables` - When set to `true` the list of tables to truncate or delete from will only be read from the DB once, otherwise it will be read before each cleanup run. Set this to `false` if (1) you create and drop tables in your tests, or (2) you change Postgres schemas (`ActiveRecord::Base.connection.schema_search_path`) in your tests (for example, in a multitenancy setup with each tenant in a different Postgres schema). Defaults to `true`.
 
+* `:reset_ids` - Only valid for deletion strategy, when set to `true` resets ids to 1 after each table is cleaned.
+
 ## Adapter configuration options
 
 `#db` defaults to the default ActiveRecord database, but can be specified manually in a few ways:
@@ -95,7 +97,7 @@ You can also add this parameter to your database.yml file:
 test:
   adapter: postgresql
   # ...
-  min_messages: WARNING  
+  min_messages: WARNING
 </pre>
 
 ## COPYRIGHT

data/database_cleaner-active_record.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "mysql2"
   spec.add_development_dependency "pg"
   spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "trilogy"
 end

data/gemfiles/rails_6.1.gemfile

@@ -4,17 +4,11 @@ source "https://rubygems.org"
 
 gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
 gem "rails", "~> 6.1.0"
+gem "sqlite3", "~> 1.5"
 
 group :test do
   gem "simplecov", require: false
   gem "codecov", require: false
 end
 
-if RUBY_VERSION >= '3.1'
-  gem 'net-smtp', require: false
-  gem 'net-imap', require: false
-  gem 'net-pop', require: false
-end
-
-
 gemspec path: "../"

data/gemfiles/rails_7.0.gemfile

@@ -4,6 +4,7 @@ source "https://rubygems.org"
 
 gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
 gem "rails", "~> 7.0.0"
+gem "sqlite3", "~> 1.7"
 
 group :test do
   gem "simplecov", require: false

data/gemfiles/rails_7.1.gemfile

@@ -3,7 +3,8 @@
 source "https://rubygems.org"
 
 gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
-gem "rails", github: 'rails/rails' # "~> 7.1.0"
+gem "rails", "~> 7.1.0"
+gem "sqlite3", "~> 1.7"
 
 group :test do
   gem "simplecov", require: false

data/gemfiles/{rails_5.1.gemfile → rails_7.2.gemfile}

@@ -3,7 +3,7 @@
 source "https://rubygems.org"
 
 gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
-gem "rails", "~> 5.1.0"
+gem "rails", "~> 7.2.0.beta2"
 
 group :test do
   gem "simplecov", require: false

data/gemfiles/{rails_5.2.gemfile → rails_edge.gemfile}

@@ -3,7 +3,7 @@
 source "https://rubygems.org"
 
 gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
-gem "rails", "~> 5.2.0"
+gem "rails", github: "rails/rails"
 
 group :test do
   gem "simplecov", require: false

data/lib/database_cleaner/active_record/base.rb

@@ -15,7 +15,9 @@ module DatabaseCleaner
 
     class Base < DatabaseCleaner::Strategy
       def self.migration_table_name
-        if Gem::Version.new("6.0.0") <= ::ActiveRecord.version
+        if ::ActiveRecord::Base.connection_pool.respond_to?(:schema_migration) # Rails >= 7.2
+          ::ActiveRecord::Base.connection_pool.schema_migration.table_name
+        elsif ::ActiveRecord::Base.connection.respond_to?(:schema_migration) # Rails >= 6.0
           ::ActiveRecord::Base.connection.schema_migration.table_name
         else
           ::ActiveRecord::SchemaMigration.table_name

data/lib/database_cleaner/active_record/deletion.rb

@@ -7,9 +7,9 @@ module DatabaseCleaner
       def clean
         connection.disable_referential_integrity do
           if pre_count? && connection.respond_to?(:pre_count_tables)
-            delete_tables(connection, connection.pre_count_tables(tables_to_truncate(connection)))
+            delete_tables(connection, connection.pre_count_tables(tables_to_clean(connection)))
           else
-            delete_tables(connection, tables_to_truncate(connection))
+            delete_tables(connection, tables_to_clean(connection))
           end
         end
       end
@@ -19,6 +19,7 @@ module DatabaseCleaner
       def delete_tables(connection, table_names)
         table_names.each do |table_name|
           delete_table(connection, table_name)
+          reset_id_sequence(connection, table_name) if @reset_ids
         end
       end
 
@@ -26,7 +27,20 @@ module DatabaseCleaner
         connection.execute("DELETE FROM #{connection.quote_table_name(table_name)} WHERE 1=1")
       end
 
-      def tables_to_truncate(connection)
+      def reset_id_sequence connection, table_name
+        case connection.adapter_name
+        when 'Mysql2', 'Trilogy'
+          connection.execute("ALTER TABLE #{table_name} AUTO_INCREMENT = 1;")
+        when 'SQLite'
+          connection.execute("delete from sqlite_sequence where name='#{table_name}';")
+        when 'PostgreSQL'
+          connection.reset_pk_sequence!(table_name)
+        else
+          raise "reset_id option not supported for #{connection.adapter_name}"
+        end
+      end
+
+      def tables_to_clean(connection)
         if information_schema_exists?(connection)
           @except += connection.database_cleaner_view_cache + migration_storage_names
           (@only.any? ? @only : tables_with_new_rows(connection)) - @except
@@ -64,7 +78,7 @@ module DatabaseCleaner
       end
 
       def information_schema_exists? connection
-        connection.adapter_name == "Mysql2"
+        ["Mysql2", "Trilogy"].include?(connection.adapter_name)
       end
     end
   end

data/lib/database_cleaner/active_record/transaction.rb

@@ -4,17 +4,25 @@ module DatabaseCleaner
   module ActiveRecord
     class Transaction < Base
       def start
+        connection = if ::ActiveRecord.version >= Gem::Version.new("7.2")
+          connection_class.lease_connection
+        else
+          connection_class.connection
+        end
+
         # Hack to make sure that the connection is properly set up before cleaning
-        connection_class.connection.transaction {}
+        connection.transaction {}
 
-        connection_class.connection.begin_transaction joinable: false
+        connection.begin_transaction joinable: false
       end
 
 
       def clean
         connection_class.connection_pool.connections.each do |connection|
-          next unless connection.open_transactions > 0
-          connection.rollback_transaction
+          connection.lock.synchronize do
+            next unless connection.open_transactions > 0
+            connection.rollback_transaction
+          end
         end
       end
     end

data/lib/database_cleaner/active_record/truncation.rb

@@ -1,18 +1,18 @@
 require "delegate"
-require 'active_record/base'
 require 'database_cleaner/active_record/base'
 
 module DatabaseCleaner
   module ActiveRecord
     class Truncation < Base
       def initialize(opts={})
-        if !opts.empty? && !(opts.keys - [:only, :except, :pre_count, :cache_tables]).empty?
-          raise ArgumentError, "The only valid options are :only, :except, :pre_count, and :cache_tables. You specified #{opts.keys.join(',')}."
+        if !opts.empty? && !(opts.keys - [:only, :except, :pre_count, :cache_tables, :reset_ids]).empty?
+          raise ArgumentError, "The only valid options are :only, :except, :pre_count, :reset_ids, and :cache_tables. You specified #{opts.keys.join(',')}."
         end
 
         @only = Array(opts[:only]).dup
         @except = Array(opts[:except]).dup
 
+        @reset_ids = opts[:reset_ids]
         @pre_count = opts[:pre_count]
         @cache_tables = opts.has_key?(:cache_tables) ? !!opts[:cache_tables] : true
       end
@@ -20,9 +20,9 @@ module DatabaseCleaner
       def clean
         connection.disable_referential_integrity do
           if pre_count? && connection.respond_to?(:pre_count_truncate_tables)
-            connection.pre_count_truncate_tables(tables_to_truncate(connection))
+            connection.pre_count_truncate_tables(tables_to_clean(connection))
           else
-            connection.truncate_tables(tables_to_truncate(connection))
+            connection.truncate_tables(tables_to_clean(connection))
           end
         end
       end
@@ -30,10 +30,16 @@ module DatabaseCleaner
       private
 
       def connection
-        @connection ||= ConnectionWrapper.new(connection_class.connection)
+        @connection ||= ConnectionWrapper.new(
+          if ::ActiveRecord.version >= Gem::Version.new("7.2")
+            connection_class.lease_connection
+          else
+            connection_class.connection
+          end
+        )
       end
 
-      def tables_to_truncate(connection)
+      def tables_to_clean(connection)
         if @only.none?
           all_tables = cache_tables? ? connection.database_cleaner_table_cache : connection.database_tables
           @only = all_tables.map { |table| table.split(".").last }
@@ -62,7 +68,7 @@ module DatabaseCleaner
       def initialize(connection)
         extend AbstractAdapter
         case connection.adapter_name
-        when "Mysql2"
+        when "Mysql2", "Trilogy"
           extend AbstractMysqlAdapter
         when "SQLite"
           extend AbstractMysqlAdapter
@@ -218,7 +224,7 @@ module DatabaseCleaner
         def has_been_used?(table)
           return has_rows?(table) unless has_sequence?(table)
 
-          cur_val = select_value("SELECT currval('#{table}_id_seq');").to_i rescue 0
+          cur_val = select_value("SELECT last_value from #{table}_id_seq;").to_i
           cur_val > 0
         end
 
@@ -246,4 +252,3 @@ module DatabaseCleaner
     private_constant :ConnectionWrapper
   end
 end
-

data/lib/database_cleaner/active_record/version.rb

@@ -1,5 +1,5 @@
 module DatabaseCleaner
   module ActiveRecord
-    VERSION = "2.1.0"
+    VERSION = "2.2.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: database_cleaner-active_record
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Ernesto Tagwerker
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-02-17 00:00:00.000000000 Z
+date: 2024-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: database_cleaner-core
@@ -137,6 +137,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: trilogy
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Strategies for cleaning databases using ActiveRecord. Can be used to
   ensure a clean state for testing.
 email:
@@ -148,7 +162,6 @@ files:
 - ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - Gemfile
@@ -159,12 +172,11 @@ files:
 - bin/setup
 - database_cleaner-active_record.gemspec
 - gemfiles/.bundle/config
-- gemfiles/rails_5.1.gemfile
-- gemfiles/rails_5.2.gemfile
-- gemfiles/rails_6.0.gemfile
 - gemfiles/rails_6.1.gemfile
 - gemfiles/rails_7.0.gemfile
 - gemfiles/rails_7.1.gemfile
+- gemfiles/rails_7.2.gemfile
+- gemfiles/rails_edge.gemfile
 - lib/database_cleaner-active_record.rb
 - lib/database_cleaner/active_record.rb
 - lib/database_cleaner/active_record/base.rb
@@ -192,7 +204,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.5.10
 signing_key:
 specification_version: 4
 summary: Strategies for cleaning databases using ActiveRecord. Can be used to ensure

data/.travis.yml

@@ -1,25 +0,0 @@
-language: ruby
-services:
-  - mysql
-  - postgresql
-rvm:
-  - 2.5
-  - 2.6
-  - 2.7
-  - 3.0
-gemfile:
-  - gemfiles/rails_5.1.gemfile
-  - gemfiles/rails_5.2.gemfile
-  - gemfiles/rails_6.0.gemfile
-  - gemfiles/rails_6.1.gemfile
-jobs:
-  exclude: # Unsupported combos: https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html
-  - rvm: 3.0
-    gemfile: gemfiles/rails_5.1.gemfile
-  - rvm: 3.0
-    gemfile: gemfiles/rails_5.2.gemfile
-
-before_install:
-  - bin/setup
-cache:
-  bundler: true

data/gemfiles/rails_6.0.gemfile

@@ -1,13 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
-gem "rails", "~> 6.0.0"
-
-group :test do
-  gem "simplecov", require: false
-  gem "codecov", require: false
-end
-
-gemspec path: "../"