data_sanity 0.0.3 → 0.0.5

data/lib/data_sanity/inspector.rb

@@ -1,34 +1,54 @@
 module DataSanity
   class Inspector
 
+    CONSIDERED_RECORDS = 1
     ALLOWED_VALIDATION = [:all, :random]
-
-    attr_accessor :all, :random, :models
+    attr_accessor :all, :random, :models, :records_per_model
 
     def initialize options = {}
       options[:validate] == :random ? @random = true : @all = true
+      @records_per_model = options[:records_per_model] || CONSIDERED_RECORDS
       @models = load_models
     end
 
     def investigate
       @models.each do |model_string|
         model = model_string.constantize
-        model.all.each do |instance|
-          unless instance.valid?
-            DataInspector.create(:table_name => model_string,
-                                 :table_primary_key => model.primary_key,
-                                 :primary_key_value => instance.send(model.primary_key),
-                                 :validation_errors => instance.errors.full_messages.to_yaml)
-          end
-        end
+        validate_all(model) if @all
+        validate_random(model) if @random
       end
     end
 
     private
 
+    def validate_all(model)
+      model.all.each do |instance|
+        populate_if_invalid_record(instance, model)
+      end
+    end
+
+    def validate_random(model)
+      no_of_records = model.count
+      @records_per_model.times do
+        instance = model.first(:limit => 1, :offset => rand(no_of_records))
+        populate_if_invalid_record(instance, model)
+      end
+    end
+
+    def populate_if_invalid_record(instance, model)
+      DataInspector.create(:table_name => model.to_s,
+                           :table_primary_key => model.primary_key,
+                           :primary_key_value => instance.send(model.primary_key),
+                           :validation_errors => instance.errors.full_messages.to_yaml) unless instance.valid?
+
+    end
+
     def load_models
       Dir["#{Rails.root}/app/models/**/*.rb"].each { |file_path| require file_path rescue nil }
-      ActiveRecord::Base.descendants.select(&:descends_from_active_record?).collect(&:name)
+      all_models = ActiveRecord::Base.descendants.select(&:descends_from_active_record?)
+      all_models.delete(DataInspector)
+      all_models.collect(&:name)
     end
+
   end
 end

data/lib/data_sanity/models/data_inspector.rb

@@ -0,0 +1,4 @@
+require 'active_record'
+
+class DataInspector < ActiveRecord::Base
+end

data/lib/data_sanity/tasks.rb

@@ -3,14 +3,16 @@ namespace :db do
     desc 'Create data inspector model for data sanity results'
     task :migrate => :environment do
       Dir.chdir("#{Rails.root}") do
-        system "rails g model DataInspector table_name:string table_primary_key:string primary_key_value:string validation_errors:text"
+        system "rails g migration create_data_inspector"
+        system "rails g migration add_columns_to_data_inspector table_name:string table_primary_key:string primary_key_value:string validation_errors:text"
       end
     end
 
     desc 'Destroy data inspector model for data sanity results'
     task :rollback do
       Dir.chdir("#{Rails.root}") do
-        system "rails destroy model DataInspector"
+        system "rails destroy migration add_columns_to_data_inspector"
+        system "rails destroy migration create_data_inspector"
       end
     end
   end

data/lib/data_sanity/version.rb

@@ -1,3 +1,3 @@
 module DataSanity
-  VERSION = "0.0.3"
+  VERSION = "0.0.5"
 end

data/lib/data_sanity.rb

@@ -2,4 +2,5 @@ require "rails"
 
 require File.dirname(__FILE__) + "/data_sanity/inspector"
 require File.dirname(__FILE__) + "/data_sanity/railtie"
+require File.dirname(__FILE__) + "/data_sanity/models/data_inspector"
 require File.dirname(__FILE__) + "/data_sanity/version"

data/spec/data_sanity/inspector_spec.rb

@@ -9,6 +9,20 @@ describe "DataSanity::Inspector" do
       inspector.all.should be_true
       inspector.models.should == ["Person"]
     end
+
+    it "should set random switch, populate default records_per_model and populate all models of the applications" do
+      inspector = DataSanity::Inspector.new :validate => :random
+      inspector.random.should be_true
+      inspector.records_per_model.should == 1
+      inspector.models.should == ["Person"]
+    end
+
+    it "should set random switch, populate records_per_model and populate all models of the applications" do
+      inspector = DataSanity::Inspector.new :validate => :random, :records_per_model => 5
+      inspector.random.should be_true
+      inspector.records_per_model.should == 5
+      inspector.models.should == ["Person"]
+    end
   end
 
   describe "investigate" do
@@ -22,21 +36,38 @@ describe "DataSanity::Inspector" do
       DataInspector.count.should == 0
     end
 
-    it "should check for errors on the model and populate fields in DataInspector" do
-      inspector = DataSanity::Inspector.new
+    describe "all" do
 
-      Person.new(:name => "Valid-Record", :age => 20).save(:validate => false)
-      Person.new(:age => 1).save(:validate => false)
+      it "should check for errors on the model and populate fields in DataInspector" do
+        inspector = DataSanity::Inspector.new
 
-      inspector.investigate
-      DataInspector.count.should == 1
-
-      first_person = Person.find_by_age(1)
-      first_person.valid?
-      DataInspector.first.table_name.should == "Person"
-      DataInspector.first.table_primary_key.should == "id"
-      DataInspector.first.primary_key_value.should == first_person.id.to_s
-      YAML.load(DataInspector.first.validation_errors).should == first_person.errors.full_messages
+        Person.new(:name => "Valid-Record", :age => 20).save(:validate => false)
+        Person.new(:age => 1).save(:validate => false)
+
+        inspector.investigate
+        DataInspector.count.should == 1
+
+        first_person = Person.find_by_age(1)
+        first_person.valid?
+        DataInspector.first.table_name.should == "Person"
+        DataInspector.first.table_primary_key.should == "id"
+        DataInspector.first.primary_key_value.should == first_person.id.to_s
+        YAML.load(DataInspector.first.validation_errors).should == first_person.errors.full_messages
+      end
+    end
+
+    describe "random" do
+      it "should check for errors on the model and populate fields in DataInspector" do
+        inspector = DataSanity::Inspector.new(:validate => :random, :records_per_model => 2)
+
+        Person.new(:name => "Valid-Record").save(:validate => false)
+        Person.new(:name => "UnderAge", :age => 1).save(:validate => false)
+        Person.new(:age => 20).save(:validate => false)
+        Person.new(:age => 1).save(:validate => false)
+
+        inspector.investigate
+        DataInspector.count.should == 2
+      end
     end
 
     after :each do

data/spec/data_sanity/models/data_inspector_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+
+describe "DataInspector" do
+
+
+end

data/spec/support/helper.rb

@@ -17,5 +17,4 @@ def setup_data_inspector
     system "rake db:data_sanity:migrate"
     system "rake db:migrate"
   end
-  require "#{Rails.root}/app/models/data_inspector"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: data_sanity
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 21
   prerelease: 
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 5
+  version: 0.0.5
 platform: ruby
 authors: 
 - Habibullah, Rahul, Jigyasa, Jyotsna, Hephzibah, Garima
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-12-01 00:00:00 Z
+date: 2011-12-02 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   type: :runtime
@@ -79,10 +79,12 @@ files:
 - data_sanity.gemspec
 - lib/data_sanity.rb
 - lib/data_sanity/inspector.rb
+- lib/data_sanity/models/data_inspector.rb
 - lib/data_sanity/railtie.rb
 - lib/data_sanity/tasks.rb
 - lib/data_sanity/version.rb
 - spec/data_sanity/inspector_spec.rb
+- spec/data_sanity/models/data_inspector_spec.rb
 - spec/spec_helper.rb
 - spec/support/helper.rb
 - spec/support/sample_app/.gitignore
@@ -167,6 +169,7 @@ specification_version: 3
 summary: Gem for checking data sanity
 test_files: 
 - spec/data_sanity/inspector_spec.rb
+- spec/data_sanity/models/data_inspector_spec.rb
 - spec/spec_helper.rb
 - spec/support/helper.rb
 - spec/support/sample_app/.gitignore