data_miner 1.2.5 → 1.3.0

data/lib/data_miner/config.rb

@@ -42,11 +42,6 @@ class DataMiner
       steps.push step
     end
 
-    def verify(description = '(no description)', &blk)
-      step = Verify.new self, description, &blk
-      steps.push step
-    end
-
     # Mine data for this class.
     def run(options = {})
       options = options.dup

data/lib/data_miner/version.rb

@@ -1,3 +1,3 @@
 class DataMiner
-  VERSION = '1.2.5'
+  VERSION = '1.3.0'
 end

data/lib/data_miner.rb

@@ -25,7 +25,6 @@ class DataMiner
   autoload :Tap, 'data_miner/tap'
   autoload :Process, 'data_miner/process'
   autoload :Run, 'data_miner/run'
-  autoload :Verify, 'data_miner/verify'
   
   class << self
     delegate :logger, :to => :instance

data/test/support/aircraft.rb

@@ -96,10 +96,6 @@ class Aircraft < ActiveRecord::Base
         key   'bts_aircraft_type_code', :field_name => 'bts_aircraft_type'
         store 'brighter_planet_aircraft_class_code', :nullify => true
       end
-
-      verify 'all aircraft have a manufcaturer name specified' do
-        assert Aircraft.scoped.where(:manufacturer_name => nil).empty?
-      end
     end
   end
 end

data/test/test_old_syntax.rb

@@ -900,16 +900,4 @@ class TestOldSyntax < Test::Unit::TestCase
       assert ResidentialEnergyConsumptionSurveyResponse.find(6).residence_class.start_with?('Single-family detached house')
     end
   end
-  should "mark the run as skipped if verification fails" do
-    AutomobileFuelType.data_miner_config.instance_eval do
-      verify "failure" do
-        false
-      end
-    end
-
-    DataMiner::Run.delete_all
-    assert_raise do
-      AutomobileFuelType.run_data_miner! :from_scratch => true
-    end
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: data_miner
 version: !ruby/object:Gem::Version
-  version: 1.2.5
+  version: 1.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -15,7 +15,7 @@ date: 2011-09-22 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: remote_table
-  requirement: &2154408300 !ruby/object:Gem::Requirement
+  requirement: &2166686740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -23,10 +23,10 @@ dependencies:
         version: 1.2.2
   type: :runtime
   prerelease: false
-  version_requirements: *2154408300
+  version_requirements: *2166686740
 - !ruby/object:Gem::Dependency
   name: escape
-  requirement: &2154407800 !ruby/object:Gem::Requirement
+  requirement: &2166719520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -34,10 +34,10 @@ dependencies:
         version: 0.0.4
   type: :runtime
   prerelease: false
-  version_requirements: *2154407800
+  version_requirements: *2166719520
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &2154407340 !ruby/object:Gem::Requirement
+  requirement: &2166719060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -45,10 +45,10 @@ dependencies:
         version: 2.3.4
   type: :runtime
   prerelease: false
-  version_requirements: *2154407340
+  version_requirements: *2166719060
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2154406880 !ruby/object:Gem::Requirement
+  requirement: &2166718600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -56,10 +56,10 @@ dependencies:
         version: 2.3.4
   type: :runtime
   prerelease: false
-  version_requirements: *2154406880
+  version_requirements: *2166718600
 - !ruby/object:Gem::Dependency
   name: conversions
-  requirement: &2154406420 !ruby/object:Gem::Requirement
+  requirement: &2166718140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -67,10 +67,10 @@ dependencies:
         version: 1.4.4
   type: :runtime
   prerelease: false
-  version_requirements: *2154406420
+  version_requirements: *2166718140
 - !ruby/object:Gem::Dependency
   name: blockenspiel
-  requirement: &2154405960 !ruby/object:Gem::Requirement
+  requirement: &2166717680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -78,10 +78,10 @@ dependencies:
         version: 0.3.2
   type: :runtime
   prerelease: false
-  version_requirements: *2154405960
+  version_requirements: *2166717680
 - !ruby/object:Gem::Dependency
   name: taps
-  requirement: &2154405500 !ruby/object:Gem::Requirement
+  requirement: &2166717220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -89,10 +89,10 @@ dependencies:
         version: 0.3.11
   type: :runtime
   prerelease: false
-  version_requirements: *2154405500
+  version_requirements: *2166717220
 - !ruby/object:Gem::Dependency
   name: errata
-  requirement: &2164269740 !ruby/object:Gem::Requirement
+  requirement: &2166716760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -100,10 +100,10 @@ dependencies:
         version: 1.0.1
   type: :runtime
   prerelease: false
-  version_requirements: *2164269740
+  version_requirements: *2166716760
 - !ruby/object:Gem::Dependency
   name: force_schema
-  requirement: &2164269280 !ruby/object:Gem::Requirement
+  requirement: &2166716300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -111,10 +111,10 @@ dependencies:
         version: 0.0.2
   type: :development
   prerelease: false
-  version_requirements: *2164269280
+  version_requirements: *2166716300
 - !ruby/object:Gem::Dependency
   name: loose_tight_dictionary
-  requirement: &2164268820 !ruby/object:Gem::Requirement
+  requirement: &2166715840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -122,10 +122,10 @@ dependencies:
         version: 0.0.5
   type: :development
   prerelease: false
-  version_requirements: *2164268820
+  version_requirements: *2166715840
 - !ruby/object:Gem::Dependency
   name: test-unit
-  requirement: &2164268440 !ruby/object:Gem::Requirement
+  requirement: &2166715460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -133,10 +133,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2164268440
+  version_requirements: *2166715460
 - !ruby/object:Gem::Dependency
   name: shoulda
-  requirement: &2164267980 !ruby/object:Gem::Requirement
+  requirement: &2166715000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -144,10 +144,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2164267980
+  version_requirements: *2166715000
 - !ruby/object:Gem::Dependency
   name: mysql
-  requirement: &2164267560 !ruby/object:Gem::Requirement
+  requirement: &2166714580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -155,10 +155,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2164267560
+  version_requirements: *2166714580
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2164267140 !ruby/object:Gem::Requirement
+  requirement: &2166714160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -166,7 +166,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2164267140
+  version_requirements: *2166714160
 description: Mine remote data into your ActiveRecord models. You can also convert
   units.
 email:
@@ -192,7 +192,6 @@ files:
 - lib/data_miner/process.rb
 - lib/data_miner/run.rb
 - lib/data_miner/tap.rb
-- lib/data_miner/verify.rb
 - lib/data_miner/version.rb
 - test/helper.rb
 - test/support/aircraft.rb
@@ -203,7 +202,6 @@ files:
 - test/support/test_database.rb
 - test/test_data_miner_attribute.rb
 - test/test_data_miner_process.rb
-- test/test_data_miner_verify.rb
 - test/test_old_syntax.rb
 homepage: https://github.com/seamusabshere/data_miner
 licenses: []
@@ -239,5 +237,4 @@ test_files:
 - test/support/test_database.rb
 - test/test_data_miner_attribute.rb
 - test/test_data_miner_process.rb
-- test/test_data_miner_verify.rb
 - test/test_old_syntax.rb

data/lib/data_miner/verify.rb

@@ -1,28 +0,0 @@
-class DataMiner
-  class Verify
-    attr_reader :config
-    attr_reader :description
-    attr_reader :blk
-    
-    def initialize(config, description, &blk)
-      @config = config
-      @description = description
-      @blk = blk
-    end
-    
-    def resource
-      config.resource
-    end
-
-    def inspect
-      %{#<DataMiner::Verify(#{resource}) #{description}>}
-    end
-
-    def run
-      unless blk.call
-        raise "FAILED VERIFICATION: #{inspect}"
-      end
-      nil
-    end
-  end
-end

data/test/test_data_miner_verify.rb

@@ -1,21 +0,0 @@
-require File.expand_path('helper', File.dirname(__FILE__))
-
-class TestDataMinerVerify < Test::Unit::TestCase
-  context '#run' do
-    should 'raise an exception if the verification block fails through exception' do
-      raising_check = lambda { raise "boom" }
-      verify = DataMiner::Verify.new Aircraft.data_miner_config, 'verification of engine type', &raising_check
-      assert_raise(::RuntimeError) { verify.run }
-    end
-    should 'raise an exception if the result of the verification block is false' do
-      failing_check = lambda { false }
-      verify = DataMiner::Verify.new Aircraft.data_miner_config, 'verification of engine type', &failing_check
-      assert_raise(::RuntimeError) { verify.run }
-    end
-    should 'return true if the verification block succeeds' do
-      passing_check = lambda { true }
-      verify = DataMiner::Verify.new Aircraft.data_miner_config, 'verification of engine type', &passing_check
-      assert_nil verify.run
-    end
-  end
-end