data_migrate 8.4.2 → 8.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7cc2467bde93f842786d6a5bb5077e8a1ef595a80e5868a03ae960552a232faa
-  data.tar.gz: 452420d3616deaaa6776511bb6cabbe765f92106d19e67b017fafb717ca0d760
+  metadata.gz: c0ed214d2b242e9802276616e52abc79dc40081b413f6c38cdcbc5414d5897e9
+  data.tar.gz: f4045cba836825fa34a0da775d38999ea472f2fb8624537e8ffc216f01204e85
 SHA512:
-  metadata.gz: aa097fbb8c8560e888984965d6ce10e9b09fcda1031c18aeccbe9e25b46db7baa3c9821e9ea18468a2df24aba7cb94412fc3fb15aa88e2a110f71018697db323
-  data.tar.gz: f9f1bc42960a703223edd39c22285e6dfa0c541bf723152992da61b24a689c1b90e30dee0d2902b15a489d1606b681eb03b4b6d6723fccf932745b20d8f71f72
+  metadata.gz: c98becc1b27f1afc98a8e45c4c81ea35195a992f2ff7433d8891b542cc05063dde7ffd1655ba521e14e700e477acc23345b15a893e2a900c508fc0b72c69302c
+  data.tar.gz: 04560cc96cf6696b032b7a9d6892d70b772801b62910899ea2c360d7a17b98e8ab58bcd535e9a1fbdd40aa07c8633e92f5f52db8f9a6340c00788919eb5acf5b

data/.github/workflows/gempush.yml

@@ -3,7 +3,7 @@ name: Ruby Gem
 on:
   push:
     branches:
-      - master
+      - main
 
 jobs:
   build:

data/Changelog.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 8.5.0
+
+Allow custom templates [bazay](https://github.com/bazay)
+
 ## 8.4.0
 
 Avoid Globally Accessible Functions for All Rake Tasks [berniechiu](https://github.com/berniechiu)

data/README.md

@@ -108,6 +108,7 @@ You can override this setting in `config/initializers/data_migrate.rb`
 ```ruby
 DataMigrate.configure do |config|
   config.data_migrations_path = 'db/awesomepath/'
+  config.data_template_path = Rails.root.join("lib", "awesomepath", "custom_data_migration.rb")
   config.db_configuration = {
     'host' => '127.0.0.1',
     'database' => 'awesome_database',

data/lib/data_migrate/config.rb

@@ -12,12 +12,21 @@ module DataMigrate
   end
 
   class Config
-    attr_accessor :data_migrations_path, :db_configuration, :spec_name
+    attr_accessor :data_migrations_path, :data_template_path, :db_configuration, :spec_name
+
+    DEFAULT_DATA_TEMPLATE_PATH = "data_migration.rb"
 
     def initialize
       @data_migrations_path = "db/data/"
+      @data_template_path = DEFAULT_DATA_TEMPLATE_PATH
       @db_configuration = nil
       @spec_name = nil
     end
+
+    def data_template_path=(value)
+      @data_template_path = value.tap do |path|
+        raise ArgumentError, "File not found: '#{path}'" unless path == DEFAULT_DATA_TEMPLATE_PATH || File.exists?(path)
+      end
+    end
   end
 end

data/lib/data_migrate/version.rb

@@ -1,3 +1,3 @@
 module DataMigrate
-  VERSION = "8.4.2".freeze
+  VERSION = "8.5.0".freeze
 end

data/lib/data_migrate.rb

@@ -19,4 +19,7 @@ else
 end
 
 module DataMigrate
+  def self.root
+    File.dirname(__FILE__)
+  end
 end

data/lib/generators/data_migrate.rb

@@ -1,9 +1,22 @@
 require 'rails/generators/named_base'
+
 module DataMigrate
   module Generators
     class DataMigrationGenerator < Rails::Generators::NamedBase #:nodoc:
-      def self.source_root
-         @_data_migrate_source_root ||= File.expand_path(File.join(File.dirname(__FILE__), generator_name, 'templates'))
+      class << self
+        def source_root
+          build_data_migrate_source_root
+        end
+
+        private
+
+        def build_data_migrate_source_root
+          if DataMigrate.config.data_template_path == DataMigrate::Config::DEFAULT_DATA_TEMPLATE_PATH
+            File.expand_path(File.join(File.dirname(__FILE__), generator_name, 'templates'))
+          else
+            File.expand_path(File.dirname(DataMigrate.config.data_template_path))
+          end
+        end
       end
     end
   end

data/lib/generators/data_migration/data_migration_generator.rb

@@ -14,7 +14,7 @@ module DataMigrate
 
       def create_data_migration
         set_local_assigns!
-        migration_template "data_migration.rb", data_migrations_file_path
+        migration_template template_path, data_migrations_file_path
       end
 
       protected
@@ -26,6 +26,10 @@ module DataMigrate
         end
       end
 
+      def template_path
+        DataMigrate.config.data_template_path
+      end
+
       def migration_base_class_name
         "ActiveRecord::Migration[#{ActiveRecord::Migration.current_version}]"
       end

data/spec/data_migrate/config_spec.rb

@@ -1,12 +1,16 @@
 require "spec_helper"
 
 describe DataMigrate::Config do
-
   it "sets default data_migrations_path path", :no_override do
     expect(DataMigrate.config.data_migrations_path).to eq "db/data/"
   end
 
+  it "sets default data_template_path path", :no_override do
+    expect(DataMigrate.config.data_template_path).to eq DataMigrate::Config::DEFAULT_DATA_TEMPLATE_PATH
+  end
+
   describe "data migration path configured" do
+    subject { DataMigrate.config.data_migrations_path }
     before do
       @before = DataMigrate.config.data_migrations_path
       DataMigrate.configure do |config|
@@ -20,8 +24,43 @@ describe DataMigrate::Config do
       end
     end
 
-    it do
-      expect(DataMigrate.config.data_migrations_path).to eq "db/awesome/"
+    it "equals the custom data migration path" do
+      is_expected.to eq "db/awesome/"
+    end
+  end
+
+  describe "data template path configured" do
+    subject { DataMigrate.config.data_template_path }
+
+    before do
+      @before = DataMigrate.config.data_template_path
+      DataMigrate.configure do |config|
+        config.data_template_path = data_template_path
+      end
+    end
+
+    let(:data_template_path) do
+      File.join(DataMigrate.root, "generators", "data_migration", "templates", "data_migration.rb")
+    end
+
+    after do
+      DataMigrate.configure do |config|
+        config.data_template_path = @before
+      end
+    end
+
+    it "equals the custom data template path" do
+      is_expected.to eq data_template_path
+    end
+
+    context "when path does not exist" do
+      subject { DataMigrate.config.data_template_path = invalid_path }
+
+      let(:invalid_path) { "lib/awesome/templates/data_migration.rb" }
+
+      it "checks that file exists on setting config var" do
+        expect { subject }.to raise_error { ArgumentError.new("File not found: '#{data_template_path}'") }
+      end
     end
   end
 end

data/spec/generators/data_migration/data_migration_generator_spec.rb

@@ -4,7 +4,8 @@ require 'rails/generators/migration'
 require 'generators/data_migration/data_migration_generator'
 
 describe DataMigrate::Generators::DataMigrationGenerator do
-  let(:subject) { DataMigrate::Generators::DataMigrationGenerator }
+  subject { DataMigrate::Generators::DataMigrationGenerator }
+
   describe :next_migration_number do
     it "next migration" do
       Timecop.freeze("2016-12-03 22:15:26 -0800") do
@@ -19,14 +20,18 @@ describe DataMigrate::Generators::DataMigrationGenerator do
   end
 
   describe :migration_base_class_name do
-    let(:subject) { DataMigrate::Generators::DataMigrationGenerator.new(['my_migration']) }
+    subject { generator.send(:migration_base_class_name) }
+
+    let(:generator) { DataMigrate::Generators::DataMigrationGenerator.new(['my_migration']) }
+
     it "returns the correct base class name" do
-      expect(subject.send(:migration_base_class_name)).to eq("ActiveRecord::Migration[#{ActiveRecord::Migration.current_version}]")
+      is_expected.to eq("ActiveRecord::Migration[#{ActiveRecord::Migration.current_version}]")
     end
   end
 
   describe :create_data_migration do
-    let(:subject) { DataMigrate::Generators::DataMigrationGenerator.new(['my_migration']) }
+    subject { DataMigrate::Generators::DataMigrationGenerator.new(['my_migration']) }
+
     let(:data_migrations_file_path) { 'abc/my_migration.rb' }
 
     context 'when custom data migrations path has a trailing slash' do
@@ -35,7 +40,7 @@ describe DataMigrate::Generators::DataMigrationGenerator do
       end
 
       it 'returns correct file path' do
-        expect(subject).to receive(:migration_template).with(
+        is_expected.to receive(:migration_template).with(
           'data_migration.rb', data_migrations_file_path
         )
 
@@ -49,7 +54,7 @@ describe DataMigrate::Generators::DataMigrationGenerator do
       end
 
       it 'returns correct file path' do
-        expect(subject).to receive(:migration_template).with(
+        is_expected.to receive(:migration_template).with(
           'data_migration.rb', data_migrations_file_path
         )
 
@@ -57,4 +62,40 @@ describe DataMigrate::Generators::DataMigrationGenerator do
       end
     end
   end
+
+  describe ".source_root" do
+    subject { described_class.source_root }
+
+    let(:default_source_root) do
+      File.expand_path(
+        File.dirname(File.join(DataMigrate.root, "generators", "data_migration", "templates", "data_migration.rb"))
+      )
+    end
+
+    it { is_expected.to eq default_source_root }
+
+    context "when DateMigrate.config.data_template_path is set" do
+      before do
+        @before = DataMigrate.config.data_template_path
+        DataMigrate.configure do |config|
+          config.data_template_path = data_template_path
+        end
+      end
+
+      let(:data_template_path) do
+        File.join(DataMigrate.root, "generators", "data_migration", "templates", "data_migration.rb")
+      end
+      let(:expected_source_root) { File.dirname(data_template_path) }
+
+      after do
+        DataMigrate.configure do |config|
+          config.data_template_path = @before
+        end
+      end
+
+      it "reads directory from config data template path" do
+        is_expected.to eq expected_source_root
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: data_migrate
 version: !ruby/object:Gem::Version
-  version: 8.4.2
+  version: 8.5.0
 platform: ruby
 authors:
 - Andrew J Vargo
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-14 00:00:00.000000000 Z
+date: 2023-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord