data_migrate 1.2.0 → 2.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 23e116644d7dd0d7284d7b947531ba6c458dc1eb
+  data.tar.gz: 6122e7766a889e121f3089b9f34e9971e240bdcf
+SHA512:
+  metadata.gz: 6596304649605db5edeaf00d0a15f9d2e9c1259c3aed3e0c45f9a76e0414a9c6e5282904a42863573455e12abe3da46afeb8fdccaeef3aa97309a59d8f199412
+  data.tar.gz: a0c1d3c00a95216f872cacfa8662263816a5261e6e5624802b054cd28f40a473e47a3f8af955ae3731a2c7f0b86bffba736a4a4ef0e921cf9fba37c83dc2051e

data/README.md

@@ -68,10 +68,23 @@ schema and data migrations in the proper order.
 
 Note: If a data and schema migration share the same version number, schema gets precedence when migrating up. Data does down.
 
-Rails 3 and Ruby 1.9
+Rails Support
 --------------------
 
-Data Migrate is Rails 3 and Ruby 1.9 compatible.
+Rails 3.1: Version 1.2 supports Rails 3.1.0 and higher **but** is not longer maintained.
+
+Rails 4: Version 2.0 supports Rails 4.0 and higher
+
+Rails 5: Not tested
+
+### Important note
+
+If you upgraded to Rails 4 while using `data_migrate` prior to version 2,
+the gem wrote data migration versions into
+`schema_migrations` table. After the fix, it was corrected to write into
+`data_migrations`.
+
+This may cause some unintended consequences. See [#22](https://github.com/ilyakatz/data-migrate/issues/22)
 
 Installation
 ------------
@@ -106,7 +119,6 @@ If you need a data only migration, either run it as such, with the skip-schema-m
 
     rails g data_migration add_this_to_that --skip-schema-migration
 
-
 ### Rake Tasks
 
     $> rake -T data
@@ -144,5 +156,8 @@ Going down instead of up would be the opposite.
 
 Thanks
 ------
+[Andrew J Vargo](http://github.com/ajvargo) Andrew was the original creator and maintainer of this project!
+
 [Jeremy Durham](http://jeremydurham.com/) for fleshing out the idea with me, and providing guidance.
+
 You!  Yes, you. Thanks for checking it out.

data/data_migrate.gemspec

@@ -6,15 +6,16 @@ Gem::Specification.new do |s|
   s.name        = "data_migrate"
   s.version     = DataMigrate::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.authors     = ["Andrew J Vargo"]
-  s.email       = ["ajvargo@computer.org"]
+  s.authors     = ["Andrew J Vargo", "Ilya Katz"]
+  s.email       = ["ajvargo@computer.org", "ilyakatz@gmail.com"]
   s.homepage    = "http://ajvargo.com"
   s.summary     = %q{Rake tasks to migrate data alongside schema changes.}
   s.description = %q{Rake tasks to migrate data alongside schema changes.}
+  s.license     = "MIT"
 
   s.rubyforge_project = "data_migrate"
 
-  s.add_dependency('rails', '>= 3.0.0')
+  s.add_dependency('rails', '>= 4.0')
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

data/lib/data_migrate.rb

@@ -1,2 +1,4 @@
 require File.join(File.dirname(__FILE__), 'data_migrate', 'data_migrator')
+require File.join(File.dirname(__FILE__), 'data_migrate', 'data_schema_migration')
+require File.join(File.dirname(__FILE__), 'data_migrate', 'migration')
 require File.join(File.dirname(__FILE__), 'data_migrate', 'railtie')

data/lib/data_migrate/data_migrator.rb

@@ -1,8 +1,37 @@
 require 'active_record'
 
 module DataMigrate
+
   class DataMigrator < ActiveRecord::Migrator
+
+    def record_version_state_after_migrating(version)
+      if down?
+        migrated.delete(version)
+        DataMigrate::DataSchemaMigration.where(:version => version.to_s).delete_all
+      else
+        migrated << version
+        DataMigrate::DataSchemaMigration.create!(:version => version.to_s)
+      end
+    end
+
     class << self
+      def get_all_versions(connection = ActiveRecord::Base.connection)
+        if connection.table_exists?(schema_migrations_table_name)
+          # Certain versions of the gem wrote data migration versions into
+          # schema_migrations table. After the fix, it was corrected to write into
+          # data_migrations. However, not to break anything we are going to
+          # get versions from both tables.
+          #
+          # This may cause some problems:
+          # Eg. rake data:versions will show version from the schema_migrations table
+          # which may be a version of actual schema migration and not data migration
+          DataMigrate::DataSchemaMigration.all.map { |x| x.version.to_i }.sort +
+            ActiveRecord::SchemaMigration.all.map { |x| x.version.to_i }.sort
+        else
+          []
+        end
+      end
+
       def schema_migrations_table_name
         ActiveRecord::Base.table_name_prefix + 'data_migrations' + ActiveRecord::Base.table_name_suffix
       end

data/lib/data_migrate/data_schema_migration.rb

@@ -0,0 +1,14 @@
+module DataMigrate
+  class DataSchemaMigration < ::ActiveRecord::SchemaMigration
+    class << self
+      def table_name
+        ActiveRecord::Base.table_name_prefix + 'data_migrations' + ActiveRecord::Base.table_name_suffix
+      end
+
+      def index_name
+        "#{table_name_prefix}unique_data_migrations#{table_name_suffix}"
+      end
+    end
+  end
+end
+

data/lib/data_migrate/migration.rb

@@ -0,0 +1,28 @@
+module DataMigrate
+  class Migration < ::ActiveRecord::Migration
+
+    class << self
+      def check_pending!(connection = ::ActiveRecord::Base.connection)
+        binding.pry
+        raise ActiveRecord::PendingMigrationError if DataMigrator::Migrator.needs_migration?(connection)
+      end
+
+      def migrate(direction)
+        new.migrate direction
+      end
+
+      def table_name
+        binding.pry
+        ActiveRecord::Base.table_name_prefix + 'data_migrations' + ActiveRecord::Base.table_name_suffix
+      end
+
+      def index_name
+        "#{table_name_prefix}unique_data_migrations#{table_name_suffix}"
+      end
+    end
+
+    def initialize(name = self.class.name, version = nil)
+      super(name, version)
+    end
+  end
+end

data/lib/data_migrate/version.rb

@@ -1,3 +1,3 @@
 module DataMigrate
-  VERSION = "1.2.0"
+  VERSION = "2.0.0"
 end

data/lib/generators/data_migration/templates/data_migration.rb

@@ -3,6 +3,6 @@ class <%= migration_class_name %> < ActiveRecord::Migration
   end
 
   def self.down
-    raise IrreversibleMigration
+    raise ActiveRecord::IrreversibleMigration
   end
 end

data/tasks/databases.rake

@@ -217,7 +217,7 @@ namespace :data do
   desc 'Migrate data migrations (options: VERSION=x, VERBOSE=false)'
   task :migrate => :environment do
     assure_data_schema_table
-    ActiveRecord::Migration.verbose = ENV["VERBOSE"] ? ENV["VERBOSE"] == "true" : true
+    #ActiveRecord::Migration.verbose = ENV["VERBOSE"] ? ENV["VERBOSE"] == "true" : true
     DataMigrate::DataMigrator.migrate("db/data/", ENV["VERSION"] ? ENV["VERSION"].to_i : nil)
   end
 

metadata

@@ -1,40 +1,39 @@
 --- !ruby/object:Gem::Specification
 name: data_migrate
 version: !ruby/object:Gem::Version
-  version: 1.2.0
-  prerelease: 
+  version: 2.0.0
 platform: ruby
 authors:
 - Andrew J Vargo
+- Ilya Katz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-29 00:00:00.000000000 Z
+date: 2016-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '4.0'
 description: Rake tasks to migrate data alongside schema changes.
 email:
 - ajvargo@computer.org
+- ilyakatz@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE
 - README.md
@@ -42,6 +41,8 @@ files:
 - data_migrate.gemspec
 - lib/data_migrate.rb
 - lib/data_migrate/data_migrator.rb
+- lib/data_migrate/data_schema_migration.rb
+- lib/data_migrate/migration.rb
 - lib/data_migrate/railtie.rb
 - lib/data_migrate/version.rb
 - lib/generators/data_migrate.rb
@@ -51,27 +52,27 @@ files:
 - tasks/.gitkeep
 - tasks/databases.rake
 homepage: http://ajvargo.com
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: data_migrate
-rubygems_version: 1.8.23
+rubygems_version: 2.4.8
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Rake tasks to migrate data alongside schema changes.
 test_files: []