data247 0.2.0 → 0.3.0

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.3.0

data/lib/data247.rb

@@ -54,14 +54,27 @@ class Data247
       new(:status=>"Timeout from Data24-7")
     end
 
+    # When using FakeWeb for testing (which you should), use this to setup a fake response that returns the data you want.
+    #
+    # Required parameters:
+    # * :msisdn
+    #
+    # Optional parameters:
+    # * :status (defaults to "OK")
+    # * :username (defaults to Data247.username)
+    # * :password (defaults to Data247.password)
+    # * :operator (defaults to "T-Mobile")
+    # * :result (operator code, defaults to "123345", the T-Mobile operator code)
     def setup_fakeweb_response(options={})
       raise "FakeWeb is not defined. Please require 'fakeweb' and make sure the fakeweb rubygem is installed." unless defined?(FakeWeb)
       raise ArgumentError.new("Option missing: :msisdn") unless options[:msisdn]
-      options[:status] ||= "OK"
+      options[:status]  ||= "OK"
       options[:username]||= self.username
       options[:password]||= self.password
+      options[:operator] ||= "T-Mobile"
+      options[:result] ||= "123345"
       FakeWeb.register_uri :get, "http://api.data24-7.com/carrier.php?username=#{options[:username]}&password=#{options[:password]}&p1=#{options[:msisdn]}", :body=> <<-MSG
-<?xml version="1.0"?><response><results><result item="1"><status>#{options[:status]}</status><number>#{options[:msisdn]}</number><wless>y</wless><carrier_name>T-Mobile</carrier_name><carrier_id>#{options[:result]}</carrier_id><sms_address>#{options[:msisdn]}@tmomail.net</sms_address><mms_address>#{options[:msisdn]}@tmomail.net</mms_address></result></results><balance>21.5000</balance></response>
+<?xml version="1.0"?><response><results><result item="1"><status>#{options[:status]}</status><number>#{options[:msisdn]}</number><wless>y</wless><carrier_name>#{options[:operator]}</carrier_name><carrier_id>#{options[:result]}</carrier_id><sms_address>#{options[:msisdn]}@tmomail.net</sms_address><mms_address>#{options[:msisdn]}@tmomail.net</mms_address></result></results><balance>21.5000</balance></response>
 MSG
     end
   end

data/spec/data247_spec.rb

@@ -21,16 +21,20 @@ describe "Data247" do
     end
 
     describe "the returned Data247 instance" do
-      before(:each) do
-        @data247 = Data247.detect("31612345678")
-      end
+      let(:data247) { Data247.detect("31612345678") }
 
       it "should contain the returned operator code" do
-        @data247.operator_code.should == "12345"
+        data247.operator_code.should == "12345"
       end
 
       it "should contain the returned msisdn" do
-        @data247.msisdn.should == "31612345678"
+        data247.msisdn.should == "31612345678"
+      end
+
+      it "should contain the operator name" do
+        Data247.setup_fakeweb_response(:msisdn=>"31612345679", :status=>"OK", :result => 130730, :operator=>"KPN")
+        data = Data247.detect("31612345679")
+        data.operator_name.should == "KPN"
       end
     end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: data247
 version: !ruby/object:Gem::Version 
-  hash: 23
-  prerelease: false
+  hash: 19
+  prerelease: 
   segments: 
   - 0
-  - 2
+  - 3
   - 0
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Gerard de Brieder
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-13 00:00:00 +02:00
+date: 2011-07-19 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -58,7 +58,6 @@ extra_rdoc_files:
 - LICENSE
 - README.rdoc
 files: 
-- .gitignore
 - LICENSE
 - README.rdoc
 - Rakefile
@@ -71,8 +70,8 @@ homepage: http://github.com/smeevil/data247
 licenses: []
 
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
+rdoc_options: []
+
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
@@ -96,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Wrapper class for Data24-7 mobile operator detection based on msisdn.

data/.gitignore

@@ -1,22 +0,0 @@
-## MAC OS
-.DS_Store
-
-## TEXTMATE
-*.tmproj
-tmtags
-
-## EMACS
-*~
-\#*
-.\#*
-
-## VIM
-*.swp
-
-## PROJECT::GENERAL
-coverage
-rdoc
-pkg
-
-## PROJECT::SPECIFIC
-*.gemspec