dat-analysis 1.2.0 → 1.3.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 8934b7381698c14681f2e9cc7d6d158528d7d79e
+  data.tar.gz: 69361f17512a7afa27e941949afb0ebf432bc22c
+SHA512:
+  metadata.gz: 94ba51bb3d704b03131291b9f1c46d8d6c86b05c5842dae27b52dae538b61a80d4f86da1e3f20e01db36367a0f7e12251aa4e8731313ac4b3bf56747c4915009
+  data.tar.gz: 2abf8dce31f8882ea0488695e9677364cc6dd696f7328f17a05b9665b7e7f1d57c0d360c45dafe62464ce514765ab02d24207804fae46e95ab3f6791baf98041

data/dat-analysis.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name          = "dat-analysis"
-  gem.version       = "1.2.0"
+  gem.version       = "1.3.0"
   gem.authors       = ["John Barnette", "Rick Bradley"]
   gem.email         = ["bradley@github.com"]
   gem.description   = "Analyze results from dat-science"

data/lib/dat/analysis.rb

@@ -95,11 +95,11 @@ module Dat
       end
     end
 
-    # Public: skip pending mismatch results not satisfying the provided block.
+    # Public: skip pending mismatch results satisfying the provided block.
     # May modify current mismatch result.
     #
     # &block - block accepting a prepared mismatch result and returning true
-    #          or false.
+    #          if the result should be skipped and false otherwise.
     #
     # Examples:
     #
@@ -115,15 +115,16 @@ module Dat
     #     result['timestamp'].to_i > 1.hour.ago
     #   end
     #
-    # Returns nil if no satisfying results are found.  Current result will be nil.
-    # Returns count of remaining results if a satisfying result found.  Leaves
-    # current result set to first result for which block returns a truthy value.
+    # Returns nil if all results are skipped.  Current result will be nil.
+    # Returns count of remaining results if a result not matching the skip
+    # condition is found.  Leaves current result set to first result for
+    # which block returns a falsey value.
     def skip(&block)
       raise ArgumentError, "a block is required" unless block_given?
 
       while more?
         fetch
-        return count if yield(current)
+        return count unless yield(current)
       end
 
       # clear current result since nothing of interest was found.

data/test/dat_analysis_test.rb

@@ -281,59 +281,59 @@ class DatAnalysisTest < MiniTest::Unit::TestCase
     end
   end
 
-  def test_skip_returns_0_if_the_current_result_satisfies_the_block_and_no_other_results_are_available
+  def test_skip_returns_0_if_the_current_result_does_not_satisfy_the_block_and_no_other_results_are_available
     @analyzer.mismatches.push @result
 
     remaining = @analyzer.skip do |result|
-      true
+      false
     end
 
     assert_equal 0, remaining
   end
 
-  def test_skip_returns_the_number_of_additional_results_if_the_current_result_satisfies_the_block_and_other_results_are_available
+  def test_skip_returns_the_number_of_additional_results_if_the_current_result_does_not_satisfy_the_block_and_other_results_are_available
     @analyzer.mismatches.push @result
     @analyzer.mismatches.push @result
     @analyzer.mismatches.push @result
 
     remaining = @analyzer.skip do |result|
-      true
+      false
     end
 
     assert_equal 2, remaining
   end
 
-  def test_skip_returns_nil_if_no_results_are_satisfying
+  def test_skip_returns_nil_if_all_results_are_satisfying
     @analyzer.mismatches.push @result
     @analyzer.mismatches.push @result
     @analyzer.mismatches.push @result
 
     remaining = @analyzer.skip do |result|
-      false
+      true
     end
 
     assert_nil remaining
   end
 
-  def test_skip_skips_all_results_if_no_results_are_satisfying
+  def test_skip_skips_all_results_if_all_results_are_satisfying
     @analyzer.mismatches.push @result
     @analyzer.mismatches.push @result
     @analyzer.mismatches.push @result
 
     remaining = @analyzer.skip do |result|
-      false
+      true
     end
 
     assert !@analyzer.more?
   end
 
-  def test_skip_leaves_current_as_nil_if_no_results_are_satisfying
+  def test_skip_leaves_current_as_nil_if_all_results_are_satisfying
     @analyzer.mismatches.push @result
     @analyzer.mismatches.push @result
     @analyzer.mismatches.push @result
 
     remaining = @analyzer.skip do |result|
-      false
+      true
     end
 
     assert_nil @analyzer.current

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dat-analysis
 version: !ruby/object:Gem::Version
-  version: 1.2.0
-  prerelease: 
+  version: 1.3.0
 platform: ruby
 authors:
 - John Barnette
@@ -10,38 +9,34 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-23 00:00:00.000000000 Z
+date: 2014-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Analyze results from dat-science
@@ -85,27 +80,26 @@ files:
 - test/fixtures/invalid-matcher/matcher.rb
 homepage: https://github.com/github/dat-analysis
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: HYPOTHESIZE THIS.
 test_files:
 - test/dat_analysis_subclassing_test.rb