darlingtonia 3.0.3 → 3.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fccf4f74b294b16ddf86169a11cf05fa000acb4d76f2d3e0e53478570925ffbc
-  data.tar.gz: f572b72305be4c963cfeafd03375920740fc37b19c6eb9a9fe670c427a704cf7
+  metadata.gz: b417d442d5f092672b0843b6e4f724a6fed90c0913a8470976edb5b17c367b25
+  data.tar.gz: b6240dd8d7c293f128f8905bd2dcd1e664ef90d0b81b892ee3a3e30a3d67b9bc
 SHA512:
-  metadata.gz: afd4ad7a896b84d6b51a048cdbfb0d74beb87fc4296296625267741323804ba55e0b78aeb400195e930fcea6401c7323f534d3aba443989237ee783177eca593
-  data.tar.gz: d2297c4746b3b797ee90750baad25ec5fa326da33963bf67f73e05b31d1cb2655d0a34876dc3fbeba1e5e78838733699bae9442ce839d63161a685a6bc529bfe
+  metadata.gz: 39cb14bd001b7359b69284a45fbe8642a0e4a797a67ecccd66bc3e1722576eb63994e8efa16cfad8257c6e1fdbcb94a5141d1224b6ac05b2a360ca897ed88a8f
+  data.tar.gz: 4b99fc45b3434de8fbf398a8397c689ce49617bb081f2047dc4f483cbcc8fdd2922f26d356b81c54debc4943c084ffd52d75805e6cf6570cd04db465c7a3d2cf

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+3.0.4 - Fri Feb 22, 2019
+
+* Allow subclassed libraries not to have a files field
+
+  It should be fine to use HyraxRecordImporter with a customized mapper
+  that does not contain a field called files. There are other strategies
+  for attaching files, such as the remote_files strategy used at UCLA in
+  the Californica project.
+
 3.0.3 - Thu Feb 21, 2019
 
 * Bug fix: Ensure there is no files metadata field passed

data/lib/darlingtonia/hyrax_record_importer.rb

@@ -86,6 +86,7 @@ module Darlingtonia
     # @param [Darlingtonia::InputRecord]
     # @return [Array] an array of Hyrax::UploadedFile ids
     def create_upload_files(record)
+      return unless record.mapper.respond_to?(:files)
       files_to_attach = record.mapper.files
       return [] if files_to_attach.nil? || files_to_attach.empty?
 
@@ -178,7 +179,7 @@ module Darlingtonia
                                                    attrs)
 
         if Hyrax::CurationConcern.actor.create(actor_env)
-          info_stream << "event: record_created, batch_id: #{batch_id}, record_id: #{created.id}, collection_id: #{collection_id}, record_title: #{attrs[:title].first}"
+          info_stream << "event: record_created, batch_id: #{batch_id}, record_id: #{created.id}, collection_id: #{collection_id}, record_title: #{attrs[:title]&.first}"
           @success_count += 1
         else
           created.errors.each do |attr, msg|

data/lib/darlingtonia/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Darlingtonia
-  VERSION = '3.0.3'
+  VERSION = '3.0.4'
 end

data/spec/darlingtonia/hyrax_record_importer_spec.rb

@@ -40,6 +40,29 @@ describe Darlingtonia::HyraxRecordImporter, :clean do
     end
   end
 
+  # Instead of having a files field in the mapper, which will create a
+  # Hyrax::UploadedFile for each file before attaching it, some importers will
+  # use a remote_files strategy and instead treat each file as a remote file and
+  # fetch it at object creation time. This might be faster, and we might eventually
+  # want to adopt it as our default. For now, do not raise an error if there is no
+  # `files` field in the mapper being used.
+  context 'with no files filed in the mapper' do
+    let(:metadata) do
+      {
+        'title' => 'A Title',
+        'language' => 'English',
+        'visibility' => 'open'
+      }
+    end
+    let(:record) { Darlingtonia::InputRecord.from(metadata: metadata, mapper: Darlingtonia::MetadataMapper.new) }
+
+    it 'creates a work for record' do
+      expect { importer.import(record: record) }
+        .to change { Work.count }
+        .by 1
+    end
+  end
+
   context 'with attached files' do
     before do
       ENV['IMPORT_PATH'] = File.expand_path('../fixtures/images', File.dirname(__FILE__))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: darlingtonia
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
 platform: ruby
 authors:
 - Data Curation Experts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-21 00:00:00.000000000 Z
+date: 2019-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active-fedora