darlingtonia 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d2846b9bcfda0f77bed4980b06ffebeea86fa2d
-  data.tar.gz: 5768f600be72e578ef9969e84d1d71d3e5160c06
+  metadata.gz: de3308c4bc712e18cdca102c0dd860638aad4ffc
+  data.tar.gz: 2ee3c0231d0ee94f69c9b95bf8f07b84d67c42e0
 SHA512:
-  metadata.gz: 1565987780f909a9ba63b872c68da62a6f782c46d5363930b188a7c64e63bc323e1cdbfb1d54274291b6a6dfea046a6a87d672648d7a11d6a707dafb25e11db8
-  data.tar.gz: ddae5b051da31ee14317e09b5c36597cd3ec6ad550d6ddd1585ac4d30ba77dccae2cbbbcf0deb8cf6d790bf6a37be87c46f9a766502423603e8609b27b1beb00
+  metadata.gz: b0057d871e574a744e6b9d2c53f9fef71e93b5b6cc3259a8a5f212469123e57595eba3ee93ab9bd9764c9dede09459c4171fb5e3301b493cf11daf3c9c5f22f7
+  data.tar.gz: d7907d65a9c6a97067ee12f1c5a0732b0305858bb8d49bd7e5440415e7f0f307f30024ddf727fd48b8a5ae131adc4a78f4232e135f52909e0dbaea46c351449f

data/.gitignore

@@ -1,2 +1,3 @@
+pkg
 tmp
 Gemfile.lock

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+0.3.0 - Fri Jan 19, 2018
+------------------------
+
+Representative files.
+
+  - `ImportRecord` now passes through a `#representative_file` to its mapper,
+    returning `nil` if the mapper does not provide such a method.
+  - `CsvParser#records` now returns an empty record collection if it is given
+    invalid CSV input. This allows cleaner handling in other validations and
+    imports.
+
 0.2.0 - Wed Jan 17, 2018
 ------------------------
 

data/lib/darlingtonia/input_record.rb

@@ -29,6 +29,16 @@ module Darlingtonia
       end
     end
 
+    ##
+    # @return [String, nil] an identifier for the representative file; nil if
+    #   none is given.
+    def representative_file
+      return mapper.representative_file if
+        mapper.respond_to?(:representative_file)
+
+      nil
+    end
+
     ##
     # Respond to methods matching mapper fields
     def method_missing(method_name, *args, &block)

data/lib/darlingtonia/parsers/csv_parser.rb

@@ -38,6 +38,8 @@ module Darlingtonia
       CSV.parse(file.read, headers: true).each do |row|
         yield InputRecord.from(metadata: row)
       end
+    rescue CSV::MalformedCSVError
+      []
     end
   end
 end

data/lib/darlingtonia/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Darlingtonia
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/spec/darlingtonia/csv_parser_spec.rb

@@ -34,16 +34,26 @@ EOS
   end
 
   describe '#records' do
-    include_context 'with content'
+    context 'with valid content' do
+      include_context 'with content'
+
+      it 'has the correct titles' do
+        expect(parser.records.map(&:title))
+          .to contain_exactly(['The Moomins and the Great Flood'],
+                              ['Comet in Moominland'])
+      end
 
-    it 'has the correct titles' do
-      expect(parser.records.map(&:title))
-        .to contain_exactly(['The Moomins and the Great Flood'],
-                            ['Comet in Moominland'])
+      it 'has correct other fields' do
+        expect(parser.records.map(&:date)).to contain_exactly(['1945'], ['1946'])
+      end
     end
 
-    it 'has correct other fields' do
-      expect(parser.records.map(&:date)).to contain_exactly(['1945'], ['1946'])
+    context 'with invalid file' do
+      let(:file) { File.open('spec/fixtures/bad_example.csv') }
+
+      it 'is empty' do
+        expect(parser.records.to_a).to be_empty
+      end
     end
   end
 

data/spec/darlingtonia/input_record_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'spec_helper'
+
 describe Darlingtonia::InputRecord do
   subject(:record) { described_class.from(metadata: metadata) }
 
@@ -17,6 +19,30 @@ describe Darlingtonia::InputRecord do
     it 'handles basic text fields' do
       expect(record.attributes).to include(:title, :description)
     end
+
+    it 'does not include representative_file' do
+      expect(record.attributes).not_to include(:representative_file)
+    end
+  end
+
+  describe '#representative_file' do
+    it 'is nil if mapper does not provide a representative file' do
+      expect(record.representative_file).to be_nil
+    end
+
+    context 'when mapper provides representative_file' do
+      let(:representative_file) { :A_DUMMY_FILE }
+
+      before do
+        allow(record.mapper)
+          .to receive(:representative_file)
+          .and_return(representative_file)
+      end
+
+      it 'is the file from the mapper' do
+        expect(record.representative_file).to eql representative_file
+      end
+    end
   end
 
   describe 'mapped fields' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: darlingtonia
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Tom Johnson
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-17 00:00:00.000000000 Z
+date: 2018-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active-fedora