dangerous_open_uri 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 96cdce9d0358d8066a0f0e8b3611871f48b9c5c5
-  data.tar.gz: 1a26ebb5c237195b637d6d43215ff4ff30a1a835
+  metadata.gz: abb4db861c1b5ab25d7f11bd1bb2f544b8e9bada
+  data.tar.gz: 4155750ebc90ebd926a93f3e5dff9d78b16b578a
 SHA512:
-  metadata.gz: 73ad28a9db52241a31499b745c2f46645120e85fb82bf72058fc94f6117495441cc49ce7937f5eb177b579906d28c97c516e90456ceedbf98681a88e8b2474aa
-  data.tar.gz: 10a0ac994c377000cbed6a35d647117861be3dc089343ab34a3b1e4a76e2b733ffd7d54cac8758b4515dd43b730e5f52a07a56a31136756eaad5eb99ab14f096
+  metadata.gz: 4c65d12e43e7a4a88411a945f7bf506f0ee84ead54357fed556d16345538a8e782a88d25bd2a8807e11c5de4a2fe789501887d6fb2ab8999091c99157452dabc
+  data.tar.gz: ad36b7cc1d7bef21b6f9987a25f868b0227dcd9172e866c8f52e5ece16857cd0dcacfcd6bb1406f7e5b6e06fa58d38cc2db86ac944130994cd5605ffdafa1245

data/README.md

@@ -39,7 +39,7 @@ require 'dangerous_open_uri'
 open('http://user:pass@example.co.jp/secret/page').read
 #=> Enable to read `http://user:pass@example.co.jp/secret/page` sources
 
-open('http://example.co.jp/index.html, proxy: 'http://user:pass@proxy.example.com')
+open('http://example.co.jp/index.html', proxy: 'http://user:pass@proxy.example.com')
 #=> Proxy basic authentication uses `user` and `pass`
 ```
 

data/lib/dangerous_open_uri/version.rb

@@ -1,3 +1,3 @@
 module DangerousOpenUri
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/lib/dangerous_open_uri.rb

@@ -16,11 +16,13 @@ module OpenURI
       end
     end
 
-    if target.userinfo
-      options[:http_basic_authentication] = [target.user, target.password]
-      target.userinfo = ""
+    _target = target.dup
+
+    if _target.userinfo
+      options[:http_basic_authentication] = [_target.user, _target.password]
+      _target.userinfo = ""
     end
 
-    original_open_http(buf, target, proxy, options)
+    original_open_http(buf, _target, proxy, options)
   end
 end

data/spec/lib/dangerous_open_uri_spec.rb

@@ -68,6 +68,17 @@ describe OpenURI do
         ).to eq('aaa')
       end
 
+      it 'given URI::Generic does not change the argument object' do
+        uri = URI.parse('http://user:pass@www.example.com/secret/page.html')
+
+        stub_request(:any, 'http://user:pass@www.example.com/secret/page.html')
+          .to_return(body: 'aaa')
+
+        open(uri)
+
+        expect(uri).to eq(URI.parse('http://user:pass@www.example.com/secret/page.html'))
+      end
+
       describe 'given proxy' do
         it 'original_open_http receives the correct proxy arguments' do
           uri       = URI.parse('http://www.example.com/secret/page.html')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dangerous_open_uri
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - mgi166
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-19 00:00:00.000000000 Z
+date: 2014-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler