danger 9.3.1 → 9.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 719588ed490c1115e2439aabacb0dd400e1852bf03a0f25514b26dcb08e0ad9e
-  data.tar.gz: 7426ab63483923ceffd843789c473a46f7726b1f9057a74b558bbeeb2c6948d9
+  metadata.gz: 7310f8ce0107be43eb12fbf841273878fb0fd4c8e8a0f623689506a930c354cc
+  data.tar.gz: 1b187cc8027ed57b2f204f3e8222f4373baf40c63e94a35bdcc22079dfbc1d47
 SHA512:
-  metadata.gz: 9fa39fb8d2a11ac973a1c4b7a9647bef1a0bfdd36411d403e1f3121b3a1b7490dbaa7489c17f018fa1ae88be4ceccc6ee213267ee32133dfbf162cb3bab93e6f
-  data.tar.gz: 01ba1c81cfdb4a37661826f913ed3227e1432fbbede1d69e6521eacfd4d6c8595f8a5140134c431446b591f81027797a4f93b67b674fcfd9c860d452575ea5fb
+  metadata.gz: dd4d4a9b2810edde68fb71823868c3566fd3f12141876f46d7b2b91c381901c328550e3f3521fcbcfd4faa27f16a435dc4f81e09e30708aef5e6ce103ef5dc32
+  data.tar.gz: b19572d95dfdc38061db32f12a77cdc4f7e21c5447f75214a489467140a3d3caee4e1ac3501a5a87aba5b1037614d20b5aa50a33ee0248b1480d489d2b7d3e6b

data/README.md

@@ -2,8 +2,7 @@
 
 [![License](http://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://github.com/orta/danger/blob/master/LICENSE)
 [![Gem](https://img.shields.io/gem/v/danger.svg?style=flat)](http://rubygems.org/gems/danger)
-[![Travis CI](https://img.shields.io/travis/danger/danger.svg?style=flat)](https://travis-ci.org/danger/danger)
-[![Join the community on Spectrum](https://withspectrum.github.io/badge/badge.svg)](https://spectrum.chat/danger)
+[![CI](https://github.com/danger/danger/actions/workflows/CI.yml/badge.svg)](https://github.com/danger/danger/actions/workflows/CI.yml)
 
 Formalize your Pull Request etiquette.
 

data/lib/danger/ci_source/azure_pipelines.rb

@@ -29,8 +29,6 @@ module Danger
   # which will automatically get your vsts domain and your project name needed for the vsts api.
   #
   class AzurePipelines < CI
-
-
     def self.validates_as_ci?(env)
       has_all_variables = ["AGENT_ID", "BUILD_SOURCEBRANCH", "BUILD_REPOSITORY_URI", "BUILD_REASON", "BUILD_REPOSITORY_NAME"].all? { |x| env[x] && !env[x].empty? }
 

data/lib/danger/ci_source/ci_source.rb

@@ -31,7 +31,7 @@ module Danger
     end
 
     def initialize(_env)
-      raise "Subclass and overwrite initialize"
+      raise "Subclass and overwrite initialize" if method(__method__).owner == Danger::CI
     end
   end
 end

data/lib/danger/ci_source/custom_ci_with_github.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/request_sources/github/github"
 
 module Danger
@@ -31,6 +33,8 @@ module Danger
     end
 
     def initialize(env)
+      super
+
       self.repo_slug = env["GITHUB_REPOSITORY"]
       pull_request_event = JSON.parse(File.read(env["GITHUB_EVENT_PATH"]))
       self.pull_request_id = pull_request_event["number"]

data/lib/danger/ci_source/support/pull_request_finder.rb

@@ -146,7 +146,7 @@ module Danger
         require "danger/request_sources/bitbucket_server_api"
         project, slug = repo_slug.split("/")
         RequestSources::BitbucketServerAPI.new(project, slug, specific_pull_request_id, env)
-      
+
       when :vsts
         require "danger/request_sources/vsts_api"
         RequestSources::VSTSAPI.new(repo_slug, specific_pull_request_id, env)
@@ -181,7 +181,7 @@ module Danger
       elsif remote_url =~ %r{/pull-requests/}
         :bitbucket_server
       elsif remote_url =~ /\.visualstudio\.com/i || remote_url =~ /dev\.azure\.com/i
-        :vsts 
+        :vsts
       else
         :github
       end

data/lib/danger/request_sources/bitbucket_cloud.rb

@@ -70,18 +70,14 @@ module Danger
       def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false, remove_previous_comments: false)
         delete_old_comments(danger_id: danger_id) if !new_comment || remove_previous_comments
 
-        comment = generate_description(warnings: warnings, errors: errors, template: "bitbucket_server")
-        comment += "\n\n"
-
         warnings = update_inline_comments_for_kind!(:warnings, warnings, danger_id: danger_id)
         errors = update_inline_comments_for_kind!(:errors, errors, danger_id: danger_id)
         messages = update_inline_comments_for_kind!(:messages, messages, danger_id: danger_id)
         markdowns = update_inline_comments_for_kind!(:markdowns, markdowns, danger_id: danger_id)
 
-        has_comments = (warnings.count > 0 || errors.count > 0 || messages.count > 0 || markdowns.count > 0)
+        has_comments = (warnings.count.positive? || errors.count.positive? || messages.count.positive? || markdowns.count.positive?)
         if has_comments
-          comment = generate_description(warnings: warnings,
-                                         errors: errors)
+          comment = generate_description(warnings: warnings, errors: errors, template: "bitbucket_server")
           comment += "\n\n"
           comment += generate_comment(warnings: warnings,
                                       errors: errors,

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "9.3.1".freeze
+  VERSION = "9.3.2".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 9.3.1
+  version: 9.3.2
 platform: ruby
 authors:
 - Orta Therox
 - Juanito Fatas
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-06 00:00:00.000000000 Z
+date: 2023-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -329,7 +329,7 @@ homepage: https://github.com/danger/danger
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -344,8 +344,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.26
+signing_key:
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.
 test_files: []