danger 9.1.0 → 9.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fc4bd35f1d805c6e3ef5b0467cd59281f0251c10b0580ebb138002e3b370e62
-  data.tar.gz: 29df2722f598ead34bee294304b60b3f6343c6147cce87054772aac2b40f1f2b
+  metadata.gz: 9ad61c252b1b62b1fb4e7aa07c2ef21727ada06dcfdd66e23ce70840ab37fcff
+  data.tar.gz: a1e98cfa27d937448822f2ece399fc157b5f30358ed675f976ccc7c20b7bfb5f
 SHA512:
-  metadata.gz: 304581c49ae31baa62f135883e006536e993a824a6cea8a920a37d58b232ea3118eccf773ffc760281c8a49b70446b51b955c952379e9d41e12e9d9e9842a4d7
-  data.tar.gz: d68b392bcb4075b852cc988fdaa3e9e2fd3df080417dd31d1cb314bf9ec1a4f3af5fdf759f7f106e5071b60e48ae4affb78750ae58a43ecadb94d533d9e80d83
+  metadata.gz: f4531b7f35bccbfdc0df07dedae51b009e1a9a0bcf00d566293d28c143c1a00e29f3ef8f7e47421a6ff32e48cd8b2b640866392aab161d0e95d16d9eff6ad1b6
+  data.tar.gz: fcce02992e6488c454ca914e4a81be0d397cbd19b9f3e63cf058c05068606376020281b552cb489b9d88bf8d0958b6a99b442093d62123a095c3d4418955a1c1

data/bin/danger

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
-$LOAD_PATH.push File.expand_path("../../lib", __FILE__)
+$LOAD_PATH.push File.expand_path("../lib", __dir__)
 
 require "danger"
 Danger::Runner.run ARGV

data/lib/danger/ci_source/appcircle.rb

@@ -3,81 +3,81 @@
 require "danger/request_sources/github/github"
 require "danger/request_sources/gitlab"
 module Danger
-    # ### CI Setup
-    #
-    # Add a Custom Script step to your workflow and set it as a bash:
-    #
-    # ```shell
-    #   cd $AC_REPOSITORY_DIR  
-    #   bundle install
-    #   bundle exec danger
-    # ```
-    # ### Token Setup
-    #
-    # Login to Appcircle and select your build profile. Go to your *Config* and
-    # choose *Environment Variables*.
-    # https://docs.appcircle.io/environment-variables/managing-variables
-    #
-    # #### GitHub
-    # Add the `DANGER_GITHUB_API_TOKEN` to your profile's ENV.
-    #
-    # #### GitLab
-    # Add the `DANGER_GITLAB_API_TOKEN` to your profile's ENV.
-    #
-    # #### Bitbucket Cloud
-    # Add the `DANGER_BITBUCKETSERVER_USERNAME`, `DANGER_BITBUCKETSERVER_PASSWORD`
-    # to your profile's ENV.
-    #
-    # #### Bitbucket server
-    # Add the `DANGER_BITBUCKETSERVER_USERNAME`, `DANGER_BITBUCKETSERVER_PASSWORD`
-    # and `DANGER_BITBUCKETSERVER_HOST` to your profile's ENV.
-    #
-    class Appcircle < CI
-        def self.validates_as_ci?(env)
-        env.key? "AC_APPCIRCLE"
-      end
-  
-      def self.validates_as_pr?(env)
-        return false unless env.key? "AC_PULL_NUMBER"
-        env["AC_PULL_NUMBER"].to_i > 0
-      end
+  # ### CI Setup
+  #
+  # Add a Custom Script step to your workflow and set it as a bash:
+  #
+  # ```shell
+  #   cd $AC_REPOSITORY_DIR
+  #   bundle install
+  #   bundle exec danger
+  # ```
+  # ### Token Setup
+  #
+  # Login to Appcircle and select your build profile. Go to your *Config* and
+  # choose *Environment Variables*.
+  # https://docs.appcircle.io/environment-variables/managing-variables
+  #
+  # #### GitHub
+  # Add the `DANGER_GITHUB_API_TOKEN` to your profile's ENV.
+  #
+  # #### GitLab
+  # Add the `DANGER_GITLAB_API_TOKEN` to your profile's ENV.
+  #
+  # #### Bitbucket Cloud
+  # Add the `DANGER_BITBUCKETSERVER_USERNAME`, `DANGER_BITBUCKETSERVER_PASSWORD`
+  # to your profile's ENV.
+  #
+  # #### Bitbucket server
+  # Add the `DANGER_BITBUCKETSERVER_USERNAME`, `DANGER_BITBUCKETSERVER_PASSWORD`
+  # and `DANGER_BITBUCKETSERVER_HOST` to your profile's ENV.
+  #
+  class Appcircle < CI
+    def self.validates_as_ci?(env)
+      env.key? "AC_APPCIRCLE"
+    end
 
-      def supported_request_sources
-        @supported_request_sources ||= [
-          Danger::RequestSources::GitHub,
-          Danger::RequestSources::BitbucketCloud,
-          Danger::RequestSources::BitbucketServer,
-          Danger::RequestSources::GitLab
-        ]
-      end
+    def self.validates_as_pr?(env)
+      return false unless env.key? "AC_PULL_NUMBER"
 
-      def initialize(env)
-        self.pull_request_id = env["AC_PULL_NUMBER"]
-        self.repo_url = env["AC_GIT_URL"]
-        self.repo_slug = repo_slug_from(self.repo_url)
-      end
-  
-      def repo_slug_from(url)
-        if url =~ URI::regexp
-          # Try to parse the URL as a valid URI. This should cover the cases of http/https/ssh URLs.
-          begin
-            uri = URI.parse(url)
-            return uri.path.sub(/^(\/)/,'').sub(/(.git)$/,'')
-          rescue URI::InvalidURIError
-            # In case URL could not be parsed fallback to git URL parsing.
-            repo_slug_asgiturl(url)
-          end
-        else
-          # In case URL could not be parsed fallback to git URL parsing. git@github.com:organization/repo.git
+      env["AC_PULL_NUMBER"].to_i > 0
+    end
+
+    def supported_request_sources
+      @supported_request_sources ||= [
+        Danger::RequestSources::GitHub,
+        Danger::RequestSources::BitbucketCloud,
+        Danger::RequestSources::BitbucketServer,
+        Danger::RequestSources::GitLab
+      ]
+    end
+
+    def initialize(env)
+      self.pull_request_id = env["AC_PULL_NUMBER"]
+      self.repo_url = env["AC_GIT_URL"]
+      self.repo_slug = repo_slug_from(self.repo_url)
+    end
+
+    def repo_slug_from(url)
+      if url =~ URI::DEFAULT_PARSER.make_regexp
+        # Try to parse the URL as a valid URI. This should cover the cases of http/https/ssh URLs.
+        begin
+          uri = URI.parse(url)
+          return uri.path.sub(%r{^(/)}, "").sub(/(.git)$/, "")
+        rescue URI::InvalidURIError
+          # In case URL could not be parsed fallback to git URL parsing.
           repo_slug_asgiturl(url)
         end
+      else
+        # In case URL could not be parsed fallback to git URL parsing. git@github.com:organization/repo.git
+        repo_slug_asgiturl(url)
       end
-  
-      def repo_slug_asgiturl(url)
-        matcher_url = url
-        repo_matches = matcher_url.match(%r{([\/:])(([^\/]+\/)+[^\/]+?)(\.git$|$)})[2]
-        return repo_matches unless repo_matches.nil?
-      end
+    end
+
+    def repo_slug_asgiturl(url)
+      matcher_url = url
+      repo_matches = matcher_url.match(%r{([/:])(([^/]+/)+[^/]+?)(\.git$|$)})[2]
+      return repo_matches unless repo_matches.nil?
     end
   end
-  
+end

data/lib/danger/ci_source/appveyor.rb

@@ -42,6 +42,7 @@ module Danger
 
     def self.validates_as_pr?(env)
       return false unless env.key? "APPVEYOR_PULL_REQUEST_NUMBER"
+
       env["APPVEYOR_PULL_REQUEST_NUMBER"].to_i > 0
     end
 

data/lib/danger/ci_source/azure_pipelines.rb

@@ -1,6 +1,7 @@
 # https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables
 require "uri"
 require "danger/request_sources/github/github"
+require "danger/request_sources/vsts"
 
 module Danger
   # ### CI Setup
@@ -15,15 +16,28 @@ module Danger
   #
   # ### Token Setup
   #
-  # Add the `DANGER_GITHUB_API_TOKEN` to your environment variables.
+  # #### GitHub
+  #
+  # You need to add the `DANGER_GITHUB_API_TOKEN` environment variable, to do this, go to your build definition's variables tab.
+  #  #
+  # #### Azure Git
+  #
+  # You need to add the `DANGER_VSTS_API_TOKEN` and `DANGER_VSTS_HOST` environment variable, to do this,
+  # go to your build definition's variables tab. The `DANGER_VSTS_API_TOKEN` is your vsts personal access token.
+  # Instructions for creating a personal access token can be found [here](https://www.visualstudio.com/en-us/docs/setup-admin/team-services/use-personal-access-tokens-to-authenticate).
+  # For the `DANGER_VSTS_HOST` variable the suggested value is `$(System.TeamFoundationCollectionUri)$(System.TeamProject)`
+  # which will automatically get your vsts domain and your project name needed for the vsts api.
   #
   class AzurePipelines < CI
+
+
     def self.validates_as_ci?(env)
+      has_all_variables = ["AGENT_ID", "BUILD_SOURCEBRANCH", "BUILD_REPOSITORY_URI", "BUILD_REASON", "BUILD_REPOSITORY_NAME"].all? { |x| env[x] && !env[x].empty? }
+
       # AGENT_ID is being used by AppCenter as well, so checking here to make sure AppCenter CI doesn't get a false positive for AzurePipelines
       # Anyone working with AzurePipelines could provide a better/truly unique env key to avoid checking for AppCenter
-      !Danger::Appcenter::validates_as_ci?(env) &&
-      env.key?("AGENT_ID") &&
-      env["BUILD_REPOSITORY_PROVIDER"] != "TfsGit"
+      !Danger::Appcenter.validates_as_ci?(env) &&
+        has_all_variables
     end
 
     def self.validates_as_pr?(env)
@@ -35,7 +49,8 @@ module Danger
         Danger::RequestSources::GitHub,
         Danger::RequestSources::GitLab,
         Danger::RequestSources::BitbucketServer,
-        Danger::RequestSources::BitbucketCloud
+        Danger::RequestSources::BitbucketCloud,
+        Danger::RequestSources::VSTS
       ]
     end
 

data/lib/danger/ci_source/bamboo.rb

@@ -34,7 +34,7 @@ module Danger
     def initialize(env)
       self.repo_url = env["bamboo_planRepository_repositoryUrl"]
       self.pull_request_id = env["bamboo_repository_pr_key"]
-      repo_matches = self.repo_url.match(%r{([\/:])([^\/]+\/[^\/]+?)(\.git$|$)})
+      repo_matches = self.repo_url.match(%r{([/:])([^/]+/[^/]+?)(\.git$|$)})
       self.repo_slug = repo_matches[2] unless repo_matches.nil?
     end
   end

data/lib/danger/ci_source/bitbucket_pipelines.rb

@@ -16,7 +16,6 @@ module Danger
   # You can find them in Settings > Pipelines > Repository Variables
 
   class BitbucketPipelines < CI
-
     def self.validates_as_ci?(env)
       env.key? "BITBUCKET_BUILD_NUMBER"
     end
@@ -31,7 +30,7 @@ module Danger
 
     def initialize(env)
       self.repo_url = env["BITBUCKET_GIT_HTTP_ORIGIN"]
-      self.repo_slug = "#{env["BITBUCKET_REPO_OWNER"]}/#{env["BITBUCKET_REPO_SLUG"]}"
+      self.repo_slug = "#{env['BITBUCKET_REPO_OWNER']}/#{env['BITBUCKET_REPO_SLUG']}"
       self.pull_request_id = env["BITBUCKET_PR_ID"]
     end
   end

data/lib/danger/ci_source/bitrise.rb

@@ -54,11 +54,11 @@ module Danger
     end
 
     def repo_slug_from(url)
-      if url =~ URI::regexp
+      if url =~ URI::DEFAULT_PARSER.make_regexp
         # Try to parse the URL as a valid URI. This should cover the cases of http/https/ssh URLs.
         begin
           uri = URI.parse(url)
-          return uri.path.sub(/^(\/)/,'').sub(/(.git)$/,'')
+          return uri.path.sub(%r{^(/)}, "").sub(/(.git)$/, "")
         rescue URI::InvalidURIError
           # In case URL could not be parsed fallback to git URL parsing.
           repo_slug_asgiturl(url)
@@ -71,7 +71,7 @@ module Danger
 
     def repo_slug_asgiturl(url)
       matcher_url = url
-      repo_matches = matcher_url.match(%r{([\/:])(([^\/]+\/)+[^\/]+?)(\.git$|$)})[2]
+      repo_matches = matcher_url.match(%r{([/:])(([^/]+/)+[^/]+?)(\.git$|$)})[2]
       return repo_matches unless repo_matches.nil?
     end
   end

data/lib/danger/ci_source/buildkite.rb

@@ -40,7 +40,7 @@ module Danger
       self.repo_url = env["BUILDKITE_REPO"]
       self.pull_request_id = env["BUILDKITE_PULL_REQUEST"]
 
-      repo_matches = self.repo_url.match(%r{([\/:])([^\/]+\/[^\/]+?)(\.git$|$)})
+      repo_matches = self.repo_url.match(%r{([/:])([^/]+/[^/]+?)(\.git$|$)})
       self.repo_slug = repo_matches[2] unless repo_matches.nil?
     end
 

data/lib/danger/ci_source/circle_api.rb

@@ -36,6 +36,7 @@ module Danger
       build_json = fetch_build(repo_slug, build_number, token)
       pull_requests = build_json[:pull_requests]
       return nil unless pull_requests && pull_requests.first
+
       pull_requests.first[:url]
     end
 
@@ -44,8 +45,7 @@ module Danger
       url = "project/#{repo_slug}/#{build_number}"
       params = { "circle-token" => token }
       response = client.get url, params, accept: "application/json"
-      json = JSON.parse(response.body, symbolize_names: true)
-      json
+      JSON.parse(response.body, symbolize_names: true)
     end
   end
 end

data/lib/danger/ci_source/code_build.rb

@@ -39,7 +39,7 @@ module Danger
 
       gh_host = env["DANGER_GITHUB_HOST"] || "github.com"
 
-      env["CODEBUILD_SOURCE_REPO_URL"].gsub(%r{^.*?#{Regexp.escape(gh_host)}\/(.*?)(\.git)?$}, '\1')
+      env["CODEBUILD_SOURCE_REPO_URL"].gsub(%r{^.*?#{Regexp.escape(gh_host)}/(.*?)(\.git)?$}, '\1')
     end
 
     def self.extract_repo_url(env)

data/lib/danger/ci_source/codefresh.rb

@@ -39,7 +39,7 @@ module Danger
     end
 
     def initialize(env)
-      self.repo_url = env["CF_COMMIT_URL"].to_s.gsub(/\/commit.+$/, "")
+      self.repo_url = env["CF_COMMIT_URL"].to_s.gsub(%r{/commit.+$}, "")
       self.repo_slug = self.class.slug_from(env)
       self.pull_request_id = env["CF_PULL_REQUEST_NUMBER"]
     end

data/lib/danger/ci_source/concourse.rb

@@ -2,10 +2,10 @@ require "git"
 require "danger/request_sources/local_only"
 
 module Danger
-# Concourse CI Integration
-#
-# https://concourse-ci.org/
-#
+  # Concourse CI Integration
+  #
+  # https://concourse-ci.org/
+  #
   # ### CI Setup
   #
   # With Concourse, you run the docker images yourself, so you will want to add `yarn danger ci` within one of your build jobs.
@@ -56,6 +56,5 @@ module Danger
       end
       self.repo_url = GitRepo.new.origins
     end
-
   end
 end

data/lib/danger/ci_source/dotci.rb

@@ -21,17 +21,15 @@ module Danger
     end
 
     def supported_request_sources
-      @supported_request_sources ||= begin
-        [
-          Danger::RequestSources::GitHub
-        ]
-      end
+      @supported_request_sources ||= [
+        Danger::RequestSources::GitHub
+      ]
     end
 
     def initialize(env)
       self.repo_url = self.class.repo_url(env)
       self.pull_request_id = self.class.pull_request_id(env)
-      repo_matches = self.repo_url.match(%r{([\/:])([^\/]+\/[^\/]+)$})
+      repo_matches = self.repo_url.match(%r{([/:])([^/]+/[^/]+)$})
       self.repo_slug = repo_matches[2].gsub(/\.git$/, "") unless repo_matches.nil?
     end
 

data/lib/danger/ci_source/github_actions.rb

@@ -9,7 +9,7 @@ module Danger
   #  ```yml
   #  ...
   #    steps:
-  #      - uses: actions/checkout@v1
+  #      - uses: actions/checkout@v3
   #      - uses: danger/danger@master
   #        env:
   #          DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -22,7 +22,7 @@ module Danger
 
     def self.validates_as_pr?(env)
       value = env["GITHUB_EVENT_NAME"]
-      value == "pull_request" || value == "pull_request_target"
+      ["pull_request", "pull_request_target"].include?(value)
     end
 
     def supported_request_sources
@@ -32,12 +32,12 @@ module Danger
     def initialize(env)
       self.repo_slug = env["GITHUB_REPOSITORY"]
       pull_request_event = JSON.parse(File.read(env["GITHUB_EVENT_PATH"]))
-      self.pull_request_id = pull_request_event['number']
-      self.repo_url = pull_request_event['repository']['clone_url']
+      self.pull_request_id = pull_request_event["number"]
+      self.repo_url = pull_request_event["repository"]["clone_url"]
 
       # if environment variable DANGER_GITHUB_API_TOKEN is not set, use env GITHUB_TOKEN
-      if (env.key? "GITHUB_ACTION") && (!env.key? 'DANGER_GITHUB_API_TOKEN')
-        env['DANGER_GITHUB_API_TOKEN'] = env['GITHUB_TOKEN']
+      if (env.key? "GITHUB_ACTION") && (!env.key? "DANGER_GITHUB_API_TOKEN")
+        env["DANGER_GITHUB_API_TOKEN"] = env["GITHUB_TOKEN"]
       end
     end
   end

data/lib/danger/ci_source/gitlab_ci.rb

@@ -47,11 +47,11 @@ module Danger
       client = RequestSources::GitLab.new(nil, env).client
 
       client_version = Gem::Version.new(client.version.version)
-      if (client_version >= Gem::Version.new("10.7"))
-        #Use the 'list merge requests associated with a commit' API, for speed
+      if client_version >= Gem::Version.new("10.7")
+        # Use the 'list merge requests associated with a commit' API, for speed
         # (GET /projects/:id/repository/commits/:sha/merge_requests) available for GitLab >= 10.7
         merge_request = client.commit_merge_requests(project_path, base_commit, state: :opened).first
-        if (client_version >= Gem::Version.new("13.8"))
+        if client_version >= Gem::Version.new("13.8")
           # Gitlab 13.8.0 started returning merge requests for merge commits and squashed commits
           # By checking for merge_request.state, we can ensure danger only comments on MRs which are open
           return 0 if merge_request.nil?
@@ -68,7 +68,7 @@ module Danger
 
     def self.slug_from(env)
       if env["DANGER_PROJECT_REPO_URL"]
-        env["DANGER_PROJECT_REPO_URL"].split('/').last(2).join('/')
+        env["DANGER_PROJECT_REPO_URL"].split("/").last(2).join("/")
       else
         env["CI_MERGE_REQUEST_PROJECT_PATH"] || env["CI_PROJECT_PATH"]
       end

data/lib/danger/ci_source/jenkins.rb

@@ -48,6 +48,7 @@ module Danger
   #
   class Jenkins < CI
     attr_accessor :project_url
+
     class EnvNotFound < StandardError
       def initialize
         super("ENV not found, please check your Jenkins. Related: https://stackoverflow.com/search?q=jenkins+env+null")
@@ -60,18 +61,16 @@ module Danger
 
     def self.validates_as_pr?(env)
       id = pull_request_id(env)
-      !id.nil? && !id.empty? && !!id.match(%r{^\d+$})
+      !id.nil? && !id.empty? && !!id.match(/^\d+$/)
     end
 
     def supported_request_sources
-      @supported_request_sources ||= begin
-        [
-          Danger::RequestSources::GitHub,
-          Danger::RequestSources::GitLab,
-          Danger::RequestSources::BitbucketServer,
-          Danger::RequestSources::BitbucketCloud
-        ]
-      end
+      @supported_request_sources ||= [
+        Danger::RequestSources::GitHub,
+        Danger::RequestSources::GitLab,
+        Danger::RequestSources::BitbucketServer,
+        Danger::RequestSources::BitbucketCloud
+      ]
     end
 
     def initialize(env)
@@ -85,29 +84,29 @@ module Danger
 
     def self.repo_slug(repo_url)
       slug = self.slug_ssh(repo_url)
-      slug = self.slug_http(repo_url) unless slug
-      slug = self.slug_bitbucket(repo_url) unless slug
-      slug = self.slug_fallback(repo_url) unless slug
+      slug ||= self.slug_http(repo_url)
+      slug ||= self.slug_bitbucket(repo_url)
+      slug ||= self.slug_fallback(repo_url)
       return slug.gsub(/\.git$/, "") unless slug.nil?
     end
 
     def self.slug_bitbucket(repo_url)
-      repo_matches = repo_url.match(%r{(?:[\/:])projects\/([^\/.]+)\/repos\/([^\/.]+)})
+      repo_matches = repo_url.match(%r{(?:[/:])projects/([^/.]+)/repos/([^/.]+)})
       return "#{repo_matches[1]}/#{repo_matches[2]}" if repo_matches
     end
 
     def self.slug_ssh(repo_url)
-      repo_matches = repo_url.match(%r{^git@.+:(.+)})
+      repo_matches = repo_url.match(/^git@.+:(.+)/)
       return repo_matches[1] if repo_matches
     end
 
     def self.slug_http(repo_url)
-      repo_matches = repo_url.match(%r{^https?.+(?>\.\w*\d*\/)(.+.git$)})
+      repo_matches = repo_url.match(%r{^https?.+(?>\.\w*\d*/)(.+.git$)})
       return repo_matches[1] if repo_matches
     end
 
     def self.slug_fallback(repo_url)
-      repo_matches = repo_url.match(%r{([\/:])([^\/]+\/[^\/]+)$})
+      repo_matches = repo_url.match(%r{([/:])([^/]+/[^/]+)$})
       return repo_matches[2]
     end
 
@@ -129,14 +128,14 @@ module Danger
       elsif env["CHANGE_URL"]
         change_url = env["CHANGE_URL"]
         case change_url
-        when %r{\/pull\/} # GitHub
-          matches = change_url.match(%r{(.+)\/pull\/[0-9]+})
+        when %r{/pull/} # GitHub
+          matches = change_url.match(%r{(.+)/pull/[0-9]+})
           matches[1] unless matches.nil?
-        when %r{\/merge_requests\/} # GitLab
-          matches = change_url.match(%r{(.+?)(\/-)?\/merge_requests\/[0-9]+})
+        when %r{/merge_requests/} # GitLab
+          matches = change_url.match(%r{(.+?)(/-)?/merge_requests/[0-9]+})
           matches[1] unless matches.nil?
-        when %r{\/pull-requests\/} # Bitbucket
-          matches = change_url.match(%r{(.+)\/pull-requests\/[0-9]+})
+        when %r{/pull-requests/} # Bitbucket
+          matches = change_url.match(%r{(.+)/pull-requests/[0-9]+})
           matches[1] unless matches.nil?
         else
           change_url

data/lib/danger/ci_source/local_git_repo.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # For more info see: https://github.com/schacon/ruby-git
 
 require "git"
@@ -34,7 +35,12 @@ module Danger
     end
 
     def supported_request_sources
-      @supported_request_sources ||= [Danger::RequestSources::GitHub, Danger::RequestSources::BitbucketServer, Danger::RequestSources::BitbucketCloud]
+      @supported_request_sources ||= [
+        Danger::RequestSources::GitHub,
+        Danger::RequestSources::BitbucketServer,
+        Danger::RequestSources::BitbucketCloud,
+        Danger::RequestSources::VSTS
+      ]
     end
 
     def initialize(env = {})

data/lib/danger/ci_source/local_only_git_repo.rb

@@ -11,6 +11,7 @@ module Danger
   #
   class LocalOnlyGitRepo < CI
     attr_accessor :base_commit, :head_commit
+
     HEAD_VAR = "DANGER_LOCAL_HEAD"
     BASE_VAR = "DANGER_LOCAL_BASE"
 

data/lib/danger/ci_source/support/find_repo_info_from_url.rb

@@ -4,19 +4,20 @@ module Danger
   class FindRepoInfoFromURL
     REGEXP = %r{
       ://[^/]+/
-      (?<slug>[^/]+(/[^/]+){1,2})
-      (/(pull|merge_requests|pull-requests)/)
+      (([^/]+/){1,2}_git/)?
+      (?<slug>[^/]+(/[^/]+){0,2})
+      (/(pull|pullrequest|merge_requests|pull-requests)/)
       (?<id>\d+)
-    }x
-    
+    }x.freeze
+
     # Regex used to extract info from Bitbucket server URLs, as they use a quite different format
     REGEXPBB = %r{
-      (?:[\/:])projects
-      \/([^\/.]+)
-      \/repos\/([^\/.]+)
-      \/pull-requests
-      \/(\d+)
-    }x
+      (?:[/:])projects
+      /([^/.]+)
+      /repos/([^/.]+)
+      /pull-requests
+      /(\d+)
+    }x.freeze
 
     def initialize(url)
       @url = url

data/lib/danger/ci_source/support/pull_request_finder.rb

@@ -28,7 +28,7 @@ module Danger
       ["true", "1", "yes", "y", true].include?(maybe_string)
     end
 
-    def raise_pull_request_not_found!(pull_request)
+    def raise_pull_request_not_found!(_pull_request)
       if specific_pull_request_id.empty?
         raise "No recent Pull Requests found for this repo, danger requires at least one Pull Request for the local mode."
       else
@@ -81,6 +81,12 @@ module Danger
           remote_pull_request.head.sha,
           remote_pull_request.base.sha
         )
+      when :vsts
+        RemotePullRequest.new(
+          remote_pull_request[:pullRequestId].to_s,
+          remote_pull_request[:lastMergeSourceCommit][:commitId],
+          remote_pull_request[:lastMergeTargetCommit][:commitId]
+        )
       else
         raise "SCM provider not supported: #{scm_provider}"
       end
@@ -96,16 +102,12 @@ module Danger
 
     # @return [String] Log line of format: "Merge pull request #42"
     def most_recent_merged_pull_request
-      @most_recent_merged_pull_request ||= begin
-        git_logs.lines.grep(/Merge pull request #{pull_request_ref} from/)[0]
-      end
+      @most_recent_merged_pull_request ||= git_logs.lines.grep(/Merge pull request #{pull_request_ref} from/)[0]
     end
 
     # @return [String] Log line of format: "description (#42)"
     def most_recent_squash_and_merged_pull_request
-      @most_recent_squash_and_merged_pull_request ||= begin
-        git_logs.lines.grep(/\(#{pull_request_ref}\)/)[0]
-      end
+      @most_recent_squash_and_merged_pull_request ||= git_logs.lines.grep(/\(#{pull_request_ref}\)/)[0]
     end
 
     def pick_the_most_recent_one_from_two_matches
@@ -144,6 +146,10 @@ module Danger
         require "danger/request_sources/bitbucket_server_api"
         project, slug = repo_slug.split("/")
         RequestSources::BitbucketServerAPI.new(project, slug, specific_pull_request_id, env)
+      
+      when :vsts
+        require "danger/request_sources/vsts_api"
+        RequestSources::VSTSAPI.new(repo_slug, specific_pull_request_id, env)
 
       when :github
         require "octokit"
@@ -174,6 +180,8 @@ module Danger
         :bitbucket_cloud
       elsif remote_url =~ %r{/pull-requests/}
         :bitbucket_server
+      elsif remote_url =~ /\.visualstudio\.com/i || remote_url =~ /dev\.azure\.com/i
+        :vsts 
       else
         :github
       end