danger 9.0.0 → 9.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 613bfd46794c42423189f27277eb745250ebae6a3bed733c9ba499d7507c1671
-  data.tar.gz: 309007d0119085c78e8a18dec65d5fe8f2c46d67a9267b8e7ddd7fe8f284e31a
+  metadata.gz: 8fc4bd35f1d805c6e3ef5b0467cd59281f0251c10b0580ebb138002e3b370e62
+  data.tar.gz: 29df2722f598ead34bee294304b60b3f6343c6147cce87054772aac2b40f1f2b
 SHA512:
-  metadata.gz: d934930d7677f61ec2c549c2418396f6bbb8c625fd1bc03f51952d9b5a6c4384b0e6a72fa496a0296bc1c6a524dbef8712f0bf73bbc25ff11897889896b928e4
-  data.tar.gz: c6d450cf48ed09ca021849ff8166e102bc85ab970cefa3a715f5047e807b9f6dc8b2eaa3aa59b0e965e31efbde97b70d3b5efcc9cf5ddb50b51789b1385de25f
+  metadata.gz: 304581c49ae31baa62f135883e006536e993a824a6cea8a920a37d58b232ea3118eccf773ffc760281c8a49b70446b51b955c952379e9d41e12e9d9e9842a4d7
+  data.tar.gz: d68b392bcb4075b852cc988fdaa3e9e2fd3df080417dd31d1cb314bf9ec1a4f3af5fdf759f7f106e5071b60e48ae4affb78750ae58a43ecadb94d533d9e80d83

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2019-present Orta, Felix Krause
+Copyright (c) 2015-present Orta, Felix Krause
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/lib/danger/ci_source/appcircle.rb

@@ -0,0 +1,83 @@
+# https://docs.appcircle.io/environment-variables/managing-variables
+# https://docs.appcircle.io/build/build-profile-configuration#environment-variables-configuration
+require "danger/request_sources/github/github"
+require "danger/request_sources/gitlab"
+module Danger
+    # ### CI Setup
+    #
+    # Add a Custom Script step to your workflow and set it as a bash:
+    #
+    # ```shell
+    #   cd $AC_REPOSITORY_DIR  
+    #   bundle install
+    #   bundle exec danger
+    # ```
+    # ### Token Setup
+    #
+    # Login to Appcircle and select your build profile. Go to your *Config* and
+    # choose *Environment Variables*.
+    # https://docs.appcircle.io/environment-variables/managing-variables
+    #
+    # #### GitHub
+    # Add the `DANGER_GITHUB_API_TOKEN` to your profile's ENV.
+    #
+    # #### GitLab
+    # Add the `DANGER_GITLAB_API_TOKEN` to your profile's ENV.
+    #
+    # #### Bitbucket Cloud
+    # Add the `DANGER_BITBUCKETSERVER_USERNAME`, `DANGER_BITBUCKETSERVER_PASSWORD`
+    # to your profile's ENV.
+    #
+    # #### Bitbucket server
+    # Add the `DANGER_BITBUCKETSERVER_USERNAME`, `DANGER_BITBUCKETSERVER_PASSWORD`
+    # and `DANGER_BITBUCKETSERVER_HOST` to your profile's ENV.
+    #
+    class Appcircle < CI
+        def self.validates_as_ci?(env)
+        env.key? "AC_APPCIRCLE"
+      end
+  
+      def self.validates_as_pr?(env)
+        return false unless env.key? "AC_PULL_NUMBER"
+        env["AC_PULL_NUMBER"].to_i > 0
+      end
+
+      def supported_request_sources
+        @supported_request_sources ||= [
+          Danger::RequestSources::GitHub,
+          Danger::RequestSources::BitbucketCloud,
+          Danger::RequestSources::BitbucketServer,
+          Danger::RequestSources::GitLab
+        ]
+      end
+
+      def initialize(env)
+        self.pull_request_id = env["AC_PULL_NUMBER"]
+        self.repo_url = env["AC_GIT_URL"]
+        self.repo_slug = repo_slug_from(self.repo_url)
+      end
+  
+      def repo_slug_from(url)
+        if url =~ URI::regexp
+          # Try to parse the URL as a valid URI. This should cover the cases of http/https/ssh URLs.
+          begin
+            uri = URI.parse(url)
+            return uri.path.sub(/^(\/)/,'').sub(/(.git)$/,'')
+          rescue URI::InvalidURIError
+            # In case URL could not be parsed fallback to git URL parsing.
+            repo_slug_asgiturl(url)
+          end
+        else
+          # In case URL could not be parsed fallback to git URL parsing. git@github.com:organization/repo.git
+          repo_slug_asgiturl(url)
+        end
+      end
+  
+      def repo_slug_asgiturl(url)
+        matcher_url = url
+        repo_matches = matcher_url.match(%r{([\/:])(([^\/]+\/)+[^\/]+?)(\.git$|$)})[2]
+        return repo_matches unless repo_matches.nil?
+      end
+    end
+  end
+  

data/lib/danger/ci_source/bitrise.rb

@@ -19,13 +19,13 @@ module Danger
   #
   # Add the `DANGER_GITHUB_API_TOKEN` to your workflow's [Secret App Env Vars](https://blog.bitrise.io/anyone-even-prs-can-have-secrets).
   #
-  # ### bitbucket server and bitrsie
+  # ### bitbucket server and bitrise
   #
-  # Danger will read the environment variable GIT_REPOSITORY_URL to construct the Bitbucket Server API URL 
-  # finding the project and repo slug in the GIT_REPOSITORY_URL variable. This GIT_REPOSITORY_URL variable 
-  # comes from the App Settings tab for your Bitrsie App. If you are manually setting a repo URL in the 
-  # Git Clone Repo step, you may need to set adjust this propery in the settings tab, maybe even fake it.
-  # The patterns used are `(%r{\.com/(.*)})` and `(%r{\.com:(.*)})` and .split(/\.git$|$/) to remove ".git" if the URL contains it.  
+  # Danger will read the environment variable GIT_REPOSITORY_URL to construct the Bitbucket Server API URL
+  # finding the project and repo slug in the GIT_REPOSITORY_URL variable. This GIT_REPOSITORY_URL variable
+  # comes from the App Settings tab for your Bitrise App. If you are manually setting a repo URL in the
+  # Git Clone Repo step, you may need to set adjust this property in the settings tab, maybe even fake it.
+  # The patterns used are `(%r{\.com/(.*)})` and `(%r{\.com:(.*)})` and .split(/\.git$|$/) to remove ".git" if the URL contains it.
   #
   class Bitrise < CI
     def self.validates_as_ci?(env)
@@ -48,7 +48,7 @@ module Danger
     def initialize(env)
       self.pull_request_id = env["BITRISE_PULL_REQUEST"]
       self.repo_url = env["GIT_REPOSITORY_URL"]
-      
+
       matcher_url = self.repo_url
       self.repo_slug = repo_slug_from(self.repo_url)
     end

data/lib/danger/ci_source/circle.rb

@@ -31,7 +31,7 @@ module Danger
   # to retrieve PR metadata, which will require an API token.
   #
   # 1. Go to your project > Settings > API Permissions. Create a token with scope "view-builds" and a label like "DANGER_CIRCLE_CI_API_TOKEN".
-  # 2. Settings > Environement Variables. Add the token as a CircleCI environment variable, which exposes it to the Danger process.
+  # 2. Settings > Environment Variables. Add the token as a CircleCI environment variable, which exposes it to the Danger process.
   #
   # There is no difference here for OSS vs Closed, both scenarios will need this environment variable.
   #

data/lib/danger/ci_source/gitlab_ci.rb

@@ -48,7 +48,7 @@ module Danger
 
       client_version = Gem::Version.new(client.version.version)
       if (client_version >= Gem::Version.new("10.7"))
-        #Use the 'list merge requests associated with a commit' API, for speeed
+        #Use the 'list merge requests associated with a commit' API, for speed
         # (GET /projects/:id/repository/commits/:sha/merge_requests) available for GitLab >= 10.7
         merge_request = client.commit_merge_requests(project_path, base_commit, state: :opened).first
         if (client_version >= Gem::Version.new("13.8"))

data/lib/danger/ci_source/jenkins.rb

@@ -31,7 +31,7 @@ module Danger
   #
   # #### General
   #
-  # People occasionally see issues with Danger not classing your CI runs as a PR, to give you visibilty
+  # People occasionally see issues with Danger not classing your CI runs as a PR, to give you visibility
   # the Jenkins side of Danger expects to see one of these env vars:
   # - ghprbPullId
   # - CHANGE_ID

data/lib/danger/comment_generators/gitlab_inline.md.erb

@@ -17,5 +17,5 @@
 <%= current %>
 <%# the previous line has to be aligned far to the left, otherwise markdown can break easily %>
 <%- end -%>
-<%# Add the generated_by_ as a html coment to identify comments from danger. %>
+<%# Add the generated_by_ as a html comment to identify comments from danger. %>
 <!-- "generated_by_<%= @danger_id %>" -->

data/lib/danger/danger_core/dangerfile.rb

@@ -308,7 +308,7 @@ module Danger
     private
 
     def eval_file(contents, path)
-      eval(contents, nil, path.to_s) # rubocop:disable Eval
+      eval(contents, nil, path.to_s) # rubocop:disable Security/Eval
     end
 
     def print_list(title, rows)

data/lib/danger/danger_core/plugins/dangerfile_local_only_plugin.rb

@@ -3,7 +3,7 @@ require "danger/plugin_support/plugin"
 # Danger
 module Danger
   # Handles interacting with local only plugin inside a Dangerfile.
-  # It is support pluggin for dry_run command and does not expose any methods.
+  # It is support plugin for dry_run command and does not expose any methods.
   # But you can still use other plugins like git
   #
   # @example Check that added lines contains agreed form of words 

data/lib/danger/request_sources/vsts_api.rb

@@ -28,9 +28,9 @@ module Danger
 
       def supports_comments?
         major_version = @api_version.split(".").first.to_i
-        minimun_version_for_comments = self.min_api_version_for_comments.split(".").first.to_i
+        minimum_version_for_comments = self.min_api_version_for_comments.split(".").first.to_i
 
-        major_version >= minimun_version_for_comments
+        major_version >= minimum_version_for_comments
       end
 
       def inspect

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "9.0.0".freeze
+  VERSION = "9.1.0".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 9.0.0
+  version: 9.1.0
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-09-02 00:00:00.000000000 Z
+date: 2022-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -206,6 +206,7 @@ files:
 - lib/assets/DangerfileTemplate
 - lib/danger.rb
 - lib/danger/ci_source/appcenter.rb
+- lib/danger/ci_source/appcircle.rb
 - lib/danger/ci_source/appveyor.rb
 - lib/danger/ci_source/azure_pipelines.rb
 - lib/danger/ci_source/bamboo.rb
@@ -343,7 +344,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubyforge_project: 
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.