danger 6.0.9 → 6.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49be83df41a5740ffb6d220476f14f204c1e61cc9b270179dc4c3cd1176bb6aa
-  data.tar.gz: b6b201a266feca22443d3e92953c9c0096ec7b29ac637c226e5ed4647d06ca64
+  metadata.gz: 3c67b44470cd2e591a3308ff21397f02ca56c39df0777856bdb124336b8f34d8
+  data.tar.gz: cb10a0fbe36d92be5346930a12dda0d20f33d093968a8bc60e821894752fe4e2
 SHA512:
-  metadata.gz: fecbd4258d3d092df13adcbe30770bdda38524b9f1f059c96e49579042c2654b4bf0fb7404577247367b94e9d7882726889c4a55351bf229d9f3248737c7a27c
-  data.tar.gz: 0ce55dd966931a22c7940d44e302bbcbda8aa315d36178a87fb33313e6b89660c93f44de100d96eb06b00d3be54acd33aaed2ede0cf03dbe9d7d6abeae2a35ba
+  metadata.gz: 636bd57417f223be9410e682d687eb109a93de82c2836884cc30d378261545f8c3ab1da15c278a893ffd2fcbf024bfadb4ad13f57d15c07bfd9386ac6ede8d59
+  data.tar.gz: 95bd7f1b50c46cb8d62033e72d75c7aab04161590d244ab539c6e96879961f337f165ac9c061514c0c7596812c0d12578d06cb870aac123afc930114cb7e9b38

data/lib/danger/ci_source/azure_pipelines.rb

@@ -0,0 +1,44 @@
+# https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables
+require "uri"
+require "danger/request_sources/github/github"
+
+module Danger
+  # ### CI Setup
+  #
+  # Add a script step:
+  #
+  # ``` shell
+  #   #!/usr/bin/env bash
+  #   bundle install
+  #   bundle exec danger
+  # ```
+  #
+  # ### Token Setup
+  #
+  # Add the `DANGER_GITHUB_API_TOKEN` to your environment variables.
+  #
+  class AzurePipelines < CI
+    def self.validates_as_ci?(env)
+      env.key? "AGENT_ID"
+    end
+
+    def self.validates_as_pr?(env)
+      return env["BUILD_REASON"] == "PullRequest"
+    end
+
+    def supported_request_sources
+      @supported_request_sources ||= [
+        Danger::RequestSources::GitHub,
+        Danger::RequestSources::GitLab,
+        Danger::RequestSources::BitbucketServer,
+        Danger::RequestSources::BitbucketCloud
+      ]
+    end
+
+    def initialize(env)
+      self.pull_request_id = env["SYSTEM_PULLREQUEST_PULLREQUESTID"]
+      self.repo_url = env["BUILD_REPOSITORY_URI"]
+      self.repo_slug = env["BUILD_REPOSITORY_NAME"]
+    end
+  end
+end

data/lib/danger/ci_source/circle_api.rb

@@ -35,7 +35,7 @@ module Danger
     def fetch_pull_request_url(repo_slug, build_number, token)
       build_json = fetch_build(repo_slug, build_number, token)
       pull_requests = build_json[:pull_requests]
-      return nil unless pull_requests.first
+      return nil unless pull_requests && pull_requests.first
       pull_requests.first[:url]
     end
 

data/lib/danger/ci_source/codefresh.rb

@@ -0,0 +1,53 @@
+# https://semaphoreci.com/docs/available-environment-variables.html
+require "danger/request_sources/github/github"
+
+module Danger
+  #  ### CI Setup
+  #
+  #  To set up Danger on Codefresh, create a freestyle step in your Codefresh yaml configuration:
+  #
+  #  ```yml
+  #  Danger:
+  #    title: Run Danger
+  #    image: alpine/bundle
+  #    working_directory: ${{main_clone}}
+  #    commands:
+  #      - bundle install --deployment
+  #      - bundle exec danger --verbose
+  #  ```
+  #
+  #  Don't forget to add the `DANGER_GITHUB_API_TOKEN` variable to your pipeline settings so that Danger can properly post comments to your pull request.
+  #
+  class Codefresh < CI
+    def self.validates_as_ci?(env)
+      env.key?("CF_BUILD_ID") && env.key?("CF_BUILD_URL")
+    end
+
+    def self.validates_as_pr?(env)
+      return !env["CF_PULL_REQUEST_NUMBER"].to_s.empty?
+    end
+
+    def supported_request_sources
+      @supported_request_sources ||= [Danger::RequestSources::GitHub]
+    end
+
+    def repo_slug
+      return "" if @env["CF_REPO_OWNER"].to_s.empty?
+      return "" if @env["CF_REPO_NAME"].to_s.empty?
+      "#{@env['CF_REPO_OWNER']}/#{@env['CF_REPO_NAME']}".downcase!
+    end
+
+    def repo_url
+      return "" if @env["CF_COMMIT_URL"].to_s.empty?
+      @env["CF_COMMIT_URL"].gsub(/\/commit.+$/, "")
+    end
+
+    def pull_request_id
+      @env["CF_PULL_REQUEST_NUMBER"]
+    end
+
+    def initialize(env)
+      @env = env
+    end
+  end
+end

data/lib/danger/ci_source/vsts.rb

@@ -4,7 +4,7 @@ require "danger/request_sources/vsts"
 module Danger
   # ### CI Setup
   #
-  # You need to go to your project's build definiton. Then add a "Command Line" Task with the "Tool" field set to  "bundle"
+  # You need to go to your project's build definition. Then add a "Command Line" Task with the "Tool" field set to  "bundle"
   # and the "Arguments" field set to "exec danger".
   #
   # ### Token Setup

data/lib/danger/commands/dangerfile/init.rb

@@ -1,6 +1,6 @@
 require "danger/danger_core/dangerfile_generator"
 
-# Mainly so we can have a nice strucutre for commands
+# Mainly so we can have a nice structure for commands
 
 module Danger
   class DangerfileCommand < Runner

data/lib/danger/core_ext/file_list.rb

@@ -8,7 +8,9 @@ module Danger
     # e.g. "**/something.*" for any file called something with any extension
     def include?(pattern)
       self.each do |current|
-        return true if File.fnmatch(pattern, current) || pattern == current
+        unless current.nil?
+          return true if File.fnmatch(pattern, current) || pattern == current
+        end
       end
       return false
     end

data/lib/danger/danger_core/environment_manager.rb

@@ -3,7 +3,7 @@ require "danger/request_sources/request_source"
 
 module Danger
   class EnvironmentManager
-    attr_accessor :ci_source, :request_source, :scm, :ui
+    attr_accessor :ci_source, :request_source, :scm, :ui, :danger_id
 
     # Finds a Danger::CI class based on the ENV
     def self.local_ci_source(env)
@@ -25,10 +25,11 @@ module Danger
       "danger_base".freeze
     end
 
-    def initialize(env, ui = nil)
+    def initialize(env, ui = nil, danger_id = "danger")
       ci_klass = self.class.local_ci_source(env)
       self.ci_source = ci_klass.new(env)
       self.ui = ui || Cork::Board.new(silent: false, verbose: false)
+      self.danger_id = danger_id
 
       RequestSources::RequestSource.available_request_sources.each do |klass|
         next unless self.ci_source.supports?(klass)

data/lib/danger/danger_core/executor.rb

@@ -21,8 +21,8 @@ module Danger
       # Run some validations
       validate!(cork, fail_if_no_pr: fail_if_no_pr)
 
-      # OK, we now know that Danger can run in this enviroment
-      env ||= EnvironmentManager.new(system_env, cork)
+      # OK, we now know that Danger can run in this environment
+      env ||= EnvironmentManager.new(system_env, cork, danger_id)
       dm ||= Dangerfile.new(env, cork)
 
       ran_status = begin

data/lib/danger/danger_core/plugins/dangerfile_bitbucket_server_plugin.rb

@@ -169,6 +169,20 @@ module Danger
     def markdown_link(paths, full_path: true)
       create_link(paths, full_path) { |href, text| create_markdown_link(href, text) }
     end
+    
+    # @!group Bitbucket Server Misc
+    # Updates the PR with build status and build server job link.
+    # @param    [String] status
+    #           SUCCESSFUL, FAILED and INPROGRESS
+    # @param    [String] build_job_link
+    #           Build server job link
+    # @param    [String] description
+    #           Build status description
+    # @return   [String]
+    #
+    def update_pr_build_status(status, build_job_link, description)
+        @bs.update_pr_build_status(status, build_job_link, description)
+    end
 
     private
 

data/lib/danger/danger_core/plugins/dangerfile_danger_plugin.rb

@@ -2,7 +2,7 @@ require "danger/plugin_support/plugin"
 
 module Danger
   # A way to interact with Danger herself. Offering APIs to import plugins,
-  # and Dangerfiles from muliple sources.
+  # and Dangerfiles from multiple sources.
   #
   # @example Import a plugin available over HTTP
   #
@@ -27,7 +27,7 @@ module Danger
   #
   # @example Run a Dangerfile from inside a repo
   #
-  #          danger.import_dangerfile(gitlab: "ruby-grape/danger")
+  #          danger.import_dangerfile(gitlab_project_id: 1345)
   #
   # @example Run a Dangerfile from inside a repo branch and path
   #
@@ -85,10 +85,10 @@ module Danger
         elsif opts.key?(:gem)
           import_dangerfile_from_gem(opts[:gem])
         else
-          raise "`import` requires a Hash with either :github or :gem"
+          raise "`import` requires a Hash with either :github, :gitlab, :gem, or :path"
         end
       else
-        raise "`import` requires a Hash" unless opts.kind_of?(Hash)
+        raise "`import` requires a Hash"
       end
     end
 

data/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb

@@ -53,6 +53,19 @@ module Danger
   #
   #         warn "#{gitlab.html_link("Package.json")} was edited." if git.modified_files.include? "Package.json"
   #
+  # @example Select a random group member as assignee if no assignee is selected
+  #
+  #         if gitlab.mr_json["assignee"].nil?
+  #           reviewer = gitlab.api.group_members(gitlab.api.merge_request_approvals(project_id, mr_id).to_hash["approver_groups"].first["group"]["id"]).sample
+  #           if gitlab.api.group_members(gitlab.api.merge_request_approvals(project_id, mr_id).to_hash["approver_groups"].first["group"]["id"]).length > 1
+  #             while reviewer.to_hash["id"] == gitlab.mr_json["author"]["id"] do
+  #               reviewer = gitlab.api.group_members(gitlab.api.merge_request_approvals(project_id, mr_id).to_hash["approver_groups"].first["group"]["id"]).sample
+  #             end
+  #           end
+  #           message "Reviewer roulete rolled for: #{reviewer.to_hash['name']} (@#{reviewer.to_hash['username']})"
+  #           gitlab.api.update_merge_request(project_id, mr_id, { assignee_id: reviewer.to_hash["id"] })
+  #         end
+  # 
   #
   # @see  danger/danger
   # @tags core, gitlab

data/lib/danger/danger_core/plugins/dangerfile_messaging_plugin.rb

@@ -34,7 +34,7 @@ module Danger
   # @example Failing a build
   #
   #          failure "This build didn't pass tests"
-  #          failure "Ooops!", "Something bad happend"
+  #          failure "Ooops!", "Something bad happened"
   #          failure ["This is example", "with array"]
   #
   # @example Failing a build, and note that on subsequent runs

data/lib/danger/helpers/comments_helper.rb

@@ -34,7 +34,7 @@ module Danger
       # request_source implementations are invited to override this method.
       # This is mostly here to enable sources to detect when inlines change only in their
       # commit hash and not in content per-se. since the link is implementation dependant
-      # so should be the comparision.
+      # so should be the comparison.
       #
       # @param [Violation or Markdown] m1
       # @param [Violation or Markdown] m2

data/lib/danger/plugin_support/plugin_parser.rb

@@ -56,7 +56,7 @@ module Danger
 
       # Add some of our custom tags
       YARD::Tags::Library.define_tag('tags', :tags)
-      YARD::Tags::Library.define_tag('availablity', :availablity)
+      YARD::Tags::Library.define_tag('availability', :availability)
     end
 
     def parse

data/lib/danger/request_sources/bitbucket_cloud_api.rb

@@ -45,13 +45,17 @@ module Danger
       end
 
       def delete_comment(id)
-        uri = URI("#{pr_api_endpoint_v1}/comments/#{id}")
+        uri = URI("#{pr_api_endpoint}/comments/#{id}")
         delete(uri)
       end
 
       def post_comment(text)
-        uri = URI("#{pr_api_endpoint_v1}/comments")
-        body = { content: text }.to_json
+        uri = URI("#{pr_api_endpoint}/comments")
+        body = {
+          content: { 
+            raw: text
+          }
+        }.to_json
         post(uri, body)
       end
 
@@ -65,10 +69,6 @@ module Danger
         "#{base_url(2)}/#{pull_request_id}"
       end
 
-      def pr_api_endpoint_v1
-        "#{base_url(1)}/#{pull_request_id}"
-      end
-
       def prs_api_endpoint(branch_name)
         "#{base_url(2)}?q=source.branch.name=\"#{branch_name}\""
       end

data/lib/danger/request_sources/bitbucket_server.rb

@@ -91,6 +91,15 @@ module Danger
           @api.delete_comment(c[:id], c[:version]) if c[:text] =~ /generated_by_#{danger_id}/
         end
       end
+        
+      def update_pr_build_status(status, build_job_link, description)
+        changeset = self.pr_json[:fromRef][:latestCommit]
+        # Support for older versions of Bitbucket Server
+        changeset = self.pr_json[:fromRef][:latestChangeset] if self.pr_json[:fromRef].key? :latestChangeset
+        puts "Changeset: " + changeset
+        puts self.pr_json.to_json
+        @api.update_pr_build_status(status, changeset, build_job_link, description)
+      end
     end
   end
 end

data/lib/danger/request_sources/bitbucket_server_api.rb

@@ -5,7 +5,7 @@ require "danger/helpers/comments_helper"
 module Danger
   module RequestSources
     class BitbucketServerAPI
-      attr_accessor :host, :pr_api_endpoint
+      attr_accessor :host, :pr_api_endpoint, :key, :project
 
       def initialize(project, slug, pull_request_id, environment)
         @username = environment["DANGER_BITBUCKETSERVER_USERNAME"]
@@ -14,6 +14,8 @@ module Danger
         if self.host && !(self.host.include? "http://") && !(self.host.include? "https://")
           self.host = "https://" + self.host
         end
+        self.key = slug
+        self.project = project
         self.pr_api_endpoint = "#{host}/rest/api/1.0/projects/#{project}/repos/#{slug}/pull-requests/#{pull_request_id}"
       end
 
@@ -55,6 +57,12 @@ module Danger
         body = { text: text }.to_json
         post(uri, body)
       end
+        
+      def update_pr_build_status(status, changeset, build_job_link, description)
+         uri = URI("#{self.host}/rest/build-status/1.0/commits/#{changeset}")
+         body = build_status_body(status, build_job_link, description)
+         post(uri, body)
+      end
 
       private
 
@@ -95,6 +103,15 @@ module Danger
           http.request(req)
         end
       end
+        
+      def build_status_body(status, build_job_link, description)
+          body = Hash.new
+          body["state"] = status
+          body["key"] = self.key
+          body["url"] = build_job_link
+          body["description"] = description if description
+          return body.to_json
+      end
     end
   end
 end

data/lib/danger/request_sources/github/github.rb

@@ -276,7 +276,7 @@ module Danger
           else
             # We remove non-sticky violations that have no replies
             # Since there's no direct concept of a reply in GH, we simply consider
-            # the existance of non-danger comments in that line as replies
+            # the existence of non-danger comments in that line as replies
             replies = non_danger_comments.select do |potential|
               potential["path"] == comment["path"] &&
                 potential["position"] == comment["position"] &&

data/lib/danger/request_sources/gitlab.rb

@@ -360,7 +360,7 @@ module Danger
           else
             # We remove non-sticky violations that have no replies
             # Since there's no direct concept of a reply in GH, we simply consider
-            # the existance of non-danger comments in that line as replies
+            # the existence of non-danger comments in that line as replies
             replies = non_danger_comments.select do |potential|
               potential["path"] == comment["path"] &&
                 potential["position"] == comment["position"] &&

data/lib/danger/request_sources/request_source.rb

@@ -76,6 +76,10 @@ module Danger
       def file_url(_organisation: nil, _repository: nil, _branch: "master", _path: nil)
         raise "Subclass and overwrite file_url"
       end
+      
+      def update_build_status(status)
+          raise "Subclass and overwrite update_build_status"
+      end
     end
   end
 end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "6.0.9".freeze
+  VERSION = "6.1.0".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 6.0.9
+  version: 6.1.0
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-23 00:00:00.000000000 Z
+date: 2019-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -195,6 +195,7 @@ files:
 - lib/danger.rb
 - lib/danger/ci_source/appcenter.rb
 - lib/danger/ci_source/appveyor.rb
+- lib/danger/ci_source/azure_pipelines.rb
 - lib/danger/ci_source/bitbucket_pipelines.rb
 - lib/danger/ci_source/bitrise.rb
 - lib/danger/ci_source/buddybuild.rb
@@ -204,6 +205,7 @@ files:
 - lib/danger/ci_source/circle_api.rb
 - lib/danger/ci_source/cirrus.rb
 - lib/danger/ci_source/code_build.rb
+- lib/danger/ci_source/codefresh.rb
 - lib/danger/ci_source/codeship.rb
 - lib/danger/ci_source/dotci.rb
 - lib/danger/ci_source/drone.rb