danger 5.6.7 → 5.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: eca39151f7232a27b7fc9f54c06dc434d475bd85
-  data.tar.gz: 6d135a5b57185143b620273b0f3c39a40e502b51
+SHA256:
+  metadata.gz: 56b7ad82d2578dafbf08ae9fec98faecb44d8d7e2ee810745618aac4498b6cf2
+  data.tar.gz: 973bdc8b5c6ea1c9ebecd968f298bd17939808d42969eedbe59cff1eae5fe086
 SHA512:
-  metadata.gz: 3810e8b529e8b0caa024baa621f9c1539a88364d36ff430c1dc884c6f9053141fb807a1bc6858d6d2bef98c48e9ab87334f4f3da7b25b330946d7b3fd0e6aee1
-  data.tar.gz: b5b5624c645635af6656598c98a70e250db02e6fd2c5316e22aeb3e15da292e317782f04995106048feeb48e8cd0ab15156df8bfcdad4827e3e495ac1369ce57
+  metadata.gz: 71671463fd995498764dff063365285a969decc1243406b5aeb008ffefe7e5b0173fdb6290e4e4dace391713c0d962ecc82cd2c07e1d87909c732b31bbaaf1dc
+  data.tar.gz: a33754d7365b25988126056d008ba4de240c5a42204c22fbb1b322f3242b1b99b265dd98bd6c9ba96f16db298335bb1ec974f9323b0ef4e903676218583298fe

data/README.md

@@ -24,7 +24,7 @@ Danger runs after your CI, automating your team's conventions surrounding code r
 
 This provides another logical step in your process, through this Danger can help lint your rote tasks in daily code review.
 
-You can use Danger to codify your teams norms, leaving humans to think about harder problems.
+You can use Danger to codify your team's norms, leaving humans to think about harder problems.
 
 ## For example?
 

data/lib/danger/ci_source/local_only_git_repo.rb

@@ -0,0 +1,47 @@
+require "git"
+require "danger/request_sources/local_only"
+
+module Danger
+  # ### CI Setup
+  #
+  # For setting up LocalOnlyGitRepo there is not much needed. Either `--base` and `--head` need to be specified or
+  # origin/master is expected for base and HEAD for head
+  #
+  class LocalOnlyGitRepo < CI
+    attr_accessor :base_commit, :head_commit
+    HEAD_VAR = "DANGER_LOCAL_HEAD".freeze
+    BASE_VAR = "DANGER_LOCAL_BASE".freeze
+
+    def self.validates_as_ci?(env)
+      env.key? "DANGER_USE_LOCAL_ONLY_GIT"
+    end
+
+    def self.validates_as_pr?(_env)
+      false
+    end
+
+    def git
+      @git ||= GitRepo.new
+    end
+
+    def run_git(command)
+      git.exec(command).encode("UTF-8", "binary", invalid: :replace, undef: :replace, replace: "")
+    end
+
+    def supported_request_sources
+      @supported_request_sources ||= [Danger::RequestSources::LocalOnly]
+    end
+
+    def initialize(env = {})
+      @env = env
+
+      # expects --base/--head specified OR origin/master to be base and HEAD head
+      self.base_commit = env[BASE_VAR] || run_git("rev-parse --abbrev-ref origin/master")
+      self.head_commit = env[HEAD_VAR] || run_git("rev-parse --abbrev-ref HEAD")
+    end
+
+    private
+
+    attr_reader :env
+  end
+end

data/lib/danger/commands/dry_run.rb

@@ -0,0 +1,54 @@
+require "danger/commands/local_helpers/pry_setup"
+require "fileutils"
+
+module Danger
+  class DryRun < Runner
+    self.summary = "Dry-Run the Dangerfile locally, so you could check some violations before sending real PR/MR."
+    self.command = "dry_run"
+
+    def self.options
+      [
+        ["--pry", "Drop into a Pry shell after evaluating the Dangerfile."]
+      ]
+    end
+
+    def initialize(argv)
+      show_help = true if argv.arguments == ["-h"]
+
+      # Currently CLAide doesn't support short option like -h https://github.com/CocoaPods/CLAide/pull/60
+      # when user pass in -h, mimic the behavior of passing in --help.
+      argv = CLAide::ARGV.new ["--help"] if show_help
+
+      super
+
+      if argv.flag?("pry", false)
+        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path)
+      end
+    end
+
+    def validate!
+      super
+      unless @dangerfile_path
+        help! "Could not find a Dangerfile."
+      end
+    end
+
+    def run
+      ENV["DANGER_USE_LOCAL_ONLY_GIT"] = "YES"
+      ENV["DANGER_LOCAL_HEAD"] = @head if @head
+      ENV["DANGER_LOCAL_BASE"] = @base if @base
+
+      env = EnvironmentManager.new(ENV, cork)
+      dm = Dangerfile.new(env, cork)
+
+      exit 1 if dm.run(
+        Danger::EnvironmentManager.danger_base_branch,
+        Danger::EnvironmentManager.danger_head_branch,
+        @dangerfile_path,
+        nil,
+        nil,
+        nil
+      )
+    end
+  end
+end

data/lib/danger/commands/runner.rb

@@ -2,6 +2,7 @@ module Danger
   class Runner < CLAide::Command
     require "danger/commands/init"
     require "danger/commands/local"
+    require "danger/commands/dry_run"
     require "danger/commands/systems"
     require "danger/commands/pr"
 

data/lib/danger/danger_core/dangerfile.rb

@@ -11,6 +11,7 @@ require "danger/danger_core/plugins/dangerfile_gitlab_plugin"
 require "danger/danger_core/plugins/dangerfile_bitbucket_server_plugin"
 require "danger/danger_core/plugins/dangerfile_bitbucket_cloud_plugin"
 require "danger/danger_core/plugins/dangerfile_vsts_plugin"
+require "danger/danger_core/plugins/dangerfile_local_only_plugin"
 
 module Danger
   class Dangerfile
@@ -38,7 +39,7 @@ module Danger
 
     # The ones that everything would break without
     def self.essential_plugin_classes
-      [DangerfileMessagingPlugin, DangerfileGitPlugin, DangerfileDangerPlugin, DangerfileGitHubPlugin, DangerfileGitLabPlugin, DangerfileBitbucketServerPlugin, DangerfileBitbucketCloudPlugin, DangerfileVSTSPlugin]
+      [DangerfileMessagingPlugin, DangerfileGitPlugin, DangerfileDangerPlugin, DangerfileGitHubPlugin, DangerfileGitLabPlugin, DangerfileBitbucketServerPlugin, DangerfileBitbucketCloudPlugin, DangerfileVSTSPlugin, DangerfileLocalOnlyPlugin]
     end
 
     # Both of these methods exist on all objects

data/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb

@@ -148,7 +148,7 @@ module Danger
     # @return [String]
     #
     def base_commit
-      @gitlab.base_commit
+      @gitlab.mr_json.diff_refs.base_sha
     end
 
     # @!group MR Commit Metadata
@@ -156,7 +156,7 @@ module Danger
     # @return [String]
     #
     def head_commit
-      @gitlab.commits_json.first.id
+      @gitlab.mr_json.diff_refs.head_sha
     end
 
     # @!group GitLab Misc

data/lib/danger/danger_core/plugins/dangerfile_local_only_plugin.rb

@@ -0,0 +1,42 @@
+require "danger/plugin_support/plugin"
+
+# Danger
+module Danger
+  # Handles interacting with local only plugin inside a Dangerfile.
+  # It is support pluggin for dry_run command and does not expose any methods.
+  # But you can still use other plugins like git
+  #
+  # @example Check that added lines contains agreed form of words 
+  #
+  #       git.diff.each do |chunk|
+  #         chunk.patch.lines.grep(/^+/).each do |added_line|
+  #           if added_line.gsub!(/(?<cancel>cancel)(?<rest>[^l[[:space:]][[:punct:]]]+)/i, '>>\k<cancel>-l-\k<rest><<')
+  #             fail "Single 'L' for cancellation-alike words in '#{added_line}'" 
+  #           end
+  #         end
+  #       end
+  #
+  # @see  danger/danger
+  # @tags core, local_only
+  #
+  class DangerfileLocalOnlyPlugin < Plugin
+    # So that this init can fail.
+    def self.new(dangerfile)
+      return nil if dangerfile.env.request_source.class != Danger::RequestSources::LocalOnly
+      super
+    end
+
+    def initialize(dangerfile)
+      super(dangerfile)
+
+      @local_repo = dangerfile.env.request_source
+    end
+
+    # The instance name used in the Dangerfile
+    # @return [String]
+    #
+    def self.instance_name
+      "local_repo"
+    end
+  end
+end

data/lib/danger/request_sources/gitlab.rb

@@ -65,12 +65,7 @@ module Danger
       end
 
       def base_commit
-        if self.commits_json.last
-          first_commit_in_branch = self.commits_json.last.id
-          @base_commit ||= self.scm.exec "rev-parse #{first_commit_in_branch}^1"
-        else
-          @base_commit = ""
-        end
+        @base_commit ||= self.mr_json.diff_refs.base_sha
       end
 
       def mr_comments
@@ -89,11 +84,12 @@ module Danger
       end
 
       def setup_danger_branches
-        raise "Are you running `danger local/pr` against the correct repository? Also this can happen if you run danger on MR without changes" if base_commit.empty?
         base_branch = self.mr_json.source_branch
         head_branch = self.mr_json.target_branch
         head_commit = self.scm.head_commit
 
+        raise "Are you running `danger local/pr` against the correct repository? Also this can happen if you run danger on MR without changes" if base_commit == head_commit
+
         # Next, we want to ensure that we have a version of the current branch at a known location
         scm.ensure_commitish_exists_on_branch! base_branch, base_commit
         self.scm.exec "branch #{EnvironmentManager.danger_base_branch} #{base_commit}"
@@ -106,9 +102,6 @@ module Danger
 
       def fetch_details
         self.mr_json = client.merge_request(ci_source.repo_slug, self.ci_source.pull_request_id)
-        self.commits_json = client.merge_request_commits(
-          ci_source.repo_slug, self.ci_source.pull_request_id
-        ).auto_paginate
         self.ignored_violations = ignored_violations_from_pr
       end
 
@@ -172,6 +165,13 @@ module Danger
       def organisation
         nil # TODO: Implement this
       end
+
+      # @return [String] A URL to the specific file, ready to be downloaded
+      def file_url(organisation: nil, repository: nil, branch: nil, path: nil)
+        branch ||= 'master'
+
+        "https://#{host}/#{organisation}/#{repository}/raw/#{branch}/#{path}"
+      end
     end
   end
 end

data/lib/danger/request_sources/local_only.rb

@@ -0,0 +1,53 @@
+# coding: utf-8
+
+require "danger/helpers/comments_helper"
+require "danger/helpers/comment"
+
+module Danger
+  module RequestSources
+    class LocalOnly < RequestSource
+      include Danger::Helpers::CommentsHelper
+      attr_accessor :mr_json, :commits_json
+
+      def self.env_vars
+        ["DANGER_LOCAL_ONLY"]
+      end
+
+      def initialize(ci_source, environment)
+        self.ci_source = ci_source
+        self.environment = environment
+      end
+
+      def validates_as_ci?
+        true
+      end
+
+      def validates_as_api_source?
+        true
+      end
+
+      def scm
+        @scm ||= GitRepo.new
+      end
+
+      def setup_danger_branches
+        # Check that discovered values really exists
+        [ci_source.base_commit, ci_source.head_commit].each do |commit|
+          raise "Specified commit '#{commit}' not found" if scm.exec("rev-parse --quiet --verify #{commit}").empty?
+        end
+
+        self.scm.exec "branch #{EnvironmentManager.danger_base_branch} #{ci_source.base_commit}"
+        self.scm.exec "branch #{EnvironmentManager.danger_head_branch} #{ci_source.head_commit}"
+      end
+
+      def fetch_details; end
+
+      def update_pull_request!(_hash_needed); end
+
+      # @return [String] The organisation name, is nil if it can't be detected
+      def organisation
+        nil
+      end
+    end
+  end
+end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "5.6.7".freeze
+  VERSION = "5.7.0".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 5.6.7
+  version: 5.7.0
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-14 00:00:00.000000000 Z
+date: 2018-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -191,6 +191,7 @@ files:
 - lib/danger/ci_source/gitlab_ci.rb
 - lib/danger/ci_source/jenkins.rb
 - lib/danger/ci_source/local_git_repo.rb
+- lib/danger/ci_source/local_only_git_repo.rb
 - lib/danger/ci_source/screwdriver.rb
 - lib/danger/ci_source/semaphore.rb
 - lib/danger/ci_source/support/commits.rb
@@ -210,6 +211,7 @@ files:
 - lib/danger/clients/rubygems_client.rb
 - lib/danger/commands/dangerfile/gem.rb
 - lib/danger/commands/dangerfile/init.rb
+- lib/danger/commands/dry_run.rb
 - lib/danger/commands/init.rb
 - lib/danger/commands/init_helpers/interviewer.rb
 - lib/danger/commands/local.rb
@@ -242,6 +244,7 @@ files:
 - lib/danger/danger_core/plugins/dangerfile_git_plugin.rb
 - lib/danger/danger_core/plugins/dangerfile_github_plugin.rb
 - lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb
+- lib/danger/danger_core/plugins/dangerfile_local_only_plugin.rb
 - lib/danger/danger_core/plugins/dangerfile_messaging_plugin.rb
 - lib/danger/danger_core/plugins/dangerfile_vsts_plugin.rb
 - lib/danger/danger_core/standard_error.rb
@@ -266,6 +269,7 @@ files:
 - lib/danger/request_sources/github/github_review_resolver.rb
 - lib/danger/request_sources/github/github_review_unsupported.rb
 - lib/danger/request_sources/gitlab.rb
+- lib/danger/request_sources/local_only.rb
 - lib/danger/request_sources/request_source.rb
 - lib/danger/request_sources/support/get_ignored_violation.rb
 - lib/danger/request_sources/vsts.rb
@@ -292,7 +296,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.