danger 5.5.7 → 5.5.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ac631daf8aaea436429afb68d8a534b84b03c9a9
-  data.tar.gz: aed843fe3d16f9e09fa1b1b0dbb300e0cb33f958
+  metadata.gz: 337bfe88532b4d8aaa67f9c93deab2cf92e886e8
+  data.tar.gz: 37e0165d0efe4a723c95f04d8af35b7a19b12888
 SHA512:
-  metadata.gz: d84b21f613d955ebac96ad8561126d53eb6caff28959909d10d9061e4204a470714500e98674375db4a4e405173a788e64113ef31a994429164ec5b00e979a79
-  data.tar.gz: d80f497254260a8d6cc65e61c92b7a9ac0cf7b660cb94e7e4b7d82791a02c010ff78bc36a4c5bf3ecc0c42a587641f49e238af265e672072dd8bba293cfa4e77
+  metadata.gz: b458d47ed3012209f8ada90aaaa70342b4d7580420746cd51d5e0edebeec4d6d9895fe7e9783f24b2026d3d03ae0b571eab53e9503700573290d7bbbb3f29b10
+  data.tar.gz: d57f5833a0727e64acd73a111e6d37bcca0b2a578161788b1aba7080907b7711e3dde73b5ebb926f666a552e9d8c4470cea21f435bcf66b3b1b015a1718ebd84

data/lib/danger/commands/local.rb

@@ -58,6 +58,7 @@ module Danger
           Danger::EnvironmentManager.danger_head_branch,
           @dangerfile_path,
           nil,
+          nil,
           nil
         )
       end

data/lib/danger/commands/pr.rb

@@ -63,6 +63,7 @@ module Danger
           Danger::EnvironmentManager.danger_head_branch,
           @dangerfile_path,
           nil,
+          nil,
           nil
         )
       end

data/lib/danger/commands/runner.rb

@@ -38,6 +38,7 @@ module Danger
       @head = argv.option("head")
       @fail_on_errors = argv.option("fail-on-errors", false)
       @new_comment = argv.flag?("new-comment")
+      @remove_previous_comments = argv.flag?("remove-previous-comments")
       @danger_id = argv.option("danger_id", "danger")
       @cork = Cork::Board.new(silent: argv.option("silent", false),
                               verbose: argv.option("verbose", false))
@@ -58,7 +59,8 @@ module Danger
         ["--fail-on-errors=<true|false>", "Should always fail the build process, defaults to false"],
         ["--dangerfile=<path/to/dangerfile>", "The location of your Dangerfile"],
         ["--danger_id=<id>", "The identifier of this Danger instance"],
-        ["--new-comment", "Makes Danger post a new comment instead of editing its previous one"]
+        ["--new-comment", "Makes Danger post a new comment instead of editing its previous one"],
+        ["--remove-previous-comments", "Removes all previous comment and create a new one in the end of the list"]
       ].concat(super)
     end
 
@@ -69,7 +71,8 @@ module Danger
         dangerfile_path: @dangerfile_path,
         danger_id: @danger_id,
         new_comment: @new_comment,
-        fail_on_errors: @fail_on_errors
+        fail_on_errors: @fail_on_errors,
+        remove_previous_comments: @remove_previous_comments
       )
     end
   end

data/lib/danger/danger_core/dangerfile.rb

@@ -242,7 +242,7 @@ module Danger
       violation_report[:errors].count > 0
     end
 
-    def post_results(danger_id, new_comment)
+    def post_results(danger_id, new_comment, remove_previous_comments)
       violations = violation_report
 
       env.request_source.update_pull_request!(
@@ -251,7 +251,8 @@ module Danger
         messages: violations[:messages].uniq,
         markdowns: status_report[:markdowns].uniq,
         danger_id: danger_id,
-        new_comment: new_comment
+        new_comment: new_comment,
+        remove_previous_comments: remove_previous_comments
       )
     end
 
@@ -260,7 +261,7 @@ module Danger
       env.scm.diff_for_folder(".".freeze, from: base_branch, to: head_branch)
     end
 
-    def run(base_branch, head_branch, dangerfile_path, danger_id, new_comment)
+    def run(base_branch, head_branch, dangerfile_path, danger_id, new_comment, remove_previous_comments)
       # Setup internal state
       init_plugins
       env.fill_environment_vars
@@ -275,7 +276,7 @@ module Danger
         # Push results to the API
         # Pass along the details of the run to the request source
         # to send back to the code review site.
-        post_results(danger_id, new_comment) unless danger_id.nil?
+        post_results(danger_id, new_comment, remove_previous_comments) unless danger_id.nil?
 
         # Print results in the terminal
         print_results

data/lib/danger/danger_core/executor.rb

@@ -12,7 +12,8 @@ module Danger
             dangerfile_path: nil,
             danger_id: nil,
             new_comment: nil,
-            fail_on_errors: nil)
+            fail_on_errors: nil,
+            remove_previous_comments: nil)
       # Create a silent Cork instance if cork is nil, as it's likely a test
       cork ||= Cork::Board.new(silent: false, verbose: false)
 
@@ -29,7 +30,8 @@ module Danger
           head_branch(head),
           dangerfile_path,
           danger_id,
-          new_comment
+          new_comment,
+          remove_previous_comments
         )
       end
 

data/lib/danger/request_sources/bitbucket_cloud.rb

@@ -64,8 +64,8 @@ module Danger
         nil
       end
 
-      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false)
-        delete_old_comments(danger_id: danger_id) unless new_comment
+      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false, remove_previous_comments: false)
+        delete_old_comments(danger_id: danger_id) if !new_comment || remove_previous_comments
 
         comment = generate_description(warnings: warnings, errors: errors)
         comment += "\n\n"

data/lib/danger/request_sources/bitbucket_server.rb

@@ -70,8 +70,8 @@ module Danger
         nil
       end
 
-      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false)
-        delete_old_comments(danger_id: danger_id) unless new_comment
+      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false, remove_previous_comments: false)
+        delete_old_comments(danger_id: danger_id) if !new_comment || remove_previous_comments
 
         comment = generate_description(warnings: warnings, errors: errors)
         comment += "\n\n"

data/lib/danger/request_sources/github/github.rb

@@ -140,11 +140,11 @@ module Danger
       end
 
       # Sending data to GitHub
-      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false)
+      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false, remove_previous_comments: false)
         comment_result = {}
         editable_comments = issue_comments.select { |comment| comment.generated_by_danger?(danger_id) }
         last_comment = editable_comments.last
-        should_create_new_comment = new_comment || last_comment.nil?
+        should_create_new_comment = new_comment || last_comment.nil? || remove_previous_comments
 
         previous_violations =
           if should_create_new_comment
@@ -178,8 +178,8 @@ module Danger
 
         main_violations_sum = main_violations.values.inject(:+)
 
-        if previous_violations.empty? && main_violations_sum.empty?
-          # Just remove the comment, if there's nothing to say.
+        if (previous_violations.empty? && main_violations_sum.empty?) || remove_previous_comments
+          # Just remove the comment, if there's nothing to say or --remove-previous-comments CLI was set.
           delete_old_comments!(danger_id: danger_id)
         end
 

data/lib/danger/request_sources/gitlab.rb

@@ -116,10 +116,10 @@ module Danger
         GetIgnoredViolation.new(self.mr_json.description).call
       end
 
-      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false)
+      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false, remove_previous_comments: false)
         editable_comments = mr_comments.select { |comment| comment.generated_by_danger?(danger_id) }
 
-        should_create_new_comment = new_comment || editable_comments.empty?
+        should_create_new_comment = new_comment || editable_comments.empty? || remove_previous_comments
 
         if should_create_new_comment
           previous_violations = {}
@@ -128,8 +128,8 @@ module Danger
           previous_violations = parse_comment(comment)
         end
 
-        if previous_violations.empty? && (warnings + errors + messages + markdowns).empty?
-          # Just remove the comment, if there"s nothing to say.
+        if (previous_violations.empty? && (warnings + errors + messages + markdowns).empty?) || remove_previous_comments
+          # Just remove the comment, if there's nothing to say or --remove-previous-comments CLI was set.
           delete_old_comments!(danger_id: danger_id)
         else
           body = generate_comment(warnings: warnings,

data/lib/danger/request_sources/vsts.rb

@@ -72,7 +72,7 @@ module Danger
         nil
       end
 
-      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false)
+      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false, remove_previous_comments: false)
         unless @api.supports_comments?
           return
         end
@@ -86,7 +86,7 @@ module Danger
                         previous_violations: {},
                                   danger_id: danger_id,
                                    template: "vsts")
-        if new_comment
+        if new_comment || remove_previous_comments
           post_new_comment(comment)
         else
           update_old_comment(comment, danger_id: danger_id)

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "5.5.7".freeze
+  VERSION = "5.5.8".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 5.5.7
+  version: 5.5.8
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-24 00:00:00.000000000 Z
+date: 2018-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide