danger 5.5.11 → 5.5.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b40e9480325dafce9f9b8f3f629c564db738049d
-  data.tar.gz: 99574cdbe722f0205a8603ec10dbf4c4a9450772
+  metadata.gz: d85d2d05019556062bfa26d3b27c0a2146a4c055
+  data.tar.gz: 6ac0f8c4ed32e2a7d71dac8b9ac1f26ebbdda673
 SHA512:
-  metadata.gz: dbfc890a23612ee9145f37ef0dc9baf7987ad881f3ac8bddc6bf8ed738b34dbf4df2b8b4a517b169898614f71bed9e71564c0390eacd824ba819e1ceb541dec7
-  data.tar.gz: 166a2919fca6b861fc8d4aff9b09d4d6e01fa699d7f49dfa50fc97b5b259bd31b3643824dfa6287c311078ec2d2e7b5a9c262c478a29d5bf9bf90e20ea723643
+  metadata.gz: daf471daab481e39d5ebc73ec073409d4a4d30d2645ce50d820a646e1154c3223cb65853a11e679dbb73f8d9b14be14d7f2b8e9f3ae9dc5fbfa82446c292f7e6
+  data.tar.gz: 33cc3e1026df9f338a086f251125aebc7a9fa227285ca136223c0a0f6319efe2ffd26e93ac087778e9fde8528eb8b79398605d480d7b33f4c9585f523aa75aec

data/lib/danger/core_ext/file_list.rb

@@ -2,7 +2,7 @@ require "danger/helpers/array_subclass"
 
 module Danger
   class FileList
-    include Helpers::ArraySublcass
+    include Helpers::ArraySubclass
 
     # Information about pattern: http://ruby-doc.org/core-2.2.0/File.html#method-c-fnmatch
     # e.g. "**/something.*" for any file called something with any extension

data/lib/danger/helpers/array_subclass.rb

@@ -1,6 +1,6 @@
 module Danger
   module Helpers
-    module ArraySublcass
+    module ArraySubclass
       include Comparable
 
       def initialize(array)

data/lib/danger/request_sources/github/github.rb

@@ -465,7 +465,6 @@ module Danger
       def file_url(organisation: nil, repository: nil, branch: nil, path: nil)
         organisation ||= self.organisation
 
-        return @download_url unless @download_url.nil?
         begin
           # Retrieve the download URL (default branch on nil param)
           contents = client.contents("#{organisation}/#{repository}", path: path, ref: branch)
@@ -490,8 +489,8 @@ module Danger
 
       def inline_violations_group(warnings: [], errors: [], messages: [], markdowns: [])
         cmp = proc do |a, b|
-          next -1 unless a.file
-          next 1 unless b.file
+          next -1 unless a.file && a.line
+          next 1 unless b.file && b.line
 
           next a.line <=> b.line if a.file == b.file
           next a.file <=> b.file

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "5.5.11".freeze
+  VERSION = "5.5.12".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 5.5.11
+  version: 5.5.12
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-09 00:00:00.000000000 Z
+date: 2018-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -291,7 +291,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.