danger 5.3.0 → 5.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 280aa14f35fab7d31eca02ca079f3fd139f3f4ba
-  data.tar.gz: 356443a6e67ca27bf08cb760b96bfe909d3b40ec
+  metadata.gz: e0305fd8d9f84814f1c701d8368e9d64a8f044ed
+  data.tar.gz: 95d17dcbd3290b7cc01a51e13f12790f504a7a07
 SHA512:
-  metadata.gz: f3fe03e6240ad5b9ef1fd1efe6161b46ce562ca5d851ed5f01719d52679c7f31124e3f920746ee97a5c445e5d751b8dff340b0e7f57cdc4ec441ca8fc896d119
-  data.tar.gz: d2ce6b122c7727f462aa53ca5b2d1797007bb8e811bbcb59fa1a0deaa722f5368c3d542cdfbd0622407cf38e168617d54f9ec31c35ee6c9afd601b8d3559e421
+  metadata.gz: af01026b1e5fef49454ee50c2e63eaefa33fc665b0d3cb5d83862028faa1affdd88741062be71eef74270539e9f380bf32046b1c5f1cc26117e68196ffd255f9
+  data.tar.gz: 677908dda67a4ed33ca7a18b3466bdefc805568b756fb7d95f23ed9c82d0a762c23a4cff5ffbc1d5ef596ca4dd6d33ab40f976fd8623a4a9e45d6d353553210e

data/lib/danger/helpers/comments_helper.rb

@@ -25,7 +25,7 @@ module Danger
       #
       # @return [String] The Markdown compatible link
       def markdown_link_to_message(message, _)
-        "#{messages.file}#L#{message.line}"
+        "#{message.file}#L#{message.line}"
       end
 
       # !@group Extension points

data/lib/danger/request_sources/github/github.rb

@@ -1,5 +1,7 @@
 # coding: utf-8
 
+# rubocop:disable Metrics/ClassLength
+
 require "octokit"
 require "danger/helpers/comments_helper"
 require "danger/helpers/comment"
@@ -312,13 +314,14 @@ module Danger
           end
 
           matching_comments = danger_comments.select do |comment_data|
-            if comment_data["path"] == m.file && comment_data["commit_id"] == head_ref && comment_data["position"] == position
+            if comment_data["path"] == m.file && comment_data["position"] == position
               # Parse it to avoid problems with strikethrough
               violation = violations_from_table(comment_data["body"]).first
               if violation
                 messages_are_equivalent(violation, m)
               else
-                comment_data["body"] == body
+                blob_regexp = %r{blob/[0-9a-z]+/}
+                comment_data["body"].sub(blob_regexp, "") == body.sub(blob_regexp, "")
               end
             else
               false

data/lib/danger/scm_source/git_repo.rb

@@ -14,9 +14,10 @@ module Danger
       ensure_commitish_exists!(to)
 
       merge_base = find_merge_base(repo, from, to)
+      commits_in_branch_count = commits_in_branch_count(from, to)
 
       self.diff = repo.diff(merge_base, to)
-      self.log = repo.log.between(from, to)
+      self.log = repo.log(commits_in_branch_count).between(from, to)
     end
 
     def renamed_files
@@ -108,6 +109,10 @@ module Danger
     def possible_merge_base(repo, from, to)
       [repo.merge_base(from, to)].find { |base| commit_exists?(base) }
     end
+
+    def commits_in_branch_count(from, to)
+      exec("rev-list #{from}..#{to} --count").to_i
+    end
   end
 end
 

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "5.3.0".freeze
+  VERSION = "5.3.1".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 5.3.0
+  version: 5.3.1
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-09 00:00:00.000000000 Z
+date: 2017-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide