danger 4.3.2 → 4.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7941b0c0f6d0d18603265ce8daed01d8075ea11
-  data.tar.gz: eeaea8c0c7947c8f0cdbd3e90415c93dc5510999
+  metadata.gz: ac8016ce34c94a5e3ab531f39da5d552677ea816
+  data.tar.gz: 98ec9232cc83c5378e07bb7e91ca3cda5a8ab896
 SHA512:
-  metadata.gz: bde2e5f4bdcbb18fdc5840175407c00b42929637e7de95cacd695c2ec6b440b174434d7205a995900de08543f23071dfd24f3c94c371f62daae34572eb4be26f
-  data.tar.gz: 29f6a0d0e9dd882ca98f31d53aff9c777f7e859e0078c7a89fe7702d5974ec6f6b1b779740df9212fdba6b747c7c7bb879fed5a9b2d26f6c4de4f57489dbfcdd
+  metadata.gz: f3771c0464943b15a140c27c4ee7b70a414670ea88f779002fd433cda04b8cd5ce78dbe6a7824457425872e40f2e0e21aac3f78b4004fb5d1426d01c4989a92b
+  data.tar.gz: ef2ff358cc4841a44b03f0762c0cb997452c36f6ac19df2b8bb37c8e42e15b51c19ec05f2b8afce34bb725d70c1c9405de4be45caca5016f53e39b6d89bb7c3c

data/lib/danger/commands/runner.rb

@@ -29,7 +29,7 @@ module Danger
     self.command = "danger"
     self.version = Danger::VERSION
 
-    self.plugin_prefixes = %w(claide danger)
+    self.plugin_prefixes = %w[claide danger]
 
     def initialize(argv)
       dangerfile = argv.option("dangerfile", "Dangerfile")

data/lib/danger/danger_core/dangerfile.rb

@@ -212,7 +212,7 @@ module Danger
       return if (violations[:errors] + violations[:warnings] + violations[:messages] + status[:markdowns]).count.zero?
 
       ui.section("Results:") do
-        %i(errors warnings messages).each do |key|
+        %i[errors warnings messages].each do |key|
           formatted = key.to_s.capitalize + ":"
           title = case key
                   when :errors

data/lib/danger/danger_core/plugins/dangerfile_danger_plugin.rb

@@ -154,7 +154,7 @@ module Danger
     def import_dangerfile_from_github(slug, branch = nil, path = nil)
       raise "`import_dangerfile_from_github` requires a string" unless slug.kind_of?(String)
       org, repo = slug.split("/")
-      download_url = env.request_source.file_url(organisation: org, repository: repo, branch: branch || "master", path: path || "Dangerfile")
+      download_url = env.request_source.file_url(organisation: org, repository: repo, branch: branch, path: path || "Dangerfile")
       local_path = download(download_url)
       @dangerfile.parse(Pathname.new(local_path))
     end

data/lib/danger/danger_core/plugins/dangerfile_github_plugin.rb

@@ -234,7 +234,7 @@ module Danger
       @github.dismiss_out_of_range_messages = dismiss == true
     end
 
-    %i(title body author labels json).each do |suffix|
+    %i[title body author labels json].each do |suffix|
       alias_method "mr_#{suffix}".to_sym, "pr_#{suffix}".to_sym
     end
 

data/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb

@@ -207,7 +207,7 @@ module Danger
       paths.first(paths.count - 1).join(", ") + " & " + paths.last
     end
 
-    %i(title body author labels json diff).each do |suffix|
+    %i[title body author labels json diff].each do |suffix|
       alias_method "pr_#{suffix}".to_sym, "mr_#{suffix}".to_sym
     end
 

data/lib/danger/request_sources/github/github.rb

@@ -416,9 +416,19 @@ module Danger
       end
 
       # @return [String] A URL to the specific file, ready to be downloaded
-      def file_url(organisation: nil, repository: nil, branch: "master", path: nil)
+      def file_url(organisation: nil, repository: nil, branch: nil, path: nil)
         organisation ||= self.organisation
-        "https://raw.githubusercontent.com/#{organisation}/#{repository}/#{branch}/#{path}"
+
+        return @download_url unless @download_url.nil?
+        begin
+          # Retrieve the download URL (default branch on nil param)
+          contents = client.contents("#{organisation}/#{repository}", path: path, ref: branch)
+          @download_url = contents["download_url"]
+        rescue Octokit::ClientError
+          # Fallback to github.com
+          branch ||= "master"
+          @download_url = "https://raw.githubusercontent.com/#{organisation}/#{repository}/#{branch}/#{path}"
+        end
       end
     end
   end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "4.3.2".freeze
+  VERSION = "4.3.3".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 4.3.2
+  version: 4.3.3
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-30 00:00:00.000000000 Z
+date: 2017-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide