danger 3.5.3 → 3.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 69859c177c990bcaee0d10f8af0a64d3a2e55425
-  data.tar.gz: 738a8057e92708fb38a925b87990896744782903
+  metadata.gz: 989776d07fb68d675c57bb156dcb3a5e8a42f9c1
+  data.tar.gz: 8c797383ea005b6c60b1896dcf1acb071dc08de7
 SHA512:
-  metadata.gz: 3158cef1db9039f75a6e88f1d7f228f3ed2046618bd2bd1d9fb1186fa073b343b4b1c26378ec7d634f061ee7d86157e0747e3c59545c416b9d007ccdee7a086e
-  data.tar.gz: 18f00f6ae41414d2f50dd433cc3ece132b785765323959d9c8c126648670dcd9cd0ee51242208f9adfb79586b77042fe1da49ae7f5ce79836de55fae4bdc9ba2
+  metadata.gz: 3a619a8989461ac9cc409610c71d0b1cd30f445c064e4c9a190a66b88bcd50bfedfce9c48fa3cbc0038257ac6ae18582ec2a52565ebca9ec0197df1c1405df47
+  data.tar.gz: 4d54581d81ac705ffcd9a700ebb339f61e17bef7bd612a6c99837253e91b6a5b36f91242e9f26313f6d30c099c0a7934b811dd028424c0ee7e92f458321687cb

data/lib/danger/commands/pr.rb

@@ -12,16 +12,20 @@ module Danger
     def self.options
       [
         ["--clear-http-cache", "Clear the local http cache before running Danger locally."],
-        ["--pry", "Drop into a Pry shell after evaluating the Dangerfile."]
+        ["--pry", "Drop into a Pry shell after evaluating the Dangerfile."],
+        ["--dangerfile=<path/to/dangerfile>", "The location of your Dangerfile"]
       ]
     end
 
     def initialize(argv)
       @pr_url = argv.shift_argument
       @clear_http_cache = argv.flag?("clear-http-cache", false)
+      dangerfile = argv.option("dangerfile", "Dangerfile")
 
       super
 
+      @dangerfile_path = dangerfile if File.exist?(dangerfile)
+
       setup_pry if should_pry?(argv)
     end
 

data/lib/danger/commands/runner.rb

@@ -37,7 +37,8 @@ module Danger
       @base = argv.option("base")
       @head = argv.option("head")
       @fail_on_errors = argv.option("fail-on-errors", false)
-      @danger_id = argv.option("danger_id", "danger")
+      new_comment = argv.flag?("new-comment")
+      @danger_id = new_comment ? Time.now.strftime("%v %H:%M:%S") : argv.option("danger_id", "danger")
       @cork = Cork::Board.new(silent: argv.option("silent", false),
                               verbose: argv.option("verbose", false))
       super
@@ -56,7 +57,8 @@ module Danger
         ["--head=[master|dev|stable]", "A branch/tag/commit to use as the head"],
         ["--fail-on-errors=<true|false>", "Should always fail the build process, defaults to false"],
         ["--dangerfile=<path/to/dangerfile>", "The location of your Dangerfile"],
-        ["--danger_id=<id>", "The identifier of this Danger instance"]
+        ["--danger_id=<id>", "The identifier of this Danger instance"],
+        ["--new-comment", "Makes the build process ignore other Danger instances, resulting in a new comment. Overrides '--danger_id'."]
       ].concat(super)
     end
 

data/lib/danger/danger_core/environment_manager.rb

@@ -39,7 +39,7 @@ module Danger
         self.request_source = request_source
       end
 
-      raise_error_for_no_request_source(env, ui) unless self.request_source
+      raise_error_for_no_request_source(env, self.ui) unless self.request_source
       self.scm = self.request_source.scm
     end
 

data/lib/danger/scm_source/git_repo.rb

@@ -38,6 +38,10 @@ module Danger
 
     def ensure_commitish_exists!(commitish)
       exec("fetch") if exec("rev-parse --quiet --verify \"#{commitish}^{commit}\"").empty?
+
+      if exec("rev-parse --quiet --verify \"#{commitish}^{commit}\"").empty?
+        raise_if_we_cannot_find_the_commit(commitish)
+      end
     end
 
     private
@@ -45,6 +49,10 @@ module Danger
     def default_env
       { "LANG" => "en_US.UTF-8" }
     end
+
+    def raise_if_we_cannot_find_the_commit(commit)
+      raise "Commit #{commit[0..7]} doesn't exist. Are you running `danger local/pr` against the correct repository? Also this usually happens when you rebase/reset and force-pushed."
+    end
   end
 end
 

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "3.5.3".freeze
+  VERSION = "3.5.4".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 3.5.3
+  version: 3.5.4
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-09 00:00:00.000000000 Z
+date: 2016-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide