danger 3.4.1 → 3.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: de42011bfb76e71cb7b4a3307648b54695b9b725
-  data.tar.gz: 06eb74831ab383be09312427e072f9d49096089d
+  metadata.gz: 44b2fc8e9ba271755b5995d03991b6039535ef80
+  data.tar.gz: 20de81281c3a7291570bf4d0cabef7b995806cca
 SHA512:
-  metadata.gz: c8ce21aa3ad48d64b7ac92623ec924220f05a98ff3a80dd8a41fa5354d92296625f00ab0796396d7c06882cbff5147cd62af5f802499c1a192ca04a796c64f29
-  data.tar.gz: 907dd19d7d3c044fe7f6c6e30dfbec053864de5b412e92bdbe7ebd05d29726d87c67f2de0c448f6c4e77bb6dfaf9a146a801adc4d03aefb3b09c9325b6dbb78c
+  metadata.gz: 86f4f302fdf25c27e572f08c2ec7424f52d24c87f8e125cb511e88572645e2f04a507a8aafcb82642acc73f74466695267662262cad34fc6964e9a131964dd4d
+  data.tar.gz: 35606932eacff700e806a9cb68d629e2f0eff6d27752248f6b6c1c348772d3d7c568c3f2345c2302b112fbfb4b33b624f47ba5ec404c027262e9faac2f1a64e2

data/lib/danger/ci_source/jenkins.rb

@@ -53,7 +53,7 @@ module Danger
     end
 
     def initialize(env)
-      self.repo_url = env["GIT_URL"]
+      self.repo_url = env.fetch("GIT_URL_1") { env["GIT_URL"] }
       self.pull_request_id = self.class.pull_request_id(env)
 
       repo_matches = self.repo_url.match(%r{([\/:])([^\/]+\/[^\/.]+)(?:.git)?$})

data/lib/danger/danger_core/dangerfile.rb

@@ -68,10 +68,11 @@ module Danger
       super
     end
 
-    def initialize(env_manager, cork_board)
+    # cork_board not being set comes from plugins #585
+    def initialize(env_manager, cork_board = nil)
       @plugins = {}
       @core_plugins = []
-      @ui = cork_board
+      @ui = cork_board || Cork::Board.new(silent: false, verbose: false)
 
       # Triggers the core plugins
       @env = env_manager

data/lib/danger/danger_core/environment_manager.rb

@@ -25,10 +25,10 @@ module Danger
       "danger_base".freeze
     end
 
-    def initialize(env, ui)
+    def initialize(env, ui = nil)
       ci_klass = self.class.local_ci_source(env)
       self.ci_source = ci_klass.new(env)
-      self.ui = ui
+      self.ui = ui || Cork::Board.new(silent: false, verbose: false)
 
       RequestSources::RequestSource.available_request_sources.each do |klass|
         next unless self.ci_source.supports?(klass)

data/lib/danger/scm_source/git_repo.rb

@@ -37,7 +37,7 @@ module Danger
     end
 
     def ensure_commitish_exists!(commitish)
-      exec("fetch") if exec("rev-parse --quiet --verify #{commitish}").empty?
+      exec("fetch") if exec("rev-parse --quiet --verify \"#{commitish}^{commit}\"").empty?
     end
 
     private

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "3.4.1".freeze
+  VERSION = "3.4.2".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 3.4.1
+  version: 3.4.2
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-30 00:00:00.000000000 Z
+date: 2016-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -459,7 +459,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.