danger 3.3.1 → 3.3.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/README.md +7 -6
- data/lib/danger/ci_source/local_git_repo.rb +1 -1
- data/lib/danger/plugin_support/plugin_linter.rb +2 -2
- data/lib/danger/request_sources/bitbucket_cloud.rb +1 -0
- data/lib/danger/request_sources/bitbucket_server.rb +1 -0
- data/lib/danger/request_sources/github.rb +4 -3
- data/lib/danger/version.rb +1 -1
- metadata +2 -2
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA1:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 423ee19a94a521cfab7f662fd5897bc0130ad848
|
4
|
+
data.tar.gz: dff351383ef77ef6ed555687d51584a8b733e037
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 5b44215d3633c38174e8cacc523169c76c23999f19e6b134f50be7214cc5a763d39e514e92e4118f9c332130911c8b2123f4b67cf5680ee2eee2689710a5980d
|
7
|
+
data.tar.gz: fa3be34a121bbe67101086fb3ecd6d2d0598c13bc048a28bbdf14cd4da4228168c9dcb002243877df714358e27e21660a3bead61c8831e72892e89b3cc41b7fa
|
data/README.md
CHANGED
@@ -2,6 +2,7 @@
|
|
2
2
|
|
3
3
|
[](https://github.com/orta/danger/blob/master/LICENSE)
|
4
4
|
[](http://rubygems.org/gems/danger)
|
5
|
+
[](https://travis-ci.org/danger/danger)
|
5
6
|
|
6
7
|
Formalize your Pull Request etiquette.
|
7
8
|
|
@@ -32,7 +33,7 @@ You can:
|
|
32
33
|
* Enforce using descriptive labels
|
33
34
|
* Look out for common anti-patterns
|
34
35
|
* Highlight interesting build artifacts
|
35
|
-
* Give specific files extra focus
|
36
|
+
* Give specific files extra focus
|
36
37
|
|
37
38
|
Danger provides the glue to let _you_ build out the rules specific to your team's culture, offering useful metadata and a comprehensive plugin system to share common issues.
|
38
39
|
|
@@ -42,7 +43,7 @@ Alright. So, actually, you may be in the wrong place. From here on in, this READ
|
|
42
43
|
|
43
44
|
We keep all of the end-user documentation at [http://danger.systems](http://danger.systems).
|
44
45
|
|
45
|
-
Some quick links: [Guides Index](http://danger.systems/guides.html), [DSL Reference](http://danger.systems/reference.html), [Getting Started](http://danger.systems/guides/getting_started.html) and [What does Danger Do?](http://danger.systems/guides/what_does_danger_do.html).
|
46
|
+
Some quick links: [Guides Index](http://danger.systems/guides.html), [DSL Reference](http://danger.systems/reference.html), [Getting Started](http://danger.systems/guides/getting_started.html) and [What does Danger Do?](http://danger.systems/guides/what_does_danger_do.html).
|
46
47
|
|
47
48
|
## I'm here to help out!
|
48
49
|
|
@@ -55,7 +56,7 @@ bundle install
|
|
55
56
|
bundle exec rake spec
|
56
57
|
```
|
57
58
|
|
58
|
-
This sets everything up and runs all of the tests.
|
59
|
+
This sets everything up and runs all of the tests.
|
59
60
|
|
60
61
|
#### Theory
|
61
62
|
|
@@ -63,7 +64,7 @@ Danger has a [VISION.md](https://github.com/danger/danger/blob/master/VISION.md)
|
|
63
64
|
|
64
65
|
#### Documentation
|
65
66
|
|
66
|
-
The code you write may end up in the public part of the website — the easiest way to tell is that it is vastly overdocumented. If you are working in a space that looks over-documented, please be extra considerate to add documentation. We expect the consumers of that documentation to be non-rubyists, thus you should avoid specific jargon and try to provide duplicate overlapping examples.
|
67
|
+
The code you write may end up in the public part of the website — the easiest way to tell is that it is vastly overdocumented. If you are working in a space that looks over-documented, please be extra considerate to add documentation. We expect the consumers of that documentation to be non-rubyists, thus you should avoid specific jargon and try to provide duplicate overlapping examples.
|
67
68
|
|
68
69
|
#### Testing
|
69
70
|
|
@@ -76,7 +77,7 @@ I'd strongly recommend using `bundle exec guard` to run your tests as you work.
|
|
76
77
|
Ruby is super dynamic. One of the best ways to debug Ruby code is by using [pry](http://pryrepl.org/). We include pry for developers: when you have a problem, copy these two lines just before your problem and follow the instructions from "[I Want To Be A Danger Wizard](http://danger.systems/guides/troubleshooting.html#i-want-to-be-a-danger-wizard)."
|
77
78
|
|
78
79
|
```ruby
|
79
|
-
require 'pry'
|
80
|
+
require 'pry'
|
80
81
|
binding.pry
|
81
82
|
```
|
82
83
|
|
@@ -87,7 +88,7 @@ binding.pry
|
|
87
88
|
|
88
89
|
## License, Contributor's Guidelines and Code of Conduct
|
89
90
|
|
90
|
-
We try to keep as much discussion as possible in GitHub issues, but also have a pretty inactive Slack --- if you'd like an invite, ping [@Orta](https://twitter.com/orta/) a DM on Twitter with your email. It's mostly interesting if you want to stay on top of Danger without all the emails from GitHub.
|
91
|
+
We try to keep as much discussion as possible in GitHub issues, but also have a pretty inactive Slack --- if you'd like an invite, ping [@Orta](https://twitter.com/orta/) a DM on Twitter with your email. It's mostly interesting if you want to stay on top of Danger without all the emails from GitHub.
|
91
92
|
|
92
93
|
> This project is open source under the MIT license, which means you have full access to the source code and can modify it to fit your own needs.
|
93
94
|
|
@@ -47,7 +47,7 @@ module Danger
|
|
47
47
|
|
48
48
|
pull_request_id, sha = MergedPullRequestFinder.new(
|
49
49
|
env["LOCAL_GIT_PR_ID"] || "",
|
50
|
-
run_git("log --oneline -
|
50
|
+
run_git("log --oneline -1000000".freeze)
|
51
51
|
).call
|
52
52
|
|
53
53
|
self.repo_slug = repo_slug ? repo_slug : print_repo_slug_warning
|
@@ -130,9 +130,9 @@ module Danger
|
|
130
130
|
# Generates a link to see an example of said rule
|
131
131
|
#
|
132
132
|
def link(ref)
|
133
|
-
if ref.kind_of?
|
133
|
+
if ref.kind_of?(Range)
|
134
134
|
"@see - " + "https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L#{ref.min}#-L#{ref.max}".blue
|
135
|
-
elsif ref.kind_of?
|
135
|
+
elsif ref.kind_of?(Integer)
|
136
136
|
"@see - " + "https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb#L#{ref}".blue
|
137
137
|
else
|
138
138
|
"@see - " + "https://github.com/dbgrandi/danger-prose/blob/v2.0.0/lib/danger_plugin.rb".blue
|
@@ -151,10 +151,11 @@ module Danger
|
|
151
151
|
# Note: this can terminate the entire process.
|
152
152
|
submit_pull_request_status!(warnings: warnings,
|
153
153
|
errors: errors,
|
154
|
-
details_url: comment_result["html_url"]
|
154
|
+
details_url: comment_result["html_url"],
|
155
|
+
danger_id: danger_id)
|
155
156
|
end
|
156
157
|
|
157
|
-
def submit_pull_request_status!(warnings: [], errors: [], details_url: [])
|
158
|
+
def submit_pull_request_status!(warnings: [], errors: [], details_url: [], danger_id: "danger")
|
158
159
|
status = (errors.count.zero? ? "success" : "failure")
|
159
160
|
message = generate_description(warnings: warnings, errors: errors)
|
160
161
|
latest_pr_commit_ref = self.pr_json["head"]["sha"]
|
@@ -166,7 +167,7 @@ module Danger
|
|
166
167
|
begin
|
167
168
|
client.create_status(ci_source.repo_slug, latest_pr_commit_ref, status, {
|
168
169
|
description: message,
|
169
|
-
context: "danger
|
170
|
+
context: "danger/#{danger_id}",
|
170
171
|
target_url: details_url
|
171
172
|
})
|
172
173
|
rescue
|
data/lib/danger/version.rb
CHANGED
metadata
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: danger
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 3.3.
|
4
|
+
version: 3.3.2
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Orta Therox
|
@@ -9,7 +9,7 @@ authors:
|
|
9
9
|
autorequire:
|
10
10
|
bindir: bin
|
11
11
|
cert_chain: []
|
12
|
-
date: 2016-09-
|
12
|
+
date: 2016-09-19 00:00:00.000000000 Z
|
13
13
|
dependencies:
|
14
14
|
- !ruby/object:Gem::Dependency
|
15
15
|
name: claide
|