danger 2.1.6 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8d17d6a72e1a01c0fd06eb51f4631d2aece6a2ba
-  data.tar.gz: fedf8ba1df3832bfba137371bf9e6ba57ba3ca25
+  metadata.gz: 8b7dea6bfd9bb27c05eaf6b537f6aff16e682155
+  data.tar.gz: 7ec69647d0f2d827487aefd873be938fbf11a96f
 SHA512:
-  metadata.gz: 1ac508837ab5be9fa9004e729c2c86887377e301263e9d4bf05343858852992b66e23d582d32ac7d51e59d6e121f4136d4df481b129d43c30e51626be9b16e6e
-  data.tar.gz: 830458880fdaa3afb529fac362158a2210abd49d0b9a914e967007ee8a63226d40e5a98402e2639727048f23543aac8ac285fbe8eb28b284473b64cfa4319761
+  metadata.gz: 9f724c97c2cd8bd49e6c507ebf9d05885781600e0539c0fa06af9665247b61beec387b2386cfff32ce1a5c51a3392904bc9e288bb742029f98cd049b2566fd47
+  data.tar.gz: 3e17b9025db0a22d3af9f2c53be2e80a3bcd33e86cc24e8cb32ba810bcfe04456ca46385aa0e47abfbc870f1daf40db74845f948aa7e05fe1b28b4079e4b7b72

data/lib/danger/ci_source/buildkite.rb

@@ -14,9 +14,16 @@ module Danger
   #
   # ### Token Setup
   #
+  # #### GitHub
+  #
   # As this is self-hosted, you will need to add the `DANGER_GITHUB_API_TOKEN` to your build user's ENV. The alternative
   # is to pass in the token as a prefix to the command `DANGER_GITHUB_API_TOKEN="123" bundle exec danger`.
   #
+  # #### GitLab
+  #
+  # As this is self-hosted, you will need to add the `DANGER_GITLAB_API_TOKEN` to your build user's ENV. The alternative
+  # is to pass in the token as a prefix to the command `DANGER_GITLAB_API_TOKEN="123" bundle exec danger`.
+  #
   class Buildkite < CI
     def self.validates_as_ci?(env)
       env.key? "BUILDKITE"
@@ -36,7 +43,7 @@ module Danger
     end
 
     def supported_request_sources
-      @supported_request_sources ||= [Danger::RequestSources::GitHub]
+      @supported_request_sources ||= [Danger::RequestSources::GitHub, Danger::RequestSources::GitLab]
     end
   end
 end

data/lib/danger/ci_source/drone.rb

@@ -29,7 +29,7 @@ module Danger
     end
 
     def supported_request_sources
-      @supported_request_sources ||= [Danger::RequestSources::GitHub]
+      @supported_request_sources ||= [Danger::RequestSources::GitHub, Danger::RequestSources::GitLab]
     end
 
     def initialize(env)

data/lib/danger/ci_source/gitlab_ci.rb

@@ -0,0 +1,32 @@
+# http://docs.gitlab.com/ce/ci/variables/README.html
+require "uri"
+
+module Danger
+  # ### CI Setup
+  # GitLab CI is currently not supported because GitLab's runners don't expose
+  # the required values in the environment. Namely CI_MERGE_REQUEST_ID does not
+  # exist as of yet, however there is an
+  # [MR](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5698) fixing this.
+  # If that has been merged and you are using either gitlab.com or a release
+  # with that change this CISource will wokr.
+  #
+  class GitLabCI < CI
+    def self.validates_as_ci?(env)
+      env.key? "GITLAB_CI"
+    end
+
+    def self.validates_as_pr?(env)
+      exists = ["CI_MERGE_REQUEST_ID", "CI_PROJECT_ID", "GITLAB_CI"].all? { |x| env[x] }
+      exists && env["CI_MERGE_REQUEST_ID"].to_i > 0
+    end
+
+    def supported_request_sources
+      @supported_request_sources ||= [Danger::RequestSources::GitLab]
+    end
+
+    def initialize(env)
+      self.repo_slug = env["CI_PROJECT_ID"]
+      self.pull_request_id = env["CI_MERGE_REQUEST_ID"]
+    end
+  end
+end

data/lib/danger/ci_source/jenkins.rb

@@ -5,9 +5,17 @@ module Danger
   # https://jenkins-ci.org
 
   # ### CI Setup
-  #
   # Ah Jenkins, so many memories. So, if you're using Jenkins, you're hosting your own environment. You
-  # will want to be using the [GitHub pull request builder plugin](https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin)
+  #
+  # #### GitHub
+  # You will want to be using the [GitHub pull request builder plugin](https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin)
+  # in order to ensure that you have the build environment set up for PR integration.
+  #
+  # With that set up, you can edit your job to add `bundle exec danger` at the build action.
+  #
+  # ### GitLab
+  #
+  # You will want to be using the [GitLabe Plugin](https://github.com/jenkinsci/gitlab-plugin)
   # in order to ensure that you have the build environment set up for PR integration.
   #
   # With that set up, you can edit your job to add `bundle exec danger` at the build action.
@@ -22,19 +30,28 @@ module Danger
     end
 
     def self.validates_as_pr?(env)
-      ["ghprbPullId"].all? { |x| env[x] }
+      id = pull_request_id(env)
+      !id.nil? && !id.empty?
     end
 
     def supported_request_sources
-      @supported_request_sources ||= [Danger::RequestSources::GitHub]
+      @supported_request_sources ||= [Danger::RequestSources::GitHub, Danger::RequestSources::GitLab]
     end
 
     def initialize(env)
       self.repo_url = env["GIT_URL"]
-      self.pull_request_id = env["ghprbPullId"]
+      self.pull_request_id = self.class.pull_request_id(env)
 
       repo_matches = self.repo_url.match(%r{([\/:])([^\/]+\/[^\/.]+)(?:.git)?$})
       self.repo_slug = repo_matches[2] unless repo_matches.nil?
     end
+
+    def self.pull_request_id(env)
+      if env["ghprPullId"]
+        env["ghprPullId"]
+      else
+        env["gitlabMergeRequestId"]
+      end
+    end
   end
 end

data/lib/danger/ci_source/teamcity.rb

@@ -9,34 +9,71 @@ module Danger
   #
   # ### Token + Environment Setup
   #
+  # #### GitHub
+  #
   # As this is self-hosted, you will need to add the `DANGER_GITHUB_API_TOKEN` to your build user's ENV. The alternative
   # is to pass in the token as a prefix to the command `DANGER_GITHUB_API_TOKEN="123" bundle exec danger`.
   #
   # However, you will need to find a way to add the environment vars: `GITHUB_REPO_SLUG`, `GITHUB_PULL_REQUEST_ID` and
   # `GITHUB_REPO_URL`. These are not added by default. You could do this via the GitHub API potentially.
   #
+  # #### GitLab
+  #
+  # As this is self-hosted, you will need to add the `DANGER_GITLAB_API_TOKEN` to your build user's ENV. The alternative
+  # is to pass in the token as a prefix to the command `DANGER_GITLAB_API_TOKEN="123" bundle exec danger`.
+  #
+  # However, you will need to find a way to add the environment vars: `GITLAB_REPO_SLUG`, `GITLAB_PULL_REQUEST_ID` and
+  # `GITLAB_REPO_URL`. These are not added by default. You could do this via the GitLab API potentially.
+  #
   # We would love some advice on improving this setup.
   #
   class TeamCity < CI
+    class << self
+      def validates_as_github_pr?(env)
+        ["GITHUB_PULL_REQUEST_ID", "GITHUB_REPO_URL", "GITHUB_REPO_URL"].all? { |x| env[x] && !env[x].empty? }
+      end
+
+      def validates_as_gitlab_pr?(env)
+        ["GITLAB_REPO_SLUG", "GITLAB_PULL_REQUEST_ID", "GITLAB_REPO_URL"].all? { |x| env[x] && !env[x].empty? }
+      end
+    end
+
     def self.validates_as_ci?(env)
       env.key? "TEAMCITY_VERSION"
     end
 
     def self.validates_as_pr?(env)
-      ["GITHUB_PULL_REQUEST_ID", "GITHUB_REPO_URL", "GITHUB_REPO_SLUG"].all? { |x| env[x] }
+      validates_as_github_pr?(env) || validates_as_gitlab_pr?(env)
     end
 
     def supported_request_sources
-      @supported_request_sources ||= [Danger::RequestSources::GitHub]
+      @supported_request_sources ||= [Danger::RequestSources::GitHub, Danger::RequestSources::GitLab]
     end
 
     def initialize(env)
       # NB: Unfortunately TeamCity doesn't provide these variables
       # automatically so you have to add these variables manually to your
       # project or build configuration
+
+      if self.class.validates_as_github_pr?(env)
+        extract_github_variables!(env)
+      elsif self.class.validates_as_gitlab_pr?(env)
+        extract_gitlab_variables!(env)
+      end
+    end
+
+    private
+
+    def extract_github_variables!(env)
       self.repo_slug       = env["GITHUB_REPO_SLUG"]
       self.pull_request_id = env["GITHUB_PULL_REQUEST_ID"].to_i
       self.repo_url        = env["GITHUB_REPO_URL"]
     end
+
+    def extract_gitlab_variables!(env)
+      self.repo_slug       = env["GITLAB_REPO_SLUG"]
+      self.pull_request_id = env["GITLAB_PULL_REQUEST_ID"].to_i
+      self.repo_url        = env["GITLAB_REPO_URL"]
+    end
   end
 end

data/lib/danger/commands/plugins/plugin_readme.rb

@@ -36,7 +36,6 @@ module Danger
       parser = PluginParser.new(paths)
       parser.parse
 
-      self.markdown = Kramdown::Document.new(text, input: "GFM").to_html
       self.json = JSON.parse(parser.to_json_string)
 
       template = File.join(Danger.gem_path, "lib/danger/plugin_support/templates/readme_table.html.erb")

data/lib/danger/comment_generators/github.md.erb

@@ -4,7 +4,7 @@
   <thead>
     <tr>
       <th width="50"></th>
-      <th width="100%" data-kind="<%= table[:name] %>">
+      <th width="100%" data-danger-table="true" data-kind="<%= table[:name] %>">
         <%- if table[:count] > 0 -%>
           <%= table[:count] %> <%= table[:name] %><%= "s" unless table[:count] == 1 %>
         <%- else -%>

data/lib/danger/comment_generators/gitlab.md.erb

@@ -0,0 +1,40 @@
+<%- @tables.each do |table| -%>
+  <%- if table[:content].any? || table[:resolved].any? -%>
+<table>
+  <thead>
+    <tr>
+      <th width="5%"></th>
+      <th width="95%" data-danger-table="true" data-kind="<%= table[:name] %>">
+        <%- if table[:count] > 0 -%>
+          <%= table[:count] %> <%= table[:name] %><%= "s" unless table[:count] == 1 %>
+        <%- else -%>
+          :white_check_mark: <%= random_compliment %>
+        <%- end -%>
+      </th>
+     </tr>
+  </thead>
+  <tbody>
+    <%- table[:content].each do |violation| -%>
+    <tr>
+      <td>:<%= table[:emoji] %>:</td>
+      <td data-sticky="<%= violation.sticky %>"><%= violation.message %></td>
+    </tr>
+    <%- end -%>
+    <%- table[:resolved].each do |message| -%>
+      <tr>
+        <td>:white_check_mark:</td>
+        <td data-sticky="true"><del><%= message %></del></td>
+      </tr>
+    <%- end -%>
+  </tbody>
+</table>
+  <%- end -%>
+<%- end -%>
+
+<%- @markdowns.each do |current| -%>
+<%= current %>
+<%# the previous line has to be aligned far to the left, otherwise markdown can break easily %>
+<%- end -%>
+<p align="right" data-meta="generated_by_<%= @danger_id %>">
+  Generated by :no_entry_sign: <a href="https://github.com/danger/danger/">danger</a>
+</p>

data/lib/danger/danger_core/dangerfile.rb

@@ -4,9 +4,10 @@ require "danger/danger_core/dangerfile_dsl"
 require "danger/danger_core/standard_error"
 
 require "danger/danger_core/plugins/dangerfile_messaging_plugin"
-require "danger/danger_core/plugins/dangerfile_import_plugin"
+require "danger/danger_core/plugins/dangerfile_danger_plugin"
 require "danger/danger_core/plugins/dangerfile_git_plugin"
 require "danger/danger_core/plugins/dangerfile_github_plugin"
+require "danger/danger_core/plugins/dangerfile_gitlab_plugin"
 
 module Danger
   class Dangerfile
@@ -34,7 +35,7 @@ module Danger
 
     # The ones that everything would break without
     def self.essential_plugin_classes
-      [DangerfileMessagingPlugin, DangerfileGitPlugin, DangerfileImportPlugin, DangerfileGitHubPlugin]
+      [DangerfileMessagingPlugin, DangerfileGitPlugin, DangerfileDangerPlugin, DangerfileGitHubPlugin, DangerfileGitLabPlugin]
     end
 
     # Both of these methods exist on all objects

data/lib/danger/danger_core/environment_manager.rb

@@ -22,8 +22,9 @@ module Danger
       RequestSources::RequestSource.available_request_sources.each do |klass|
         next unless self.ci_source.supports?(klass)
 
-        request_source = klass.new(self.ci_source, ENV)
+        request_source = klass.new(self.ci_source, env)
         next unless request_source.validates_as_ci?
+        next unless request_source.validates_as_api_source?
         self.request_source = request_source
       end
 

data/lib/danger/danger_core/executor.rb

@@ -38,14 +38,9 @@ module Danger
         ci_head = head || EnvironmentManager.danger_head_branch
         dm.env.scm.diff_for_folder(".", from: ci_base, to: ci_head)
 
+        # Parse the local Dangerfile
         dm.parse(Pathname.new(dangerfile_path))
 
-        if dm.env.request_source.organisation && !dm.env.request_source.danger_repo? && (danger_repo = dm.env.request_source.fetch_danger_repo)
-          url = dm.env.request_source.file_url(repository: danger_repo.name, path: "Dangerfile")
-          path = dm.plugin.download(url)
-          dm.parse(Pathname.new(path))
-        end
-
         post_results(dm, danger_id)
         dm.print_results
       ensure

data/lib/danger/danger_core/plugins/{dangerfile_import_plugin.rb → dangerfile_danger_plugin.rb}

@@ -10,36 +10,36 @@ module Danger
   # @example Import a plugin available over HTTP
   #
   #          device_grid = "https://raw.githubusercontent.com/fastlane/fastlane/master/danger-device_grid/lib/device_grid/plugin.rb"
-  #          plugin.import device_grid
+  #          danger.import_plugin(device_grid)
   #
   # @example Import from a local file reference
   #
-  #          plugin.import "danger/plugins/watch_plugin.rb"
+  #          danger.import_plugin("danger/plugins/watch_plugin.rb")
   #
   # @example Import all files inside a folder
   #
-  #          plugin.import "danger/plugins/*.rb"
+  #          danger.import_plugin("danger/plugins/*.rb")
   #
   # @see  danger/danger
   # @tags core, plugins
 
-  class DangerfileImportPlugin < Plugin
+  class DangerfileDangerPlugin < Plugin
     # The instance name used in the Dangerfile
     # @return [String]
     #
     def self.instance_name
-      "plugin"
+      "danger"
     end
 
-    # @!group Plugins
-    # Download a local or remote plugin and use it inside the Dangerfile.
+    # @!group Danger
+    # Download a local or remote plugin and make it usable inside the Dangerfile.
     #
     # @param    [String] path_or_url
     #           a local path or a https URL to the Ruby file to import
     #           a danger plugin from.
     # @return   [void]
     #
-    def import(path_or_url)
+    def import_plugin(path_or_url)
       raise "`import` requires a string" unless path_or_url.kind_of?(String)
 
       if path_or_url.start_with?("http")
@@ -49,8 +49,25 @@ module Danger
       end
     end
 
+    # @!group Danger
+    # Download and execute a remote Dangerfile.
+    #
+    # @param    [String] repo slug
+    #           A slug that represents the repo where the Dangerfile is.
+    # @return   [void]
+    #
+    def import_dangerfile(slug)
+      raise "`import` requires a string" unless slug.kind_of?(String)
+      org, repo = slug.split("/")
+      download_url = env.request_source.file_url(organisation: org, repository: repo, branch: "master", path: "Dangerfile")
+      local_path = import_url(download_url)
+      dangerfile.parse(Pathname.new(local_path))
+    end
+
+    private
+
     # @!group Plugins
-    # Download a local or remote plugin or Dangerfile
+    # Download a local or remote plugin or Dangerfile.
     # This method will not import the file for you, use plugin.import instead
     #
     # @param    [String] path_or_url
@@ -75,8 +92,6 @@ module Danger
       return path
     end
 
-    private
-
     # @!group Plugins
     # Download a remote plugin and use it locally.
     #

data/lib/danger/danger_core/plugins/dangerfile_github_plugin.rb

@@ -14,7 +14,7 @@ module Danger
   #
   # @example Ensure that labels have been used on the PR
   #
-  #          fail "Please add labels to this PR" if github.labels.empty?
+  #          fail "Please add labels to this PR" if github.pr_labels.empty?
   #
   # @example Check if a user is in a specific GitHub org, and message them if so
   #
@@ -205,6 +205,10 @@ module Danger
       paths.first(paths.count - 1).join(", ") + " & " + paths.last
     end
 
+    [:title, :body, :author, :labels, :json].each do |suffix|
+      alias_method "mr_#{suffix}".to_sym, "pr_#{suffix}".to_sym
+    end
+
     private
 
     def create_link(href, text)

data/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb

@@ -0,0 +1,190 @@
+require "danger/plugin_support/plugin"
+
+module Danger
+  # Handles interacting with GitLab inside a Dangerfile. Provides a few functions which wrap `mr_json` and also
+  # through a few standard functions to simplify your code.
+  #
+  # @example Warn when an MR is classed as work in progress
+  #
+  #          warn "MR is classed as Work in Progress" if gitlab.mr_title.include? "[WIP]"
+  #
+  # @example Declare a MR to be simple to avoid specific Danger rules
+  #
+  #          declared_trivial = (gitlab.mr_title + gitlab.mr_body).include?("#trivial")
+  #
+  # @example Ensure that labels have been applied to the MR
+  #
+  #          fail "Please add labels to this MR" if gitlab.mr_labels.empty?
+  #
+  # @example Ensure that all MRs have an assignee
+  #
+  #          warn "This MR does not have any assignees yet." unless gitlab.mr_json["assignee"]
+  #
+  # @example Ensure there is a summary for a MR
+  #
+  #          fail "Please provide a summary in the Pull Request description" if gitlab.mr_body.length < 5
+  #
+  # @example Only accept MRs to the develop branch
+  #
+  #          fail "Please re-submit this MR to develop, we may have already fixed your issue." if gitlab.branch_for_base != "develop"
+  #
+  # @example Note when MRs don't reference a milestone, which goes away when it does
+  #
+  #          has_milestone = gitlab.mr_json["milestone"] != nil
+  #          warn("This MR does not refer to an existing milestone", sticky: false) unless has_milestone
+  #
+  # @example Note when a MR cannot be manually merged, which goes away when you can
+  #
+  #          can_merge = gitlab.mr_json["mergeable"]
+  #          warn("This MR cannot be merged yet.", sticky: false) unless can_merge
+  #
+  # @example Highlight when a celebrity makes a pull request
+  #
+  #          message "Welcome, Danger." if gitlab.mr_author == "dangermcshane"
+  #
+  # @example Send a message with links to a collection of specific files
+  #
+  #          if git.modified_files.include? "config/*.js"
+  #            config_files = git.modified_files.select { |path| path.include? "config/" }
+  #            message "This MR changes #{ gitlab.html_link(config_files) }"
+  #          end
+  #
+  # @example Highlight with a clickable link if a Package.json is changed
+  #
+  #         warn "#{gitlab.html_link("Package.json")} was edited." if git.modified_files.include? "Package.json"
+  #
+  #
+  # @see  danger/danger
+  # @tags core, gitlab
+  #
+  class DangerfileGitLabPlugin < Plugin
+    # So that this init can fail.
+    def self.new(dangerfile)
+      return nil if dangerfile.env.request_source.class != Danger::RequestSources::GitLab
+      super
+    end
+
+    # The instance name used in the Dangerfile
+    # @return [String]
+    #
+    def self.instance_name
+      "gitlab"
+    end
+
+    def initialize(dangerfile)
+      super(dangerfile)
+
+      @gitlab = dangerfile.env.request_source
+    end
+
+    # @!group MR Metadata
+    # The title of the Merge Request
+    # @return [String]
+    #
+    def mr_title
+      @gitlab.mr_json.title.to_s
+    end
+
+    # @!group MR Metadata
+    # The body text of the Merge Request
+    # @return [String]
+    #
+    def mr_body
+      @gitlab.mr_json.description.to_s
+    end
+
+    # @!group MR Metadata
+    # The username of the author of the Merge Request
+    # @return [String]
+    #
+    def mr_author
+      @gitlab.mr_json.author.username.to_s
+    end
+
+    # @!group MR Metadata
+    # The labels assigned to the Merge Request
+    # @return [String]
+    #
+    def mr_labels
+      @gitlab.mr_json.labels
+    end
+
+    # @!group MR Commit Metadata
+    # The branch to which the MR is going to be merged into
+    # @return [String]
+    #
+    def branch_for_merge
+      @gitlab.mr_json.target_branch
+    end
+
+    # @!group MR Commit Metadata
+    # The base commit to which the MR is going to be merged as a parent
+    # @return [String]
+    #
+    def base_commit
+      @gitlab.base_commit
+    end
+
+    # @!group MR Commit Metadata
+    # The head commit to which the MR is requesting to be merged from
+    # @return [String]
+    #
+    def head_commit
+      @gitlab.commits_json.first.id
+    end
+
+    # @!group GitLab Misc
+    # The hash that represents the MR's JSON. See documentation for the
+    # structure [here](http://docs.gitlab.com/ce/api/merge_requests.html#get-single-mr)
+    # @return [Hash]
+    #
+    def mr_json
+      @gitlab.mr_json.to_hash
+    end
+
+    # @!group GitLab Misc
+    # Provides access to the GitLab API client used inside Danger. Making
+    # it easy to use the GitLab API inside a Dangerfile.
+    # @return [GitLab::Client]
+    def api
+      @gitlab.client
+    end
+
+    # @!group GitLab Misc
+    # Returns a list of HTML anchors for a file, or files in the head repository. An example would be:
+    # `<a href='https://gitlab.com/artsy/eigen/blob/561827e46167077b5e53515b4b7349b8ae04610b/file.txt'>file.txt</a>`. It returns a string of multiple anchors if passed an array.
+    # @param    [String or Array<String>] paths
+    #           A list of strings to convert to gitlab anchors
+    # @param    [Bool] full_path
+    #           Shows the full path as the link's text, defaults to `true`.
+    #
+    # @return [String]
+    def html_link(paths, full_path: true)
+      paths = [paths] unless paths.kind_of?(Array)
+      commit = head_commit
+      same_repo = mr_json[:project_id] == mr_json[:source_project_id]
+      sender_repo = ci_source.repo_slug.split("/").first + "/" + mr_json[:author][:username]
+      repo = same_repo ? ci_source.repo_slug : sender_repo
+      host = @gitlab.host
+
+      paths = paths.map do |path|
+        url_path = path.start_with?("/") ? path : "/#{path}"
+        text = full_path ? path : File.basename(path)
+        create_link("https://#{host}/#{repo}/blob/#{commit}#{url_path}", text)
+      end
+
+      return paths.first if paths.count < 2
+      paths.first(paths.count - 1).join(", ") + " & " + paths.last
+    end
+
+    [:title, :body, :author, :labels, :json].each do |suffix|
+      alias_method "pr_#{suffix}".to_sym, "mr_#{suffix}".to_sym
+    end
+
+    private
+
+    def create_link(href, text)
+      "<a href='#{href}'>#{text}</a>"
+    end
+  end
+end

data/lib/danger/helpers/comments_helper.rb

@@ -28,8 +28,9 @@ module Danger
         tables = parse_tables_from_comment(comment)
         violations = {}
         tables.each do |table|
-          next unless table =~ %r{<th width="100%"(.*?)</th>}im
-          title = Regexp.last_match(1)
+          match = danger_table?(table)
+          next unless match
+          title = match[1]
           kind = table_kind_from_title(title)
           next unless kind
 
@@ -101,6 +102,44 @@ module Danger
                       "Yay.", "Jolly good show.", "Good on 'ya.", "Nice work."]
         compliment.sample
       end
+
+      private
+
+      GITHUB_OLD_REGEX = %r{<th width="100%"(.*?)</th>}im
+      NEW_REGEX = %r{<th.*data-danger-table="true"(.*?)</th>}im
+
+      def danger_table?(table)
+        # The old GitHub specific method relied on
+        # the width of a `th` element to find the table
+        # title and determine if it was a danger table.
+        # The new method uses a more robust data-danger-table
+        # tag instead.
+        match = GITHUB_OLD_REGEX.match(table)
+        return match if match
+
+        return NEW_REGEX.match(table)
+      end
+
+      class Comment
+        attr_reader :id, :body
+
+        def initialize(id, body)
+          @id = id
+          @body = body
+        end
+
+        def self.from_github(comment)
+          self.new(comment[:id], comment[:body])
+        end
+
+        def self.from_gitlab(comment)
+          self.new(comment.id, comment.body)
+        end
+
+        def generated_by_danger?(danger_id)
+          body.include?("generated_by_#{danger_id}")
+        end
+      end
     end
   end
 end

data/lib/danger/request_source/github.rb

@@ -16,11 +16,15 @@ module Danger
 
         Octokit.auto_paginate = true
         @token = @environment["DANGER_GITHUB_API_TOKEN"]
-        if @environment["DANGER_GITHUB_API_HOST"]
-          Octokit.api_endpoint = @environment["DANGER_GITHUB_API_HOST"]
+        if api_url
+          Octokit.api_endpoint = api_url
         end
       end
 
+      def validates_as_api_source?
+        @token && !@token.empty?
+      end
+
       def scm
         @scm ||= GitRepo.new
       end
@@ -29,6 +33,13 @@ module Danger
         @host = @environment["DANGER_GITHUB_HOST"] || "github.com"
       end
 
+      def api_url
+        # `DANGER_GITHUB_API_HOST` is the old name kept for legacy reasons and
+        # backwards compatibility. `DANGER_GITHUB_API_BASE_URL` is the new
+        # correctly named variable.
+        @environment["DANGER_GITHUB_API_HOST"] || @environment["DANGER_GITHUB_API_BASE_URL"]
+      end
+
       def client
         raise "No API token given, please provide one using `DANGER_GITHUB_API_TOKEN`" if !@token && !support_tokenless_auth
         @client ||= Octokit::Client.new(access_token: @token)
@@ -68,17 +79,20 @@ module Danger
         self.issue_json = client.get(href)
       end
 
+      def issue_comments
+        @comments ||= client.issue_comments(ci_source.repo_slug, ci_source.pull_request_id)
+                            .map { |comment| Comment.from_github(comment) }
+      end
+
       # Sending data to GitHub
       def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger")
         comment_result = {}
-
-        comments = client.issue_comments(ci_source.repo_slug, ci_source.pull_request_id)
-        editable_comments = comments.select { |comment| danger_comment?(comment, danger_id) }
+        editable_comments = issue_comments.select { |comment| comment.generated_by_danger?(danger_id) }
 
         if editable_comments.empty?
           previous_violations = {}
         else
-          comment = editable_comments.first[:body]
+          comment = editable_comments.first.body
           previous_violations = parse_comment(comment)
         end
 
@@ -97,7 +111,7 @@ module Danger
           if editable_comments.empty?
             comment_result = client.add_comment(ci_source.repo_slug, ci_source.pull_request_id, body)
           else
-            original_id = editable_comments.first[:id]
+            original_id = editable_comments.first.id
             comment_result = client.update_comment(ci_source.repo_slug, original_id, body)
           end
         end
@@ -145,11 +159,10 @@ module Danger
 
       # Get rid of the previously posted comment, to only have the latest one
       def delete_old_comments!(except: nil, danger_id: "danger")
-        comments = client.issue_comments(ci_source.repo_slug, ci_source.pull_request_id)
-        comments.each do |comment|
-          next unless danger_comment?(comment, danger_id)
-          next if comment[:id] == except
-          client.delete_comment(ci_source.repo_slug, comment[:id])
+        issue_comments.each do |comment|
+          next unless comment.generated_by_danger?(danger_id)
+          next if comment.id == except
+          client.delete_comment(ci_source.repo_slug, comment.id)
         end
       end
 
@@ -161,45 +174,11 @@ module Danger
         nil
       end
 
-      # @return [Hash] with the information about the repo
-      #   returns nil if the repo is not available
-      def fetch_repository(organisation: nil, repository: nil)
-        organisation ||= self.organisation
-        repository ||= self.ci_source.repo_slug.split("/").last
-        self.client.repo("#{organisation}/#{repository}")
-      rescue Octokit::NotFound
-        nil # repo doesn't exist
-      end
-
-      # @return [Hash] with the information about the repo.
-      #   This will automatically detect if the repo is capitalised
-      #   returns nil if there is no danger repo
-      def fetch_danger_repo(organisation: nil)
-        data = nil
-        data ||= fetch_repository(organisation: organisation, repository: DANGER_REPO_NAME.downcase)
-        data ||= fetch_repository(organisation: organisation, repository: DANGER_REPO_NAME.capitalize)
-        data
-      end
-
-      # @return [Bool] is this repo the danger repo of the org?
-      def danger_repo?(organisation: nil, repository: nil)
-        repo = fetch_repository(organisation: organisation, repository: repository)
-        repo[:name].casecmp(DANGER_REPO_NAME).zero? || repo[:parent] && repo[:parent][:full_name] == "danger/danger"
-      rescue
-        false
-      end
-
       # @return [String] A URL to the specific file, ready to be downloaded
       def file_url(organisation: nil, repository: nil, branch: "master", path: nil)
         organisation ||= self.organisation
         "https://raw.githubusercontent.com/#{organisation}/#{repository}/#{branch}/#{path}"
       end
-
-      private
-
-      def danger_comment?(comment, danger_id)
-        comment[:body].include?("generated_by_#{danger_id}")
-      end
     end
   end
 end

data/lib/danger/request_source/gitlab.rb

@@ -0,0 +1,133 @@
+# coding: utf-8
+require "gitlab"
+require "danger/helpers/comments_helper"
+
+module Danger
+  module RequestSources
+    class GitLab < RequestSource
+      include Danger::Helpers::CommentsHelper
+      attr_accessor :mr_json, :commits_json
+
+      def initialize(ci_source, environment)
+        self.ci_source = ci_source
+        self.environment = environment
+
+        @token = @environment["DANGER_GITLAB_API_TOKEN"]
+      end
+
+      def client
+        token = @environment["DANGER_GITLAB_API_TOKEN"]
+        raise "No API token given, please provide one using `DANGER_GITLAB_API_TOKEN`" unless token
+        params = { private_token: token }
+        params[:endpoint] = endpoint
+
+        @client ||= Gitlab.client(params)
+      end
+
+      def validates_as_api_source?
+        @token && !@token.empty?
+      end
+
+      def scm
+        @scm ||= GitRepo.new
+      end
+
+      def endpoint
+        @endpoint ||= @environment["DANGER_GITLAB_API_BASE_URL"] || "https://gitlab.com/api/v3"
+      end
+
+      def host
+        @host ||= @environment["DANGER_GITLAB_HOST"] || "gitlab.com"
+      end
+
+      def base_commit
+        first_commit_in_branch = self.commits_json.last.id
+        @base_comit ||= self.scm.exec "rev-parse #{first_commit_in_branch}^1"
+      end
+
+      def mr_comments
+        @comments ||= client.merge_request_comments(escaped_ci_slug, ci_source.pull_request_id)
+                            .map { |comment| Comment.from_gitlab(comment) }
+      end
+
+      def escaped_ci_slug
+        @escaped_ci_slug ||= CGI.escape(ci_source.repo_slug)
+      end
+
+      def setup_danger_branches
+        head_commit = self.scm.head_commit
+
+        # Next, we want to ensure that we have a version of the current branch at a known location
+        self.scm.exec "branch #{EnvironmentManager.danger_base_branch} #{base_commit}"
+
+        # OK, so we want to ensure that we have a known head branch, this will always represent
+        # the head of the PR ( e.g. the most recent commit that will be merged. )
+        self.scm.exec "branch #{EnvironmentManager.danger_head_branch} #{head_commit}"
+      end
+
+      def fetch_details
+        self.mr_json = client.merge_request(escaped_ci_slug, self.ci_source.pull_request_id)
+        self.commits_json = client.merge_request_commits(escaped_ci_slug, self.ci_source.pull_request_id)
+        self.ignored_violations = ignored_violations_from_pr(self.mr_json)
+      end
+
+      def ignored_violations_from_pr(mr_json)
+        pr_body = mr_json.description
+        return [] if pr_body.nil?
+        pr_body.chomp.scan(/>\s*danger\s*:\s*ignore\s*"(.*)"/i).flatten
+      end
+
+      def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger")
+        editable_comments = mr_comments.select { |comment| comment.generated_by_danger?(danger_id) }
+
+        if editable_comments.empty?
+          previous_violations = {}
+        else
+          comment = editable_comments.first.body
+          previous_violations = parse_comment(comment)
+        end
+
+        if previous_violations.empty? && (warnings + errors + messages + markdowns).empty?
+          # Just remove the comment, if there"s nothing to say.
+          delete_old_comments!(danger_id: danger_id)
+        else
+          body = generate_comment(warnings: warnings,
+                                    errors: errors,
+                                  messages: messages,
+                                 markdowns: markdowns,
+                       previous_violations: previous_violations,
+                                 danger_id: danger_id,
+                                  template: "gitlab")
+
+          if editable_comments.empty?
+            client.create_merge_request_comment(
+              escaped_ci_slug, ci_source.pull_request_id, body
+            )
+          else
+            original_id = editable_comments.first.id
+            client.edit_merge_request_comment(
+              escaped_ci_slug, ci_source.pull_request_id, original_id, body
+            )
+          end
+        end
+      end
+
+      def delete_old_comments!(except: nil, danger_id: "danger")
+        mr_comments.each do |comment|
+          next unless comment.generated_by_danger?(danger_id)
+          next if comment.id == except
+          client.delete_merge_request_comment(
+            escaped_ci_slug,
+            ci_source.pull_request_id,
+            comment.id
+          )
+        end
+      end
+
+      # @return [String] The organisation name, is nil if it can't be detected
+      def organisation
+        nil # TODO: Implement this
+      end
+    end
+  end
+end

data/lib/danger/request_source/request_source.rb

@@ -23,6 +23,10 @@ module Danger
         !!self.scm.origins.match(%r{#{Regexp.escape self.host}(:|/)(?<repo_slug>.+/.+?)(?:\.git)?$})
       end
 
+      def validates_as_api_source?
+        raise "Subclass and overwrite validates_as_api_source?"
+      end
+
       def scm
         @scm ||= nil
       end
@@ -51,18 +55,6 @@ module Danger
         raise "Subclass and overwrite organisation"
       end
 
-      def fetch_repository(_organisation: nil, _repository: nil)
-        raise "Subclass and overwrite fetch_repository"
-      end
-
-      def fetch_danger_repo(_organisation: nil)
-        raise "Subclass and overwrite fetch_danger_repo"
-      end
-
-      def danger_repo?(_organisation: nil, _repository: nil)
-        raise "Subclass and overwrite danger_repo?"
-      end
-
       def file_url(_organisation: nil, _repository: nil, _branch: "master", _path: nil)
         raise "Subclass and overwrite file_url"
       end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "2.1.6".freeze
+  VERSION = "3.0.0".freeze
   DESCRIPTION = "Automate your PR etiquette.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 2.1.6
+  version: 3.0.0
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-19 00:00:00.000000000 Z
+date: 2016-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -73,14 +73,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: faraday-http-cache
   requirement: !ruby/object:Gem::Requirement
@@ -151,6 +151,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: gitlab
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.7.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.7.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -319,6 +333,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.12.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.12.0
 description: Stop Saying 'You Forgot To…' in Code Review
 email:
 - orta.therox@gmail.com
@@ -339,6 +367,7 @@ files:
 - lib/danger/ci_source/circle.rb
 - lib/danger/ci_source/circle_api.rb
 - lib/danger/ci_source/drone.rb
+- lib/danger/ci_source/gitlab_ci.rb
 - lib/danger/ci_source/jenkins.rb
 - lib/danger/ci_source/local_git_repo.rb
 - lib/danger/ci_source/semaphore.rb
@@ -356,15 +385,17 @@ files:
 - lib/danger/commands/runner.rb
 - lib/danger/commands/systems.rb
 - lib/danger/comment_generators/github.md.erb
+- lib/danger/comment_generators/gitlab.md.erb
 - lib/danger/core_ext/file_list.rb
 - lib/danger/core_ext/string.rb
 - lib/danger/danger_core/dangerfile.rb
 - lib/danger/danger_core/dangerfile_dsl.rb
 - lib/danger/danger_core/environment_manager.rb
 - lib/danger/danger_core/executor.rb
+- lib/danger/danger_core/plugins/dangerfile_danger_plugin.rb
 - lib/danger/danger_core/plugins/dangerfile_git_plugin.rb
 - lib/danger/danger_core/plugins/dangerfile_github_plugin.rb
-- lib/danger/danger_core/plugins/dangerfile_import_plugin.rb
+- lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb
 - lib/danger/danger_core/plugins/dangerfile_messaging_plugin.rb
 - lib/danger/danger_core/standard_error.rb
 - lib/danger/danger_core/violation.rb
@@ -375,6 +406,7 @@ files:
 - lib/danger/plugin_support/plugin_parser.rb
 - lib/danger/plugin_support/templates/readme_table.html.erb
 - lib/danger/request_source/github.rb
+- lib/danger/request_source/gitlab.rb
 - lib/danger/request_source/request_source.rb
 - lib/danger/scm_source/git_repo.rb
 - lib/danger/version.rb