danger 2.1.5 → 2.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f2e2226e12824fc11ac62cf2a5db48a4add6ec31
-  data.tar.gz: 2a763da22a526ab15228e3bdb7b57702c3ac94e2
+  metadata.gz: 8d17d6a72e1a01c0fd06eb51f4631d2aece6a2ba
+  data.tar.gz: fedf8ba1df3832bfba137371bf9e6ba57ba3ca25
 SHA512:
-  metadata.gz: 21209a7ef5de1d76336cd132793d334b25ab2cd16ee9946241cc56ff61f954c77a40b75f3af6d46ae40de0c4550e4dc1710bb5341e4c658c9ca955c4fc59f994
-  data.tar.gz: 99b9dbe5cc93c644168525024913453ce958af27c5a0735ba4b41fc94bead9fa689fb46571236cd31737c81281c464b06f936577aeffcb22318a1c62776392ea
+  metadata.gz: 1ac508837ab5be9fa9004e729c2c86887377e301263e9d4bf05343858852992b66e23d582d32ac7d51e59d6e121f4136d4df481b129d43c30e51626be9b16e6e
+  data.tar.gz: 830458880fdaa3afb529fac362158a2210abd49d0b9a914e967007ee8a63226d40e5a98402e2639727048f23543aac8ac285fbe8eb28b284473b64cfa4319761

data/README.md

@@ -17,14 +17,16 @@ Formalize your Pull Request etiquette.
 
 ## What is Danger?
 
-Danger runs after your CI, and gives teams the chance to automate common code review chores.
+Danger runs after your CI, automating your team's conventions surrounding code review.
 
 This provides another logical step in your process, through this Danger can help lint your rote tasks in daily code review.
 
-You can use Danger to codify your teams norms. Leaving humans to think about harder problems.
+You can use Danger to codify your teams norms, leaving humans to think about harder problems.
 
 ## For example?
 
+You can:
+
 * Enforce CHANGELOGs
 * Enforce links to Trello/JIRA in PR/MR bodies
 * Enforce using descriptive labels
@@ -32,13 +34,13 @@ You can use Danger to codify your teams norms. Leaving humans to think about har
 * Highlight interesting build artifacts
 * Give specific files extra focus 
 
-Danger simply provides the glue to let _you_ build out the rules specific to your team's culture. Offering a lot of useful metadata, and a comprehensive plugin system to share common issues. 
+Danger provides the glue to let _you_ build out the rules specific to your team's culture, offering useful metadata and a comprehensive plugin system to share common issues.
 
 ## Getting Started
 
-Alright. So, actually, you may be in the wrong place. From here on in, this README is going to be for people who are interested in working on / improving on Danger. 
+Alright. So, actually, you may be in the wrong place. From here on in, this README is going to be for people who are interested in working on and improving on Danger.
 
-We keep all of the end-user documentation inside [http://danger.systems](http://danger.systems).
+We keep all of the end-user documentation at [http://danger.systems](http://danger.systems).
 
 Some quick links: [Guides Index](http://danger.systems/guides.html), [DSL Reference](http://danger.systems/reference.html), [Getting Started](http://danger.systems/guides/getting_started.html) and [What does Danger Do?](http://danger.systems/guides/what_does_danger_do.html). 
 
@@ -57,21 +59,21 @@ This sets everything up and runs all of the tests.
 
 #### Theory
 
-Danger has a [VISION.md](https://github.com/danger/danger/blob/master/VISION.md) file, this sums up the ideas around what Danger is. It's the lower bounds of what Danger means. Orta has written on handling, and creating Danger [on the Artsy blog](http://artsy.github.io/blog/categories/danger/) too.
+Danger has a [VISION.md](https://github.com/danger/danger/blob/master/VISION.md) file, which sums up the ideas around what Danger is. It is the lower bounds of what Danger means. Orta has written on handling and creating Danger [on the Artsy blog](http://artsy.github.io/blog/categories/danger/), too.
 
 #### Documentation
 
-The code you write may end up in the public part of the website, the easiest way to tell is that it is vastly overdocumented. If you are working in a space that looks over-documented, please be extra considerate to add documentation. We expect the consumers of that documentation to be non-rubyists, thus avoid specific jargon and try to provide duplicate overlapping examples.  
+The code you write may end up in the public part of the website — the easiest way to tell is that it is vastly overdocumented. If you are working in a space that looks over-documented, please be extra considerate to add documentation. We expect the consumers of that documentation to be non-rubyists, thus you should avoid specific jargon and try to provide duplicate overlapping examples.  
 
 #### Testing
 
-So far, we've not really figured out the right way to make tests for our CLI commands. When we have done so, they've ended up brittle. So ideally, try to move any logic that would go into a command into separate classes, and test those. We're OK with the command not having coverage, but ideally the classes that make up what it does do.
+So far, we've not really figured out the right way to make tests for our CLI commands. When we have done so, they've ended up being brittle. So, ideally, try to move any logic that would go into a command into separate classes, and test those. We're okay with the command not having coverage, but ideally the classes that make up what it does will.
 
 I'd strongly recommend using `bundle exec guard` to run your tests as you work. Any changes you make in the lib, or specs will have corresponding tests run instantly.
 
 #### Debugging
 
-Ruby is super dynamic, one of the best ways to debug is by using [pry](http://pryrepl.org/). We include pry for developers, when you have a problem copy these two lines just before your problem and follow the instructions from "[I Want To Be A Danger Wizard](http://danger.systems/guides/troubleshooting.html#i-want-to-be-a-danger-wizard)."
+Ruby is super dynamic. One of the best ways to debug Ruby code is by using [pry](http://pryrepl.org/). We include pry for developers: when you have a problem, copy these two lines just before your problem and follow the instructions from "[I Want To Be A Danger Wizard](http://danger.systems/guides/troubleshooting.html#i-want-to-be-a-danger-wizard)."
 
 ```ruby
 require 'pry'      
@@ -81,11 +83,11 @@ binding.pry
 ## Tell me of these Plugins
 
 * Follow the [Creating your first plugin](http://danger.systems/guides/creating_your_first_plugin.html) guide
-* Talk through the tech specs here
+* (Talk through the tech specs here.)
 
 ## License, Contributor's Guidelines and Code of Conduct
 
-We try to keep as much discussion as possible in GitHub issues, but also have a pretty inactive slack, if you'd like an invite ping [@Orta](https://twitter.com/orta/) a DM on twitter with your email. It's mostly interesting if you want to stay on top of Danger without all of the emails from GitHub. 
+We try to keep as much discussion as possible in GitHub issues, but also have a pretty inactive Slack --- if you'd like an invite, ping [@Orta](https://twitter.com/orta/) a DM on Twitter with your email. It's mostly interesting if you want to stay on top of Danger without all the emails from GitHub. 
 
 > This project is open source under the MIT license, which means you have full access to the source code and can modify it to fit your own needs.
 

data/lib/danger/commands/init.rb

@@ -90,7 +90,7 @@ module Danger
       ui.say "Here are great resources for creative commons images of robots:"
       ui.link "https://www.flickr.com/search/?text=robot&license=2%2C3%2C4%2C5%2C6%2C9"
       ui.link "https://www.google.com/search?q=robot&tbs=sur:fmc&tbm=isch&tbo=u&source=univ&sa=X&ved=0ahUKEwjgy8-f95jLAhWI7hoKHV_UD00QsAQIMQ&biw=1265&bih=1359"
-      ui.pause ""
+      ui.pause 1
 
       if considered_an_oss_repo?
         ui.say "#{@bot_name} does not need privilidged access to your repo or org. This is because Danger will only"

data/lib/danger/request_source/github.rb

@@ -72,13 +72,13 @@ module Danger
       def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger")
         comment_result = {}
 
-        issues = client.issue_comments(ci_source.repo_slug, ci_source.pull_request_id)
-        editable_issues = issues.select { |issue| danger_issue?(issue, danger_id) }
+        comments = client.issue_comments(ci_source.repo_slug, ci_source.pull_request_id)
+        editable_comments = comments.select { |comment| danger_comment?(comment, danger_id) }
 
-        if editable_issues.empty?
+        if editable_comments.empty?
           previous_violations = {}
         else
-          comment = editable_issues.first[:body]
+          comment = editable_comments.first[:body]
           previous_violations = parse_comment(comment)
         end
 
@@ -94,10 +94,10 @@ module Danger
                                  danger_id: danger_id,
                                   template: "github")
 
-          if editable_issues.empty?
+          if editable_comments.empty?
             comment_result = client.add_comment(ci_source.repo_slug, ci_source.pull_request_id, body)
           else
-            original_id = editable_issues.first[:id]
+            original_id = editable_comments.first[:id]
             comment_result = client.update_comment(ci_source.repo_slug, original_id, body)
           end
         end
@@ -145,11 +145,11 @@ module Danger
 
       # Get rid of the previously posted comment, to only have the latest one
       def delete_old_comments!(except: nil, danger_id: "danger")
-        issues = client.issue_comments(ci_source.repo_slug, ci_source.pull_request_id)
-        issues.each do |issue|
-          next unless danger_issue?(issue, danger_id)
-          next if issue[:id] == except
-          client.delete_comment(ci_source.repo_slug, issue[:id])
+        comments = client.issue_comments(ci_source.repo_slug, ci_source.pull_request_id)
+        comments.each do |comment|
+          next unless danger_comment?(comment, danger_id)
+          next if comment[:id] == except
+          client.delete_comment(ci_source.repo_slug, comment[:id])
         end
       end
 
@@ -197,8 +197,8 @@ module Danger
 
       private
 
-      def danger_issue?(issue, danger_id)
-        issue[:body].include?("generated_by_#{danger_id}")
+      def danger_comment?(comment, danger_id)
+        comment[:body].include?("generated_by_#{danger_id}")
       end
     end
   end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "2.1.5".freeze
+  VERSION = "2.1.6".freeze
   DESCRIPTION = "Automate your PR etiquette.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 2.1.5
+  version: 2.1.6
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-18 00:00:00.000000000 Z
+date: 2016-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide