danger-yajp 1.0.1 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2868f707abb91adf4aac75dbc2c882083fdee0851e7abb37fc90b939ae7c944e
-  data.tar.gz: fce1af4f4cd6cfa8fb3b0be1f36d5d507f86b8d43a45c78203078a2120572c65
+  metadata.gz: be2734f0b1913daffe2d4a199f0b2e285dfced1f0fa8e9a3af1f08586e8cda32
+  data.tar.gz: 10a973e093f80980d4f754c1042e5c43341d2418a52b9b39d3c8188ad614dc69
 SHA512:
-  metadata.gz: edc00b2e66a419e4408f36b3238dc57e59189a0ad63eabaf2d3a13be41f0da26041313ffc4b050118b19ab014324ef6b360f3ee4ee11f29fc5adb64870044df3
-  data.tar.gz: 2e5273d151a6b9ced079a5b2dabbbf5e370a04a7250232f76095aeb3c2942a8d49c97b46669079d5c9019aa6cb388dc8dc22139ce620011c83e153246071e7dd
+  metadata.gz: c5e9cdd87fcd59815a23b45a387fa8882e3dbdfead08db06f8131508449429adb3275cc672320a3af68bf1ff2da6b39c294ed44c5e9674eadb9a7b2c1906ae22
+  data.tar.gz: 338712d8c31aa30f6a37fe81988fb77fc28492653b4ba9da8a7cc872b157aaa1e9651f2723faa4059719d7ecdd22ed3435fc5529d8bc44b855ac08248f5e3ebb

data/.github/workflows/create-tag.yml

@@ -2,22 +2,22 @@ name: Create release
 
 on:
   push:
-    branches: main
+    branches: [main]
 
 jobs:
   build:
     name: Retrieve version + create release
     runs-on: ubuntu-latest
-    
+
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v5
       with:
         fetch-depth: 0
-      
-    - name: Set up Ruby 2.6
-      uses: actions/setup-ruby@v1
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.6.x
+        ruby-version: '3.4'
 
     - name: Retrieve version
       id: version
@@ -25,15 +25,12 @@ jobs:
         version=$(ruby -e 'require "./lib/yajp/gem_version.rb"' -e 'puts Yajp::VERSION')
         echo "TAG_NAME=$version" >> $GITHUB_ENV
         latest_tag=$(git describe --tags --abbrev=0)
-        echo 'VERSION_DESCRIPTION<<EOF' >> $GITHUB_ENV
-        git log --pretty='format:%h %s' ${latest_tag}..HEAD >> $GITHUB_ENV
-        echo $'\nEOF' >> $GITHUB_ENV
+        git log --pretty='format:%h %s' ${latest_tag}..HEAD > release_notes.txt
 
     - name: Create release
-      uses: actions/create-release@v1
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      with:
-        tag_name: ${{ env.TAG_NAME }}
-        release_name: v${{ env.TAG_NAME }}
-        body: ${{ env.VERSION_DESCRIPTION }}
+      run: |
+        gh release create "${{ env.TAG_NAME }}" \
+          --title "v${{ env.TAG_NAME }}" \
+          --notes-file release_notes.txt

data/.github/workflows/gem-push.yml

@@ -2,7 +2,7 @@ name: Ruby Gem
 
 on:
   push:
-    branches: main
+    branches: [main]
 
 jobs:
   build:
@@ -10,13 +10,18 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby 2.6
-      uses: actions/setup-ruby@v1
+    - uses: actions/checkout@v5
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.6.x
+        ruby-version: '3.4'
+        bundler-cache: true
+
+    - name: Run tests
+      run: bundle exec rake spec
 
     - name: Publish to GPR
+      continue-on-error: true
       run: |
         mkdir -p $HOME/.gem
         touch $HOME/.gem/credentials

data/.gitignore

@@ -68,3 +68,9 @@ yarn-debug.log*
 
 # Ignore docs file
 .yardoc
+
+# Ignore bundler binstubs
+/bin
+
+# Claude config
+/.claude

data/.rubocop.yml

@@ -2,9 +2,14 @@
 
 # If you don't like these settings, just delete this file :)
 
+plugins:
+  - rubocop-rake
+  - rubocop-rspec
+
 AllCops:
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 3.0
   NewCops: enable
+  SuggestExtensions: false
 
 Style/StringLiterals:
   EnforcedStyle: single_quotes
@@ -19,14 +24,14 @@ Lint/UselessAssignment:
   Exclude:
     - '**/spec/**/*'
 
-# We could potentially enable the 2 below:
+# Aligned hash values are used throughout the codebase for readability
 Layout/FirstHashElementIndentation:
   Enabled: false
 
 Layout/HashAlignment:
   Enabled: false
 
-# HoundCI doesn't like this rule
+# Codebase uses trailing-dot style for multiline method chains
 Layout/DotPosition:
   Enabled: false
 
@@ -99,7 +104,7 @@ Style/RedundantSelf:
 Metrics/MethodLength:
   Max: 60
 
-# We're not there yet
+# Public API is documented via YARD; inline class/module docs are not enforced
 Style/Documentation:
   Enabled: false
 
@@ -115,7 +120,6 @@ Style/BlockComments:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
-# FIXME: 25
 Metrics/BlockLength:
   Max: 345
   Exclude:
@@ -131,7 +135,7 @@ Layout/HeredocIndentation:
   Enabled: false
 
 Style/SpecialGlobalVars:
-  Enabled: false
+  Enabled: true
 
 Style/PercentLiteralDelimiters:
   PreferredDelimiters:
@@ -147,3 +151,25 @@ Style/PercentLiteralDelimiters:
 
 Security/YAMLLoad:
   Enabled: false
+
+# RSpec cops
+# Danger's plugin API requires stubbing chained methods (e.g. github.pr_title)
+RSpec/MessageChain:
+  Enabled: false
+
+# JIRA::Client and JIRA::Base don't expose test-friendly interfaces
+RSpec/AnyInstance:
+  Enabled: false
+
+# Integration-style tests for an API plugin are inherently longer
+RSpec/ExampleLength:
+  Max: 15
+
+# Verifying stub + result expectation is the accepted pattern here
+RSpec/MultipleExpectations:
+  Max: 2
+
+# Guard output in spec_helper is intentional (exits early without a git remote)
+RSpec/Output:
+  Exclude:
+    - 'spec/spec_helper.rb'

data/Gemfile.lock

@@ -1,70 +1,90 @@
 PATH
   remote: .
   specs:
-    danger-yajp (1.0.0)
+    danger-yajp (1.0.3)
       danger-plugin-api
       jira-ruby
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.3.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+    activesupport (8.1.2)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
+      json
+      logger (>= 1.4.2)
       minitest (>= 5.1)
-      tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
-    addressable (2.7.0)
-      public_suffix (>= 2.0.2, < 5.0)
-    ast (2.4.2)
-    atlassian-jwt (0.2.0)
-      jwt (~> 2.1.0)
-    claide (1.0.3)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
+    addressable (2.8.9)
+      public_suffix (>= 2.0.2, < 8.0)
+    ast (2.4.3)
+    atlassian-jwt (0.2.1)
+      jwt (~> 2.1)
+    base64 (0.3.0)
+    bigdecimal (4.0.1)
+    cgi (0.5.1)
+    claide (1.1.0)
     claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
     coderay (1.1.3)
     colored2 (3.1.2)
-    concurrent-ruby (1.1.8)
+    concurrent-ruby (1.3.6)
+    connection_pool (3.0.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    crack (0.4.5)
+    crack (1.0.1)
+      bigdecimal
       rexml
-    danger (8.2.3)
+    danger (9.5.3)
+      base64 (~> 0.2)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
-      colored2 (~> 3.1)
+      colored2 (>= 3.1, < 5)
       cork (~> 0.1)
-      faraday (>= 0.9.0, < 2.0)
+      faraday (>= 0.9.0, < 3.0)
       faraday-http-cache (~> 2.0)
-      git (~> 1.7)
-      kramdown (~> 2.3)
+      git (>= 1.13, < 3.0)
+      kramdown (>= 2.5.1, < 3.0)
       kramdown-parser-gfm (~> 1.0)
-      no_proxy_fix
-      octokit (~> 4.7)
-      terminal-table (>= 1, < 4)
+      octokit (>= 4.0)
+      pstore (~> 0.1)
+      terminal-table (>= 1, < 5)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
-    diff-lcs (1.4.4)
-    faraday (1.3.0)
-      faraday-net_http (~> 1.0)
-      multipart-post (>= 1.2, < 3)
-      ruby2_keywords
-    faraday-http-cache (2.2.0)
+    diff-lcs (1.6.2)
+    drb (2.2.3)
+    faraday (2.14.1)
+      faraday-net_http (>= 2.0, < 3.5)
+      json
+      logger
+    faraday-http-cache (2.6.1)
       faraday (>= 0.8)
-    faraday-net_http (1.0.1)
-    ffi (1.15.0-x64-mingw32)
-    formatador (0.2.5)
-    git (1.8.1)
+    faraday-net_http (3.4.2)
+      net-http (~> 0.5)
+    ffi (1.17.3)
+    formatador (1.2.3)
+      reline
+    git (2.3.3)
+      activesupport (>= 5.0)
+      addressable (~> 2.8)
+      process_executer (~> 1.1)
       rchardet (~> 1.8)
-    guard (2.16.2)
+    guard (2.20.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
+      logger (~> 1.6)
       lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
-      pry (>= 0.9.12)
+      pry (>= 0.13.0)
       shellany (~> 0.0)
       thor (>= 0.18.1)
     guard-compat (1.2.1)
@@ -72,96 +92,146 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    hashdiff (1.0.1)
-    i18n (1.8.10)
+    hashdiff (1.2.1)
+    hashie (5.1.0)
+      logger
+    i18n (1.14.8)
       concurrent-ruby (~> 1.0)
-    jira-ruby (2.1.5)
+    io-console (0.8.2)
+    jira-ruby (3.1.0)
       activesupport
       atlassian-jwt
+      cgi
       multipart-post
-      oauth (~> 0.5, >= 0.5.0)
-    jwt (2.1.0)
-    kramdown (2.3.1)
-      rexml
+      oauth (~> 1.0)
+    json (2.19.1)
+    json-schema (6.2.0)
+      addressable (~> 2.8)
+      bigdecimal (>= 3.1, < 5)
+    jwt (2.10.2)
+      base64
+    kramdown (2.5.2)
+      rexml (>= 3.4.4)
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
-    listen (3.5.1)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
+    listen (3.10.0)
+      logger
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    lumberjack (1.2.8)
-    method_source (1.0.0)
-    minitest (5.14.4)
-    multipart-post (2.1.1)
+    logger (1.7.0)
+    lumberjack (1.4.2)
+    mcp (0.8.0)
+      json-schema (>= 4.1)
+    method_source (1.1.0)
+    minitest (6.0.2)
+      drb (~> 2.0)
+      prism (~> 1.5)
+    multipart-post (2.4.1)
     nap (1.1.0)
     nenv (0.3.0)
-    no_proxy_fix (0.1.2)
+    net-http (0.9.1)
+      uri (>= 0.11.1)
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    oauth (0.5.6)
-    octokit (4.20.0)
-      faraday (>= 0.9)
-      sawyer (~> 0.8.0, >= 0.5.3)
+    oauth (1.1.3)
+      base64 (~> 0.1)
+      oauth-tty (~> 1.0, >= 1.0.6)
+      snaky_hash (~> 2.0)
+      version_gem (~> 1.1, >= 1.1.9)
+    oauth-tty (1.0.6)
+      version_gem (~> 1.1, >= 1.1.9)
+    octokit (10.0.0)
+      faraday (>= 1, < 3)
+      sawyer (~> 0.9)
     open4 (1.3.4)
-    parallel (1.20.1)
-    parser (3.0.1.0)
+    parallel (1.27.0)
+    parser (3.3.10.2)
       ast (~> 2.4.1)
-    pry (0.14.0)
+      racc
+    prism (1.9.0)
+    process_executer (1.3.0)
+    pry (0.16.0)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (4.0.6)
-    rainbow (3.0.0)
-    rake (13.0.3)
-    rb-fsevent (0.10.4)
-    rb-inotify (0.10.1)
+      reline (>= 0.6.0)
+    pstore (0.2.1)
+    public_suffix (7.0.5)
+    racc (1.8.1)
+    rainbow (3.1.1)
+    rake (13.3.1)
+    rb-fsevent (0.11.2)
+    rb-inotify (0.11.1)
       ffi (~> 1.0)
-    rchardet (1.8.0)
-    regexp_parser (2.1.1)
-    rexml (3.2.5)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
+    rchardet (1.10.0)
+    regexp_parser (2.11.3)
+    reline (0.6.3)
+      io-console (~> 0.5)
+    rexml (3.4.4)
+    rspec (3.13.2)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.6)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.8)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
-    rubocop (1.12.1)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.7)
+    rubocop (1.85.1)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      mcp (~> 0.6)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.2.0, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.4.1)
-      parser (>= 2.7.1.5)
-    ruby-progressbar (1.11.0)
-    ruby2_keywords (0.0.4)
-    sawyer (0.8.2)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.49.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.7)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    rubocop-rspec (3.9.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.81)
+    ruby-progressbar (1.13.0)
+    sawyer (0.9.3)
       addressable (>= 2.3.5)
-      faraday (> 0.8, < 2.0)
+      faraday (>= 0.17.3, < 3)
+    securerandom (0.4.1)
     shellany (0.0.1)
-    terminal-table (1.6.0)
-    thor (1.1.0)
-    tzinfo (2.0.4)
+    snaky_hash (2.0.3)
+      hashie (>= 0.1.0, < 6)
+      version_gem (>= 1.1.8, < 3)
+    terminal-table (4.0.0)
+      unicode-display_width (>= 1.1.1, < 4)
+    thor (1.5.0)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.0.0)
-    webmock (3.12.2)
-      addressable (>= 2.3.6)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.2.0)
+    uri (1.1.1)
+    version_gem (1.1.9)
+    webmock (3.26.1)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    yard (0.9.26)
-    zeitwerk (2.4.2)
+    yard (0.9.38)
 
 PLATFORMS
-  x64-mingw32
+  x64-mingw-ucrt
+  x86_64-linux
 
 DEPENDENCIES
   bundler
@@ -172,8 +242,10 @@ DEPENDENCIES
   rake (~> 13.0)
   rspec (~> 3)
   rubocop (~> 1)
+  rubocop-rake (~> 0)
+  rubocop-rspec (~> 3)
   webmock (~> 3)
   yard (~> 0.9)
 
 BUNDLED WITH
-   2.2.3
+  4.0.8

data/Rakefile

@@ -21,5 +21,5 @@ end
 
 desc 'Ensure that the plugin passes `danger plugins lint`'
 task :spec_docs do
-  sh 'bundle exec danger plugins lint'
+  sh RbConfig.ruby, Gem.bin_path('danger', 'danger'), 'plugins', 'lint'
 end

data/danger-yajp.gemspec

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('lib', __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'yajp/gem_version'
+require_relative 'lib/yajp/gem_version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'danger-yajp'
@@ -14,12 +12,16 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/juliendms/danger-yajp'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.metadata = {
+    'homepage_uri'          => spec.homepage,
+    'source_code_uri'       => spec.homepage,
+    'rubygems_mfa_required' => 'true'
+  }
+
+  spec.files         = `git ls-files`.split("\n")
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.6.0'
+  spec.required_ruby_version = '>= 3.0.0'
 
   spec.add_runtime_dependency 'danger-plugin-api'
   spec.add_runtime_dependency 'jira-ruby'
@@ -34,6 +36,8 @@ Gem::Specification.new do |spec|
 
   # Linting code and docs
   spec.add_development_dependency 'rubocop', '~> 1'
+  spec.add_development_dependency 'rubocop-rake', '~> 0'
+  spec.add_development_dependency 'rubocop-rspec', '~> 3'
   spec.add_development_dependency 'yard', '~> 0.9'
 
   # Makes testing easy via `bundle exec guard`

data/lib/yajp/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Yajp
-  VERSION = '1.0.1'
+  VERSION = '1.0.3'
 end

data/lib/yajp/issue.rb

@@ -11,7 +11,7 @@ module Danger
     # @return [String] the URL of the issue
     #
     def link
-      "#{ENV['DANGER_JIRA_URL']}/browse/#{key}"
+      "#{ENV.fetch('DANGER_JIRA_URL', nil)}/browse/#{key}"
     end
 
     # Update the issue.

data/lib/yajp/plugin.rb

@@ -45,12 +45,12 @@ module Danger
     def initialize(dangerfile)
       throw Error('The environment variable DANGER_JIRA_URL is required') if ENV['DANGER_JIRA_URL'].nil?
 
-      super(dangerfile)
-      url_parser = %r{(?<site>https?://[^/]+)(?<context_path>/.+)}.match(ENV['DANGER_JIRA_URL'])
+      super
+      url_parser = %r{(?<site>https?://[^/]+)(?<context_path>/.+)}.match(ENV.fetch('DANGER_JIRA_URL', nil))
 
       options = {
-        username:       ENV['DANGER_JIRA_USER'],
-        password:       ENV['DANGER_JIRA_API_TOKEN'],
+        username:       ENV.fetch('DANGER_JIRA_USER', nil),
+        password:       ENV.fetch('DANGER_JIRA_API_TOKEN', nil),
         site:           url_parser[:site],
         context_path:   url_parser[:context_path],
         auth_type:      :basic

data/spec/spec_helper.rb

@@ -2,8 +2,8 @@
 
 require 'pathname'
 ROOT = Pathname.new(File.expand_path('..', __dir__))
-$:.unshift("#{ROOT}lib".to_s)
-$:.unshift("#{ROOT}spec".to_s)
+$LOAD_PATH.unshift("#{ROOT}lib")
+$LOAD_PATH.unshift("#{ROOT}spec")
 
 require 'bundler/setup'
 require 'pry'
@@ -34,7 +34,6 @@ require 'danger_plugin'
 # it comes with an extra function `.string` which will
 # strip all ANSI colours from the string.
 
-# rubocop:disable Lint/NestedMethodDefinition
 def testing_ui
   @output = StringIO.new
   def @output.winsize
@@ -47,7 +46,6 @@ def testing_ui
   end
   cork
 end
-# rubocop:enable Lint/NestedMethodDefinition
 
 # Example environment (ENV) that would come from
 # running a PR on TravisCI

data/spec/yajp_spec.rb

@@ -11,8 +11,8 @@ module Danger
       ENV['DANGER_JIRA_PASSWORD'] = 'password'
     end
 
-    it 'should be a plugin' do
-      expect(Danger::DangerYajp.new(nil)).to be_a Danger::Plugin
+    it 'is a plugin' do
+      expect(described_class.new(nil)).to be_a Danger::Plugin
     end
 
     describe 'with Dangerfile' do
@@ -20,10 +20,10 @@ module Danger
       let(:plugin) { dangerfile.jira }
 
       before do
-        DangerYajp.send(:public, *DangerYajp.private_instance_methods)
+        described_class.send(:public, *described_class.private_instance_methods)
       end
 
-      it 'should return a JIRA::Client instance' do
+      it 'returns a JIRA::Client instance' do
         expect(plugin.api).to be_a(JIRA::Client)
       end
 
@@ -77,14 +77,14 @@ module Danger
       # rubocop:disable Naming/VariableNumber
       it 'can split transition field from other fields' do
         json = File.read("#{File.dirname(__FILE__)}/support/transitions.all.json")
-        url = "#{ENV['DANGER_JIRA_URL']}/rest/api/2/issue/WEB-130/transitions"
+        url = "#{ENV.fetch('DANGER_JIRA_URL', nil)}/rest/api/2/issue/WEB-130/transitions"
         transition_data = { assignee: { name: 'username' }, summary: 'new_summary' }
         fields = { colour: 'red', customfield_11005: 'example' }
 
         allow_any_instance_of(JIRA::Base).to receive(:self).and_return(url)
         stub = stub_request(:get, "#{url}/transitions?expand=transitions.fields").
           to_return(body: json)
-        result = plugin.split_transition_fields(plugin.api.Issue.build, 2, **transition_data.merge(fields))
+        result = plugin.split_transition_fields(plugin.api.Issue.build, 2, **transition_data, **fields)
 
         expect(stub).to have_been_requested.once
         expect(result).to eq({ transition_fields: transition_data, other_fields: fields })
@@ -93,7 +93,7 @@ module Danger
       it 'can transition an issue' do
         expected_json = '{"transition":{"id":"2"},"fields":{"assignee":{"name":"username"},"customfield_11005":"example"}}'
         issue_id = Random.rand(1000)
-        url = "#{ENV['DANGER_JIRA_URL']}/rest/api/2/issue/#{issue_id}/transitions"
+        url = "#{ENV.fetch('DANGER_JIRA_URL', nil)}/rest/api/2/issue/#{issue_id}/transitions"
         issue = plugin.api.Issue.build({ 'id' => issue_id, 'key' => 'WEB-131' })
         transition_1 = issue.transitions.build({ 'id' => '2', 'name' => 'TEST' })
         transition_2 = issue.transitions.build({ 'id' => '3', 'name' => 'FAKE' })
@@ -109,9 +109,9 @@ module Danger
 
       it 'can update issues' do
         expected_json = '{"fields":{"assignee":{"name":"username"},"customfield_11005":"example"}}'
-        uri_template = Addressable::Template.new "#{ENV['DANGER_JIRA_URL']}/rest/api/2/issue/{issue}"
-        issue1 = plugin.api.Issue.build({ 'id' => Random.rand(1000), 'self' => "#{ENV['DANGER_JIRA_URL']}/rest/api/2/issue/WEB-132", 'key' => 'WEB-132' })
-        issue2 = plugin.api.Issue.build({ 'id' => Random.rand(1000), 'self' => "#{ENV['DANGER_JIRA_URL']}/rest/api/2/issue/WEB-133", 'key' => 'WEB-133' })
+        uri_template = Addressable::Template.new "#{ENV.fetch('DANGER_JIRA_URL', nil)}/rest/api/2/issue/{issue}"
+        issue1 = plugin.api.Issue.build({ 'id' => Random.rand(1000), 'self' => "#{ENV.fetch('DANGER_JIRA_URL', nil)}/rest/api/2/issue/WEB-132", 'key' => 'WEB-132' })
+        issue2 = plugin.api.Issue.build({ 'id' => Random.rand(1000), 'self' => "#{ENV.fetch('DANGER_JIRA_URL', nil)}/rest/api/2/issue/WEB-133", 'key' => 'WEB-133' })
 
         stub = stub_request(:put, uri_template).
           with(body: expected_json)
@@ -125,13 +125,12 @@ module Danger
       it 'can add remote link' do
         pr_title = 'PR Title'
         pr_json = { 'html_url' => 'https://github.com/test/pull/1234' }
-        url = "#{ENV['DANGER_JIRA_URL']}/rest/api/2/issue/WEB-134/remotelink"
+        url = "#{ENV.fetch('DANGER_JIRA_URL', nil)}/rest/api/2/issue/WEB-134/remotelink"
         json = File.read("#{File.dirname(__FILE__)}/support/remotelink.json")
         issue = plugin.api.Issue.build
 
         allow(issue).to receive(:key_value).and_return('WEB-134')
-        allow(dangerfile.github).to receive(:pr_json).and_return(pr_json)
-        allow(dangerfile.github).to receive(:pr_title).and_return(pr_title)
+        allow(dangerfile.github).to receive_messages(pr_json: pr_json, pr_title: pr_title)
 
         stub = stub_request(:post, url).
           with(body: json)

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: danger-yajp
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.3
 platform: ruby
 authors:
 - juliendms
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-09 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -108,6 +107,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -195,8 +222,10 @@ files:
 homepage: https://github.com/juliendms/danger-yajp
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  homepage_uri: https://github.com/juliendms/danger-yajp
+  source_code_uri: https://github.com/juliendms/danger-yajp
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -204,20 +233,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Yet Another Jira Plugin is a danger plugin to find issues, access their parameters
   and perform operations on them.
-test_files:
-- spec/spec_helper.rb
-- spec/support/remotelink.json
-- spec/support/transitions.all.json
-- spec/yajp_spec.rb
+test_files: []